I believe we may have found an issue with the way @embed is replaced in less files. According to the comments and code in CSSMin.php (around #313) @embed should not have the fallback for old IE versions added when the file is an SVG. However, we've found that this is exactly what happens - for example, see Vector's generated css.
This is the case in 1.25 and core.
Thanks to @connorshea for noticing something weird in the first place.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| CSSMin: Correctly avoid fallbacks when embedding SVG files | mediawiki/core | master | +3 -3 |
Any chance to attach a screenshot that shows the problem for affected browsers (old IE)? Wondering "how bad" this is and don't have an old IE handy...
Oh, I may have explained this wrong. As I understand the code and comments, the following should happen:
We make use of the @embed solution to have svg icons on our wiki, and it'd be expected only the embed happens, not the IE fallback, as per the comments in the code. However, this is the result.
Note that background-image always has an !ie fallback when using svgs. We're using these mixins, as in Vector, and this also appears to happen in vector.
Thanks for taking a look at the code! Appreciated!
Just in case you feel like cooking a patch, you are very welcome to use developer access to submit a Git branch into Gerrit (or you can also use the Gerrit Patch Uploader).
Change 319280 had a related patch set uploaded (by Bartosz Dziewoński):
CSSMin: Correctly avoid fallbacks when embedding SVG files
Change 319280 merged by jenkins-bot:
CSSMin: Correctly avoid fallbacks when embedding SVG files