Page MenuHomePhabricator

Don't use version detection for rawcontinue
Open, MediumPublic

Description

One factor complicating site initialisation is that Request._add_defaults loads Siteinfo if action=query to determine whether to add rawcontinue.

As mentioned on wikitech-l, that should be fixable by always adding rawcontinue if neither continue or rawcontinue are present, and Pywikibot explicitly not supporting the 1.25 branches where this caused a nasty warning.

Event Timeline

jayvdb raised the priority of this task from to Medium.
jayvdb updated the task description. (Show Details)
jayvdb added subscribers: Unknown Object (MLST), jayvdb, Aklapper, XZise.

To be honest I don't see much of a benefit. Do all versions we support also support the rawcontinue parameter? It also caches the siteinfo so if later another siteinfo (e.g. namespaces) are needed, it would load the version anyway. Also what do you mean with “nasty warning”?

xSavitar renamed this task from Dont use version detection for rawcontinue to Don't use version detection for rawcontinue.Feb 1 2022, 7:13 PM