Make pybal accept 30[12] for ProxyFetch
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	BBlack
	Jun 14 2015, 3:36 AM

Description

Pybal considers the 30[12] TLS redirects to be failures. I've worked around the pragmatic immediate-term issue by avoiding the situation (ProxyFetch only on HTTPS, not HTTP services), but in the long term we should fix this so that we can healthcheck our public HTTP services fully, which will return 301s for most things going forward...

Details

Subject	Repo	Branch	Lines +/-
Handle HTTP status 302 and 303 as well as 301	operations/debs/pybal	master	+6 -8
Make pybal accept 30[12] for ProxyFetch	operations/debs/pybal	master	+1 -1
Add support for http_status to ProxyFetch	operations/debs/pybal	master	+75 -43
Revert s/en/de/ for LVS monitoring; switch ProxyFetch to TLS	operations/puppet	production	+12 -28

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Joe	T113151 pybal fails to detect dead servers under production lb IPs for port 80
		Resolved		Joe	T102393 Make pybal accept 30[12] for ProxyFetch

Event Timeline

BBlack created this task.Jun 14 2015, 3:36 AM

BBlack raised the priority of this task from to High.

BBlack updated the task description. (Show Details)

BBlack added projects: acl*sre-team, Traffic.

BBlack added subscribers: BBlack, faidon, mark.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2015, 3:36 AM

Change 218285 had a related patch set uploaded (by BBlack):
Revert s/en/de/ for LVS monitoring; switch ProxyFetch to TLS

https://gerrit.wikimedia.org/r/218285

gerritbot added a project: Patch-For-Review.Jun 14 2015, 11:53 PM

Switched this task up a bit. We'll merge the patch above to get past short term issues, and this is now about fixing it for good later.

Change 218285 merged by BBlack:
Revert s/en/de/ for LVS monitoring; switch ProxyFetch to TLS

https://gerrit.wikimedia.org/r/218285

BBlack mentioned this in rOPUP1f5ec7aa3c05: Revert s/en/de/ for LVS monitoring; switch ProxyFetch to TLS.Jun 15 2015, 2:53 PM

fgiunchedi assigned this task to BBlack.Jul 21 2015, 1:51 PM

fgiunchedi subscribed.

Restricted Application added a subscriber: Matanya. · View Herald TranscriptJul 21 2015, 1:51 PM

Change 233054 had a related patch set uploaded (by Ori.livneh):
Make pybal accept 30[12] for ProxyFetch

https://gerrit.wikimedia.org/r/233054

gerritbot added a project: Patch-For-Review.Aug 21 2015, 9:15 PM

BBlack added a parent task: T113151: pybal fails to detect dead servers under production lb IPs for port 80.Sep 21 2015, 4:02 PM

@ori, @BBlack: Any plans to rework that last patch?
Asking as this task is blocking T113151 which has priority "Unbreak now".

Change 243139 had a related patch set uploaded (by Giuseppe Lavagetto):
Add support for http_status to ProxyFetch

https://gerrit.wikimedia.org/r/243139

Joe claimed this task.Oct 2 2015, 11:08 AM

Change 243139 merged by jenkins-bot:
Add support for http_status to ProxyFetch

https://gerrit.wikimedia.org/r/243139

Joe mentioned this in rODCB76520483ea36: Add support for http_status to ProxyFetch.Oct 5 2015, 10:53 AM

Joe closed this task as Resolved.Nov 3 2015, 12:58 PM

BBlack moved this task from Backlog to Done on the Traffic board.Nov 30 2015, 6:02 PM

Change 233054 abandoned by Ori.livneh:
Make pybal accept 30[12] for ProxyFetch

https://gerrit.wikimedia.org/r/233054

Change 430393 had a related patch set uploaded (by Mark Bergsma; owner: Mark Bergsma):
[operations/debs/pybal@master] Handle HTTP status 302 and 303 as well as 301

https://gerrit.wikimedia.org/r/430393

Change 430393 merged by jenkins-bot:
[operations/debs/pybal@master] Handle HTTP status 302 and 303 as well as 301