Page MenuHomePhabricator

"Forgot to leave an edit summary" preference mis-fires when edit sessions are lost
Closed, ResolvedPublic

Description

Author: titoxd.wikimedia

Description:
I've found a bug that's currently ongoing on the live site. Here's the steps I
used to replicate it:

  1. First, I edited page, opening the edit window
  2. Filled out the edit summary, first thing
  3. Made the edit
  4. *Got the "We cannot process your edit due to a loss of session data. Please

try again" error message. I tried again.

  1. Got another lost-session message. Kept trying
  2. After n number of tries, my edit succeeds, however, I get a "you forgot to

leave an edit summary" message.

Tried saving, lost my session again.

This happened several times yesterday, and I never changed the edit summary
between tries. I think that is the reason the "you did not enter an edit
summary" message was triggered.


Version: 1.9.x
Severity: normal

Details

Reference
bz8340

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:29 PM
bzimport set Reference to bz8340.
bzimport added a subscriber: Unknown Object (MLST).

rotemliss wrote:

Bug 7200 (which was fixed in r16372) may be related. About the edit summary: was
it blank first, and was reset to be blank?

ayg wrote:

(bug 7220, not bug 7200)

titoxd.wikimedia wrote:

No, it was never blank, nor reset to blank. It was the same non-blank value all
the way along.

Just testing, please ignore :)

I noticed that the auto summary for undo seems to trigger this as well.

titoxd.wikimedia wrote:

When is the MD5 hash for the edit summary calculated? If it is generated only
once, on the first call of ?action=edit, then this error shouldn't be triggered.
Same thing for the undo error, as the MD5 hash seems to be generated after the
"Undo revision..." summary is filled by MediaWiki.

tderouin wrote:

FWIW: i usually find that this happens when either mediawiki can't reach a
memcached server or the memcached server is incorrectly configured in
LocalSettings.php.

EN.WP.ST47 wrote:

Attempted to replicate, was unable to do so. Correct spelling in title and add testme tag.

EN.WP.ST47 wrote:

Actually, this looks like a similar bug to bug 8912, and people there seem to have tried similar debugging steps, but much more recently.

*** This bug has been marked as a duplicate of bug 8912 ***