Page MenuHomePhabricator

"Undo" feature seems to be broken
Closed, ResolvedPublic

Description

Author: robchur

Description:
The "undo" feature appears to be broken. Two cases:

  • Attempt to undo a previous, non-current revision. It flat-out fails with a

nice big red error; "The edit could not be undone because of conflicting
intermediate edits. Please manually undo the edits."

  • Attempt to undo the most recent revision. It claims success, but the text in

the box is clearly the most recent revision itself.

An obvious regression from when it worked.


Version: unspecified
Severity: normal

Details

Reference
bz8362

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:31 PM
bzimport set Reference to bz8362.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

Based on a fresh checkout of r17937, it seems that the feature doesn't work,
even in the simplest cases.

rotemliss wrote:

About the first one, very basic things (e.g. A: multiple lines saying "Hey"; B:
changing the first one to "Bye"; C: changing the last one to "Bye"; D: reverting
B without reverting C) do work.

About the second one, I confirm, and Bug 8351 is about that.

robchur wrote:

All right, resolved that; seems it was some odd local quirk.

marek wrote:

This bug is still in effect as described in the initial comment. Confirmed on pl and en wiki,
both as logged in and unlogged in user, from a different machine using a different browser
(Opera 9.1 on MacOs 10.4.8).

  • This bug has been marked as a duplicate of 8351 ***