Page MenuHomePhabricator

Review/approval process shows no message indicating pending changes for imported pages (item, property)
Open, LowPublic

Description

Hello. This is Dongju Bae.

While I was trying to find a review system, I found something great which is FlaggedRevs.
I'm really interested in your work(FlaggedRevs-Extension) and I'm trying to use the work for my project.

Currently I'm checking about importing several data at once
by calling wikibase api or utilizing extensions/Wikibase/repo/maintenance/importInterlang.php (importing items).

  1. When I finish import the status of each page is "unchecked" and belong to unreviewed pages.

2-1. If I edit a page with user account which is neither an editor nor reviwer,
the change is simply applied without review
2-2. If I make a review on imported page with reviewer account first,
then user editing will provoke pending request as it is expected.

For temporally, I'm thinking about using unreviewedpages and review api for imported pages.
But It might be not the best way.

I'm quite new here, and maybe this is not an issue
but please give me some advice.

  • Summary of the task:
  • import item
  • edit item page with user account(neither editor nor reviewer)
  • no message indicating pending changes. No pending changes tab on the right upper corner or message.

Thank you,
Dongju

Event Timeline

Bdjwiki assigned this task to aaron.
Bdjwiki raised the priority of this task from to Needs Triage.
Bdjwiki updated the task description. (Show Details)
Bdjwiki subscribed.

Bdjwiki: Thanks for reporting this. Why did you assign this to aaron? Did you talk to him before doing that?

Aklapper renamed this task from Review(approval) process does not work for pages(item, property, ) imported to Review (approval) process does not work for pages (item, property) imported.Jul 2 2015, 11:03 AM
Aklapper updated the task description. (Show Details)
Aklapper set Security to None.

Also, could you explain what "does not work" exactly and edit the task summary accordingly?

Aklapper:

Hello. I didn't know to whom this should be assigned
and what would be proper way to contact/ask,
so I just added author of the extension, aaron((Aaron Schulz)).
(I checked author name on https://www.mediawiki.org/wiki/Extension:FlaggedRevs)
I haven't had a change to talk with Aaron.
If I've made a request wrongly, please let me know.

"Does not work" means in short:
0. use extension version 1.25

  1. import item
  2. edit item page with user account(neither editor nor reviewer)
  3. no message indicating pending changes. No pending changes tab on the right upper corner or message.

After reviewer make a review, pending changes tab appear.
So, I just added review api call in the later part of import code,
I could avoid the situation after writing the task.

Maybe this could be not a problem, but I was curious about it.

Thanks

Dongju Bae

Aklapper renamed this task from Review (approval) process does not work for pages (item, property) imported to Review/approval process shows no message indicating pending changes for imported pages (item, property).Jul 2 2015, 1:43 PM
Aklapper removed aaron as the assignee of this task.
Aklapper triaged this task as Low priority.