Page MenuHomePhabricator

'last' link in history page should have 'diff=prev'
Closed, DeclinedPublic

Description

Author: angus

Description:
See also bug 8498.

Currently, the 'last' link in the history page has an URL with

diff=nnnn&oldid=mmmm

where oldid is the rev. id of the edit in this row, and nnnn the rev. id of the
edit in the previous one.

I think there should be always 'diff=prev'. Even if someone deleted or restored
the previous revision between the time I loaded the page and now, I think I
should see the differences between the selected and its previous revision (even
if it isn't listed).

(I'm not so sure of this one.)

Thanks.


Version: unspecified
Severity: normal

Details

Reference
bz8499

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:33 PM
bzimport set Reference to bz8499.
bzimport added a subscriber: Unknown Object (MLST).

'prev' detection is currently pretty crappy, as I recall, incorrectly using id
numbers.

ayg wrote:

Then let's leave this open but dependent on that bug. Unless that's also WONTFIX?