Page MenuHomePhabricator

Still have extra data in RDF update queries
Closed, ResolvedPublic

Description

From recent query on db01:

# Clear out of date site links
DELETE {
  ?s ?p ?o .
}
WHERE {
  ?s <http://schema.org/about> <http://www.wikidata.org/entity/Q13536649> .
  ?s ?p ?o .
  # This construct is constantly reused throughout the updates.  Its job is to not delete statements
  # that are still in use.
  FILTER NOT EXISTS {
    VALUES ( ?s ?p ?o ) {
      ( <http://www.wikidata.org/reference/95541d0f0f90a1cf32daf28a8778388cea9185a1> <http://www.wikidata.org/prop/reference/value/P813> <http://www.wikidata.org/value/526c88f3ddf7fb39b97e4f3458b013fb> )
( <http://www.wikidata.org/value/526c88f3ddf7fb39b97e4f3458b013fb> <http://wikiba.se/ontology#timeValue> "2015-07-11T00:00:00Z"^^<http://www.w3.org/2001/XMLSchema#dateTime> )
( <http://www.wikidata.org/reference/95541d0f0f90a1cf32daf28a8778388cea9185a1> <http://www.wikidata.org/prop/reference/P813> "2015-07-11T00:00:00Z"^^<http://www.w3.org/2001/XMLSchema#dateTime> )
( <http://www.wikidata.org/reference/95541d0f0f90a1cf32daf28a8778388cea9185a1> <http://www.wikidata.org/prop/reference/P248> <http://www.wikidata.org/entity/Q82486> )
( <http://www.wikidata.org/value/526c88f3ddf7fb39b97e4f3458b013fb> <http://wikiba.se/ontology#timeTimezone> "0"^^<http://www.w3.org/2001/XMLSchema#integer> )
( <http://www.wikidata.org/value/526c88f3ddf7fb39b97e4f3458b013fb> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://wikiba.se/ontology#TimeValue> )
( <http://www.wikidata.org/value/526c88f3ddf7fb39b97e4f3458b013fb> <http://wikiba.se/ontology#timeCalendarModel> <http://www.wikidata.org/entity/Q1985727> )
( <http://www.wikidata.org/value/526c88f3ddf7fb39b97e4f3458b013fb> <http://wikiba.se/ontology#timePrecision> "11"^^<http://www.w3.org/2001/XMLSchema#integer> )
    }
  }
};

We should not be trying to match values or refs to sitelinks.

Event Timeline

Smalyshev raised the priority of this task from to High.
Smalyshev updated the task description. (Show Details)
Smalyshev subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The command line there is:

java -cp lib/wikidata-query-tools-0.0.3-SNAPSHOT-jar-with-dependencies.jar -Dlogback.configurationFile=updater-logs.xml org.wikidata.query.rdf.tool.Update --labelLanguage en --singleLabel en --skipSiteLinks --sparqlUrl http://localhost:9999/bigdata/namespace/wdq/sparql -b 500

Change 226657 had a related patch set uploaded (by Smalyshev):
Fix T105718: do not put value/refs statements into about query

https://gerrit.wikimedia.org/r/226657

Change 226657 merged by jenkins-bot:
Fix T105718: do not put value/refs statements into about query

https://gerrit.wikimedia.org/r/226657

Smalyshev claimed this task.
Smalyshev moved this task from Backlog to Done on the Discovery-Wikidata-Query-Service-Sprint board.