This project is wonderful, absolutely wonderful. Thank you so much. Main feature missing for me is diff preview—I need to know whether it's worth clicking through. I usually do this through pop-ups (which is nice because it has lots of watch/unwatch/go to talk easy access), but any kind of diff preview would fit.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add expand/collapse button for diff preview | labs/tools/crosswatch | master | +47 -35 |
Related Objects
Related Objects
- Mentioned Here
- T108056: Create priority celery queue and workers
Event Timeline
Comment Actions
Hey, that actually already exist, clicking on a edit (the white/text area) expands it show a diff and some additional links:
It should make it more obvious though that clicking on it does that.
Comment Actions
Oh, nice! Yes, something like a mouseover effect (to show that the data was loaded) in the whitespace to the right would make it more self-evident.
Comment Actions
And depending on how slow your internet is you might not notice a diff loading in the background :| Maybe when you click it adds text like "Loading diff..." so you know that it is going to do something?
Comment Actions
Change 229407 had a related patch set uploaded (by Sitic):
Add expand/collapse button for diff preview
Comment Actions
I've added a expand/show diff button and a collapse diff button to each edit. Tooltip didn't really work, because there is quite a lot of clickable area with links inside, which might be a bit confusing.
@Legoktm I've tested it with a loading bar, but usually the diff renders in 200-400ms. This would cause flickering if the loading bar is only briefly shown. I think you just had a bad timing and clicked on it when other users where loading their watchlist. I've created T108056: Create priority celery queue and workers to address this.