Page MenuHomePhabricator

Diff preview is too hidden
Closed, ResolvedPublic


This project is wonderful, absolutely wonderful. Thank you so much. Main feature missing for me is diff preview—I need to know whether it's worth clicking through. I usually do this through pop-ups (which is nice because it has lots of watch/unwatch/go to talk easy access), but any kind of diff preview would fit.


Related Gerrit Patches:
labs/tools/crosswatch : masterAdd expand/collapse button for diff preview

Event Timeline

czar created this task.Aug 3 2015, 5:11 AM
czar raised the priority of this task from to Needs Triage.
czar updated the task description. (Show Details)
czar added a project: crosswatch.
czar added a subscriber: czar.
Restricted Application added subscribers: MGChecker, Luke081515, Aklapper. · View Herald TranscriptAug 3 2015, 5:11 AM
Sitic added a subscriber: Sitic.Aug 3 2015, 12:28 PM

Hey, that actually already exist, clicking on a edit (the white/text area) expands it show a diff and some additional links:

It should make it more obvious though that clicking on it does that.

czar added a comment.EditedAug 3 2015, 6:02 PM

Oh, nice! Yes, something like a mouseover effect (to show that the data was loaded) in the whitespace to the right would make it more self-evident.

czar renamed this task from Diff preview to Diff preview is too hidden.Aug 3 2015, 6:03 PM
czar set Security to None.
Sitic moved this task from Backlog to In Progress on the crosswatch board.Aug 3 2015, 9:54 PM

And depending on how slow your internet is you might not notice a diff loading in the background :| Maybe when you click it adds text like "Loading diff..." so you know that it is going to do something?

Change 229407 had a related patch set uploaded (by Sitic):
Add expand/collapse button for diff preview

Change 229407 merged by Sitic:
Add expand/collapse button for diff preview

Sitic closed this task as Resolved.Aug 5 2015, 5:02 PM
Sitic claimed this task.

I've added a expand/show diff button and a collapse diff button to each edit. Tooltip didn't really work, because there is quite a lot of clickable area with links inside, which might be a bit confusing.

@Legoktm I've tested it with a loading bar, but usually the diff renders in 200-400ms. This would cause flickering if the loading bar is only briefly shown. I think you just had a bad timing and clicked on it when other users where loading their watchlist. I've created T108056: Create priority celery queue and workers to address this.