Page MenuHomePhabricator

User module liable to being loaded twice or being loaded with an incorrect version
Closed, ResolvedPublic

Description

rMWd7905627fdc3: resourceloader: Async all the way dropped the mw.loader.state( {"user": "loading"} ) call for the user module. Consequently, if a call is made to mw.loader.load or mw.loader.using for the user module before the user module has actually arrived, ResourceLoader will request it, and it will do so using the (wrong) version data from the startup module.

This primarily affected wikis that have modules in the default load queue that depend on the user module (or that call mw.loader.using( "user" ) from e.g. Common.js).

Event Timeline

ori created this task.Aug 7 2015, 12:53 AM
ori assigned this task to Krinkle.
ori raised the priority of this task from to Unbreak Now!.
ori updated the task description. (Show Details)
ori added a subscriber: ori.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2015, 12:53 AM

Change 230018 had a related patch set uploaded (by Krinkle):
resourceloader: Restore anticipated loader states for hardcoded module requests

https://gerrit.wikimedia.org/r/230018

Change 230020 had a related patch set uploaded (by Ori.livneh):
resourceloader: Restore anticipated loader states for hardcoded module requests

https://gerrit.wikimedia.org/r/230020

Change 230020 merged by Ori.livneh:
resourceloader: Restore anticipated loader states for hardcoded module requests

https://gerrit.wikimedia.org/r/230020

Change 230018 merged by jenkins-bot:
resourceloader: Restore anticipated loader states for hardcoded module requests

https://gerrit.wikimedia.org/r/230018

ori closed this task as Resolved.Aug 7 2015, 4:29 AM