Page MenuHomePhabricator
Create Task
Maniphest T108359

Embedded video player broken
Closed, ResolvedPublic
Actions

Description

Example: https://commons.wikimedia.org/wiki/File%3ACuriosity%27s_Seven_Minutes_of_Terror.ogv?embedplayer=yes

JS errs include:

ReferenceError: mw is not defined
"TypeError: mw.mergeConfig is not a function"
Error: Error loading EmbedPlayer dependency set: One or more dependencies failed to load

Might be a regression related to ogv.js merge. :(

Details

SubjectRepoBranchLines +/-
Another hack at fixing embed playermediawiki/extensions/TimedMediaHandlermaster+4 -1
Fix regression in iframe embedding for MediaWiki core updatesmediawiki/extensions/TimedMediaHandlerwmf/1.26wmf17+25 -20
Fix regression in iframe embedding for MediaWiki core updatesmediawiki/extensions/TimedMediaHandlermaster+25 -20
Customize query in gerrit

Related Objects

Event Timeline

• brooke created this task.Aug 7 2015, 6:25 PM
• brooke claimed this task.
• brooke raised the priority of this task from to Needs Triage.
• brooke updated the task description. (Show Details)
• brooke added projects: TimedMediaHandler, Video.
• brooke subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptAug 7 2015, 6:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• brooke added a comment.Aug 7 2015, 6:30 PM

Looks more like a core JS/RL change... startup script is now loaded asynchronously, which breaks all the scripts in the embed player that attempt to use mw synchronously. :P

Restricted Application added a subscriber: Matanya. · View Herald TranscriptAug 7 2015, 6:30 PM
• brooke mentioned this in T107399: Make top queue fully asynchronous.Aug 7 2015, 6:42 PM
gerritbot subscribed.Aug 7 2015, 6:44 PM

Change 230151 had a related patch set uploaded (by Brion VIBBER):
Fix regression in iframe embedding for MediaWiki core updates

https://gerrit.wikimedia.org/r/230151

gerritbot added a project: Patch-For-Review.Aug 7 2015, 6:44 PM
gerritbot added a comment.Aug 7 2015, 10:37 PM

Change 230151 merged by jenkins-bot:
Fix regression in iframe embedding for MediaWiki core updates

https://gerrit.wikimedia.org/r/230151

• brooke mentioned this in rETMH33e4cbd460f1: Fix regression in iframe embedding for MediaWiki core updates.Aug 7 2015, 10:37 PM
Diffusion mentioned this in rMEXT6f1733669a49: Updated mediawiki/extensions Project: mediawiki/extensions/TimedMediaHandler….Aug 7 2015, 10:37 PM
• Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 7 2015, 11:00 PM
gerritbot added a comment.Aug 10 2015, 9:14 PM

Change 230656 had a related patch set uploaded (by Jforrester):
Fix regression in iframe embedding for MediaWiki core updates

https://gerrit.wikimedia.org/r/230656

gerritbot added a comment.Aug 10 2015, 11:29 PM

Change 230656 merged by jenkins-bot:
Fix regression in iframe embedding for MediaWiki core updates

https://gerrit.wikimedia.org/r/230656

• brooke mentioned this in rMWb8a7e61b3636: Updated mediawiki/core Project: mediawiki/extensions/TimedMediaHandler….Aug 10 2015, 11:29 PM
Jdforrester-WMF mentioned this in rETMH322f62656a2d: Fix regression in iframe embedding for MediaWiki core updates.Aug 10 2015, 11:29 PM
Krenair subscribed.Aug 10 2015, 11:54 PM

I don't think that fully fixed it

• Forrestbot added a project: WMF-deploy-2015-08-04_(1.26wmf17).Aug 11 2015, 12:00 AM
• brooke added a comment.Aug 11 2015, 12:17 AM

Hmm... it works in debug mode https://commons.wikimedia.org/wiki/File%3ACuriosity%27s_Seven_Minutes_of_Terror.ogv?embedplayer=yes&debug=yes but not without; something getting loaded out of order perhaps.

Aklapper added a comment.Aug 18 2015, 3:16 PM

Was there time to analyze this further?

Jdforrester-WMF triaged this task as Unbreak Now! priority.Sep 4 2015, 6:52 PM
Jdforrester-WMF moved this task from Untriaged to Doing on the Multimedia board.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from Doing to Done on the Multimedia board.Sep 8 2015, 3:38 PM
• brooke added a comment.Sep 8 2015, 6:39 PM

Definitely still broken:

Exception in module-execute in module mw.MediaSource:
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:177 TypeError: mw.mergeConfig is not a function TypeError: mw.mergeConfig is not a function(…)log @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:177handler @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:155jQuery.Callbacks.fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:45jQuery.Callbacks.self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:46jQuery.Callbacks.self.fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:46mw.track @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:155runScript @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:163mw.loader.checkCssHandles @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:163execute @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:164mw.loader.modules.implement @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:170(anonymous function) @ VM175:140(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:4jQuery.extend.globalEval @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:4mw.loader.modules.work @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:166request @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:164mw.loader.modules.load @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:171(anonymous function) @ File%3ACuriosity's_Seven_Minutes_of_Terror.ogv?embedplayer=yes:66startUp @ load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector:66script.onload.script.onreadystatechange @ load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector:67
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:177 Exception in load-callback in module mw.MwEmbedSupport:
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Kk41yJbu:177 Error: Error loading EmbedPlayer dependency set: One or more dependencies failed to load Error: Error loading EmbedPlayer dependency set: One or more dependencies failed to load(…)
gerritbot added a comment.Sep 8 2015, 7:02 PM

Change 236858 had a related patch set uploaded (by Brion VIBBER):
Another hack at fixing embed player

https://gerrit.wikimedia.org/r/236858

gerritbot added a comment.Sep 8 2015, 7:24 PM

Change 236858 merged by jenkins-bot:
Another hack at fixing embed player

https://gerrit.wikimedia.org/r/236858

• brooke mentioned this in rETMH7b8cd0766d53: Another hack at fixing embed player.Sep 8 2015, 7:25 PM
• brooke mentioned this in rMEXT2a1f8ff32166: Updated mediawiki/extensions Project: mediawiki/extensions/TimedMediaHandler….
Krenair moved this task from Done to Needs code review on the Multimedia board.Sep 8 2015, 7:46 PM
MarkTraceur moved this task from Needs code review to Done on the Multimedia board.Sep 9 2015, 3:32 PM
• brooke added a comment.Sep 9 2015, 3:35 PM

Ok this is merged since yesterday; should go out with next weeks updates as usual or we can SWAT it if we're in a hurry.

ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 10 2015, 9:12 PM
Jdforrester-WMF closed this task as Resolved.Sep 11 2015, 6:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL