Page MenuHomePhabricator
Create Task
Maniphest T109559

LinkSearch namespace field is broken (removed by JS)
Closed, ResolvedPublic
Actions

Description

The LinkSearch namespace field (which only shows when miser mode is off) is broken. The field (but not label) is removed by JS:

Missing namespace field.png (279×778 px, 6 KB)

Details

SubjectRepoBranchLines +/-
Refactor NamespaceInputWidgetmediawiki/coremaster+307 -142
Customize query in gerrit

Related Objects

Event Timeline

• Mattflaschen-WMF created this task.Aug 19 2015, 6:14 AM
• Mattflaschen-WMF raised the priority of this task from to Needs Triage.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added projects: MediaWiki-Special-pages, JavaScript.
• Mattflaschen-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 6:14 AM
• Mattflaschen-WMF added a subscriber: matmarex.Aug 19 2015, 6:14 AM
Aklapper renamed this task from LinkSearch namespace field is broken to LinkSearch namespace field is broken (removed by JS).Aug 19 2015, 1:13 PM
Aklapper set Security to None.
matmarex added a comment.EditedAug 19 2015, 1:17 PM

Not sure what causes this, but it is no doubt related to the immense hackiness of the JS version of NamespaceInputWidget (see T106138). It appears that https://gerrit.wikimedia.org/r/#/c/230821/ fixes this issue.

matmarex claimed this task.Aug 19 2015, 1:18 PM
matmarex triaged this task as High priority.
matmarex added a project: Patch-For-Review.
gerritbot subscribed.Aug 20 2015, 3:10 PM

Change 230821 had a related patch set uploaded (by Bartosz Dziewoński):
Refactor NamespaceInputWidget

https://gerrit.wikimedia.org/r/230821

gerritbot added a comment.Aug 21 2015, 3:33 PM

Change 230821 merged by jenkins-bot:
Refactor NamespaceInputWidget

https://gerrit.wikimedia.org/r/230821

matmarex mentioned this in rMWb6046dff660f: Refactor NamespaceInputWidget.Aug 21 2015, 3:33 PM
matmarex closed this task as Resolved.Aug 21 2015, 4:02 PM
• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-08-25_(1.26wmf20).Aug 23 2015, 12:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL