Page MenuHomePhabricator

radio buttons not showing up on history page
Closed, DeclinedPublic

Description

Author: imre.gergely

Description:
In 1.9.1 i noticed that on all the history pages, the radio button are just
gone. so i cant select any revisions to see diffs. all the rest is there, all
the lines, "(cur) (last) 19:03, 12 February 2007 User (Talk | contribs) (->..)",
but the radio buttons aren't.

I first upgraded to 1.9.2, but nothing changed. Then i installed a fresh
mediawiki 1.9.2, which was working fine.

I did a little digging and landed in includes/PageHistory.php, on line 289 where
there is a condition, which checks if there is more then one line on the page to
show radio buttons or not. This condition is always false, wherefore no radio
button is displayed. I reversed the "greater then" sign to see if this is what
happens, and the radio buttons appeared. ie:

if( $this->linesonpage < 1) { ... show radio button on line ... }

I would guess there is something wrong with my upgrade process, but i don't know
what. This still could be a bug, because the page is displaying ok, and there
are history lines (a lot of them, with paging and all, and the paging works
too). I checked the revision table in mysql and there are over 3000 records.

(On upgrade i'm doing 'php update.php', then 'php rebuildall.php').

PHP: 5.0.4, MySQL: 4.1.20. Only extension used is ParserFunctions, but was
disabled during digging.


Version: 1.9.x
Severity: normal
Platform: PC

Details

Reference
bz8971

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:32 PM
bzimport set Reference to bz8971.
bzimport added a subscriber: Unknown Object (MLST).

Seems to have been fixed at some point. WORKSFORME now.