Page MenuHomePhabricator

[AOI] Links to oldid revisions are broken in Firefox when RevisionJumper is enabled
Closed, ResolvedPublic5 Estimated Story Points

Description

Per T108424, we should fix the bug in RevisionJumper that breaks certain links in Firefox.

From https://en.wikipedia.org/wiki/User_talk:DerHexer/revisionjumper#Revisionjumper_option_in_Firefox_kills_section_anchor_links_to_oldid_revisions:

I'm trying to make a link to a section (or subsecion) of an old version of an article. Clicking the link takes me to the old version of the article, but the section anchor seems to have no effect. The cursor always ends up at the top of the page. Example: https://en.wikipedia.org/w/index.php?title=User_talk:DVdm&oldid=655052178#Proper_length

It looks like this is due to Firefox never completing the page load for some reason.

Event Timeline

kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added a project: Community-Tech.
kaldari subscribed.
kaldari renamed this task from [AOI] Fix bug in RevisionJumper where links to oldid revisions are broken in Firefox to [AOI] Links to oldid revisions are broken in Firefox when RevisionJumper is enabled.Aug 25 2015, 6:48 AM
kaldari updated the task description. (Show Details)
kaldari set Security to None.
kaldari updated the task description. (Show Details)
kaldari moved this task from New & TBD Tickets to Blocked on the Community-Tech board.
kaldari triaged this task as Medium priority.Aug 25 2015, 7:41 PM
kaldari moved this task from Blocked to Ready on the Community-Tech board.

Support: Medium
Feasibility: Good
Impact: Low
Risk: Low

Priority: Normal

I haven't been able to reproduce this with Firefox 40.0.3 (Mozilla Firefox for Ubuntu canonical - 1.0).

I enabled RevisionJumper in my preferences and went back to the diff reported on the talk page. The page loaded as normal.

The bug report mentioned that using NoScript might have been a problem. I set NoScript to block JS on wikipedia.org, and went to the diff link with section. It loaded normally.

This needs more testing to reproduce and/or more information in the bug report. Commented on the talk page.