@MusikAnimal: This isn't actually assigned to anyone. Are you taking it?
Having no content is pretty common on Commons (for categories at least). Maybe exact matches should be weighted higher there. In an ideal world, the search engine for Commons would consider the titles of images in categories, but I imagine that isn't trivial to implement.
@Niharika: That sucks. I guess the best thing to do would be to file a bug against mediawiki-api-base and do a work-around for now. Maybe you could fetch the page and do a regex for a header :P
Looks like this is still throwing fatal errors, specifically when a page exists, but doesn't have a section 1:
PHP Fatal error: Uncaught exception 'Mediawiki\Api\UsageException' with message 'There is no section 1 in Wikipedia:WikiProject Gambia/Popular pages.' in /mnt/nfs/labstore-secondary-tools-project/popularpages-dev/public_html/vendor/addwiki/mediawiki-api-base/src/MediawikiApi.php:273 Stack trace: #0 /mnt/nfs/labstore-secondary-tools-project/popularpages-dev/public_html/vendor/addwiki/mediawiki-api-base/src/MediawikiApi.php(218): Mediawiki\Api\MediawikiApi->throwUsageExceptions(Array) #1 /mnt/nfs/labstore-secondary-tools-project/popularpages-dev/public_html/vendor/addwiki/mediawiki-api-base/src/MediawikiApi.php(188): Mediawiki\Api\MediawikiApi->decodeResponse(Object(GuzzleHttp\Psr7\Response)) #2 /mnt/nfs/labstore-secondary-tools-project/popularpages-dev/public_html/ApiHelper.php(337): Mediawiki\Api\MediawikiApi->getRequest(Object(Mediawiki\Api\FluentRequest)) #3 /mnt/nfs/labstore-secondary-tools-project/popularpages-dev/public_html/ApiHelper.php(76): ApiHelper->apiQuery(Array, 'parse') #4 /mnt/nfs/labstore-secondary-tools-proje in /mnt/nfs/labstore-secondary-tools-project/popularpages-dev/public_html/vendor/addwiki/mediawiki-api-base/src/MediawikiApi.php on line 273
@DannyH: I was thinking some more about the notifications for failed log-ins (while testing MusikAnimal's patch), and I was wondering if maybe we should give the user more specific advice, like:
Would probably be best to implement T50826 by including the CodeMirror library within the CodeEditor extension and switching out the back-end, rather than making the CodeEditor extension dependent on the CodeMirror extension. But once they are both using the CodeMirror library, it would make sense to consider merging them into 1 extension.
Just one minor change requested.
As Leon's manager, I approve and endorse this request.
Wed, Mar 22
@dpatrick: Description updated. Let me know if you need any other info. Thanks!
One small issue.
Tue, Mar 21
@Niharika: I think it's to avoid constantly invalidating the squid caches, although I wonder how we're avoiding that with including the total in the page. Seems like it would be just as problematic.
@Mvolz: I'm assuming this task is no longer relevant since citoid has been moved to restbase, correct?
@Pastakhov, @Bawolff: We met with @Esanders. We're now investigating the possibility of integrating CodeMirror with the new WikiText editor rather than emulating it. (See T161052 and T161054.) We currently have no blockers for implementing this as an opt-in feature in the old WikiText editor besides security and design reviews.
This will also probably necessitate adding a way to specify looking at a particular month to the code (so that the results are consistant for testing).
Let's see if we can get a QA person to handle this one.
If this does turn out to be a possible issue, we should see if there is a way that we could visually alert the user to cases where the syncing is off, for example, using semi-transparent text (in a separate task).
@Niharika: Looks good. Just a couple comments: https://github.com/wikimedia/popularpages/commit/f454067ed68c28f399f898cf299d111c8b30548e
Mon, Mar 20
Sat, Mar 18
@Niharika: I added WikiProject Beyoncé to the config. I think we're done! Nice work on the clean-up!
@Niharika: https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Beyonc%C3%A9 and https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Bj%C3%B6rk. Looks like the characters got mangled. WikiProject Björk/Popular pages seems to be working fine. It doesn't look like a popular pages report for WikiProject Beyoncé ever existed, but it wouldn't hurt to create one.
The State Highway ones were migrated to WikiProject U.S. Roads.
Fri, Mar 17
We also decided to set LoginNotifyEnableOnSuccess to false for now, until a system is developed for allowing the user to force all sessions to log-out via an email link.
At last meeting, Danny, Niharika, and I reached consensus to set LoginNotifyAttemptsKnownIP to 10 and LoginNotifyAttemptsNewIP to 2. Any other opinions are welcome.
@Niharika: Sounds reasonable. You can use the rvuser query string parameter to only retrieve revisions by a specific user.
I think simplifying it is a good idea for now. The whole thing had become so complicated it was virtually impossible to test all the edge cases. Let's get the basic idea working reliably and then it can be improved from there.