The issue is present in betalabs and testwiki wmf.21
For example, Special:Recentchanges
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Release | mmodell | T264801 1.36.0-wmf.21 deployment blockers | ||
Resolved | Volker_E | T269477 [wmf.21-regression] RC/Watchlist -misaligned close icon in oo-ui-tagMultiselectWidget-group |
Event Timeline
I am adding this to the Growth team's Ready for Development column. @Catrope is going to look at it so that we can prevent this from getting to the production wikis later this week.
Change 647222 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] themes: Fix TagItem size
Change 647225 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] RCFilters: Temporarily fix TagItemWidget remove button size
Even with above patches, we might need an additional OOUI release, given the number of interfaces that use TagItemWidget. Could need your help Growth team member devs tomorrow.
Change 647225 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Temporarily fix TagItemWidget remove button size
Change 647305 had a related patch set uploaded (by Catrope; owner: VolkerE):
[mediawiki/core@wmf/1.36.0-wmf.21] RCFilters: Temporarily fix TagItemWidget remove button size
I'd be happy to help with that, feel free to ping me. I'll also deploy the RCFilters patch in the 19:00 UTC backport window tomorrow.
I think we should push out a MediaWiki-wide fix for this ASAP. TagItemWidget is prominently used in the Preferences interface, the Search interface, in ContentTranslation, UploadWizard, etc. Once this hits Wikipedia, a lot of people are going to notice.
Do you mean something other than https://gerrit.wikimedia.org/r/c/mediawiki/core/+/647305 ?
This is blocking the train currently, I'm wondering if the above-mentioned temporary fix is enough to unblock the train or do we need something more (like an OOJS/UI update) before wmf.21 goes to all wikis?
Change 647305 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.21] RCFilters: Temporarily fix TagItemWidget remove button size
Mentioned in SAL (#wikimedia-operations) [2020-12-10T19:41:54Z] <catrope@deploy1001> Synchronized php-1.36.0-wmf.21/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterTagMultiselectWidget.less: Work around OOUI bug breaking RCFilters UI (T269477) (duration: 01m 04s)
@mmodell Yeah, above patches are not enough. We need to make a backport of either a new OOUI release or similar to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/615434
@mmodell: It was a misguided hope. I'm done with my 5 hours of meetings today and can now care about this.
Change 647790 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] OOUI: Backport I18799e54ef46232a54d36e86e2b3d08c3ee0a3d5
Change 647641 had a related patch set uploaded (by Catrope; owner: VolkerE):
[mediawiki/core@wmf/1.36.0-wmf.21] OOUI: Backport I18799e54ef46232a54d36e86e2b3d08c3ee0a3d5
Change 647790 merged by jenkins-bot:
[mediawiki/core@master] OOUI: Backport I18799e54ef46232a54d36e86e2b3d08c3ee0a3d5
Change 647641 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.21] OOUI: Backport I18799e54ef46232a54d36e86e2b3d08c3ee0a3d5
Mentioned in SAL (#wikimedia-operations) [2020-12-10T22:32:31Z] <twentyafterfour@deploy1001> Synchronized php-1.36.0-wmf.21/resources/lib/ooui/oojs-ui-widgets-wikimediaui.css: sync https://gerrit.wikimedia.org/r/c/mediawiki/core/+/647641 to fix T269477 and unblock T264801 (duration: 01m 04s)
Change 658692 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.41.1