Page MenuHomePhabricator
Create Task
Maniphest T269477

[wmf.21-regression] RC/Watchlist -misaligned close icon in oo-ui-tagMultiselectWidget-group
Closed, ResolvedPublic
Actions

Description

The issue is present in betalabs and testwiki wmf.21
For example, Special:Recentchanges

Screen Shot 2020-12-04 at 1.07.56 PM.png (213×851 px, 27 KB)

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.41.1mediawiki/coremaster+335 -133
OOUI: Backport I18799e54ef46232a54d36e86e2b3d08c3ee0a3d5mediawiki/coremaster+4 -2
OOUI: Backport I18799e54ef46232a54d36e86e2b3d08c3ee0a3d5mediawiki/corewmf/1.36.0-wmf.21+4 -2
RCFilters: Temporarily fix TagItemWidget remove button sizemediawiki/coremaster+7 -0
RCFilters: Temporarily fix TagItemWidget remove button sizemediawiki/corewmf/1.36.0-wmf.21+7 -0
themes: Fix TagItem sizeoojs/uimaster+18 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Dec 4 2020, 9:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2020, 9:14 PM
Etonkovidova renamed this task from [betalabs] RC/Watchlist -misaligned close icon in oo-ui-tagMultiselectWidget-group to [wmf.21-regression] RC/Watchlist -misaligned close icon in oo-ui-tagMultiselectWidget-group .Dec 9 2020, 12:08 AM
Etonkovidova added a project: Regression.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a subscriber: Catrope.
MMiller_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Editing-team.Dec 9 2020, 12:29 AM
MMiller_WMF subscribed.

I am adding this to the Growth team's Ready for Development column. @Catrope is going to look at it so that we can prevent this from getting to the production wikis later this week.

MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 9 2020, 12:30 AM
Volker_E triaged this task as High priority.EditedDec 9 2020, 11:11 AM

Yuck, that's also broken on OOUI master. Thanks @Etonkovidova!

gerritbot added a comment.Dec 9 2020, 12:12 PM

Change 647222 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] themes: Fix TagItem size

https://gerrit.wikimedia.org/r/647222

gerritbot added a project: Patch-For-Review.Dec 9 2020, 12:12 PM
gerritbot added a comment.Dec 9 2020, 12:30 PM

Change 647225 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] RCFilters: Temporarily fix TagItemWidget remove button size

https://gerrit.wikimedia.org/r/647225

gerritbot added a comment.Dec 9 2020, 3:44 PM

Change 647222 merged by jenkins-bot:
[oojs/ui@master] themes: Fix TagItem size

https://gerrit.wikimedia.org/r/647222

MMiller_WMF assigned this task to Volker_E.Dec 9 2020, 4:20 PM
Volker_E merged a task: T269810: Close buttons of OOUI tagItem widgets misplaced.Dec 9 2020, 10:49 PM
Volker_E added a subscriber: kaldari.
kaldari merged a task: T269810: Close buttons of OOUI tagItem widgets misplaced.Dec 9 2020, 10:49 PM
Volker_E merged a task: T269801: OOUI tag widget close buttons misaligned on 1.36.0-wmf.21 (search, API sandbox, …).Dec 9 2020, 10:57 PM
Volker_E added subscribers: LucasWerkmeister, Agusbou2015.
Volker_E added a comment.Dec 9 2020, 10:59 PM

Even with above patches, we might need an additional OOUI release, given the number of interfaces that use TagItemWidget. Could need your help Growth team member devs tomorrow.

gerritbot added a comment.Dec 9 2020, 11:29 PM

Change 647225 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Temporarily fix TagItemWidget remove button size

https://gerrit.wikimedia.org/r/647225

• mmodell added a parent task: T264801: 1.36.0-wmf.21 deployment blockers.Dec 9 2020, 11:34 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 10 2020, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 10 2020, 12:10 AM
gerritbot added a comment.Dec 10 2020, 2:17 AM

Change 647305 had a related patch set uploaded (by Catrope; owner: VolkerE):
[mediawiki/core@wmf/1.36.0-wmf.21] RCFilters: Temporarily fix TagItemWidget remove button size

https://gerrit.wikimedia.org/r/647305

gerritbot added a project: Patch-For-Review.Dec 10 2020, 2:17 AM
Catrope added a comment.Dec 10 2020, 2:19 AM
In T269477#6680840, @Volker_E wrote:

Even with above patches, we might need an additional OOUI release, given the number of interfaces that use TagItemWidget. Could need your help Growth team member devs tomorrow.

I'd be happy to help with that, feel free to ping me. I'll also deploy the RCFilters patch in the 19:00 UTC backport window tomorrow.

kaldari added a comment.Dec 10 2020, 4:22 PM

I think we should push out a MediaWiki-wide fix for this ASAP. TagItemWidget is prominently used in the Preferences interface, the Search interface, in ContentTranslation, UploadWizard, etc. Once this hits Wikipedia, a lot of people are going to notice.

• mmodell subscribed.EditedDec 10 2020, 7:27 PM
In T269477#6682564, @kaldari wrote:

I think we should push out a MediaWiki-wide fix for this ASAP. TagItemWidget is prominently used in the Preferences interface, the Search interface, in ContentTranslation, UploadWizard, etc. Once this hits Wikipedia, a lot of people are going to notice.

Do you mean something other than https://gerrit.wikimedia.org/r/c/mediawiki/core/+/647305 ?

This is blocking the train currently, I'm wondering if the above-mentioned temporary fix is enough to unblock the train or do we need something more (like an OOJS/UI update) before wmf.21 goes to all wikis?

gerritbot added a comment.Dec 10 2020, 7:33 PM

Change 647305 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.21] RCFilters: Temporarily fix TagItemWidget remove button size

https://gerrit.wikimedia.org/r/647305

Stashbot added a comment.Dec 10 2020, 7:41 PM

Mentioned in SAL (#wikimedia-operations) [2020-12-10T19:41:54Z] <catrope@deploy1001> Synchronized php-1.36.0-wmf.21/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterTagMultiselectWidget.less: Work around OOUI bug breaking RCFilters UI (T269477) (duration: 01m 04s)

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.21; 2020-12-08); removed MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 10 2020, 8:01 PM
• mmodell added a comment.Dec 10 2020, 8:18 PM

So the temp fix has been deployed, can I remove this as a train blocker?

Volker_E added a comment.EditedDec 10 2020, 8:19 PM

@mmodell Yeah, above patches are not enough. We need to make a backport of either a new OOUI release or similar to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/615434

• mmodell added a comment.EditedDec 10 2020, 8:20 PM

@Volker_E: so the train remains blocked? why even bother with the temp fix then?

Volker_E added a comment.EditedDec 10 2020, 8:27 PM

@mmodell: It was a misguided hope. I'm done with my 5 hours of meetings today and can now care about this.

gerritbot added a comment.Dec 10 2020, 9:02 PM

Change 647790 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] OOUI: Backport I18799e54ef46232a54d36e86e2b3d08c3ee0a3d5

https://gerrit.wikimedia.org/r/647790

gerritbot added a comment.Dec 10 2020, 9:10 PM

Change 647641 had a related patch set uploaded (by Catrope; owner: VolkerE):
[mediawiki/core@wmf/1.36.0-wmf.21] OOUI: Backport I18799e54ef46232a54d36e86e2b3d08c3ee0a3d5

https://gerrit.wikimedia.org/r/647641

gerritbot added a comment.Dec 10 2020, 9:33 PM

Change 647790 merged by jenkins-bot:
[mediawiki/core@master] OOUI: Backport I18799e54ef46232a54d36e86e2b3d08c3ee0a3d5

https://gerrit.wikimedia.org/r/647790

gerritbot added a comment.Dec 10 2020, 9:42 PM

Change 647641 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.21] OOUI: Backport I18799e54ef46232a54d36e86e2b3d08c3ee0a3d5

https://gerrit.wikimedia.org/r/647641

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.22; 2020-12-15); removed MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 10 2020, 10:00 PM
Stashbot mentioned this in T264801: 1.36.0-wmf.21 deployment blockers.Dec 10 2020, 10:32 PM

Mentioned in SAL (#wikimedia-operations) [2020-12-10T22:32:31Z] <twentyafterfour@deploy1001> Synchronized php-1.36.0-wmf.21/resources/lib/ooui/oojs-ui-widgets-wikimediaui.css: sync https://gerrit.wikimedia.org/r/c/mediawiki/core/+/647641 to fix T269477 and unblock T264801 (duration: 01m 04s)

• mmodell closed this task as Resolved.Dec 10 2020, 10:41 PM

Deployed to wmf.21 and seemingly fixed on mediawiki.org

gerritbot added a comment.Jan 26 2021, 11:05 PM

Change 658692 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.41.1

https://gerrit.wikimedia.org/r/658692

gerritbot added a comment.Jan 27 2021, 4:30 PM

Change 658692 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.41.1

https://gerrit.wikimedia.org/r/658692

Esanders merged a task: T269829: TagMultiSelectWidget misaligned "x" in tags.Mar 4 2021, 4:51 PM
Esanders added subscribers: dom_walden, Masumrezarock100.
Volker_E moved this task from Backlog to OOUI-0.41.1 on the OOUI board.Mar 14 2021, 7:36 PM
Volker_E edited projects, added OOUI (OOUI-0.41.1); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL