Page MenuHomePhabricator

dom_walden (Dom Walden)
Test Engineer for Community Tech and Anti-Harassment Tools

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2018, 4:33 PM (193 w, 1 d)
Availability
Available
LDAP User
Dom Walden
MediaWiki User
DWalden (WMF) [ Global Accounts ]

Recent Activity

Today

dom_walden closed T312141: IP Info: Update XTools lang value as Resolved.

This looks fine to me. As this is a trivial change, I will immediately resolve it.

Wed, Jul 6, 10:18 AM · Anti-Harassment (AHaT Sprint 11: The Fascinator), Design, IP Info
dom_walden closed T312141: IP Info: Update XTools lang value, a subtask of T311031: IP Info: Add links to global contribs and xtools, as Resolved.
Wed, Jul 6, 10:18 AM · Anti-Harassment (AHaT Sprint 11: The Fascinator), Design, IP Info
dom_walden added a comment to T254452: Timeline: Page title and timestamp columns flipped if page title is RTL.

@Tchanders Just to check my understanding of the <bdi> tag. It means that the page title should appear the same regardless of the direction of the user's interface language.

Wed, Jul 6, 9:22 AM · Anti-Harassment (AHaT Sprint 11: The Fascinator), I18n, RTL, CheckUser
dom_walden changed the visibility for F35309511: article_rtl_1.png.
Wed, Jul 6, 9:22 AM
dom_walden changed the visibility for F35309508: article_ltr_1.png.
Wed, Jul 6, 9:22 AM
dom_walden changed the visibility for F35309506: article_rtl.png.
Wed, Jul 6, 9:22 AM
dom_walden changed the visibility for F35309504: article_ltr.png.
Wed, Jul 6, 9:22 AM
dom_walden changed the visibility for F35309496: rc_rtl.png.
Wed, Jul 6, 9:21 AM
dom_walden changed the visibility for F35309494: rc_ltr.png.
Wed, Jul 6, 9:21 AM
dom_walden changed the visibility for F35309492: si_rtl.png.
Wed, Jul 6, 9:21 AM
dom_walden changed the visibility for F35309490: si_ltr.png.
Wed, Jul 6, 9:21 AM
dom_walden moved T312141: IP Info: Update XTools lang value from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.
Wed, Jul 6, 6:40 AM · Anti-Harassment (AHaT Sprint 11: The Fascinator), Design, IP Info
dom_walden added a comment to T311032: IP Info: Add links to block log.

I can imagine that even if there are no active blocks a user might want to see the logs to check any past blocks.

That makes sense. I thought we didn't keep information about past blocks (at least not for too long), is that incorrect?

Wed, Jul 6, 6:37 AM · Anti-Harassment (AHaT Sprint 11: The Fascinator), Design, IP Info

Yesterday

dom_walden added a comment to T311032: IP Info: Add links to block log.

@Prtksxna The log link only appears when there is at least one active block. Is that OK? I can imagine that even if there are no active blocks a user might want to see the logs to check any past blocks.

Tue, Jul 5, 2:49 PM · Anti-Harassment (AHaT Sprint 11: The Fascinator), Design, IP Info
dom_walden changed the visibility for F35307126: block_log_link.png.
Tue, Jul 5, 2:47 PM
dom_walden added a comment to T311581: Remove activeTab permission from Who Wrote That? browser extension.

I've tested this briefly on Firefox on enwiki, dewiki and eswiki and Chromium on euwiki and trwiki. Just to see that nothing is obviously broken.

Tue, Jul 5, 12:48 PM · Community-Tech (CommTech-Sprint-28), Who-Wrote-That

Mon, Jul 4

dom_walden moved T310815: RevisionHandler should check whether author is an IP address before looking up data from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.

I looked up 100 revisions which had been added by importing articles on beta.

Mon, Jul 4, 1:22 PM · Anti-Harassment (AHaT Sprint 11: The Fascinator), IP Info
dom_walden added a comment to T311938: IPInfo does not recognize Structured Discussions posts as "edits".

Possibly the same as T310813.

Mon, Jul 4, 7:32 AM · IP Info

Fri, Jul 1

dom_walden moved T310646: Reduce timeouts for prolific editors from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.

Submitting the Special:SimilarEditors form with every user the Similarusers service knows about from the test data.

Fri, Jul 1, 1:49 PM · Anti-Harassment (AHaT Sprint 11: The Fascinator), Patch-For-Review, Similar Editors
dom_walden added a comment to T261215: Math: Support phantom tags.

@Physikerwelt When are we going to do the npm release (sorry I don't know how to do this myself).

Fri, Jul 1, 10:25 AM · Community-Tech (CommTech-Sprint-28), Patch-For-Review, Texvcjs, CommTech-Hackathon-AKA-CodeJam-2022, Math
dom_walden closed T310140: Create action API endpoint in Phonos as Resolved.

I ran every IPA string we have in our test corpus against the new API. There were no errors and it always produced a base64 encoded audio string.

Fri, Jul 1, 8:44 AM · Community-Tech (CommTech-Sprint-27), IPA-Audio-Renderer-Wish-2022
dom_walden added a comment to T311031: IP Info: Add links to global contribs and xtools.

@AGueyte I guess Xtools should be XTools here.

Fri, Jul 1, 7:29 AM · Anti-Harassment (AHaT Sprint 11: The Fascinator), Design, IP Info
dom_walden added a comment to T311031: IP Info: Add links to global contribs and xtools.

@AGueyte If we are setting the XTools URL in the translations file, the URL will depend on the user's interface language. But shouldn't it depend on the current wiki? For example, if you are looking up an IP on frwiki the link to xtools should always be https://xtools.wmflabs.org/ec/fr.wikipedia.org/$ip.

Fri, Jul 1, 7:18 AM · Anti-Harassment (AHaT Sprint 11: The Fascinator), Design, IP Info

Thu, Jun 30

dom_walden added a comment to T261215: Math: Support phantom tags.

We were quite bad in the past in updating the documentation of the functionality. https://www.ctan.org/pkg/texvc The idea is that if you include only the texvc package in a plain latex document you can compile tex from MediaWiki without undefined macros. If phantom is part of core tex there might be no need to change anything in the package documentation.

Thu, Jun 30, 1:38 PM · Community-Tech (CommTech-Sprint-28), Patch-For-Review, Texvcjs, CommTech-Hackathon-AKA-CodeJam-2022, Math
dom_walden added a comment to T261215: Math: Support phantom tags.

I am happy to share a text or a link. However, you can also do it yourself. I can't find time to write reasonable documentation in the near future.

Thu, Jun 30, 1:29 PM · Community-Tech (CommTech-Sprint-28), Patch-For-Review, Texvcjs, CommTech-Hackathon-AKA-CodeJam-2022, Math
dom_walden moved T310759: Fix interface messages for IP Info from Needs Design/Product 🎨 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.

Thanks for pointing this out @dom_walden. You're right things have gotten inconsistent with the capitalization and the naming of the product. I've created T311683: IP Info: Audit capitalization in messages to track this. If the initial scope of the task is complete, would it be okay to move this to the done column and do the other changes as part of the new task?

Thu, Jun 30, 12:07 PM · Anti-Harassment (AHaT Sprint 11: The Fascinator), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), IP Info, Design
dom_walden updated subscribers of T261215: Math: Support phantom tags.

@dom_walden can you coordinate with @akosiaris about the deployment of the latest image at the moment (https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/809194)

Thu, Jun 30, 10:58 AM · Community-Tech (CommTech-Sprint-28), Patch-For-Review, Texvcjs, CommTech-Hackathon-AKA-CodeJam-2022, Math
dom_walden added a comment to T310140: Create action API endpoint in Phonos.

I'm not even sure we should be returning the SSML to the client :-) It's not used for anything. I just added it because there's a chance that it can be used by the in-browser speech synthesis API (which we're not using nor planning on using).

Thu, Jun 30, 9:17 AM · Community-Tech (CommTech-Sprint-27), IPA-Audio-Renderer-Wish-2022
dom_walden added a comment to T310140: Create action API endpoint in Phonos.

Further to what I was saying yesterday, making the request from the example (http://localhost:8081/w/api.php?action=phonos&format=json&ipa=h%C9%99%CB%88l%C9%99%CA%8A&text=hello&lang=en) the return value is:

{
    "phonos": {
        "ssml": "<?xml version=\"1.0\"?>\n<speak xmlns=\"http://www.w3.org/2001/10/synthesis\" version=\"1.1\" xml:lang=\"en\"><phoneme alphabet=\"ipa\" ph=\"h&#x259;&#x2C8;l&#x259;&#x28A;\">hello</phoneme></speak>\n",
        ...
    }
}

With the hex-encoded IPA notation. I don't know if this is OK.

Thu, Jun 30, 8:28 AM · Community-Tech (CommTech-Sprint-27), IPA-Audio-Renderer-Wish-2022
dom_walden created T311684: Preserve scroll position of editing pane when opening/closing Realtime Preview.
Thu, Jun 30, 7:08 AM · Community-Tech (CommTech-Sprint-28), Realtime-Preview-Wish-2021
dom_walden added a comment to T311496: Linter highlight is removed when realtime preview loads.

@Samwilson I guess you will also need to fix this bug in CodeMirror? The highlighting still gets removed there when opening/closing RTP.

Thu, Jun 30, 6:46 AM · Community-Tech (CommTech-Sprint-28), Realtime-Preview-Wish-2021, MediaWiki-extensions-Linter, WikiEditor

Wed, Jun 29

dom_walden added a comment to T261215: Math: Support phantom tags.

@dom_walden how is your availability in the near future? If we deploy the new mathoid version you or someone from your team should be around. Also is there a mechanism from Community-Tech to announce the change to the community? I remember a few years ago @JStrodt_WMDE wrote a very nice post about a "whish" implemented by the math community that I could also use for distribution within the math channels.

Wed, Jun 29, 2:06 PM · Community-Tech (CommTech-Sprint-28), Patch-For-Review, Texvcjs, CommTech-Hackathon-AKA-CodeJam-2022, Math
dom_walden added a comment to T310140: Create action API endpoint in Phonos.

I guess phenome should be phoneme here?:

"apihelp-phonos-param-ipa": "The IPA phenome to render."
Wed, Jun 29, 8:56 AM · Community-Tech (CommTech-Sprint-27), IPA-Audio-Renderer-Wish-2022
dom_walden moved T307659: Popup transparent after using direct unwatch marker in Special:Watchlist from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.
AC
  • Remove the button when something is watchlisted
Wed, Jun 29, 6:38 AM · Anti-Harassment (AHaT Sprint 11: The Fascinator), Patch-For-Review, IP Info

Tue, Jun 28

dom_walden moved T305451: Investigate: IP Info Feedback template returns broken syntax [8H] from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

Feedback link now goes to https://meta.wikimedia.org/wiki/IP_Editing:_Privacy_Enhancement_and_Abuse_Mitigation/IP_Info_feature/Feedback?action=edit&section=new&preloadtitle=Feedback+from+Dom+walden&preload=Special%3AMyLanguage%2FTemplate%3AIPInfoFeedback regardless of the user's interface language.

Tue, Jun 28, 12:50 PM · Anti-Harassment (AHaT Sprint 10: The Mokorotlo), MW-1.39-notes (1.39.0-wmf.10; 2022-05-02), I18n, WikimediaMessages, IP Info
dom_walden added a comment to T310140: Create action API endpoint in Phonos.

@Samwilson When I don't include the text parameter I get an error:

{
    "error": {
        "code": "internal_api_error_TypeError",
        "info": "[4540245937393c630e235698] Exception caught: Argument 2 passed to MediaWiki\\Extension\\Phonos\\Engine\\EspeakEngine::getAudioData() must be of the type string, null given, called in /var/www/html/w/extensions/Phonos/includes/PhonosApi.php on line 35",
        "errorclass": "TypeError",
        "*": "TypeError at /var/www/html/w/extensions/Phonos/includes/Engine/EspeakEngine.php(16)\nfrom /var/www/html/w/extensions/Phonos/includes/Engine/EspeakEngine.php(16)\n#0 /var/www/html/w/extensions/Phonos/includes/PhonosApi.php(35): MediaWiki\\Extension\\Phonos\\Engine\\EspeakEngine->getAudioData(string, NULL, string)\n#1 /var/www/html/w/includes/api/ApiMain.php(1901): MediaWiki\\Extension\\Phonos\\PhonosApi->execute()\n#2 /var/www/html/w/includes/api/ApiMain.php(875): ApiMain->executeAction()\n#3 /var/www/html/w/includes/api/ApiMain.php(846): ApiMain->executeActionWithErrorHandling()\n#4 /var/www/html/w/api.php(90): ApiMain->execute()\n#5 /var/www/html/w/api.php(45): wfApiMain()\n#6 {main}"
    },
    "servedby": "6aed8d9700af"
}

Should the text parameter be required or will that depend on the specific engine?

Tue, Jun 28, 9:29 AM · Community-Tech (CommTech-Sprint-27), IPA-Audio-Renderer-Wish-2022
dom_walden moved T311030: IP Info: Add help text for ASN from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

Here is what the popup looks like on beta, Vector 2022, English:

asn_popup_beta.png (339×1 px, 48 KB)

Tue, Jun 28, 9:10 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Design, IP Info
dom_walden changed the visibility for F35283165: asn_popup_beta.png.
Tue, Jun 28, 9:06 AM
dom_walden moved T309329: Preloading with Special:MyLanguage broken when the UI language is same as the content language from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

The bug is no longer reproducible on beta in wikieditor or visualeditor.

Tue, Jun 28, 7:44 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Patch-For-Review, I18n, MediaWiki-Internationalization, MediaWiki-Page-editing

Mon, Jun 27

dom_walden added a comment to T309400: Add a type selector to the ipinfo log.

The language was proposed by @STran in the patch (see previous and updated wording side-by-side). If you all think another wording is better, please let me know, I can upload another patch to change it.

Mon, Jun 27, 11:43 AM · Patch-For-Review, Anti-Harassment (AHaT Sprint 11: The Fascinator), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-MarcoAurelio, IP Info
dom_walden moved T309035: Add links to interaction timeline from Special:SimilarEditors results from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

We should link to the:

  • interaction timeline tool: https://interaction-timeline.toolforge.org/
  • filtered to the input user and the user from that row
  • filtered to the wiki on which Special:SimilarEditors is being visited filtered to enwiki, with a comment referencing T309675
  • not filtered to a particular time period
Mon, Jun 27, 10:33 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Similar Editors
dom_walden added a comment to T310646: Reduce timeouts for prolific editors.

@dom_walden If beta is now broken, I may need to revert the patch for this until we've fixed the production config - let me know if you find this is the case before I do...

Mon, Jun 27, 10:18 AM · Anti-Harassment (AHaT Sprint 11: The Fascinator), Patch-For-Review, Similar Editors
dom_walden changed the visibility for F35280029: not_available.png.
Mon, Jun 27, 9:25 AM
dom_walden changed the visibility for F35280032: no_access.png.
Mon, Jun 27, 9:25 AM
dom_walden moved T309829: Show different labels for IP info when data isn't available vs when there is no access from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

User with full viewing rights but no data:

not_available.png (341×1 px, 41 KB)

Mon, Jun 27, 9:19 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Design, IP Info

Fri, Jun 24

dom_walden moved T309400: Add a type selector to the ipinfo log from QA/Testing 🐞 to Design Review 🔬 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

Due to the above error I couldn't test this on beta but I have tested it locally.

Fri, Jun 24, 2:57 PM · Patch-For-Review, Anti-Harassment (AHaT Sprint 11: The Fascinator), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-MarcoAurelio, IP Info
dom_walden changed the visibility for F35271929: ipinfo_log_type_dropdown.png.
Fri, Jun 24, 2:50 PM
dom_walden added a comment to T310815: RevisionHandler should check whether author is an IP address before looking up data.

I believe one side affect of this is the error on beta (recorded here: T309400#8025778). There are records in the logs of IPInfo lookups which are not of actual IP addresses.

Fri, Jun 24, 2:15 PM · Anti-Harassment (AHaT Sprint 11: The Fascinator), IP Info
dom_walden added a comment to T309400: Add a type selector to the ipinfo log.
Fri, Jun 24, 2:14 PM · Patch-For-Review, Anti-Harassment (AHaT Sprint 11: The Fascinator), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-MarcoAurelio, IP Info
dom_walden added a comment to T309400: Add a type selector to the ipinfo log.

@MarcoAurelio Trying to access the IPInfo logs on beta (https://en.wikipedia.beta.wmflabs.org/wiki/Special:Log?type=ipinfo&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers) I get the exception:

[YrXCZWGXEEzZDXncyWtEDQAAAAk] /wiki/Special:Log?type=ipinfo&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers InvalidArgumentException: Invalid IP address
Fri, Jun 24, 1:58 PM · Patch-For-Review, Anti-Harassment (AHaT Sprint 11: The Fascinator), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-MarcoAurelio, IP Info
dom_walden added a comment to T310759: Fix interface messages for IP Info.

@Niharika How far do we want to go with these changes?

Fri, Jun 24, 8:33 AM · Anti-Harassment (AHaT Sprint 11: The Fascinator), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), IP Info, Design
dom_walden changed the visibility for F35270303: disable_instructions.png.
Fri, Jun 24, 6:44 AM
dom_walden added a comment to T310759: Fix interface messages for IP Info.

@Diesel_kapasule ipinfo-infobox-disable-instructions isn't displaying for me correctly on beta. It displays as: If you'd like to disable this feature you can do so from [[{{#special:Preferences}}]].

Fri, Jun 24, 6:27 AM · Anti-Harassment (AHaT Sprint 11: The Fascinator), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), IP Info, Design

Thu, Jun 23

dom_walden added a comment to T309035: Add links to interaction timeline from Special:SimilarEditors results.

@STran We might need to URL encode after all.

Thu, Jun 23, 10:19 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Similar Editors
dom_walden moved T310454: IP Info: Add IP version information in box from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

How it looks on beta for an IPv4 address (beta does not support IPv6).

ip_version_beta.png (342×1 px, 41 KB)

Thu, Jun 23, 9:08 AM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), IP Info
dom_walden changed the visibility for F35267325: ip_version_beta.png.
Thu, Jun 23, 9:06 AM
dom_walden moved T309232: Similarusers service should check for 'user' key in results returned from Revisions API from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

I used a script to submit the Special:SimilarEditors form for every user it knows about. I then compared the number of results, MW logs and Similaruser logs to data I had collected for a previous version of the Similarusers service.

Thu, Jun 23, 9:02 AM · Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Platform Engineering, Similar Editors

Wed, Jun 22

dom_walden created T311128: Shortcut key does not work on Mac.
Wed, Jun 22, 12:02 PM · Realtime-Preview-Wish-2021, Community-Tech
dom_walden moved T309830: Remove italics from the IP info legal disclaimer label from Design Review 🔬 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

Notice that the Not Available is also in italics. @Prtksxna do we want that removed as well?

We want to keep the italics here, but yeah, it'll break in all the same ways as the legal disclaimer. There is a longer discussion that Thalia and I need to have around text emphasis in non-latin languages, will create relevant tickets once we do.

Wed, Jun 22, 9:16 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Design, IP Info
dom_walden moved T310491: Don't show table of results on Special:SimilarEditors if there are no similar editors from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

Here is what the example from the description looks like now:

no_results_now.png (442×1 px, 40 KB)

Wed, Jun 22, 7:42 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Similar Editors
dom_walden changed the visibility for F35262685: no_results_now.png.
Wed, Jun 22, 7:41 AM
dom_walden changed the visibility for F35182259: only_headers.png.
Wed, Jun 22, 7:38 AM
dom_walden changed the visibility for F35258592: removed_italics.png.
Wed, Jun 22, 7:11 AM
dom_walden added a comment to T310454: IP Info: Add IP version information in box.

@Prtksxna I assume we don't want VERSION to be capitalised?

Wed, Jun 22, 6:38 AM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), IP Info
dom_walden moved T310508: Improve test coverage of Rest/Presenter/DefaultPresenter.php from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

Rest/Presenter/DefaultPresenter.php now reports 100% coverage: https://doc.wikimedia.org/cover-extensions/IPInfo/Rest/Presenter/DefaultPresenter.php.html

Wed, Jun 22, 6:24 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Test-Coverage, IP Info
dom_walden moved T310505: Improve test coverage of Jobs/LogIPInfoAccessJob.php from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

Jobs/LogIPInfoAccessJob.php now reports 100% code coverage: https://doc.wikimedia.org/cover-extensions/IPInfo/Jobs/LogIPInfoAccessJob.php.html

Wed, Jun 22, 6:14 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Test-Coverage, IP Info

Tue, Jun 21

dom_walden changed the visibility for F35248536: unjump.gif.
Tue, Jun 21, 7:05 AM
dom_walden moved T309830: Remove italics from the IP info legal disclaimer label from QA/Testing 🐞 to Design Review 🔬 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

Here is what is looks like on beta on the Vector 2022 skin in English:

removed_italics.png (293×1 px, 35 KB)

Tue, Jun 21, 6:41 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Design, IP Info

Fri, Jun 17

dom_walden created T310857: Special:SimilarEditors is a GET so username being investigated will be visible in transit.
Fri, Jun 17, 7:20 AM · Patch-For-Review, Similar Editors, Anti-Harassment
dom_walden moved T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022 from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-26) board.

I have briefly tested editing on WikiEditor and VisualEditor on enwiki, fawiki, viwiki and plwiki.

Fri, Jun 17, 7:11 AM · Community-Tech (CommTech-Sprint-28), Editing-team, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Patch-For-Review, Desktop Improvements, Realtime-Preview-Wish-2021
dom_walden moved T309542: IPInfo icon not shown in mw-contributions-blocked-notice from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

How Special:Contributions looks when the IP is blocked:
{F35248573}

Fri, Jun 17, 6:44 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), IP Info
dom_walden added a comment to T310813: Investigate: IPInfo buttons not always showing on Special:RecentChanges [8H].

The rows where the IPInfo icon does not appear next to IP addresses also do a jump (the opposite of this bug T271486).

unjump.gif (480×640 px, 198 KB)

Fri, Jun 17, 6:23 AM · Anti-Harassment (AHaT Sprint 11: The Fascinator), IP Info

Thu, Jun 16

dom_walden added a comment to T310537: [Regression] Minerva notification count is not localized to current language.

@dom_walden I am unable to replicate that and not seeing any visual regressions like that on https://pixel.wmcloud.org/reports/echo/index.html. Are you sure you are running the master version of Echo, MobileFrontend and Minerva? (note all 3 of those currently have code relating to Echo)

Thu, Jun 16, 11:47 AM · Regression, MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Readers-Web-Backlog (Kanbanana-FY-2021-22), MinervaNeue, Notifications

Wed, Jun 15

dom_walden added a comment to T309232: Similarusers service should check for 'user' key in results returned from Revisions API.

@Tchanders I didn't spot these before, but there seem to be some other cases where we get the same error.

Wed, Jun 15, 12:10 PM · Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Platform Engineering, Similar Editors
dom_walden moved T308581: Add help link to Special:SimilarEditors from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

The link goes to: https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Extension:SimilarEditors (which I assume is correct assuming the help page will be translated one day).

Wed, Jun 15, 9:01 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Anti-Harassment (AHaT Sprint 10: The Mokorotlo), Similar Editors
dom_walden added a comment to T310537: [Regression] Minerva notification count is not localized to current language.

@Jdlrobson Here is what Minerva looks like on my local docker server, I am not sure what is happening:

minerva_alert.png (423×1 px, 32 KB)

Wed, Jun 15, 8:57 AM · Regression, MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Readers-Web-Backlog (Kanbanana-FY-2021-22), MinervaNeue, Notifications

Tue, Jun 14

dom_walden added a comment to T294977: Investigate: Match the preview area to the wikitext area.

@Samwilson I find the auto-scrolling does not happen when syntax highlighting (CodeMirror) is on. Is this expected?

Tue, Jun 14, 7:24 AM · Community-Tech (CommTech-Sprint-28), MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Realtime-Preview-Wish-2021
dom_walden moved T309420: [[MediaWiki:Logentry-ipinfo-change access]] i18n issue from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 9: The Beret) board.

Here is how the message in Special:Log looks in English.

Tue, Jun 14, 7:01 AM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Anti-Harassment (AHaT Sprint 9: The Beret), Gender-Support, I18n, IP Info
dom_walden created T310569: InvalidArgumentException: Unknown cluster 'extension2'.
Tue, Jun 14, 6:37 AM · Beta-Cluster-reproducible, Beta-Cluster-Infrastructure
dom_walden moved T307023: Display results of Special:SimilarEditors from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 9: The Beret) board.

Thanks @Tchanders. I have nothing more to add here.

Tue, Jun 14, 6:15 AM · Anti-Harassment (AHaT Sprint 9: The Beret), MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), Similar Editors

Mon, Jun 13

dom_walden closed T309264: Use ResourceLoader to load onboarding SVG rather than direct CSS URL as Resolved.

Here is the SVG on beta wikisource:

svg_rl.png (513×765 px, 83 KB)

Mon, Jun 13, 2:10 PM · Technical-Debt, MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Community-Tech (CommTech-Sprint-26), Wikimedia OCR
dom_walden moved T309983: Conditionally show some GuidedTour steps on Special:Investigate from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 9: The Beret) board.

I have tested the GuidedTour in Special:Investigate in each of the below cases:

User has block rightsWiki has VE
yesyes
yesno
noyes
nono
Mon, Jun 13, 1:14 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Anti-Harassment (AHaT Sprint 9: The Beret), CheckUser
dom_walden moved T309330: TypeError: this.button is undefined / TypeError: Cannot read properties of undefined (reading 'isVisible') from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-26) board.

I loaded the WikiEditor/CodeEditor for pages in various namespaces on beta wikisource (where RTP is loaded as a gadget).

Mon, Jun 13, 9:38 AM · Community-Tech (CommTech-Sprint-27), MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), JavaScript, Realtime-Preview-Wish-2021, Wikimedia-production-error
dom_walden moved T307039: CodeEditor resize broken with realtimepreview layout from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-26) board.

The CodeEditor resize now works on beta wikisource, where RTP is loaded as a gadget. See, for example, https://en.wikisource.beta.wmflabs.org/w/index.php?title=MediaWiki:Common.js/watchlist.js&action=edit.

Mon, Jun 13, 9:35 AM · Community-Tech (CommTech-Sprint-27), CodeEditor, Realtime-Preview-Wish-2021
dom_walden moved T308176: CodeEditor is broken with realtime preview enabled from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-26) board.

I tested a few pages on beta wikisource where the CodeEditor is used (e.g. here, here, here). The Realtime Preview does not get loaded. The regular CodeEditor behaves as I understand it should. All the basic functionality appears to function.

Mon, Jun 13, 9:31 AM · Community-Tech (CommTech-Sprint-27), Realtime-Preview-Wish-2021, WikiEditor, CodeEditor
dom_walden added a comment to T308176: CodeEditor is broken with realtime preview enabled.

@dom_walden: Yes, that's correct. Sorry, I should've thought of this before — I've now added it as a default gadget on Beta English Wikisource (e.g.). You'll have to turn off the beta feature.

Mon, Jun 13, 8:14 AM · Community-Tech (CommTech-Sprint-27), Realtime-Preview-Wish-2021, WikiEditor, CodeEditor
dom_walden added a comment to T308176: CodeEditor is broken with realtime preview enabled.

I don't think there is much I can do to test this at the moment.

Mon, Jun 13, 7:27 AM · Community-Tech (CommTech-Sprint-27), Realtime-Preview-Wish-2021, WikiEditor, CodeEditor
dom_walden moved T294589: Pulsating UI to onboard users to new Preview feature in toolbar from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-26) board.

Acceptance Criteria

  • The pulsating UI should appear upon first exposure to the functionality
Mon, Jun 13, 6:37 AM · Community-Tech (CommTech-Sprint-27), MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Realtime-Preview-Wish-2021

Fri, Jun 10

dom_walden added a comment to T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022.

Test report for beta:

Fri, Jun 10, 3:08 PM · Community-Tech (CommTech-Sprint-28), Editing-team, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Patch-For-Review, Desktop Improvements, Realtime-Preview-Wish-2021
dom_walden added a comment to T310309: VE opens at full-width in Vector (2022) in some situations.

Thanks @dom_walden, that's a good one to remember. I think it might be the same as Case #2 above, in that it requires directly going to ?action=edit. Can you confirm that it doesn't happen if you first go to https://en.wikipedia.beta.wmflabs.org/wiki/Talk:ET11/Archive_1 and then click Add topic? In that case, it should load within the narrow view (because the page doesn't reload). It's only if you're already editing and then click Add topic that it ends up wide.

Fri, Jun 10, 11:06 AM · Community-Tech (CommTech-Sprint-29), VisualEditor
dom_walden created T310336: Call to a member function canManage() on null.
Fri, Jun 10, 7:48 AM · Beta-Cluster-reproducible, MediaWiki-extensions-Newsletter
dom_walden added a comment to T310309: VE opens at full-width in Vector (2022) in some situations.

This also affects the "Add topic" functionality (sorry I don't know if this has a special name). I am guessing it has the same underlying cause, but let me know if you want a separate bug.

Fri, Jun 10, 7:00 AM · Community-Tech (CommTech-Sprint-29), VisualEditor
dom_walden updated subscribers of T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022.

Related: @NRodriguez would it be alright for the Editing Team to assume CommTech will be able to take care of this QA?

Fri, Jun 10, 6:27 AM · Community-Tech (CommTech-Sprint-28), Editing-team, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Patch-For-Review, Desktop Improvements, Realtime-Preview-Wish-2021

Thu, Jun 9

dom_walden updated subscribers of T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022.

@EAkinloose found this bug on beta. Notice that the image slightly overflows its border on the right:

images_overflow_right.png (413×1 px, 216 KB)

Page: https://en.wikipedia.beta.wmflabs.org/wiki/Cat?veaction=edit

Thu, Jun 9, 2:13 PM · Community-Tech (CommTech-Sprint-28), Editing-team, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Patch-For-Review, Desktop Improvements, Realtime-Preview-Wish-2021
dom_walden added a comment to T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022.

@Samwilson After clicking "Show Preview" or "Show changes" the WikiEditor is not full-width.

Thu, Jun 9, 10:29 AM · Community-Tech (CommTech-Sprint-28), Editing-team, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Patch-For-Review, Desktop Improvements, Realtime-Preview-Wish-2021
dom_walden added a comment to T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022.

@Samwilson I find that when I open the WikiEditor and then switch to VE, the VE editor is full-width. However, if I go to VE first VE is not full-width.

Thu, Jun 9, 10:20 AM · Community-Tech (CommTech-Sprint-28), Editing-team, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Patch-For-Review, Desktop Improvements, Realtime-Preview-Wish-2021
dom_walden moved T309235: URL encode user name in Similarusers service request URL from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 9: The Beret) board.

I tested for two risks:

  • SimilarEditors extension sends invalid URLs.
  • URL encoding the username means the similarusers service looks up a different username than the one intended.
Thu, Jun 9, 8:53 AM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Anti-Harassment (AHaT Sprint 9: The Beret), Similar Editors

Wed, Jun 8

dom_walden moved T309618: Restrict SimilarEditors to work with the same wikis that the Similarusers service works with from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 9: The Beret) board.
  • Allow any user to be entered in the user input (ideally we would allow any user that exists on English Wikipedia, but I don't think that complexity is necessary for this temporary change)
Wed, Jun 8, 3:52 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Anti-Harassment (AHaT Sprint 9: The Beret), Similar Editors

Tue, Jun 7

dom_walden created T310064: Coordinates stick to top right of Realtime Preview pane.
Tue, Jun 7, 12:08 PM · Realtime-Preview-Wish-2021, Community-Tech
dom_walden moved T309363: Hide the "IP Information" infobox header from mobile from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 9: The Beret) board.

The infobox does not appear on mobile view (e.g. https://en.m.wikipedia.beta.wmflabs.org).

Tue, Jun 7, 9:12 AM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Anti-Harassment (AHaT Sprint 9: The Beret), IP Info