This looks fine to me. As this is a trivial change, I will immediately resolve it.

@Tchanders Just to check my understanding of the <bdi> tag. It means that the page title should appear the same regardless of the direction of the user's interface language.

In T311032#8054203, @Prtksxna wrote:

In T311032#8051958, @dom_walden wrote:

I can imagine that even if there are no active blocks a user might want to see the logs to check any past blocks.

That makes sense. I thought we didn't keep information about past blocks (at least not for too long), is that incorrect?

@Prtksxna The log link only appears when there is at least one active block. Is that OK? I can imagine that even if there are no active blocks a user might want to see the logs to check any past blocks.

I've tested this briefly on Firefox on enwiki, dewiki and eswiki and Chromium on euwiki and trwiki. Just to see that nothing is obviously broken.

I looked up 100 revisions which had been added by importing articles on beta.

Possibly the same as T310813.

Submitting the Special:SimilarEditors form with every user the Similarusers service knows about from the test data.

@Physikerwelt When are we going to do the npm release (sorry I don't know how to do this myself).

I ran every IPA string we have in our test corpus against the new API. There were no errors and it always produced a base64 encoded audio string.

@AGueyte I guess Xtools should be XTools here.

@AGueyte If we are setting the XTools URL in the translations file, the URL will depend on the user's interface language. But shouldn't it depend on the current wiki? For example, if you are looking up an IP on frwiki the link to xtools should always be https://xtools.wmflabs.org/ec/fr.wikipedia.org/$ip.

In T261215#8040238, @Physikerwelt wrote:

We were quite bad in the past in updating the documentation of the functionality. https://www.ctan.org/pkg/texvc The idea is that if you include only the texvc package in a plain latex document you can compile tex from MediaWiki without undefined macros. If phantom is part of core tex there might be no need to change anything in the package documentation.

In T261215#8040127, @Physikerwelt wrote:

I am happy to share a text or a link. However, you can also do it yourself. I can't find time to write reasonable documentation in the near future.

In T310759#8038987, @Prtksxna wrote:

Thanks for pointing this out @dom_walden. You're right things have gotten inconsistent with the capitalization and the naming of the product. I've created T311683: IP Info: Audit capitalization in messages to track this. If the initial scope of the task is complete, would it be okay to move this to the done column and do the other changes as part of the new task?

In T261215#8037329, @Physikerwelt wrote:

@dom_walden can you coordinate with @akosiaris about the deployment of the latest image at the moment (https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/809194)

In T310140#8039493, @Samwilson wrote:

I'm not even sure we should be returning the SSML to the client :-) It's not used for anything. I just added it because there's a chance that it can be used by the in-browser speech synthesis API (which we're not using nor planning on using).

Further to what I was saying yesterday, making the request from the example (http://localhost:8081/w/api.php?action=phonos&format=json&ipa=h%C9%99%CB%88l%C9%99%CA%8A&text=hello&lang=en) the return value is:

{
    "phonos": {
        "ssml": "<?xml version=\"1.0\"?>\n<speak xmlns=\"http://www.w3.org/2001/10/synthesis\" version=\"1.1\" xml:lang=\"en\"><phoneme alphabet=\"ipa\" ph=\"h&#x259;&#x2C8;l&#x259;&#x28A;\">hello</phoneme></speak>\n",
        ...
    }
}

With the hex-encoded IPA notation. I don't know if this is OK.

@Samwilson I guess you will also need to fix this bug in CodeMirror? The highlighting still gets removed there when opening/closing RTP.

In T261215#8036880, @Physikerwelt wrote:

@dom_walden how is your availability in the near future? If we deploy the new mathoid version you or someone from your team should be around. Also is there a mechanism from Community-Tech to announce the change to the community? I remember a few years ago @JStrodt_WMDE wrote a very nice post about a "whish" implemented by the math community that I could also use for distribution within the math channels.

I guess phenome should be phoneme here?:

"apihelp-phonos-param-ipa": "The IPA phenome to render."

AC

• Remove the button when something is watchlisted

Feedback link now goes to https://meta.wikimedia.org/wiki/IP_Editing:_Privacy_Enhancement_and_Abuse_Mitigation/IP_Info_feature/Feedback?action=edit&section=new&preloadtitle=Feedback+from+Dom+walden&preload=Special%3AMyLanguage%2FTemplate%3AIPInfoFeedback regardless of the user's interface language.

@Samwilson When I don't include the text parameter I get an error:

{
    "error": {
        "code": "internal_api_error_TypeError",
        "info": "[4540245937393c630e235698] Exception caught: Argument 2 passed to MediaWiki\\Extension\\Phonos\\Engine\\EspeakEngine::getAudioData() must be of the type string, null given, called in /var/www/html/w/extensions/Phonos/includes/PhonosApi.php on line 35",
        "errorclass": "TypeError",
        "*": "TypeError at /var/www/html/w/extensions/Phonos/includes/Engine/EspeakEngine.php(16)\nfrom /var/www/html/w/extensions/Phonos/includes/Engine/EspeakEngine.php(16)\n#0 /var/www/html/w/extensions/Phonos/includes/PhonosApi.php(35): MediaWiki\\Extension\\Phonos\\Engine\\EspeakEngine->getAudioData(string, NULL, string)\n#1 /var/www/html/w/includes/api/ApiMain.php(1901): MediaWiki\\Extension\\Phonos\\PhonosApi->execute()\n#2 /var/www/html/w/includes/api/ApiMain.php(875): ApiMain->executeAction()\n#3 /var/www/html/w/includes/api/ApiMain.php(846): ApiMain->executeActionWithErrorHandling()\n#4 /var/www/html/w/api.php(90): ApiMain->execute()\n#5 /var/www/html/w/api.php(45): wfApiMain()\n#6 {main}"
    },
    "servedby": "6aed8d9700af"
}

Should the text parameter be required or will that depend on the specific engine?

Here is what the popup looks like on beta, Vector 2022, English:

The bug is no longer reproducible on beta in wikieditor or visualeditor.

• https://commons.wikimedia.beta.wmflabs.org/wiki/IP_Editing:_Privacy_Enhancement_and_Abuse_Mitigation/IP_Info_feature/Feedback?action=edit&section=new&preload=Special%3AMyLanguage%2FTemplate%3AIPInfoFeedback&uselang=en
• https://commons.wikimedia.beta.wmflabs.org/wiki/IP_Editing:_Privacy_Enhancement_and_Abuse_Mitigation/IP_Info_feature/Feedback?veaction=edit&section=new&preload=Special%3AMyLanguage%2FTemplate%3AIPInfoFeedback&uselang=en

In T309400#8026215, @MarcoAurelio wrote:

The language was proposed by @STran in the patch (see previous and updated wording side-by-side). If you all think another wording is better, please let me know, I can upload another patch to change it.

We should link to the:

• interaction timeline tool: https://interaction-timeline.toolforge.org/
• filtered to the input user and the user from that row
• filtered to the wiki on which Special:SimilarEditors is being visited filtered to enwiki, with a comment referencing T309675
• not filtered to a particular time period

In T310646#8026239, @Tchanders wrote:

@dom_walden If beta is now broken, I may need to revert the patch for this until we've fixed the production config - let me know if you find this is the case before I do...

User with full viewing rights but no data:

Due to the above error I couldn't test this on beta but I have tested it locally.

I believe one side affect of this is the error on beta (recorded here: T309400#8025778). There are records in the logs of IPInfo lookups which are not of actual IP addresses.

In T309400#8025778, @dom_walden wrote:

@MarcoAurelio Trying to access the IPInfo logs on beta (https://en.wikipedia.beta.wmflabs.org/wiki/Special:Log?type=ipinfo&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers) I get the exception:

@MarcoAurelio Trying to access the IPInfo logs on beta (https://en.wikipedia.beta.wmflabs.org/wiki/Special:Log?type=ipinfo&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers) I get the exception:

[YrXCZWGXEEzZDXncyWtEDQAAAAk] /wiki/Special:Log?type=ipinfo&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers InvalidArgumentException: Invalid IP address

@Niharika How far do we want to go with these changes?

@Diesel_kapasule ipinfo-infobox-disable-instructions isn't displaying for me correctly on beta. It displays as: If you'd like to disable this feature you can do so from [[{{#special:Preferences}}]].

@STran We might need to URL encode after all.

How it looks on beta for an IPv4 address (beta does not support IPv6).

I used a script to submit the Special:SimilarEditors form for every user it knows about. I then compared the number of results, MW logs and Similaruser logs to data I had collected for a previous version of the Similarusers service.

In T309830#8018699, @Prtksxna wrote:

In T309830#8015672, @dom_walden wrote:

Notice that the Not Available is also in italics. @Prtksxna do we want that removed as well?

We want to keep the italics here, but yeah, it'll break in all the same ways as the legal disclaimer. There is a longer discussion that Thalia and I need to have around text emphasis in non-latin languages, will create relevant tickets once we do.

Here is what the example from the description looks like now:

@Prtksxna I assume we don't want VERSION to be capitalised?

Rest/Presenter/DefaultPresenter.php now reports 100% coverage: https://doc.wikimedia.org/cover-extensions/IPInfo/Rest/Presenter/DefaultPresenter.php.html

Jobs/LogIPInfoAccessJob.php now reports 100% code coverage: https://doc.wikimedia.org/cover-extensions/IPInfo/Jobs/LogIPInfoAccessJob.php.html

Here is what is looks like on beta on the Vector 2022 skin in English:

I have briefly tested editing on WikiEditor and VisualEditor on enwiki, fawiki, viwiki and plwiki.

How Special:Contributions looks when the IP is blocked:
{F35248573}

The rows where the IPInfo icon does not appear next to IP addresses also do a jump (the opposite of this bug T271486).

In T310537#8006450, @Jdlrobson wrote:

@dom_walden I am unable to replicate that and not seeing any visual regressions like that on https://pixel.wmcloud.org/reports/echo/index.html. Are you sure you are running the master version of Echo, MobileFrontend and Minerva? (note all 3 of those currently have code relating to Echo)

@Tchanders I didn't spot these before, but there seem to be some other cases where we get the same error.

The link goes to: https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Extension:SimilarEditors (which I assume is correct assuming the help page will be translated one day).

@Jdlrobson Here is what Minerva looks like on my local docker server, I am not sure what is happening:

@Samwilson I find the auto-scrolling does not happen when syntax highlighting (CodeMirror) is on. Is this expected?

Here is how the message in Special:Log looks in English.

Thanks @Tchanders. I have nothing more to add here.

Here is the SVG on beta wikisource:

I have tested the GuidedTour in Special:Investigate in each of the below cases:

I loaded the WikiEditor/CodeEditor for pages in various namespaces on beta wikisource (where RTP is loaded as a gadget).

The CodeEditor resize now works on beta wikisource, where RTP is loaded as a gadget. See, for example, https://en.wikisource.beta.wmflabs.org/w/index.php?title=MediaWiki:Common.js/watchlist.js&action=edit.

I tested a few pages on beta wikisource where the CodeEditor is used (e.g. here, here, here). The Realtime Preview does not get loaded. The regular CodeEditor behaves as I understand it should. All the basic functionality appears to function.

In T308176#7997761, @Samwilson wrote:

@dom_walden: Yes, that's correct. Sorry, I should've thought of this before — I've now added it as a default gadget on Beta English Wikisource (e.g.). You'll have to turn off the beta feature.

I don't think there is much I can do to test this at the moment.

Acceptance Criteria

• The pulsating UI should appear upon first exposure to the functionality

Test report for beta:

In T310309#7993886, @Samwilson wrote:

Thanks @dom_walden, that's a good one to remember. I think it might be the same as Case #2 above, in that it requires directly going to ?action=edit. Can you confirm that it doesn't happen if you first go to https://en.wikipedia.beta.wmflabs.org/wiki/Talk:ET11/Archive_1 and then click Add topic? In that case, it should load within the narrow view (because the page doesn't reload). It's only if you're already editing and then click Add topic that it ends up wide.

This also affects the "Add topic" functionality (sorry I don't know if this has a special name). I am guessing it has the same underlying cause, but let me know if you want a separate bug.

In T307725#7993206, @ppelberg wrote:

Related: @NRodriguez would it be alright for the Editing Team to assume CommTech will be able to take care of this QA?

@EAkinloose found this bug on beta. Notice that the image slightly overflows its border on the right:

@Samwilson After clicking "Show Preview" or "Show changes" the WikiEditor is not full-width.

@Samwilson I find that when I open the WikiEditor and then switch to VE, the VE editor is full-width. However, if I go to VE first VE is not full-width.

I tested for two risks:

• SimilarEditors extension sends invalid URLs.
• URL encoding the username means the similarusers service looks up a different username than the one intended.

• Allow any user to be entered in the user input (ideally we would allow any user that exists on English Wikipedia, but I don't think that complexity is necessary for this temporary change)

The infobox does not appear on mobile view (e.g. https://en.m.wikipedia.beta.wmflabs.org).