Page MenuHomePhabricator

dom_walden (Dom Walden)
Test Engineer for Community Tech and Anti-Harassment Teams

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2018, 4:33 PM (70 w, 2 d)
Availability
Available
LDAP User
Dom Walden
MediaWiki User
DWalden (WMF) [ Global Accounts ]

Recent Activity

Yesterday

dom_walden moved T244517: Use IndexPager's multi-column pagination for preliminary check from Done (2019-20: Q3) to QA/Testing on the Anti-Harassment (The Letter Song) board.
Wed, Feb 26, 3:56 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Anti-Harassment (The Letter Song)
dom_walden moved T244492: Support pagination on multiple columns in IndexPager from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

Testing for risk of regression, I tested a few special pages which used or inherited from IndexPager (which I think is all of them).

Wed, Feb 26, 3:55 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Anti-Harassment (The Letter Song)
dom_walden moved T244517: Use IndexPager's multi-column pagination for preliminary check from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

Testing for risk of regression, I tested a few special pages which used or inherited from IndexPager (which I think is all of them).

Wed, Feb 26, 3:54 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Anti-Harassment (The Letter Song)
dom_walden moved T241004: WWT: Refactor the relationship between the RevisionPopupWidget, Model and Controller for clarity from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

I ran a selenium script to check the correct data is in the revision popup for a small sample of articles from enwiki, eswiki and trwiki.

Wed, Feb 26, 12:46 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T240585: "Undefined variable: globalUser" submitting Special:Investigate form without CentralAuth from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

@dom_walden I can't reproduce this as anymore as of 005ce473e11b7fae03643d71fa7f092ab318dd7d
Switching back to b8d4d55d8950 does shows the warning.
There was a lot of refactoring on the file that this was failing and it should be fixed now.

Wed, Feb 26, 12:35 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T245093: Improve message for Special:Investigate preliminary check when there are no results from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

Searching just for IPs:

Wed, Feb 26, 11:59 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Anti-Harassment (The Letter Song), CheckUser
dom_walden created T246203: Hidden edit summary displays in the wrong place in the revision popup.
Wed, Feb 26, 9:39 AM · Who-Wrote-That, Community-Tech

Tue, Feb 25

dom_walden moved T242954: WWT Popup: Padding changes [x-small] from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

As with T242759#5916137, I looked at revision popups in different languages. I could not see any obvious problems with the padding.

Tue, Feb 25, 4:10 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T242759: WWT: Standardise how we do attribution percentage in translations [small] from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

In every language WWT supports I've looked at two revision popups (one for attribution percentage more than 1%, one for less).

Tue, Feb 25, 3:57 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T238782: CU 2.0: Display data in the Compare tab from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.
  • There is a new tab next to Preliminary check for Compare
Tue, Feb 25, 2:20 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dom_walden added a comment to T238782: CU 2.0: Display data in the Compare tab.

Also, I don't know if it is just my screen, but I don't find the dark background much darker than the other cells in the table.

Eek, this is a problem! While I can see the different grays in that screenshot we need to make sure that the contrast can bee seen on all types of screens. @dom_walden which screen are you using? Are the screenshots below any better?

Tue, Feb 25, 9:04 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

Mon, Feb 24

dom_walden moved T243331: WWT: Revise 'Error' message in information bar [x-small] from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

The error message now looks like:

Mon, Feb 24, 5:46 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T243302: WWT: Make extensions discoverable & remove 'beta' status [medium] from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.
  • Make WWT extensions discoverable & available to all users in Chrome/Firefox web stores (i.e., direct URL not needed)
Mon, Feb 24, 5:21 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T244157: Special:BlockList paginates on a non-unique column from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

I wanted to test that on Special:BlockList:

  • No results (blocks) were missing or duplicated across pages
  • The order of results was "correct".
Mon, Feb 24, 5:07 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Anti-Harassment (The Letter Song)

Sat, Feb 22

dom_walden moved T233441: Cookie blocks apply regardless of ipblock-exempt right from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

Autoblock cookie remains after logging in as admin, but not applied. Remains after logging out (so user is blocked again).

Sat, Feb 22, 2:39 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Anti-Harassment (The Letter Song), MediaWiki-User-management

Fri, Feb 21

dom_walden moved T238714: CU 2.0: Fetch information to be displayed in Compare tab from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

@dom_walden In my understanding, in current CheckUser, new account creations and other log entries are shown when someone picks the 'Get users' option, right?
If so, we got that covered under the Timeline tab.

Fri, Feb 21, 6:41 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T238808: CU 2.0: Pagination in the compare tab from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.
  • Results in the compare tab appear paginated with the highlights, filters and sorting working as selected by the user

Obviously there is no highlighting, filtering etc. to test yet.

Fri, Feb 21, 4:20 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T240366: CU 2.0: Figure out how to do tabs in a special page from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

Tabs seem to work fine.

Fri, Feb 21, 12:57 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Anti-Harassment (The Letter Song), Spike, CheckUser
dom_walden moved T239716: CU 2.0: Use a factory to create the pager from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

@dom_walden Not sure to what extent this needs testing - it doesn't change the pagers, just how they're created. I checked the pagers are both still there and not doing anything odd.

Fri, Feb 21, 12:38 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), CheckUser, Anti-Harassment (The Letter Song)

Wed, Feb 19

dom_walden added a comment to T238714: CU 2.0: Fetch information to be displayed in Compare tab.
  1. For an input username:
    • IP addresses they have used
      • FYI note that this is limited to the past 90 days by our data policy limits so we won't find anything from before that
Wed, Feb 19, 8:24 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Anti-Harassment (The Letter Song), CheckUser
dom_walden added a comment to T238782: CU 2.0: Display data in the Compare tab.
  • If an IP and username looked up are in the same row, make both the IP address and the username bold with darker background.
Wed, Feb 19, 5:31 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T237298: CheckUser 2.0: Display the data fetched on special page (preliminary check) from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

I think I have tested this before, but with all the recent changes I guess it is as well to retest it.

Wed, Feb 19, 3:31 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T238827: Reorganise preliminary check service for paginated results from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

I think the changes made to PreliminaryCheckService have been made obsolete by T244517. I don't think there is anything to test here.

Wed, Feb 19, 2:19 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T243631: Add links to preliminary check results table from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

The wiki column links to the User:$user page for the correct user and wiki.

Wed, Feb 19, 12:23 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Anti-Harassment (The Letter Song), CheckUser

Tue, Feb 18

dom_walden added a comment to T238961: PRU: Improve Security & Standardize Experience for Password Reset [medium].

Testing this on https://en.wikipedia.beta.wmflabs.org (version: MediaWiki 1.35.0-alpha (c664b4f) 17:32, 18 February 2020).

Tue, Feb 18, 7:00 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Community-Tech (Kanban-Q3-2019-20), Password-Reset-Update
dom_walden added a comment to T238961: PRU: Improve Security & Standardize Experience for Password Reset [medium].

Hello @dom_walden and @Samwilson
There seems to be some confusion (and apologies if there was any!). From what I read in the QA notes: If the user has PRU option checked in Special:Preferences and you enter only their username. Normal PRU message: "Both username and email address are required to receive a temporary password via email."

Tue, Feb 18, 3:55 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Community-Tech (Kanban-Q3-2019-20), Password-Reset-Update

Thu, Feb 13

dom_walden moved T231577: Deploy Special:Mute features from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

Briefly retested muting and unmuting users on Special:Mute on enwiki. Also checked that I could use it to mute globally (when I set the option globally).

Thu, Feb 13, 3:10 PM · Anti-Harassment (The Letter Song), Epic
dom_walden added a comment to T240585: "Undefined variable: globalUser" submitting Special:Investigate form without CentralAuth.

@dmaza When submitting the form, I no longer see the exception in the description.

Thu, Feb 13, 11:29 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T242359: CU 2.0: Move input form to its own page from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

After submitting the form, the preliminary check table appears on its own page.

Thu, Feb 13, 10:54 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Anti-Harassment (The Letter Song), CheckUser
dom_walden added a comment to T239680: CU 2.0: Persist the form state.

@dbarratt On the preliminary check table, when I attempt to go to a previous or next page I get:

[3d583d0a95a869c404a8887a] /w/index.php?title=Special:Investigate/Preliminary_Check&limit=10&token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJleHAiOjE1ODE2NzYwNTcsImRhdGEiOiJHVjRJNjArK2hobHZsaDl2Q1JOSGRWaWRkS1RVZE9NbWNGMytSSmE0NVlNNGFjXC82cEI3a0hMSEJ1Rk0zK0RMQWFSWG03UDJiSWc9PSJ9.qj1RfHQc0Il2WfiWP3rlJ0t77rT5p_IuUDXFGiATAQM TypeError from line 59 of /vagrant/mediawiki/extensions/CheckUser/src/TokenManager.php: Argument 1 passed to MediaWiki\CheckUser\TokenManager::encode() must be an instance of MediaWiki\Session\Session, instance of User given, called in /vagrant/mediawiki/extensions/CheckUser/src/SpecialInvestigate.php on line 120
Thu, Feb 13, 10:42 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)

Wed, Feb 12

dom_walden moved T238961: PRU: Improve Security & Standardize Experience for Password Reset [medium] from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

I used a script to systematically cover every (valid) combination of username + email based on:

  • Is the username/email blank
  • Does the username/email exist on the system
  • Does the username/email have PRU enabled
  • Does the username have an email associated with it
  • Has the username/email hit their password reset request limit (more than one request in 24 hours)
Wed, Feb 12, 12:04 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Community-Tech (Kanban-Q3-2019-20), Password-Reset-Update

Fri, Feb 7

dom_walden moved T243538: CU 2.0: Remove the "Include all..." checkbox from the input form from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

It is no longer there on my local version, CheckUser 2.5 (ed83bea) 00:33, 7 February 2020.

Fri, Feb 7, 4:34 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Anti-Harassment (The Letter Song), CheckUser

Tue, Feb 4

dom_walden moved T243077: TagMultiselectWidget performs unnecessary validity check in change handler from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

Testing for this was done at the same time as T243075.

Tue, Feb 4, 5:24 PM · OOUI (OOUI-0.36.3), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T243075: TagMultiselectWidget clears input before adding tag, causing validation failure in downstream widgets from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

Testing the Page and Namespace input in Special:Block and email-blacklist in Special:Preferences, comparing beta with test.

Tue, Feb 4, 5:23 PM · OOUI (OOUI-0.36.3), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T243643: Set selected MenuTagMultiselectWidget items as options in the constructor from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

Bug in T243075#5829744 no longer occurs Special:Preferences on https://en.wikipedia.beta.wmflabs.org (1.35.0-alpha (74b7a2b) 14:09, 4 February 2020).

Tue, Feb 4, 3:53 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T238318: Let UsersMultiselectWidget disallow arbitrary input from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

I can no longer add a tag, unless it is of a valid user.

Tue, Feb 4, 1:02 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T238277: Allow UsersMultiselectWidget to show valid IP addresses and ranges in the autocomplete menu from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

This depends on config (see T238277#5705031). In Special:Investigate on testwiki, the menu should appear for:

  • Any valid IP address
  • Any valid IPv4 range ending /16 or higher
  • Any valid IPv6 range ending /32 or higher
Tue, Feb 4, 12:54 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Anti-Harassment (The Letter Song), CheckUser

Jan 24 2020

dom_walden added a comment to T243075: TagMultiselectWidget clears input before adding tag, causing validation failure in downstream widgets.

@Tchanders When you submit the Special:Investigate form, the usernames get cleared (although the data appears to get posted). This does not happen before the commit in T243075#5828523.

Jan 24 2020, 3:52 PM · OOUI (OOUI-0.36.3), Anti-Harassment (The Letter Song), CheckUser
dom_walden created T243582: Fatal exception of type "TypeError" when submitting IP address in Special:Investigate when CentralAuth is disabled.
Jan 24 2020, 10:00 AM · CheckUser, Anti-Harassment

Jan 23 2020

dom_walden moved T231424: WWT: Original article HTML not necessarily preserved (was: Images have their links changed from Commons to local) [medium] from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

I can no longer reproduce the bugs in the 3 examples.

Jan 23 2020, 5:40 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden added a comment to T242759: WWT: Standardise how we do attribution percentage in translations [small].
Jan 23 2020, 12:57 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T239634: WWT: Display WWT Link in Interface Language [small] from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

The WWT translations now work for roa-tara (https://en.wikipedia.org/wiki/Mast_(sailing)?uselang=roa-tara).

Jan 23 2020, 12:29 PM · Community-Tech (Kanban-Q3-2019-20), I18n, Who-Wrote-That
dom_walden moved T241062: WWT: Handle hidden edit summaries in revision details pop-up [small] from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

If the edit summary is hidden, the revision popup shows (edit summary removed).

Jan 23 2020, 12:06 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T237756: Reduce length of extension name and description for Chrome from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

Not much to test here. Moving to Product sign-off.

Jan 23 2020, 11:56 AM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T239938: PRU: Address 'No Email Will Be Sent' Issue for Unconfirmed Users [small] from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

The PRU checkbox is now above the "Email confirmation:" section.

Jan 23 2020, 10:30 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Community-Tech (Kanban-Q3-2019-20), Password-Reset-Update

Jan 22 2020

dom_walden created P10243 custom MW API request in node.js.
Jan 22 2020, 11:58 AM
dom_walden updated the task description for T231424: WWT: Original article HTML not necessarily preserved (was: Images have their links changed from Commons to local) [medium].
Jan 22 2020, 10:51 AM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T239840: No translations on Firefox Add-Ons repository from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

@Samwilson The German version has no description. Should it fall back to English? (https://addons.mozilla.org/de/firefox/addon/whowrotethat/)

Oh weird: you're right, it didn't have a description. So I opened it for editing, clicked into the empty description box, then without typing anything clicked save. Now it falls back to English correctly!

Jan 22 2020, 10:17 AM · Community-Tech (Kanban-Q3-2019-20), translatewiki.net, Who-Wrote-That
dom_walden added a comment to T239840: No translations on Firefox Add-Ons repository.

@Samwilson The German version has no description. Should it fall back to English? (https://addons.mozilla.org/de/firefox/addon/whowrotethat/)

Jan 22 2020, 7:58 AM · Community-Tech (Kanban-Q3-2019-20), translatewiki.net, Who-Wrote-That

Jan 21 2020

dom_walden added a comment to T233091: Revision Details Pop-up sometimes in wrong place .

@dom_walden Is this still an issue? I'm unable to reproduce the issue, but maybe you're still seeing it. Let me know. Thanks!

Jan 21 2020, 6:36 PM · Who-Wrote-That, Community-Tech
dom_walden moved T237532: Preferences are saved as GlobalPreferences when autoglobal is enabled for the field from QA/Testing to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

If, for the user, the setting is not global -> save in local
If, for the user, the setting is global -> save in global
If, for the user, the setting is global *but* uses local override -> save in local override.

Jan 21 2020, 3:17 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Anti-Harassment (The Letter Song), Community-Tech, MediaWiki-extensions-GlobalPreferences
dom_walden added a comment to T243111: PRU: Verify that PRU can be turned on as a global preference.

Acceptance Criteria:

  • Confirm whether or not PRU can be made a global preference for all users
Jan 21 2020, 1:38 PM · Password-Reset-Update, Community-Tech

Jan 16 2020

dom_walden moved T242993: WWT: Investigate Console Error from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

@ifried I am moving this into Product Sign-Off, but it has yet to be released to the Chrome Store or Firefox Addons.

Jan 16 2020, 5:37 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden added a comment to T242993: WWT: Investigate Console Error.

For each of the five supported wikis, loaded a random article both with the Welcome Tour popup and without it.

Jan 16 2020, 5:18 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That

Jan 14 2020

dom_walden created T242761: WWT: Article links and previews accessible via keyboard.
Jan 14 2020, 3:39 PM · Who-Wrote-That, Community-Tech
dom_walden created T242759: WWT: Standardise how we do attribution percentage in translations [small].
Jan 14 2020, 3:22 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T237756: Reduce length of extension name and description for Chrome from QA to In Development on the Community-Tech (Kanban-Q3-2019-20) board.
Jan 14 2020, 9:21 AM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That

Jan 13 2020

dom_walden moved T235015: WWT: Support for Latest Version of a Page after VE Edits from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

After submitting an edit using VisualEditor, WWT uses the correct revision ID, which means the changes made in the edit are reflected in WWT.

Jan 13 2020, 5:38 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden added a comment to T241062: WWT: Handle hidden edit summaries in revision details pop-up [small].

Note: I'm fairly sure this will be a lot easier to do (if not outright fixed?) with the refactoring PR at https://github.com/wikimedia/WhoWroteThat/pull/128

I believe this issue was fixed with this pull request. I'm no longer able to replicate it.

Jan 13 2020, 11:46 AM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That

Jan 11 2020

dom_walden moved T241834: WWT: Extension should not be loaded on Turkish Special pages from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

On Turkish Special pages (e.g. https://tr.wikipedia.org/wiki/Özel:SonDeğişiklikler) wwtDebug is not defined, which means WWT is not loaded (which is what we want).

Jan 11 2020, 11:37 AM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T233169: WWT: Support RTL languages for WWT from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

Testing with a variety of RTL languages, some for which we have translations (e.g. Hebrew) and some for which we don't (e.g. Farsi).

Jan 11 2020, 11:31 AM · Community-Tech (Kanban-Q3-2019-20), I18n, RTL, Who-Wrote-That
dom_walden moved T241992: WWT: Do not flip the plus/minus sign in size diff when doing RTL [small] from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

The plus/minus sign now always appears to the left of the numbers. This is the case even in RTL languages and where a language has its own number system (e.g. Arabic).

Jan 11 2020, 9:24 AM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That

Jan 10 2020

dom_walden added a comment to T241004: WWT: Refactor the relationship between the RevisionPopupWidget, Model and Controller for clarity.

And I don't know what is going on here, edit summary cut off:

Jan 10 2020, 6:41 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden added a comment to T239634: WWT: Display WWT Link in Interface Language [small].

@Samwilson I'm still not able to get this to work for roa-tara. Can for pt-br and zh-hant.

Jan 10 2020, 6:19 PM · Community-Tech (Kanban-Q3-2019-20), I18n, Who-Wrote-That
dom_walden added a comment to T241004: WWT: Refactor the relationship between the RevisionPopupWidget, Model and Controller for clarity.

@Mooeypoo I think this has slightly changed the display of revision popups.

Jan 10 2020, 12:16 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T241371: WWT: Update Guided Tour Instructional Language from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

Text now reads: "Activate the tool from the sidebar. Hover over text to highlight contributions by the same author. Click to see the author and revision details."

Jan 10 2020, 11:28 AM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That

Jan 9 2020

dom_walden moved T240262: WWT: Address Opacity Overlap Bug [small] from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

PR: https://github.com/wikimedia/WhoWroteThat/pull/127
We still have the "problem" of the lighter line crossing the infobox, but now it only happens when you hover over the specific template, which (at least in my opinion) gives the user some sense of what it's attached to as a box on the screen.

Jan 9 2020, 3:05 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T234709: WWT: Good article badge comes over the WWT bar from QA to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

For a few random enwiki articles, I checked that the revision popup appears over the top of the infobar and also image thumbnails, templates, badges, and other parts of the UI (e.g. search bar in timeless).

Jan 9 2020, 2:46 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden created T242328: WWT: Fix RTL Date Formatting Bug (when no translations for language).
Jan 9 2020, 9:55 AM · Who-Wrote-That, Community-Tech

Jan 7 2020

dom_walden created T242091: Spike: WWT: WhoColor API does not work with some tokens.
Jan 7 2020, 11:14 AM · Who-Wrote-That, Community-Tech

Jan 6 2020

dom_walden created T241992: WWT: Do not flip the plus/minus sign in size diff when doing RTL [small].
Jan 6 2020, 3:33 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That

Jan 3 2020

dom_walden added a comment to T233091: Revision Details Pop-up sometimes in wrong place .

Recently, I have found this in a number of places, e.g.:

Jan 3 2020, 3:30 PM · Who-Wrote-That, Community-Tech
dom_walden moved T240690: WWT: Fix Incorrect Tool Access on Main & Article Pages from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

On each of the 5 supported wikis, I walk through the menu items to find different special pages, portals, etc.

Jan 3 2020, 2:29 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden created T241834: WWT: Extension should not be loaded on Turkish Special pages.
Jan 3 2020, 2:20 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T232460: [BUG] Unresponsive script when loading articles in non-default language [8 hours] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

I loaded random articles on en, de, es, eu and trwiki. Each wiki was on a different skin and language. Watching for any slowdowns or long-running scripts.

Jan 3 2020, 1:41 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden updated subscribers of T240984: WWT: Consider supporting mobile version of Wikipedia.
Jan 3 2020, 10:38 AM · Who-Wrote-That, Community-Tech

Jan 2 2020

dom_walden moved T236702: WWT: Decouple Bytes from Edit Summary [small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

I think the fix in T236702#5726839 is already deprecated by T240707. We now show 3 shimmer lines in edit summaries.

Jan 2 2020, 5:57 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Dec 23 2019

dom_walden moved T239842: Who Wrote That? link is slightly bigger than you think from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

I am seeing the WWT link on pages like the Main_Page or in other namespaces (e.g. User_talk).

This was T240690 and has been fixed now.

Dec 23 2019, 3:22 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T240707: WWT: Adjust Username Appearance [high priority] [medium] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Acceptance Criteria:

  • Remove the display of the username/IP address from the information bar in WWT
Dec 23 2019, 2:56 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Dec 20 2019

dom_walden created T241258: WWT: Investigate and/or Fix Welcome Tour Pop-up Positioning Bug.
Dec 20 2019, 5:03 PM · Who-Wrote-That, Community-Tech
dom_walden created T241256: WWT: Improve look on MonoBook skin.
Dec 20 2019, 4:56 PM · Who-Wrote-That, Community-Tech

Dec 19 2019

dom_walden moved T234711: WWT: UX Improvements for the 'Guided Tour' Pop-up [x-small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Acceptance Criteria:

  • Don't italicize 'Who Wrote That?' in the guided tour pop-up
Dec 19 2019, 12:14 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T234710: WWT: UX Improvements for the Information Bar [small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Acceptance Criteria:

  • Remove italicization of 'Who Wrote That' in the loading state of the information bar
Dec 19 2019, 12:13 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden created T241135: WWT: Top of Information Bar slightly obscured in Timeless skin.
Dec 19 2019, 11:50 AM · Who-Wrote-That, Community-Tech

Dec 18 2019

dom_walden updated the task description for T241062: WWT: Handle hidden edit summaries in revision details pop-up [small].
Dec 18 2019, 2:00 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden added a comment to T240707: WWT: Adjust Username Appearance [high priority] [medium].

@MusikAnimal FYI, I found bug T241062 while testing this change. The bug existed before your change, although the impact of it is greater now.

Dec 18 2019, 1:48 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden created T241062: WWT: Handle hidden edit summaries in revision details pop-up [small].
Dec 18 2019, 1:46 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
dom_walden moved T234952: Password Reset: Inform Users of Preference in Basic Info Section [small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

I believe testing this is covered by T239937#5750498.

Dec 18 2019, 9:50 AM · Community-Tech (Kanban-Q3-2019-20), Password-Reset-Update
dom_walden moved T239937: Password Reset Update: Inform Unconfirmed Users of Special Preference [x-small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Acceptance Criteria:

  • If the email is confirmed or unconfirmed, display the following message: "Account recovery is enabled. See Email options for settings."
Dec 18 2019, 9:49 AM · Community-Tech (Kanban-Q3-2019-20), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Password-Reset-Update
dom_walden moved T240736: PRU: Enable PRU Functionality via UI in Test Wiki from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

The PRU checkbox now appears on test and test2.

Dec 18 2019, 9:43 AM · Password-Reset-Update, Community-Tech (Kanban-Q2-2019-20)
dom_walden added a comment to T240586: Should hidden blocks be shown in Preliminary Check?.

I did not know hidden blocks were a thing.

Dec 18 2019, 9:17 AM · CheckUser, Anti-Harassment

Dec 17 2019

dom_walden created T240984: WWT: Consider supporting mobile version of Wikipedia.
Dec 17 2019, 6:44 PM · Who-Wrote-That, Community-Tech
dom_walden added a project to T240936: VisualEditor does not show a block message for TorBlocks: VisualEditor.
Dec 17 2019, 11:34 AM · VisualEditor, MediaWiki-extensions-TorBlock
dom_walden created T240936: VisualEditor does not show a block message for TorBlocks.
Dec 17 2019, 11:32 AM · VisualEditor, MediaWiki-extensions-TorBlock
dom_walden added a comment to T240927: WWT: Prevent Info Bar from Blocking Revision Details Pop-up [don't take until we discuss].

I believe this has/will be fixed here: T234709#5739746.

Dec 17 2019, 11:10 AM · Community-Tech, Who-Wrote-That

Dec 16 2019

dom_walden added a comment to T240300: Introduce a temporary banner on Special:Block to inform users about upcoming partial blocks deploy.

There are no translations to test yet. I have made a todo for myself to test these as soon as they are up.

Dec 16 2019, 5:23 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Anti-Harassment (The Letter Song)
dom_walden moved T239112: WWT: Fix Revision Details pop-up for image thumbnails [8 hours] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

The functionality now appears to be ok:

  • Hovering over an image thumbnail shows the contributor name in the infobar
  • Any other tokens added by that contributor are highlighted
  • Clicking the thumbnail shows the revision popup
Dec 16 2019, 4:03 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T234463: WWT: Only Show Loading Animation in Revision Details Pop-up If Data Not Yet Loaded from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

After clicking a token, the Edit Summary gets cached. If you click the same token, or another token which was added in the same revision, the Edit Summary appears immediately.

Dec 16 2019, 3:59 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden added a comment to T239937: Password Reset Update: Inform Unconfirmed Users of Special Preference [x-small].

@ifried Should this show even if PRU is not enabled on the wiki? ($wgAllowRequiringEmailForResets)

Dec 16 2019, 10:08 AM · Community-Tech (Kanban-Q3-2019-20), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Password-Reset-Update

Dec 13 2019

dom_walden added a comment to T234709: WWT: Good article badge comes over the WWT bar.

@MusikAnimal Oh damn. I missed that the toolbar is now over the revision popup. Do you want a separate bug?

Dec 13 2019, 3:17 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That