Page MenuHomePhabricator

dom_walden (Dom Walden)
Test Engineer for Community Tech and Anti-Harassment Tools

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2018, 4:33 PM (267 w, 5 d)
Availability
Available
LDAP User
Dom Walden
MediaWiki User
DWalden (WMF) [ Global Accounts ]

Recent Activity

Fri, Dec 1

dom_walden moved T351100: [S] Prevent exception when running createExtensionTables.php for a wiki that already has the table for MediaModeration from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.

See below output of successive runs of the WikimediaMaintenance/createExtensionTables.php script:

$ docker-compose exec mediawiki php extensions/WikimediaMaintenance/createExtensionTables.php mediamoderation
Fri, Dec 1, 3:18 PM · Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), Trust and Safety Product Team, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), MediaModeration (MediaModeration 2.0)
dom_walden created T352535: Data too long for column 'gb_range_start' at row 1.
Fri, Dec 1, 1:57 PM · GlobalBlocking, Beta-Cluster-reproducible
dom_walden added a comment to T350116: Block messages duplicated for anonymous user with IP Masking enabled.

Change 977680 merged by jenkins-bot:

[mediawiki/core@master] EditPage: Remove unnecessary extra check for blocks

https://gerrit.wikimedia.org/r/977680

Fri, Dec 1, 11:34 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), Temporary accounts, MediaWiki-Blocks
dom_walden moved T352310: Unknown column 'bl_timestamp' in 'where clause' from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

I cannot reproduce the exception either on beta (MariaDB) or locally (SQLite).

Fri, Dec 1, 9:13 AM · Community-Tech (CommTech-Kanban), MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Multiblocks, MediaWiki-Blocks, Beta-Cluster-reproducible

Wed, Nov 29

dom_walden added a comment to T346293: ipblocks schema redesign for multiblocks.

@tstarling Drawing attention to T352310. Is there a migration stage we have to do on beta?

Wed, Nov 29, 3:57 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Patch-For-Review, Multiblocks, Community-Tech (CommTech-Kanban), MediaWiki-Blocks
dom_walden created T352310: Unknown column 'bl_timestamp' in 'where clause'.
Wed, Nov 29, 3:56 PM · Community-Tech (CommTech-Kanban), MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Multiblocks, MediaWiki-Blocks, Beta-Cluster-reproducible
dom_walden moved T344942: [S] Ensure that tunnel rows are updated with the correct data during actor data import and update from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.

This is expected behavior for now. I think we'll have a discussion later on about historical data/updating IP information.

Wed, Nov 29, 8:25 AM · Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), iPoid-Service

Tue, Nov 28

dom_walden added a comment to T351869: Soft refreshes can clear Edit Recovery data on Firefox.

I'm trying to replicate this but can't yet. Do you think it's related to T351821: Edit Recovery interaction with browser data recovery? It sounds like it's not seeing any difference between the 'original' data and what's now stored, probably because it's got the wrong idea of what 'original' is.

Tue, Nov 28, 1:02 PM · Community-Tech (CommTech-Kanban), Edit Recovery

Mon, Nov 27

dom_walden added a comment to T343089: Save edit recovery data on visibilitychange event.

Change 967683 merged by jenkins-bot:

[mediawiki/core@master] Edit Recovery: only save when form contents has changed

https://gerrit.wikimedia.org/r/967683

Mon, Nov 27, 3:46 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Community-Tech (CommTech-Kanban), Edit Recovery
dom_walden added a comment to T344410: Decide how we are going to handle editing sections.

I have raised T352028, but I wonder if we should just move the current bug back into In Development?

Mon, Nov 27, 3:43 PM · MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), Community-Tech (CommTech-Kanban), Edit Recovery
dom_walden created T352028: Recovery data cleared for whole page when section is saved.
Mon, Nov 27, 2:08 PM · Community-Tech (CommTech-Kanban), Edit Recovery

Thu, Nov 23

dom_walden added a comment to T351869: Soft refreshes can clear Edit Recovery data on Firefox.

This also happens after you close and restore a tab (ctrl+shift+t). I am still investigating.

Thu, Nov 23, 3:11 PM · Community-Tech (CommTech-Kanban), Edit Recovery
dom_walden renamed T351869: Soft refreshes can clear Edit Recovery data on Firefox from Repeated soft refreshes clears Edit Recovery data on Firefox to Soft refreshes can clear Edit Recovery data on Firefox.
Thu, Nov 23, 11:26 AM · Community-Tech (CommTech-Kanban), Edit Recovery
dom_walden created T351869: Soft refreshes can clear Edit Recovery data on Firefox.
Thu, Nov 23, 9:48 AM · Community-Tech (CommTech-Kanban), Edit Recovery

Wed, Nov 22

dom_walden created T351821: Edit Recovery interaction with browser data recovery.
Wed, Nov 22, 3:11 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Community-Tech (CommTech-Kanban), Edit Recovery
dom_walden added a comment to T344942: [S] Ensure that tunnel rows are updated with the correct data during actor data import and update.

@STran @Tchanders We don't appear to be updating the tunnels if their type changes. This could affect what is returned by the /vpn endpoints. Is this OK?

Wed, Nov 22, 12:57 PM · Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), iPoid-Service
dom_walden moved T351197: TypeError: Cannot read properties of undefined (reading 'operator') from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.

I can no longer reproduce the error from the description.

Wed, Nov 22, 9:12 AM · Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), Patch-For-Review, iPoid-Service

Tue, Nov 21

dom_walden edited projects for T351371: "countries" not updated, added: Trust and Safety Product Team; removed Anti-Harassment.
Tue, Nov 21, 10:56 AM · Trust and Safety Product Team, iPoid-Service
dom_walden edited projects for T351405: Exceptions thrown for missing data on update, added: Trust and Safety Product Team; removed Anti-Harassment.
Tue, Nov 21, 10:56 AM · Trust and Safety Product Team, iPoid-Service
dom_walden edited projects for T351490: Errors when there are duplicate entries for proxies, behaviours and tunnels, added: Trust and Safety Product Team; removed Anti-Harassment.
Tue, Nov 21, 10:56 AM · Trust and Safety Product Team, iPoid-Service
dom_walden moved T350500: Make it easier to remove temporary files added while running the pipeline in debug mode from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.

Could probably skip QA? cc @dom_walden

Tue, Nov 21, 9:45 AM · Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), Patch-For-Review, iPoid-Service

Mon, Nov 20

dom_walden moved T351100: [S] Prevent exception when running createExtensionTables.php for a wiki that already has the table for MediaModeration from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.
Mon, Nov 20, 4:14 PM · Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), Trust and Safety Product Team, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), MediaModeration (MediaModeration 2.0)
dom_walden moved T350323: Write an empty row to scan table on file upload from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.
Mon, Nov 20, 4:14 PM · Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Trust and Safety Product Team, MediaModeration (MediaModeration 2.0)
dom_walden moved T350500: Make it easier to remove temporary files added while running the pipeline in debug mode from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.
Mon, Nov 20, 4:14 PM · Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), Patch-For-Review, iPoid-Service
dom_walden moved T351197: TypeError: Cannot read properties of undefined (reading 'operator') from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.
Mon, Nov 20, 4:14 PM · Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), Patch-For-Review, iPoid-Service
dom_walden edited projects for T351197: TypeError: Cannot read properties of undefined (reading 'operator'), added: Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)); removed Trust and Safety Product Sprint (Sprint Bodhrán).
Mon, Nov 20, 4:13 PM · Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), Patch-For-Review, iPoid-Service
dom_walden edited projects for T350500: Make it easier to remove temporary files added while running the pipeline in debug mode, added: Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)); removed Trust and Safety Product Sprint (Sprint Bodhrán).
Mon, Nov 20, 4:13 PM · Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), Patch-For-Review, iPoid-Service
dom_walden added a comment to T344942: [S] Ensure that tunnel rows are updated with the correct data during actor data import and update.

@STran I'm not making this a deployment blocker, because I don't believe we are using these values to begin with. Is that correct?

Mon, Nov 20, 2:45 PM · Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), iPoid-Service
dom_walden added a comment to T351371: "countries" not updated.

I notice we are doing arrayCompare for client.countries, which seems wrong as they are integers. https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/blob/main/output-sql.js?ref_type=heads#L120

Mon, Nov 20, 1:53 PM · Trust and Safety Product Team, iPoid-Service
dom_walden added a comment to T344703: Trying to edit anonymously via the API when globally blocked returns a different error code when IP Masking enabled.

@dom_walden can you confirm if this bug still persists?

Mon, Nov 20, 12:56 PM · Trust and Safety Product Team, GlobalBlocking, Anti-Harassment, MediaWiki-Blocks, Temporary accounts

Fri, Nov 17

dom_walden moved T344463: Local block messages should override global ones from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Bodhrán) board.

I tested this along with T349826.

Fri, Nov 17, 2:32 PM · Trust and Safety Product Sprint (Sprint Bodhrán), MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Community-Tech, Multiblocks, GlobalBlocking, Stewards-and-global-tools, MediaWiki-Blocks
dom_walden moved T349826: Show multiple block messages on UserBlockedError page from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Bodhrán) board.

Some examples of multiple block messages on beta and locally.

Fri, Nov 17, 2:31 PM · Trust and Safety Product Sprint (Sprint Bodhrán), MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Community-Tech, Multiblocks, Stewards-and-global-tools, MediaWiki-Blocks
dom_walden created T351490: Errors when there are duplicate entries for proxies, behaviours and tunnels.
Fri, Nov 17, 8:02 AM · Trust and Safety Product Team, iPoid-Service

Thu, Nov 16

dom_walden created T351405: Exceptions thrown for missing data on update.
Thu, Nov 16, 1:50 PM · Trust and Safety Product Team, iPoid-Service
dom_walden created T351371: "countries" not updated.
Thu, Nov 16, 8:32 AM · Trust and Safety Product Team, iPoid-Service

Tue, Nov 14

dom_walden moved T345683: Review of MediaWiki block-related code from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

I think I have done with this for now.

Tue, Nov 14, 7:34 AM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Blocks, Community-Tech (CommTech-Kanban)

Mon, Nov 13

dom_walden added a comment to T347435: Warn when adding a URL that matches blocked external domains in the 2010 editor.

@MusikAnimal I did a bit of testing of this on Friday and found a few potential bugs. In order of importance (in my opinion):

  • There are circumstances where clicking on "Review link" will take you to the blocked url instead of opening the "Insert link" dialog.
    • This happens when you move or delete the link you just inserted before clicking "Review link".
      • e.g. type a link, see the popup, before the link type "[", click "Review link"
    • Having the blocked url as the href of the "Review link" seems vulnerable to me. A user might open it in a new tab. I also don't know if all browsers/devices will behave the same way when you click on it.
  • If the blocked URL is not the first thing on the line, after clicking "Review link", the URL automatically entered in the "Insert link" dialog is incorrect.
    • e.g. type foobar <blocked URL>, click "Review link", in the "Insert link" dialog the URL will be "foobar <blocked URL>"
  • The popup only appears if the URL starts with http:// or https://, even if you add it after.
    • You can make a legit link with just // (e.g. [//<blocked URL>]). If you try to publish this, AbuseFilter will stop you (at least on beta). Perhaps we should maintain functional parity.
  • If there is already a popup and you trigger another popup, it flashes in the top left.
    output.gif (768×1 px, 1 MB)
  • If copy and pasting, only warns if the blocked URL is just before point.
    • e.g. copy and paste foobar <blocked URL> foobaz, you will not see a popup
  • If the text of the link is a blocked domain but the actual link is not, still see popup.
    • e.g. [https://duckduckgo.com <blocked URL>]
    • Arguably a popup here is not so bad as the edit does not seem in good faith.
  • Does not always work well with find and replace.
    • Not triggered if you do "Replace all".
    • If you do "Find next" and "Replace" one by one, the "Review link" does not insert the link in the correct place.
      output.gif (768×1 px, 1 MB)
Mon, Nov 13, 8:43 AM · Community-Tech (CommTech-Kanban), MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), AbuseFilter, CommTech-Wishathon, Community-Wishlist-Survey-2023

Nov 8 2023

dom_walden moved T345238: Implement db schema updating from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Bodhrán) board.
Nov 8 2023, 3:35 PM · Patch-For-Review, Trust and Safety Product Sprint (Sprint Bodhrán), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), iPoid-Service
dom_walden moved T345238: Implement db schema updating from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

First time, I have to run node -e "require('./init-db.js')(true);". Any other combination of parameters returns the below exception. I guess this makes sense.

/srv/service/node_modules/mariadb/lib/misc/errors.js:64
  return new SqlError(msg, sql, fatal, info, sqlState, errno, additionalStack, addHeader);
         ^
Nov 8 2023, 3:33 PM · Patch-For-Review, Trust and Safety Product Sprint (Sprint Bodhrán), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), iPoid-Service

Nov 1 2023

dom_walden moved T344273: Add proxies, tunnels API endpoints to ipoid service from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Bodhrán) board.

So far, the only bug I have found is T348745. More testing will be done after the fix for that.

Nov 1 2023, 3:37 PM · Trust and Safety Product Sprint (Sprint Bodhrán), iPoid-Service, Anti-Harassment (AHaT Sprint 32 - Baseball Cap)
dom_walden moved T348130: Make batch count configurable from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Bodhrán) board.

Probably no testing needed here. Will move to Done.

Nov 1 2023, 3:24 PM · Trust and Safety Product Sprint (Sprint Bodhrán), iPoid-Service
dom_walden moved T341122: Implement daily data update routine from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Bodhrán) board.

More testing of this will be done as part of T348992. I will move this to Done.

Nov 1 2023, 3:23 PM · Trust and Safety Product Sprint (Sprint Bodhrán), Patch-For-Review, Anti-Harassment (AHaT Sprint 32 - Baseball Cap), iPoid-Service

Oct 31 2023

dom_walden added a comment to T344463: Local block messages should override global ones.

Change 965048 merged by jenkins-bot:

[mediawiki/core@master] Display all error messages for a CompositeBlock

https://gerrit.wikimedia.org/r/965048

Oct 31 2023, 3:44 PM · Trust and Safety Product Sprint (Sprint Bodhrán), MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Community-Tech, Multiblocks, GlobalBlocking, Stewards-and-global-tools, MediaWiki-Blocks
dom_walden updated the task description for T350116: Block messages duplicated for anonymous user with IP Masking enabled.
Oct 31 2023, 9:06 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), Temporary accounts, MediaWiki-Blocks
dom_walden added a comment to T345683: Review of MediaWiki block-related code.

@tstarling Since this change, when attempting to edit as an IP from an IP that is blocked and ip masking is enabled, the block message is duplicated.

Oct 31 2023, 9:03 AM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Blocks, Community-Tech (CommTech-Kanban)
dom_walden created T350116: Block messages duplicated for anonymous user with IP Masking enabled.
Oct 31 2023, 9:02 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), Temporary accounts, MediaWiki-Blocks

Oct 30 2023

dom_walden moved T348949: Column 'behavior_id' cannot be null from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Bodhrán) board.
Oct 30 2023, 4:43 PM · Trust and Safety Product Sprint (Sprint Bodhrán), iPoid-Service, Anti-Harassment
dom_walden moved T348952: TypeError: data.client.behaviors.forEach is not a function from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Bodhrán) board.
Oct 30 2023, 4:43 PM · Patch-For-Review, Trust and Safety Product Sprint (Sprint Bodhrán), iPoid-Service, Anti-Harassment
dom_walden moved T345238: Implement db schema updating from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Bodhrán) board.
Oct 30 2023, 4:42 PM · Patch-For-Review, Trust and Safety Product Sprint (Sprint Bodhrán), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), iPoid-Service
dom_walden moved T341122: Implement daily data update routine from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Bodhrán) board.
Oct 30 2023, 4:42 PM · Trust and Safety Product Sprint (Sprint Bodhrán), Patch-For-Review, Anti-Harassment (AHaT Sprint 32 - Baseball Cap), iPoid-Service
dom_walden moved T344273: Add proxies, tunnels API endpoints to ipoid service from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Bodhrán) board.
Oct 30 2023, 4:42 PM · Trust and Safety Product Sprint (Sprint Bodhrán), iPoid-Service, Anti-Harassment (AHaT Sprint 32 - Baseball Cap)
dom_walden moved T348121: Error when importing field with semi-colon from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Bodhrán) board.
Oct 30 2023, 4:42 PM · Trust and Safety Product Sprint (Sprint Bodhrán), iPoid-Service
dom_walden added a comment to T341660: Investigate non-deterministic behaviour of import.

The non-deterministic problem should be solved, so I'll close this in favour of the other task.

Oct 30 2023, 12:58 PM · Trust and Safety Product Sprint, Patch-For-Review, iPoid-Service

Oct 26 2023

dom_walden moved T341660: Investigate non-deterministic behaviour of import from QA to Blocked on the iPoid-Service board.
Oct 26 2023, 12:08 PM · Trust and Safety Product Sprint, Patch-For-Review, iPoid-Service
dom_walden moved T344939: Log when the lookup fails on attempting to INSERT to actor_data (because the proxy/behaviour doesn't exist) from Deployment blockers to Blocked on the iPoid-Service board.
Oct 26 2023, 12:08 PM · Trust and Safety Product Sprint, iPoid-Service

Oct 25 2023

dom_walden moved T347056: Unable to activate Phonos button with keyboard when it has an error from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

I can activate Phonos buttons with errors with enter and space.

Oct 25 2023, 3:21 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Community-Tech (CommTech-Kanban), Accessibility, MediaWiki-extensions-Phonos
dom_walden added a comment to T348714: Handle edit conflicts.

@dom_walden I'm still having trouble reproducing this issue. I noticed that if I'm logged in as the same user for step 2 and 3, I don't get the conflict mentioned in step 5.

Does step 1 applies to both step 2 and 3? Or only step 2 needs to be logged in? Are you still able to reproduce this?

Many thanks!

Oct 25 2023, 12:04 PM · Community-Tech (CommTech-Kanban), Edit Recovery
dom_walden added a comment to T345683: Review of MediaWiki block-related code.

Change 964610 merged by jenkins-bot:

[mediawiki/core@master] Multiblocks preparation in User::getBlock(), PermissionManager and BlockManager

https://gerrit.wikimedia.org/r/964610

Oct 25 2023, 10:30 AM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Blocks, Community-Tech (CommTech-Kanban)

Oct 18 2023

dom_walden updated the task description for T348745: Inconsistent number of IPs returned for /proxies, /vpns compared to /proxy/:label, /vpn/:label.
Oct 18 2023, 6:22 AM · Trust and Safety Product Sprint, iPoid-Service
dom_walden renamed T348745: Inconsistent number of IPs returned for /proxies, /vpns compared to /proxy/:label, /vpn/:label from Inconsistent number of IPs returned for /proxies compared to /proxy/:label to Inconsistent number of IPs returned for /proxies, /vpns compared to /proxy/:label, /vpn/:label.
Oct 18 2023, 6:20 AM · Trust and Safety Product Sprint, iPoid-Service
dom_walden added a comment to T348745: Inconsistent number of IPs returned for /proxies, /vpns compared to /proxy/:label, /vpn/:label.

I have found cases where this bug happens for /vpns as well. Importing the Spur feed from 20231017 and comparing /vpns and /vpn/NORD_VPN the former has a smaller number of IPs compared to the latter.

Oct 18 2023, 6:19 AM · Trust and Safety Product Sprint, iPoid-Service

Oct 17 2023

dom_walden added a comment to T346429: Add tooltip to inline toggle.

@HMonroy @TheresNoTime Did we want a tooltip or a help icon (i)? The task description and the user's comment suggests we want a tooltip.

Oct 17 2023, 10:42 AM · MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), Community-Tech (CommTech-Kanban), MediaWiki-Page-diffs, Better-Diffs-2023
dom_walden moved T349025: Leading whitespace in Phonos tag parsed as code block from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

Whitespace is trimmed when included in either the label or ipa parameter.

Oct 17 2023, 10:22 AM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Community-Tech (CommTech-Kanban), MediaWiki-extensions-Phonos

Oct 16 2023

dom_walden added a comment to T347869: Handle undoing edits.

In addition to not loading Edit Recovery when undoing edits, I wonder if we would want to also delete any edit recovery data for the page — because if someone's undoing to an earlier revision it's pretty likely that they're not worried about any work in progress they have for that page. Although I guess they could have started editing, hit a conflict, then gone to undo the conflict so that they can save without any issues?

Oct 16 2023, 12:09 PM · MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), Community-Tech (CommTech-Kanban), Edit Recovery
dom_walden created T348952: TypeError: data.client.behaviors.forEach is not a function.
Oct 16 2023, 7:39 AM · Patch-For-Review, Trust and Safety Product Sprint (Sprint Bodhrán), iPoid-Service, Anti-Harassment
dom_walden created T348949: Column 'behavior_id' cannot be null.
Oct 16 2023, 6:31 AM · Trust and Safety Product Sprint (Sprint Bodhrán), iPoid-Service, Anti-Harassment

Oct 13 2023

dom_walden added a comment to T327966: Revise structure of Accessibility Playbook.

Yes, it can be a valid approach to Quickstart checklist too. One of my concerns for such a pre-set, detailed Quickstart checklist was that any specific instructions, e.g. - Use Chrome Lighthouse and report as a separate phab task any found defect might not suit to current needs of a specific team or a project.

Oct 13 2023, 12:03 PM · Quality-and-Test-Engineering-Team (Test engineering)

Oct 12 2023

dom_walden added a comment to T327966: Revise structure of Accessibility Playbook.

https://www.mediawiki.org/wiki/User:DWalden_(WMF)/A11y_playbook_draft3

Current latest draft. I need help filling out the "Quickstart" section.

I think this section could have some general instructions (with references to different sections of the document). Here is an outline

  • check with your team what (or if) a specific project/features need in terms of accessibility testing
  • create a QA checklist for accessibility testing (and communicate it if needed to your team for feedback). Your QA checklist might include details about what approach/techniques you'll use)
  • based on the above, the results of accessibility testing might be reported in phab task(s) or documented differently
Oct 12 2023, 2:45 PM · Quality-and-Test-Engineering-Team (Test engineering)
dom_walden moved T344273: Add proxies, tunnels API endpoints to ipoid service from Blocked/Stalled 🚧 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

@dom_walden The actual issues you found via testing haven't been fixed yet. Do you think we should wait for those to be fixed before further QA?

Oct 12 2023, 1:53 PM · Trust and Safety Product Sprint (Sprint Bodhrán), iPoid-Service, Anti-Harassment (AHaT Sprint 32 - Baseball Cap)
dom_walden updated the task description for T348745: Inconsistent number of IPs returned for /proxies, /vpns compared to /proxy/:label, /vpn/:label.
Oct 12 2023, 1:17 PM · Trust and Safety Product Sprint, iPoid-Service
dom_walden updated the task description for T348745: Inconsistent number of IPs returned for /proxies, /vpns compared to /proxy/:label, /vpn/:label.
Oct 12 2023, 1:17 PM · Trust and Safety Product Sprint, iPoid-Service
dom_walden created T348745: Inconsistent number of IPs returned for /proxies, /vpns compared to /proxy/:label, /vpn/:label.
Oct 12 2023, 1:16 PM · Trust and Safety Product Sprint, iPoid-Service
dom_walden renamed T348718: How should we handle preloaded text? from How should we handle pages with preloaded text? to How should we handle preloaded text?.
Oct 12 2023, 8:04 AM · Edit Recovery, Community-Tech
dom_walden created T348718: How should we handle preloaded text?.
Oct 12 2023, 8:04 AM · Edit Recovery, Community-Tech
dom_walden created T348714: Handle edit conflicts.
Oct 12 2023, 7:24 AM · Community-Tech (CommTech-Kanban), Edit Recovery

Oct 10 2023

dom_walden moved T343983: Error: Call to a member function getTimestamp() on null from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

I think I found a way to reproduce the bug by setting this database trigger:

CREATE TRIGGER stop_insert BEFORE INSERT ON recentchanges FOR EACH ROW DELETE FROM logging WHERE log_id = new.rc_logid;

Every time a row is inserted into the recentchanges table, the associated row in the logging table is deleted. It might be a bit unrealistic, but it seems to reliably reproduce the bug in the parent commit.

Oct 10 2023, 1:06 PM · MediaWiki-Platform-Team (Radar), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), MediaWiki-User-rename, MediaWiki-extensions-CentralAuth, CheckUser, Wikimedia-production-error

Oct 3 2023

dom_walden moved T316360: Oversighted action text is shown in Special:CheckUser when the checkuser does not have the right to see it from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

I tested all the different combinations of visibility for a log entry.

Oct 3 2023, 2:35 PM · Security-Team, Anti-Harassment (AHaT Sprint 32 - Baseball Cap), SecTeam-Processed, Vuln-Infoleak, CheckUser, Security
dom_walden moved T336512: Remove convinence link to "checks by this user" on Special:Contribution pages of temporary accounts from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

The Checks done by this user link does not appear for temporary users and IPs. It does for regular users.

Oct 3 2023, 7:24 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), CheckUser, Temporary accounts
dom_walden moved T328995: Enable read new support in Special:CheckUser's 'Get edits' mode from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

I think everything else is okay so QA shouldn't be blocked for this task (let me know if I've missed something).

Oct 3 2023, 6:23 AM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Patch-For-Review, Anti-Harassment (AHaT Sprint 32 - Baseball Cap), CheckUser

Oct 2 2023

dom_walden added a comment to T327966: Revise structure of Accessibility Playbook.

Current latest draft. I need help filling out the "Quickstart" section.

Oct 2 2023, 3:09 PM · Quality-and-Test-Engineering-Team (Test engineering)
dom_walden added a comment to T343089: Save edit recovery data on visibilitychange event.

Another potential risk of this change is that every time an editor visits the Source Editor for a page Edit Recovery will save the current content (even if they don't make an edit).

Oct 2 2023, 1:54 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Community-Tech (CommTech-Kanban), Edit Recovery
dom_walden created T347869: Handle undoing edits.
Oct 2 2023, 1:42 PM · MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), Community-Tech (CommTech-Kanban), Edit Recovery
dom_walden created T347867: Should we support Edit Recovery for old revisions?.
Oct 2 2023, 1:33 PM · Edit Recovery, Community-Tech
dom_walden renamed T347864: Handle switching between Visual and Source Editor from How to handle switching between Visual and Source Editor to Handle switching between Visual and Source Editor.
Oct 2 2023, 1:23 PM · Edit Recovery, Community-Tech
dom_walden created T347864: Handle switching between Visual and Source Editor.
Oct 2 2023, 1:23 PM · Edit Recovery, Community-Tech
dom_walden added a comment to T343089: Save edit recovery data on visibilitychange event.

@Samwilson I cannot get it to clear the indexeddb data when I click Cancel on the edit page, like it did before. Is that because it is triggering one of the events?

Oct 2 2023, 11:11 AM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Community-Tech (CommTech-Kanban), Edit Recovery
dom_walden moved T347400: Read new cannot parse the log_params of global block log entries from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Special:CheckUser now correctly parses a variety of log parameters, including those that use the legacy log params such as global block and interwiki. I did not see any errors or warnings on the page or in the logs.

Oct 2 2023, 9:12 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), CheckUser

Sep 29 2023

dom_walden moved T329774: IP Masking (CommTech): LoginNotify from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

When attempting to login as a temporary user, I don't see any emails or echo notifications, nothing new in echo_event database, and in the logs I see:

[LoginNotify] Skipping recording failure for user *Unregistered 232 - can't authenticate
Sep 29 2023, 2:00 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Community-Tech (CommTech-Kanban), MediaWiki-extensions-LoginNotify, Temporary accounts
dom_walden moved T346308: Update get-feed.js to take and use a date parameter from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

I see I can download today and yesterday's feed. The files are different sizes, so I assume they are different files. I cannot verify that the files are for the correct date.

Sep 29 2023, 1:10 PM · Anti-Harassment (AHaT Sprint 32 - Baseball Cap), iPoid-Service
dom_walden created T347669: moveLogEntriesFromCuChanges import inconsistencies.
Sep 29 2023, 8:34 AM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), CheckUser
dom_walden updated the task description for T347556: Some user creation entries have incorrect Special:Log url.
Sep 29 2023, 6:55 AM · Trust and Safety Product Team, CheckUser, Anti-Harassment

Sep 28 2023

dom_walden added a comment to T328995: Enable read new support in Special:CheckUser's 'Get edits' mode.

Differences that I have observed so far between SCHEMA_COMPAT_READ_OLD and SCHEMA_COMPAT_READ_NEW:

  1. Usernames, temporary usernames and IPs are links, have mw-userlink class and are wrapped in <bdi>. Before they were plain text.
  2. Temp user links to special:contribs and has mw-tempuserlink class, so they are properly styled.
  3. Many entries now have two log links (log | logs), for the Special:Log&logid=<log id> and Special:Log&page=<page or user> respectively.
    log_logs.png (100×2 px, 63 KB)
  4. Entries for group membership changes use the public(?) name for user groups, not their internal name. For example, it says administrator rather than sysop.
  5. Entries for blocks have the expiry in a <span class="blockExpiry" title="‎infinity">indefinite</span>, which means you get a tooltip.
  6. It recognises where a page is a redirect and adds redirect=no to the page's URL.
  7. Entries of page suppressions show in full. Before they showed as (username removed) (log details removed).
    page_suppress_log.png (100×1 px, 66 KB)
Sep 28 2023, 2:26 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Patch-For-Review, Anti-Harassment (AHaT Sprint 32 - Baseball Cap), CheckUser
dom_walden moved T328997: Enable read new support in Special:CheckUser's 'Get users' mode from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

I compared the HTML output of "Get users" with SCHEMA_COMPAT_READ_OLD and SCHEMA_COMPAT_READ_NEW for all the IP addresses I had on my local wiki. There were no differences.

Sep 28 2023, 1:53 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Patch-For-Review, CheckUser
dom_walden moved T325630: Implement call to data vendor from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.
Sep 28 2023, 1:53 PM · Patch-For-Review, Anti-Harassment (AHaT Sprint 32 - Baseball Cap), iPoid-Service
dom_walden moved T341932: Create service to return Client Hints data from the database from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.
Sep 28 2023, 1:53 PM · http-client-hints (Release 0 (Pilot wikis)), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), CheckUser
dom_walden moved T340996: Implement system to convert client hint data to a string representation from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.
Sep 28 2023, 1:53 PM · http-client-hints (Release 0 (Pilot wikis)), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), CheckUser
dom_walden created T347556: Some user creation entries have incorrect Special:Log url.
Sep 28 2023, 9:29 AM · Trust and Safety Product Team, CheckUser, Anti-Harassment

Sep 26 2023

dom_walden updated the task description for T347400: Read new cannot parse the log_params of global block log entries.
Sep 26 2023, 2:46 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), CheckUser
dom_walden created T347400: Read new cannot parse the log_params of global block log entries.
Sep 26 2023, 1:28 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), CheckUser

Sep 22 2023

dom_walden moved T346132: Inline toggle not labelled for accessibility from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

The Inline toggle now has aria-labelledby, which refers to the <label>Inline</label> element.

Sep 22 2023, 1:25 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Community-Tech (CommTech-Kanban), Accessibility, MediaWiki-Page-diffs, Better-Diffs-2023