User Details
- User Since
- Oct 22 2018, 4:33 PM (193 w, 1 d)
- Availability
- Available
- LDAP User
- Dom Walden
- MediaWiki User
- DWalden (WMF) [ Global Accounts ]
Today
This looks fine to me. As this is a trivial change, I will immediately resolve it.
@Tchanders Just to check my understanding of the <bdi> tag. It means that the page title should appear the same regardless of the direction of the user's interface language.
Yesterday
@Prtksxna The log link only appears when there is at least one active block. Is that OK? I can imagine that even if there are no active blocks a user might want to see the logs to check any past blocks.
I've tested this briefly on Firefox on enwiki, dewiki and eswiki and Chromium on euwiki and trwiki. Just to see that nothing is obviously broken.
Mon, Jul 4
I looked up 100 revisions which had been added by importing articles on beta.
Possibly the same as T310813.
Fri, Jul 1
Submitting the Special:SimilarEditors form with every user the Similarusers service knows about from the test data.
@Physikerwelt When are we going to do the npm release (sorry I don't know how to do this myself).
I ran every IPA string we have in our test corpus against the new API. There were no errors and it always produced a base64 encoded audio string.
@AGueyte If we are setting the XTools URL in the translations file, the URL will depend on the user's interface language. But shouldn't it depend on the current wiki? For example, if you are looking up an IP on frwiki the link to xtools should always be https://xtools.wmflabs.org/ec/fr.wikipedia.org/$ip.
Thu, Jun 30
Further to what I was saying yesterday, making the request from the example (http://localhost:8081/w/api.php?action=phonos&format=json&ipa=h%C9%99%CB%88l%C9%99%CA%8A&text=hello&lang=en) the return value is:
{ "phonos": { "ssml": "<?xml version=\"1.0\"?>\n<speak xmlns=\"http://www.w3.org/2001/10/synthesis\" version=\"1.1\" xml:lang=\"en\"><phoneme alphabet=\"ipa\" ph=\"həˈləʊ\">hello</phoneme></speak>\n", ... } }
With the hex-encoded IPA notation. I don't know if this is OK.
@Samwilson I guess you will also need to fix this bug in CodeMirror? The highlighting still gets removed there when opening/closing RTP.
Wed, Jun 29
I guess phenome should be phoneme here?:
"apihelp-phonos-param-ipa": "The IPA phenome to render."
AC
- Remove the button when something is watchlisted
Tue, Jun 28
Feedback link now goes to https://meta.wikimedia.org/wiki/IP_Editing:_Privacy_Enhancement_and_Abuse_Mitigation/IP_Info_feature/Feedback?action=edit§ion=new&preloadtitle=Feedback+from+Dom+walden&preload=Special%3AMyLanguage%2FTemplate%3AIPInfoFeedback regardless of the user's interface language.
@Samwilson When I don't include the text parameter I get an error:
{ "error": { "code": "internal_api_error_TypeError", "info": "[4540245937393c630e235698] Exception caught: Argument 2 passed to MediaWiki\\Extension\\Phonos\\Engine\\EspeakEngine::getAudioData() must be of the type string, null given, called in /var/www/html/w/extensions/Phonos/includes/PhonosApi.php on line 35", "errorclass": "TypeError", "*": "TypeError at /var/www/html/w/extensions/Phonos/includes/Engine/EspeakEngine.php(16)\nfrom /var/www/html/w/extensions/Phonos/includes/Engine/EspeakEngine.php(16)\n#0 /var/www/html/w/extensions/Phonos/includes/PhonosApi.php(35): MediaWiki\\Extension\\Phonos\\Engine\\EspeakEngine->getAudioData(string, NULL, string)\n#1 /var/www/html/w/includes/api/ApiMain.php(1901): MediaWiki\\Extension\\Phonos\\PhonosApi->execute()\n#2 /var/www/html/w/includes/api/ApiMain.php(875): ApiMain->executeAction()\n#3 /var/www/html/w/includes/api/ApiMain.php(846): ApiMain->executeActionWithErrorHandling()\n#4 /var/www/html/w/api.php(90): ApiMain->execute()\n#5 /var/www/html/w/api.php(45): wfApiMain()\n#6 {main}" }, "servedby": "6aed8d9700af" }
Should the text parameter be required or will that depend on the specific engine?
Here is what the popup looks like on beta, Vector 2022, English:
The bug is no longer reproducible on beta in wikieditor or visualeditor.
- https://commons.wikimedia.beta.wmflabs.org/wiki/IP_Editing:_Privacy_Enhancement_and_Abuse_Mitigation/IP_Info_feature/Feedback?action=edit§ion=new&preload=Special%3AMyLanguage%2FTemplate%3AIPInfoFeedback&uselang=en
- https://commons.wikimedia.beta.wmflabs.org/wiki/IP_Editing:_Privacy_Enhancement_and_Abuse_Mitigation/IP_Info_feature/Feedback?veaction=edit§ion=new&preload=Special%3AMyLanguage%2FTemplate%3AIPInfoFeedback&uselang=en
Mon, Jun 27
We should link to the:
- interaction timeline tool: https://interaction-timeline.toolforge.org/
- filtered to the input user and the user from that row
filtered to the wiki on which Special:SimilarEditors is being visitedfiltered to enwiki, with a comment referencing T309675- not filtered to a particular time period
User with full viewing rights but no data:
Fri, Jun 24
Due to the above error I couldn't test this on beta but I have tested it locally.
I believe one side affect of this is the error on beta (recorded here: T309400#8025778). There are records in the logs of IPInfo lookups which are not of actual IP addresses.
@MarcoAurelio Trying to access the IPInfo logs on beta (https://en.wikipedia.beta.wmflabs.org/wiki/Special:Log?type=ipinfo&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers) I get the exception:
[YrXCZWGXEEzZDXncyWtEDQAAAAk] /wiki/Special:Log?type=ipinfo&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers InvalidArgumentException: Invalid IP address
@Niharika How far do we want to go with these changes?
@Diesel_kapasule ipinfo-infobox-disable-instructions isn't displaying for me correctly on beta. It displays as: If you'd like to disable this feature you can do so from [[{{#special:Preferences}}]].
Thu, Jun 23
@STran We might need to URL encode after all.
How it looks on beta for an IPv4 address (beta does not support IPv6).
I used a script to submit the Special:SimilarEditors form for every user it knows about. I then compared the number of results, MW logs and Similaruser logs to data I had collected for a previous version of the Similarusers service.
Wed, Jun 22
Here is what the example from the description looks like now:
@Prtksxna I assume we don't want VERSION to be capitalised?
Rest/Presenter/DefaultPresenter.php now reports 100% coverage: https://doc.wikimedia.org/cover-extensions/IPInfo/Rest/Presenter/DefaultPresenter.php.html
Jobs/LogIPInfoAccessJob.php now reports 100% code coverage: https://doc.wikimedia.org/cover-extensions/IPInfo/Jobs/LogIPInfoAccessJob.php.html
Tue, Jun 21
Here is what is looks like on beta on the Vector 2022 skin in English:
Fri, Jun 17
I have briefly tested editing on WikiEditor and VisualEditor on enwiki, fawiki, viwiki and plwiki.
How Special:Contributions looks when the IP is blocked:
{F35248573}
The rows where the IPInfo icon does not appear next to IP addresses also do a jump (the opposite of this bug T271486).
Thu, Jun 16
Wed, Jun 15
@Tchanders I didn't spot these before, but there seem to be some other cases where we get the same error.
The link goes to: https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Extension:SimilarEditors (which I assume is correct assuming the help page will be translated one day).
@Jdlrobson Here is what Minerva looks like on my local docker server, I am not sure what is happening:
Tue, Jun 14
@Samwilson I find the auto-scrolling does not happen when syntax highlighting (CodeMirror) is on. Is this expected?
Here is how the message in Special:Log looks in English.
Thanks @Tchanders. I have nothing more to add here.
Mon, Jun 13
Here is the SVG on beta wikisource:
I have tested the GuidedTour in Special:Investigate in each of the below cases:
User has block rights | Wiki has VE |
yes | yes |
yes | no |
no | yes |
no | no |
I loaded the WikiEditor/CodeEditor for pages in various namespaces on beta wikisource (where RTP is loaded as a gadget).
The CodeEditor resize now works on beta wikisource, where RTP is loaded as a gadget. See, for example, https://en.wikisource.beta.wmflabs.org/w/index.php?title=MediaWiki:Common.js/watchlist.js&action=edit.
I tested a few pages on beta wikisource where the CodeEditor is used (e.g. here, here, here). The Realtime Preview does not get loaded. The regular CodeEditor behaves as I understand it should. All the basic functionality appears to function.
I don't think there is much I can do to test this at the moment.
Acceptance Criteria
- The pulsating UI should appear upon first exposure to the functionality
Fri, Jun 10
Test report for beta:
This also affects the "Add topic" functionality (sorry I don't know if this has a special name). I am guessing it has the same underlying cause, but let me know if you want a separate bug.
Thu, Jun 9
@EAkinloose found this bug on beta. Notice that the image slightly overflows its border on the right:
Page: https://en.wikipedia.beta.wmflabs.org/wiki/Cat?veaction=edit
@Samwilson After clicking "Show Preview" or "Show changes" the WikiEditor is not full-width.
@Samwilson I find that when I open the WikiEditor and then switch to VE, the VE editor is full-width. However, if I go to VE first VE is not full-width.
I tested for two risks:
- SimilarEditors extension sends invalid URLs.
- URL encoding the username means the similarusers service looks up a different username than the one intended.
Wed, Jun 8
- Allow any user to be entered in the user input (ideally we would allow any user that exists on English Wikipedia, but I don't think that complexity is necessary for this temporary change)
Tue, Jun 7
The infobox does not appear on mobile view (e.g. https://en.m.wikipedia.beta.wmflabs.org).