Page MenuHomePhabricator

dom_walden (Dom Walden)
Test Engineer for Community Tech and Anti-Harassment Tools

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2018, 4:33 PM (110 w, 4 d)
Availability
Available
LDAP User
Dom Walden
MediaWiki User
DWalden (WMF) [ Global Accounts ]

Recent Activity

Yesterday

dom_walden created T269416: CentralAuth suppress only creates a suppress log entry on the local wiki, not attached.
Fri, Dec 4, 9:22 AM · MediaWiki-Blocks, MediaWiki-extensions-CentralAuth

Thu, Dec 3

dom_walden added a comment to T269343: Wikisource Export: Validate file format.

We now default to epub if the format input is blank: https://github.com/wsexport/tool/pull/286.

Thu, Dec 3, 1:21 PM · Wikisource Export, Community-Tech
dom_walden created T269344: Wikisource Export: Use dropdown or Universal Language Selector for language input.
Thu, Dec 3, 10:44 AM · Wikisource Export, Community-Tech
dom_walden created T269343: Wikisource Export: Validate file format.
Thu, Dec 3, 10:38 AM · Wikisource Export, Community-Tech
dom_walden created T269341: API:Block should validate page restrictions.
Thu, Dec 3, 10:08 AM · MediaWiki-Blocks

Wed, Dec 2

dom_walden created T269239: mediawiki.Title: "title.replace is not a function".
Wed, Dec 2, 3:11 PM · Patch-For-Review, MediaWiki-Interface, JavaScript
dom_walden moved T266875: Watchlist Expiry: enable the feature on all remaining wikis [DEC 1] from QA 🐛 to Product sign-off 🤘 on the Community-Tech (Kanban-2020-21-Q2) board.

I did some brief smoke testing of the watch star and action=watch on a few different production Wikipedias (afwiki, zhwiki, hywiki, bewiki and commons, and glkwiki on mobile).

Wed, Dec 2, 1:45 PM · Community-Tech (Kanban-2020-21-Q2), Wikimedia-Site-requests, Expiring-Watchlist-Items
dom_walden created T269216: Images can overlap footer in New Vector .
Wed, Dec 2, 10:39 AM · Desktop Improvements

Tue, Dec 1

dom_walden created T269131: "Argument 1 passed to User::equals() must implement interface MediaWiki\User\UserIdentity, null given".
Tue, Dec 1, 1:50 PM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Growth-Team, PageCuration
dom_walden added a comment to T263752: Add a user preference for access to IP Info .

We now have a new preference at the bottom of the "User profile" tab of Special:Preferences.

Tue, Dec 1, 8:59 AM · Anti-Harassment (The Letter Song), IP Info

Mon, Nov 30

dom_walden updated the task description for T268981: IPInfo: Dotted lines on revision history jumps when opening popup (only on Firefox).
Mon, Nov 30, 12:53 PM · IP Info, Anti-Harassment
dom_walden created T268981: IPInfo: Dotted lines on revision history jumps when opening popup (only on Firefox).
Mon, Nov 30, 10:40 AM · IP Info, Anti-Harassment
dom_walden created T268973: CU 2.0: InvestigateBlock does not normalise IP range when leaving notice.
Mon, Nov 30, 9:29 AM · CheckUser, Anti-Harassment

Fri, Nov 27

dom_walden moved T263752: Add a user preference for access to IP Info from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

We now have a new preference at the bottom of the "User profile" tab of Special:Preferences.

Fri, Nov 27, 9:23 AM · Anti-Harassment (The Letter Song), IP Info
dom_walden moved T265437: Message for customizing IP tools links seems to need two open square brackets and one closing bracket from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

The English translation of the message has been corrected to use a single square bracket.

Fri, Nov 27, 8:48 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Anti-Harassment (The Letter Song), CheckUser

Thu, Nov 26

dom_walden moved T267015: Normalise IP address when checking if IP address in response matches from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

It is now possible to see information about IPv6 IPs in the popup. I have not seen the The IP address provided did not match the log or revision error since this change.

Thu, Nov 26, 2:42 PM · Anti-Harassment (The Letter Song), IP Info
dom_walden moved T267230: Set Cache-Control header in API responses from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

The response for the revision and log endpoints includes the header Cache-control: private, max-age=86400. This means a user's browser will cache the response for 24 hours.

Thu, Nov 26, 10:49 AM · Anti-Harassment (The Letter Song), IP Info
dom_walden merged task T267398: IPInfo: Blank popup if ASN is null into T268531: Check if `asn` value exists before attempting to display it in IPInfo.
Thu, Nov 26, 10:20 AM · IP Info, Anti-Harassment
dom_walden merged T267398: IPInfo: Blank popup if ASN is null into T268531: Check if `asn` value exists before attempting to display it in IPInfo.
Thu, Nov 26, 10:20 AM · IP Info, Anti-Harassment (The Letter Song)
dom_walden moved T268531: Check if `asn` value exists before attempting to display it in IPInfo from QA/Testing 🐞 to Design Review 🔬 on the Anti-Harassment (The Letter Song) board.

If MaxMind has no ASN data for an IP, the popup will only show the location and source.

Thu, Nov 26, 10:20 AM · IP Info, Anti-Harassment (The Letter Song)

Wed, Nov 25

dom_walden moved T265439: [Bug] Middle-click does not work on links in the tools menu under IP address from QA/Testing 🐞 to Design Review 🔬 on the Anti-Harassment (The Letter Song) board.

The links in the tool menu for the username and IP columns now has the "newWindow" indicator.

Wed, Nov 25, 8:40 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Anti-Harassment (The Letter Song), CheckUser

Tue, Nov 24

dom_walden added a comment to T267015: Normalise IP address when checking if IP address in response matches.

@STran @Tchanders Do we know if all IPs are "prettified" in the same way everywhere we might use IPInfo?

Tue, Nov 24, 3:28 PM · Anti-Harassment (The Letter Song), IP Info

Mon, Nov 23

dom_walden updated the task description for T268507: Watchlist Expiry: Some languages may see misleading expiry time.
Mon, Nov 23, 5:06 PM · I18n, Expiring-Watchlist-Items, Community-Tech
dom_walden created T268507: Watchlist Expiry: Some languages may see misleading expiry time.
Mon, Nov 23, 5:06 PM · I18n, Expiring-Watchlist-Items, Community-Tech
dom_walden updated the task description for T268492: When translation falls-back, does not use fall-back language's plural rules.
Mon, Nov 23, 4:53 PM · I18n, MediaWiki-Internationalization, Plural-Support
dom_walden created T268492: When translation falls-back, does not use fall-back language's plural rules.
Mon, Nov 23, 3:36 PM · I18n, MediaWiki-Internationalization, Plural-Support
dom_walden moved T268095: Special:Investigate - Check button in menu doesn't set the target from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

The Checks button now links to: ?title=Special:CheckUserLog&cuSearch=$username or ?title=Special:CheckUserLog&cuSearch=$ip.

Mon, Nov 23, 10:44 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Anti-Harassment (The Letter Song), CheckUser

Fri, Nov 20

dom_walden added a comment to T268000: Set up test books on Beta Wikisource.

I have had some success using https://www.mediawiki.org/wiki/API:Import to import pages from en.wikisource to beta wikisource (e.g. https://en.wikisource.beta.wmflabs.org/wiki/The_Climber, https://en.wikisource.beta.wmflabs.org/wiki/The_Czechoslovak_Review/Volume_2/The_Great_Czechoslovak_Romance).

Fri, Nov 20, 4:44 PM · Community-Tech, Wikisource Export
dom_walden added a comment to T266854: Wikisource Export: "Unable to launch a new process".

This has been seen on production 5 times since 18th Nov. Total number of downloads in November was ~65000.

Fri, Nov 20, 2:40 PM · Wikisource Export, Community-Tech
dom_walden renamed T266854: Wikisource Export: "Unable to launch a new process" from Wikisource Export: "Unable to launch a new process" (only reproducible on wsexport-test) to Wikisource Export: "Unable to launch a new process".
Fri, Nov 20, 2:40 PM · Wikisource Export, Community-Tech
dom_walden added a comment to T268130: Wikisource Export: The process has been signaled with signal "5".

This has been seen twice on production since 18th Nov. Total number of downloads in November was ~65000.

Fri, Nov 20, 2:38 PM · Wikisource Export, Community-Tech
dom_walden added a comment to T268253: Wikisource Export: "No page information found in response".

This error has been seen 5 times on production since 17th Nov. Total number of downloads in November was ~65000.

Fri, Nov 20, 2:35 PM · Wikisource Export, Community-Tech
dom_walden updated subscribers of T268132: Wikisource Export: "Uncaught PHP Exception GuzzleHttp\Exception\ServerException".

@ifried This error has been seen 5 times on production since 18th Nov. Total number of downloads in November was ~65000.

Fri, Nov 20, 2:34 PM · Wikisource Export, Community-Tech

Thu, Nov 19

dom_walden updated the task description for T268132: Wikisource Export: "Uncaught PHP Exception GuzzleHttp\Exception\ServerException".
Thu, Nov 19, 7:01 PM · Wikisource Export, Community-Tech
dom_walden created T268253: Wikisource Export: "No page information found in response".
Thu, Nov 19, 5:03 PM · Wikisource Export, Community-Tech

Wed, Nov 18

dom_walden moved T266874: Watchlist Expiry: enable the feature on Wikidata & Commons [NOV 17] from QA 🐛 to Product sign-off 🤘 on the Community-Tech (Kanban-2020-21-Q2) board.

I tested action=watch and the watch star on https://www.wikidata.org.

Wed, Nov 18, 2:15 PM · Community-Tech (Kanban-2020-21-Q2), Wikimedia-Site-requests, Expiring-Watchlist-Items
dom_walden updated the task description for T268136: Wikisource Export: Some font variants missing.
Wed, Nov 18, 1:18 PM · Community-Tech
dom_walden moved T261479: Wikisource: Make it possible to use any installed fonts in ebooks from QA 🐛 to Product sign-off 🤘 on the Community-Tech (Kanban-2020-21-Q2) board.

On the test site (and, since T267361, on the production site as well), you will now see a much larger selection of fonts in the dropdown. I guess this includes all available fonts.

Wed, Nov 18, 1:08 PM · Community-Tech (Kanban-2020-21-Q2), Wikisource Export
dom_walden created T268136: Wikisource Export: Some font variants missing.
Wed, Nov 18, 1:06 PM · Community-Tech
dom_walden created T268132: Wikisource Export: "Uncaught PHP Exception GuzzleHttp\Exception\ServerException".
Wed, Nov 18, 11:59 AM · Wikisource Export, Community-Tech
dom_walden created T268130: Wikisource Export: The process has been signaled with signal "5".
Wed, Nov 18, 11:48 AM · Wikisource Export, Community-Tech
dom_walden moved T268005: Unable to create Mobi of plwikisource:Dziady część III/Scena V from QA 🐛 to Product sign-off 🤘 on the Community-Tech (Kanban-2020-21-Q2) board.

As Sam says, http://wsexport.wmflabs.org/tool/book.php?format=mobi&lang=pl&page=Dziady%20cz%C4%99%C5%9B%C4%87%20III%2FScena%20V now exports correctly.

Wed, Nov 18, 11:16 AM · Community-Tech (Kanban-2020-21-Q2), Wikisource Export

Tue, Nov 17

dom_walden moved T267611: Problem with creating a page in the Meta: ExpiryDef: Invalid expiry value from QA 🐛 to Product sign-off 🤘 on the Community-Tech (Kanban-2020-21-Q2) board.

We now check the translations and only include valid expiry values in the dropdown. Any invalid expiry values are ignored and not included in the dropdown.

Tue, Nov 17, 5:47 PM · Community-Tech (Kanban-2020-21-Q2), MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Patch-For-Review, User-brennen, Expiring-Watchlist-Items, MediaWiki-Watchlist, Growth-Team, Wikimedia-production-error

Mon, Nov 16

dom_walden updated dom_walden.
Mon, Nov 16, 4:28 PM

Fri, Nov 6

dom_walden created T267406: Watchlist Expiry: Safari does not tab to expiry dropdown after using watch star.
Fri, Nov 6, 2:36 PM · Expiring-Watchlist-Items, Community-Tech
dom_walden created T267405: CU 2.0: Safari cannot access links inside the Compare and Timeline tabs using keyboard.
Fri, Nov 6, 2:27 PM · CheckUser, Anti-Harassment
dom_walden created T267403: IPInfo: Show country in the popup.
Fri, Nov 6, 2:06 PM · IP Info, Anti-Harassment
dom_walden created T267402: IPInfo: Blocked users can use IPInfo.
Fri, Nov 6, 2:04 PM · IP Info, Anti-Harassment
dom_walden moved T264905: Switching mock data in IP Info for live data from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

thegoodplace now shows IP information from MaxMind's GeoLite2.

Fri, Nov 6, 1:55 PM · Anti-Harassment (The Letter Song), IP Info
dom_walden added a comment to T267056: IPInfo: Argument 1 passed to MediaWiki\IPInfo\Info\Location::__construct() must be of the type int, null given.

I see a similar error for some other logs. I believe when the IP has no lat/long data returned. For example https://thegoodplace.wmcloud.org/rest.php/ipinfo/v0/log/95:

[497152ef9b5342a917de5ad2] /w/rest.php/ipinfo/v0/log/5025 TypeError from line 18 of /vagrant/mediawiki/extensions/IPInfo/src/Info/Coordinates.php: Argument 1 passed to MediaWiki\IPInfo\Info\Coordinates::__construct() must be of the type float, null given, called in /vagrant/mediawiki/extensions/IPInfo/src/GeoIp2InfoRetriever.php on line 117
Fri, Nov 6, 1:14 PM · Patch-For-Review, Anti-Harassment (The Letter Song), IP Info
dom_walden updated the task description for T267398: IPInfo: Blank popup if ASN is null.
Fri, Nov 6, 1:08 PM · IP Info, Anti-Harassment
dom_walden created T267398: IPInfo: Blank popup if ASN is null.
Fri, Nov 6, 1:07 PM · IP Info, Anti-Harassment

Thu, Nov 5

dom_walden moved T264879: IPInfo: Consider permissions logic for getting IP information from log entries from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.
Thu, Nov 5, 3:34 PM · Anti-Harassment (The Letter Song), IP Info
dom_walden added a comment to T264879: IPInfo: Consider permissions logic for getting IP information from log entries.

Based on testing locally:

Deleted Stateipinfoipinfo + deletedhistoryipinfo + viewsuppressed
Performer + TargetPerformer + TargetPerformer + Target
DELETED_ACTIONPerformerPerformer + TargetPerformer + Target
DELETED_USERTargetPerformer + TargetPerformer + Target
DELETED_RESTRICTED + DELETED_ACTIONPerformerPerformerPerformer + Target
DELETED_RESTRICTED + DELETED_USERTargetTargetPerformer + Target

Which I believe is consistent with Proposal 3. I made a mistake in the description. The correct right is viewsuppressed, not suppressionlog.

Thu, Nov 5, 3:16 PM · Anti-Harassment (The Letter Song), IP Info

Nov 4 2020

dom_walden created T267231: IPInfo: Location subdivisions sometimes displayed in wrong order.
Nov 4 2020, 4:03 PM · IP Info, Anti-Harassment
dom_walden moved T259791: Merge Special:InvestigateLog with Special:CheckUserLog from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

@dom_walden There's nothing extra to test here - it's just a parent task.

Nov 4 2020, 11:01 AM · Anti-Harassment (The Letter Song), Design, CheckUser
dom_walden moved T267046: Show logs with type 'investigate' in Special:CheckUserLog when filtering by a User target from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

@Tchanders Thanks for finding this.

Nov 4 2020, 10:59 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T266585: Remove SpecialInvestigateLog, InvestigateLogPager and InvestigateLogPagerFactory from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.
  • Link to the Special:Investigate form from the top of Special:CheckuserLog
Nov 4 2020, 9:45 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), CheckUser, Anti-Harassment (The Letter Song)

Nov 3 2020

dom_walden updated the task description for T267056: IPInfo: Argument 1 passed to MediaWiki\IPInfo\Info\Location::__construct() must be of the type int, null given.
Nov 3 2020, 2:56 PM · Patch-For-Review, Anti-Harassment (The Letter Song), IP Info

Nov 2 2020

dom_walden created T267056: IPInfo: Argument 1 passed to MediaWiki\IPInfo\Info\Location::__construct() must be of the type int, null given.
Nov 2 2020, 6:46 PM · Patch-For-Review, Anti-Harassment (The Letter Song), IP Info
dom_walden moved T266851: Manually install the Mukta family of fonts from QA 🐛 to Product sign-off 🤘 on the Community-Tech (Kanban-2020-21-Q2) board.

I can export an ebook with the options fonts=Mukta, fonts=Mukta Mahee, fonts=Mukta Malar and fonts=Mukta Vaani.

Nov 2 2020, 10:41 AM · Community-Tech (Kanban-2020-21-Q2), Wikisource Export

Oct 30 2020

dom_walden moved T266238: Show logs for Special:Investigate investigations on Special:CheckUserLog from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

Special:CheckUserLog and api.php?action=query&list=checkuserlog now show logs from Special:Investigate.

Oct 30 2020, 1:59 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Anti-Harassment (The Letter Song), Design, CheckUser
dom_walden moved T261646: CU 2.0: Cannot select text inside table from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

It is possible to copy text from each column of the Preliminary Check and Compare tables.

Oct 30 2020, 10:52 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T265433: Format links with the wiki name in the wikitext output from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

The Wikitext export now uses external links.

Oct 30 2020, 10:27 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T263577: Wikisource: Implement adding Symfony 5 to WSExport from QA 🐛 to Product sign-off 🤘 on the Community-Tech (Kanban-2020-21-Q2) board.

The slash issue should be fixed now.

Oct 30 2020, 10:09 AM · Community-Tech (Kanban-2020-21-Q2), Wikisource Export, Wikisource
dom_walden updated the task description for T266854: Wikisource Export: "Unable to launch a new process".
Oct 30 2020, 9:48 AM · Wikisource Export, Community-Tech
dom_walden updated the task description for T266854: Wikisource Export: "Unable to launch a new process".
Oct 30 2020, 9:34 AM · Wikisource Export, Community-Tech
dom_walden created T266854: Wikisource Export: "Unable to launch a new process".
Oct 30 2020, 9:14 AM · Wikisource Export, Community-Tech

Oct 29 2020

dom_walden created T266757: Wikisource Export: Exit Code: 2(Misuse of shell builtins) (only reproducible on wsexport-test).
Oct 29 2020, 9:24 AM · Wikisource Export, Community-Tech
dom_walden moved T263664: Watchlist Expiry: watch/unwatch links should remove clock icon from QA 🐛 to Product sign-off 🤘 on the Community-Tech (Kanban-2020-21-Q2) board.

@dom_walden I think the display of ".." when you should see a semi-colon (which displays after refresh) is minor behavior, so it doesn't need to be fixed in this ticket. It can be raised in a separate ticket, and it can be treated as a low-priority issue, that perhaps a volunteer developer may be interested in fixing (but we probably won't fix now ourselves). Thanks!

Oct 29 2020, 8:55 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Community-Tech (Kanban-2020-21-Q2), User-DannyS712, Expiring-Watchlist-Items
dom_walden created T266747: Watchlist Expiry: Special:Watchlist clock icon should be replaced by semicolon when removed.
Oct 29 2020, 8:54 AM · Expiring-Watchlist-Items, Community-Tech

Oct 28 2020

dom_walden added a comment to T263664: Watchlist Expiry: watch/unwatch links should remove clock icon.

On Special:Watchlist, clicking "x" will put a strike through all entries with the same title and the respective Talk page (if applicable). For example:

Oct 28 2020, 2:33 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Community-Tech (Kanban-2020-21-Q2), User-DannyS712, Expiring-Watchlist-Items

Oct 27 2020

dom_walden added a comment to T261479: Wikisource: Make it possible to use any installed fonts in ebooks.

@Samwilson I am seeing some discrepancies in the fonts that are included in the epub files.

Oct 27 2020, 10:34 AM · Community-Tech (Kanban-2020-21-Q2), Wikisource Export

Oct 20 2020

dom_walden moved T265088: Fix wsexport docker container after symfony switchover from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.

Following the instructions in the README file, I have been able to get the docker version of WSExport running and have been able to export ebooks using it.

Oct 20 2020, 12:37 PM · Community-Tech (Kanban-2020-21-Q2)

Oct 19 2020

dom_walden created T265918: Watchlist Expiry: Standardise direction of the half watch star in RTL languages across skins.
Oct 19 2020, 3:45 PM · Expiring-Watchlist-Items, Community-Tech
dom_walden created T265909: Watchlist Expiry: Watch star tooltip does not include number of days left in Minerva.
Oct 19 2020, 1:58 PM · Expiring-Watchlist-Items, Community-Tech
dom_walden created T265903: Watchlist Expiry: Add support for watchlist expiry to Special:UnwatchedPages.
Oct 19 2020, 1:36 PM · Expiring-Watchlist-Items, Community-Tech
dom_walden moved T264303: Use BlockUser service in SpecialInvestigateBlock from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

I used Special:InvestigateBlock to block various users, IPs and ranges, including reblocking users.

Oct 19 2020, 8:43 AM · Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T257918: Special:InvestigateBlock: "Undefined index: PreviousTarget" when trying to block self from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

I can no longer reproduce this bug.

Oct 19 2020, 8:09 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Anti-Harassment (The Letter Song), CheckUser

Oct 16 2020

dom_walden moved T258649: Watchlist Expiry: Don't run database UPDATEs to re-watch a page when the expiry is the same from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.

@dom_walden Ready for QA again! I thought I'd ping you since this was incorrectly in your column for almost 2 months... now it's intentionally there :)

Oct 16 2020, 1:23 PM · Community-Tech (Kanban-2020-21-Q2), MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, MW-1.35-notes, Expiring-Watchlist-Items

Oct 15 2020

dom_walden moved T263409: Display pending element and error message on the IPInfo popup, where appropriate from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

We now display the error message returned by the API, for example:

Oct 15 2020, 1:35 PM · Anti-Harassment (The Letter Song), IP Info

Oct 14 2020

dom_walden added a comment to T263577: Wikisource: Implement adding Symfony 5 to WSExport.

@Samwilson I am seeing more errors on the test site compared to production.

Oct 14 2020, 1:59 PM · Community-Tech (Kanban-2020-21-Q2), Wikisource Export, Wikisource
dom_walden moved T264780: Watchlist Expiry: Release to group 2 pilot wikis [TUES, OCT 13] from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.

I did some smoke testing of the core functionality on frwiki, fawiki, dewiki and cswiki, including watch star, Special:Watchlist, action=watch, Special:EditWatchlist. I did not see anything obviously wrong.

Oct 14 2020, 7:50 AM · Community-Tech (Kanban-2020-21-Q2), Expiring-Watchlist-Items

Oct 13 2020

dom_walden moved T260868: Normalize WatchedItem expiry field from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.
  • Expiry should be normalized and store as either MWTimestamp or CovertibleTimestamp (whatever makes more sense)
Oct 13 2020, 2:28 PM · Community-Tech (Kanban-2020-21-Q2), Expiring-Watchlist-Items
dom_walden added a comment to T263577: Wikisource: Implement adding Symfony 5 to WSExport.

@Samwilson I find a lot of Wikisource urls are of the form https://tools.wmflabs.org/wsexport/tool/book.php?page=.... I think this will be a 404 once this has gone to production. E.g. https://tools.wmflabs.org/wsexport-test/tool/book.php?lang=en&format=epub-3&page=Strange_Case_of_Dr_Jekyll_and_Mr_Hyde

Oct 13 2020, 12:59 PM · Community-Tech (Kanban-2020-21-Q2), Wikisource Export, Wikisource

Oct 12 2020

dom_walden moved T261639: System and Composite blocks don't always report correct anonymous value from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

Soft System and Composite blocks made up of all soft blocks now report:

"blockanononly": true
Oct 12 2020, 12:49 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Anti-Harassment (The Letter Song), MediaWiki-Blocks

Oct 8 2020

dom_walden moved T261755: CU 2.0: Log button inconsistently placed from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

I cannot notice any visual differences between the buttons on the front page and during an investigation.

Oct 8 2020, 1:41 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T261415: Watchlist Expiry: implement ability to see how many days left when in watchlist (mobile, advanced) from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.
  • If the user is in the mobile watchlist (advanced mode), and they click, on the clock icon, they should see "(XX days left)"
    • The text should be directly to the right of the clock icon
    • The text should be in light grey
    • The clock can remain in place
Oct 8 2020, 1:10 PM · Community-Tech (Kanban-2020-21-Q2), MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Readers-Web-Backlog (Tracking), Advanced Mobile Contributions, MinervaNeue, Expiring-Watchlist-Items

Oct 7 2020

dom_walden added a comment to T262780: Mobile block message drawer should show the full reason if the user starts scrolling.

@dom_walden could you look at this task description and tell us what from this not happening at the moment?

Oct 7 2020, 1:50 PM · Design, Readers-Web-Backlog (Tracking), MobileFrontend, MediaWiki-Blocks, Anti-Harassment
dom_walden created T264879: IPInfo: Consider permissions logic for getting IP information from log entries.
Oct 7 2020, 1:16 PM · Anti-Harassment (The Letter Song), IP Info

Oct 6 2020

dom_walden moved T261431: Watchlist Expiry: add support for status role & aria controls from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.

@ifried I guess the work in the ticket has been done, so moving on.

Oct 6 2020, 4:07 PM · MW-1.35-notes, Community-Tech (Kanban-2020-21-Q2), MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Expiring-Watchlist-Items
dom_walden updated subscribers of T248515: Watchlist Expiry: Add watchlist expiry support to Block API [medium].
Oct 6 2020, 4:04 PM · Community-Tech (Kanban-2020-21-Q2), MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-API, Expiring-Watchlist-Items
dom_walden moved T261430: Watchlist Expiry: tab to dropdown after tab on watchstar from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.
  • If we now have tab support in all skins except Minerva and mobile, I think that can be approached in a separate ticket. I have created a placeholder ticket for this work: T264485. This way, we can release the tab support accomplished in this ticket, which will help many users by providing tab support in many skins.
Oct 6 2020, 4:00 PM · Community-Tech (Kanban-2020-21-Q2), MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Accessibility, Expiring-Watchlist-Items
dom_walden created T264769: Watchlist Expiry: Tab sometimes "stuck" on watch star.
Oct 6 2020, 3:58 PM · Expiring-Watchlist-Items, Community-Tech
dom_walden moved T248515: Watchlist Expiry: Add watchlist expiry support to Block API [medium] from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.

When using API:Block I can now pass a watchlistexpiry parameter (alongside the existing watchuser parameter). This watches the target of the block's User and User_talk page for the time specified.

Oct 6 2020, 3:47 PM · Community-Tech (Kanban-2020-21-Q2), MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-API, Expiring-Watchlist-Items
dom_walden moved T189073: Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

I have compared validation of the Block API and Special:Block with the previous version. Some differences to note:

  • If the target is an IP, we ignore the suppress/hide parameter. Previously, we might return a validation error depending on other parameters.
  • In some cases the equality testing is stricter: Previously, setting a page or namespace restriction but not setting the block as partial would count the block as not equal to the previous block, allowing a user to be reblocked with exactly the same settings. This is no longer true.
Oct 6 2020, 9:25 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), MediaWiki-Special-pages, MediaWiki-Blocks, User-DannyS712, Anti-Harassment (The Letter Song), Platform Team Initiatives (Decoupling (CDP2)), Patch-For-Review, User-Urbanecm, Technical-Debt

Oct 5 2020

dom_walden added a comment to T260217: Special:Investigate: Allow table cells to be keyboard focusable [4HR].

Some issues that I am seeing:

  • When you tab to a Username cell, the ellipsis button is hidden and you can't tab to it (or its menu)
  • When something is pinned, no other cells show the ellipsis button when focussed

As Dom, noted there is inconsistency in how Safari and Firefox show and allow interactions on focussed elements. Should those issues be raised as part of CheckUser, OOUI or MediaWiki?

Oct 5 2020, 11:51 AM · MW-1.36-notes (1.36.0-wmf.6; 2020-08-25), Anti-Harassment (The Letter Song), CheckUser, Design
dom_walden added a comment to T261430: Watchlist Expiry: tab to dropdown after tab on watchstar.

@dom_walden, is the 'tab-stuck' behaviour happening on all skins?

Oct 5 2020, 11:46 AM · Community-Tech (Kanban-2020-21-Q2), MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Accessibility, Expiring-Watchlist-Items
dom_walden added a comment to T261430: Watchlist Expiry: tab to dropdown after tab on watchstar.
  • StructuredDiscussions issue: Can the "stuck" state be fixed by shift+tab, or no?
Oct 5 2020, 11:43 AM · Community-Tech (Kanban-2020-21-Q2), MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Accessibility, Expiring-Watchlist-Items

Oct 2 2020

dom_walden added a comment to T261430: Watchlist Expiry: tab to dropdown after tab on watchstar.

@ifried @MusikAnimal The basic use-case, being able to select an expiry period via tab, is achievable on all skins except Minerva and Mobile.

Oct 2 2020, 3:13 PM · Community-Tech (Kanban-2020-21-Q2), MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Accessibility, Expiring-Watchlist-Items