Page MenuHomePhabricator

dom_walden (Dom Walden)
Test Engineer for Community Tech and Anti-Harassment Teams

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2018, 4:33 PM (58 w, 5 d)
Availability
Available
LDAP User
Dom Walden
MediaWiki User
DWalden (WMF) [ Global Accounts ]

Recent Activity

Yesterday

dom_walden moved T236981: CheckUser 2.0: Create a new Special page in CheckUser for the redesigned version from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Special:Investigate is on thegoodplace.

Fri, Dec 6, 11:04 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Anti-Harassment (The Letter Song), CheckUser

Thu, Dec 5

dom_walden updated the task description for T232131: [BUG] WWT breaks or removes some article elements.
Thu, Dec 5, 10:09 AM · Who-Wrote-That, Community-Tech

Wed, Dec 4

dom_walden created T239842: Who Wrote That? link is slightly bigger than you think.
Wed, Dec 4, 5:00 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden created T239840: No translations on Firefox Add-Ons repository.
Wed, Dec 4, 4:47 PM · Who-Wrote-That, Community-Tech
dom_walden moved T236702: WWT: Decouple Bytes from Edit Summary [small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Bytes with Edit Summary:

Wed, Dec 4, 1:50 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T239273: WWT shows on source editing preview; does not work [small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

WWT link no longer appears on the preview page.

Wed, Dec 4, 1:40 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T232093: Investigate: Curation toolbar not advancing [4 hours] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

I have found a way of reproducing this issue, although it is not terribly realistic. It requires write access to the database. Therefore, I can only reproduce on my local system.

Wed, Dec 4, 11:51 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Community-Tech (Kanban-Q2-2019-20), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-DannyS712, English-Wikipedia-New-Pages-Patrol, Growth-Team, PageCuration
dom_walden moved T239749: Page Curation: Update Informational Text (custom message to previous reviewer) from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Placeholder when sending to reviewer: "Write a helpful note for $reviewer."

Wed, Dec 4, 9:16 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), PageCuration, Growth-Team, Community-Tech (Kanban-Q2-2019-20)

Tue, Dec 3

dom_walden moved T233729: Page Curation: Provide Customized Message to Previous Reviewer [small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Before an article has been reviewed, you can only send a message to the creator (obviously).

Tue, Dec 3, 6:14 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Community-Tech (Kanban-Q2-2019-20), PageCuration, Growth-Team
dom_walden moved T239682: CU 2.0: Namespace Service Name from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

I guess this is fine. I don't really know...

Tue, Dec 3, 2:52 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), CheckUser, Anti-Harassment (The Letter Song)
dom_walden moved T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Which hooks get fired for which actions (now, on testwiki):

Actionarticleinfomarktagsdelete
Opening "Page info" flyout
Reviewed or unreviewedx
Adding Tagxx
Speedy deletionx
Proposed deletionx
Article for deletionxx
Miscellany for deletionxx
WikiLove
"Add a message for the creator"
Tue, Dec 3, 2:28 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration
dom_walden created T239714: AfD form submits even if input is invalid.
Tue, Dec 3, 2:19 PM · Growth-Team, PageCuration, Community-Tech
dom_walden created T239712: AfD tagging behaving inconsistently.
Tue, Dec 3, 1:30 PM · Growth-Team, PageCuration, Community-Tech
dom_walden added a comment to T235130: WWT: Implement Opacity for Templates [medium].

@ifried @MusikAnimal I have noted some potential issues below. I am sure there are more, as there are probably always going to be exceptions to any rules. It depends how fussy we want to be.

  1. There are some articles in which content in tables is highlighted. For example, https://tr.wikipedia.org/wiki/Carter_Burwell?uselang=en, the bullet points are formatted using a table. They are made opaque, but they are highlighted if you hover over them. This may be true of other elements. There is probably a large number of unusually formatted wiki articles which we have not anticipated.
  2. Some elements which are not highlighted are not being made opaque, for example templates when they appear in paragraphs (e.g. translation templates, unit conversion templates). E.g. "Japonca" in the first sentence here https://tr.wikipedia.org/wiki/Himiko.
  3. The scope of the opacity is not always consistent. For example, in the references section of https://en.wikipedia.org/wiki/Minehunter, the numbers (and the caret) are not opaque. In other articles, (e.g. https://tr.wikipedia.org/wiki/Carter_Burwell?uselang=en) they are.

Not opaque:


Opaque:

  1. Something weird here (https://en.wikipedia.org/wiki/Xun_Huisheng):

Tue, Dec 3, 11:11 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Mon, Dec 2

dom_walden moved T239369: Create a changelog for WWT releases [small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

This looks fine to me. I am happy to move this along.

Mon, Dec 2, 6:31 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T239185: Fix locales directory names for languages with variant subtags from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

In the Chrome Store, we can now see three extra languages: "English", "português (Brasil)" and "português (Portugal)".

Mon, Dec 2, 5:43 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden created T239634: Some of the translations not recognised.
Mon, Dec 2, 5:40 PM · I18n, Who-Wrote-That, Community-Tech
dom_walden added a comment to T237756: Reduce length of extension name and description for Chrome.

@Samwilson Small nitpick. We seem to be warning about descriptions that are 132 characters or greater, and truncating up to the 131st character. Should it not be strictly greater than 132 characters?

Mon, Dec 2, 4:29 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T237757: Use correct Firefox extension ID for beta version from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

After installing it in the Firefox Add-Ons repository, the extension ID is reported as {7c53a467-2542-497a-86fb-59c2904a56d1}. @Samwilson are the curly braces intentional?

Mon, Dec 2, 4:09 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden added a comment to T235015: WWT: Support for Latest Version of a Page after VE Edits.

@Mooeypoo I find that, after saving in VE, WWT does not activate properly when I click the "Who Wrote That?" link.

Mon, Dec 2, 8:17 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Thu, Nov 28

dom_walden moved T233969: Update Temporary Password Email with Preference Info [x-small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

@dom_walden, updated to this

Thu, Nov 28, 8:01 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Community-Tech (Kanban-Q2-2019-20), Password-Reset-Update

Wed, Nov 27

dom_walden moved T207485: Enable page curation tools to be loaded on any page (optionally) from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Much of the testing has been done as part of related bugs/tasks. There is not much else left for me to do.

Wed, Nov 27, 5:46 PM · Community-Tech (Kanban-Q2-2019-20), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), PageCuration, Growth-Team
dom_walden added a comment to T237296: CheckUser 2.0: Create service and methods for new CU extension.

@Niharika At the moment, a user will be reported as blocked even if the block is hidden (and the check user does not have rights to see hidden blocks).

Wed, Nov 27, 2:35 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dom_walden added a comment to T237296: CheckUser 2.0: Create service and methods for new CU extension.

@dmaza Submitting the Special:Investigate form on a wiki without CentralAuth, I see in the logs:

[error] [f7d4d69c1c92ecf5b9e28a69] /core/index.php/Special:Investigate   ErrorException from line 83 of /var/www/html/core/extensions/CheckUser/src/PreliminaryCheckService.php: PHP Notice: Undefined variable: globalUser
#0 /var/www/html/core/extensions/CheckUser/src/PreliminaryCheckService.php(83): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /var/www/html/core/extensions/CheckUser/src/PreliminaryCheckService.php(61): MediaWiki\CheckUser\PreliminaryCheckService->getGlobalUser(User)
#2 /var/www/html/core/extensions/CheckUser/src/PreliminaryCheckService.php(44): MediaWiki\CheckUser\PreliminaryCheckService->getAttachedWikis(User)
#3 /var/www/html/core/extensions/CheckUser/includes/specials/pagers/PreliminaryCheckPager.php(59): MediaWiki\CheckUser\PreliminaryCheckService->getPreliminaryData(array)
#4 /var/www/html/core/includes/pager/IndexPager.php(616): PreliminaryCheckPager->doQuery()
#5 /var/www/html/core/extensions/CheckUser/includes/specials/SpecialInvestigate.php(120): IndexPager->getNumRows()
#6 /var/www/html/core/includes/htmlform/HTMLForm.php(694): SpecialInvestigate->onSubmit(array, OOUIHTMLForm)
#7 /var/www/html/core/includes/htmlform/HTMLForm.php(586): HTMLForm->trySubmit()
#8 /var/www/html/core/includes/htmlform/HTMLForm.php(601): HTMLForm->tryAuthorizedSubmit()
#9 /var/www/html/core/extensions/CheckUser/includes/specials/SpecialInvestigate.php(41): HTMLForm->show()
#10 /var/www/html/core/includes/specialpage/SpecialPage.php(575): SpecialInvestigate->execute(NULL)
#11 /var/www/html/core/includes/specialpage/SpecialPageFactory.php(607): SpecialPage->run(NULL)
#12 /var/www/html/core/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#13 /var/www/html/core/includes/MediaWiki.php(967): MediaWiki->performRequest()
#14 /var/www/html/core/includes/MediaWiki.php(530): MediaWiki->main()
#15 /var/www/html/core/index.php(46): MediaWiki->run()
#16 {main}
Wed, Nov 27, 2:30 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T237034: CheckUser 2.0: Input form from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Acceptance criteria

  • Form header: Search for usernames, IP addresses or IP ranges
    • All three types will be added in a single text field. We should auto-complete the usernames and still allow IPs/ranges that become "capsules" once they are valid by regex. We did this with Interaction Timeline and should be able to do it here as well.
Wed, Nov 27, 11:28 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T238277: Allow UsersMultiselectWidget to show valid IP addresses and ranges in the autocomplete menu from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

After this, the widget should:

  • Show no menu if the current input is not a valid IP address/range and doesn't complete to a username (as before)
Wed, Nov 27, 11:11 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T238240: Allow HTMLUsersMultiselectField to set max limit on number of selected items from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

After applying patch in https://gerrit.wikimedia.org/r/552269, I am now limited to entering 2 users/IPs in the Special:Investigate form.

Wed, Nov 27, 10:25 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Anti-Harassment (The Letter Song), CheckUser

Tue, Nov 26

dom_walden created T239273: WWT shows on source editing preview; does not work [small].
Tue, Nov 26, 7:41 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T232802: Release beta extension on Firefox Add-ons from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Acceptance criteria from T236226:

  • The extension should be called "WhoWroteThat for Wikipedia (BETA)"
Tue, Nov 26, 2:00 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T236226: WWT: Release Beta Extension for Chrome [small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Acceptance Criteria:

  • Release the beta extension for Chrome Web Store
  • The extension should be called "WhoWroteThat for Wikipedia (BETA)"
Tue, Nov 26, 12:30 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden created T239223: Maintain consistency between Firefox and Chrome extension repositories.
Tue, Nov 26, 11:42 AM · Who-Wrote-That, Community-Tech

Mon, Nov 25

dom_walden added a comment to T236226: WWT: Release Beta Extension for Chrome [small].
  1. Looking at the entry on the Chrome Store in English, the description includes some raw HTML: If you find any issues, please report them on <a href="https://phabricator.wikimedia.org/tag/who-wrote-that/">our Phabricator board</a>.
Mon, Nov 25, 5:54 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden added a comment to T232802: Release beta extension on Firefox Add-ons.

@Samwilson I am seeing some differences between how this appears in the Firefox Add-On repo and in the Chrome Store. For example, the name is slightly different ("Who Wrote That? (BETA)" vs. "WhoWroteThat for Wikipedia (BETA)"). Is this due to the Firefox release being slightly older?

Mon, Nov 25, 5:49 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T235775: WWT: Fix Percentage Attribution Scores for IP Contributors [small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Following the reproduction steps in the description, I can no longer reproduce the bug.

Mon, Nov 25, 5:32 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T234483: WWT: Closing the information bar while it's pending results in a crash from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

A followup would need to make the animation conditional so it isn't as jumpy in the cases where it shouldn't appear. I'm leaving that for the followup ticket, though: T234463: WWT: Only Show Loading Animation in Revision Details Pop-up If Data Not Yet Loaded

Mon, Nov 25, 2:02 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden created T239112: WWT: Fix Revision Details pop-up for image thumbnails [8 hours].
Mon, Nov 25, 1:59 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Since it's such a narrow use case, I think it's safe to close it. Any objections?

Mon, Nov 25, 9:48 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management

Thu, Nov 14

dom_walden closed T205130: QA the no-JS experience of Partial Blocks by filing all defects in Phab, a subtask of T214197: 👩‍👧‍👦 Parent task: MultiSelectWidget & Special:Block UI issues/enhancements/changes, as Resolved.
Thu, Nov 14, 4:54 PM · Anti-Harassment
dom_walden closed T205130: QA the no-JS experience of Partial Blocks by filing all defects in Phab as Resolved.

I believe all known defects with Partial blocks have been filed already. @dom_walden would you like this to be kept open?

Thu, Nov 14, 4:54 PM · Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden added a comment to T238240: Allow HTMLUsersMultiselectField to set max limit on number of selected items.

I don't see anything currently that uses HTMLUsersMultiselectField at the moment.

I believe this is used on https://test.wikipedia.org/wiki/Special:Preferences in the "Prohibit these users from emailing me" field as well as on https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-echo in the "Do not display notifications from these users" field. I believe these fields are enabled through config (I can figure out the configs if you would like).

Thu, Nov 14, 4:51 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T238240: Allow HTMLUsersMultiselectField to set max limit on number of selected items from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

I don't see anything currently that uses HTMLUsersMultiselectField at the moment. I don't think there is anything for me to test until other CheckUser work is complete.

Thu, Nov 14, 4:17 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Anti-Harassment (The Letter Song), CheckUser
dom_walden created T238328: Tag not included in edit summary when marking an article for deletion/miscellany for discussion.
Thu, Nov 14, 1:54 PM · Regression, PageCuration, Community-Tech, Growth-Team
dom_walden updated the task description for T238310: When sitewide blocked, cannot undelete/restore own User_talk, even if not blocked from own User_talk.
Thu, Nov 14, 10:23 AM · MediaWiki-User-management
dom_walden created T238310: When sitewide blocked, cannot undelete/restore own User_talk, even if not blocked from own User_talk.
Thu, Nov 14, 10:23 AM · MediaWiki-User-management
dom_walden moved T227412: Partial blocks leads to wrong error messages from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.
  • A user without the necessary permissions sees a permission error, whether blocked or not
Thu, Nov 14, 10:13 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Anti-Harassment (The Letter Song), Beta-Cluster-reproducible, MediaWiki-User-management, User-DannyS712

Wed, Nov 13

dom_walden added a comment to T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority].

@dom_walden we reviewed your concern during standup and since it's not very likely to happen (it has not been reported by any user) @ifried decided that it is safe to leave it as is for now. This possible case has been there since the beginning. Thank you!

Wed, Nov 13, 7:56 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration
dom_walden added a comment to T236702: WWT: Decouple Bytes from Edit Summary [small].

Is this something that we get from a separate API call or do we have it as soon as the popup loads?

Wed, Nov 13, 4:21 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden added a comment to T231508: WWT: Handle behavior with VisualEditor.

The second behavior should be fixed when https://github.com/wikimedia/WhoWroteThat/pull/80 is merged

Wed, Nov 13, 4:15 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T236814: Improve blocker information on mobile block error message drawer from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

The mobile error message drawer should be updated to handle the following situations:

  1. The blocker is a local user. Link to their user page.
Wed, Nov 13, 1:43 PM · Anti-Harassment (The Letter Song), Readers-Web-Backlog (Tracking), MobileFrontend
dom_walden moved T225939: System and composite block messages on mobile contain confusing information from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

On Beta, testing username, IP, autoblocks and cookie blocks. The "Details" link appears and links to the correct block ID in Special:BlockList.

Wed, Nov 13, 11:47 AM · Anti-Harassment (The Letter Song)

Nov 4 2019

dom_walden moved T227005: Don't require that the blocker be a User for a SystemBlock from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Tested:

  • Database blocks
  • Composite blocks
  • $wgProxyList System Blocks
  • $wgDnsBlacklistUrls System Blocks
Nov 4 2019, 7:51 PM · Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden moved T227892: [BUG] InvalidArgumentException "Blocker must be a local user or a name that cannot be a local user" from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

I can no longer reproduce this following reproduction steps, on my local VM MediaWiki 1.35.0-alpha (68d87db) 04:22, 1 November 2019.

Nov 4 2019, 7:30 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Anti-Harassment (The Letter Song), MediaWiki-User-management

Nov 1 2019

dom_walden moved T236501: Autoblocks expands templates before storing in database from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

On https://en.wikipedia.beta.wmflabs.org I created a number of autoblocks with different block reasons, including templates, other forms of wikitext, HTML tags and that had no block reason.

Nov 1 2019, 5:07 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden added a comment to T231357: Page Curation should create a new AfD discussion page if one already exists.

@dom_walden, looking at the above nomination:

Templates look to be working to me.

Nov 1 2019, 2:45 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Community-Tech (Kanban-Q2-2019-20), PageCuration, Growth-Team
dom_walden added a comment to T232512: Password Reset: Inform Users of Preference on Special:PasswordReset [small].

@MaxSem @dom_walden I just tested this on https://en.wikipedia.beta.wmflabs.org/. It appears that the message is displayed if someone just enters a username (correct behavior). However, if someone just enters the email address, the message is not displayed (incorrect behavior). Rather, they are directed to the next screen (see below), which says, "If this email address is associated with your account, then a password reset email will be sent."

Nov 1 2019, 8:51 AM · Community-Tech (Kanban-Q2-2019-20), Password-Reset-Update

Oct 31 2019

dom_walden added a comment to T225939: System and composite block messages on mobile contain confusing information.

@Tchanders I am finding on beta and test that the "Details" link in mobile block messages has an empty href.

Oct 31 2019, 11:33 AM · Anti-Harassment (The Letter Song)
dom_walden created T236996: When sitewide blocked, cannot edit tags on own User_talk, even if allowed to edit own User_talk.
Oct 31 2019, 11:01 AM · Anti-Harassment, Patch-For-Review, MediaWiki-Change-tagging, MediaWiki-User-management
dom_walden updated subscribers of T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does.

Special:CentralAuth now looks like:

Oct 31 2019, 10:02 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management

Oct 30 2019

dom_walden added a comment to T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority].

@HMonroy When there is no "Articles for deletion" log for today's date (e.g. Wikipedia:Articles for deletion/Log/2019 October 30) and I attempt the AfD action, I see the Log page for today has not been created yet! popup. If I click "OK", the AfD action continues. It adds the {{afd}} template to the article and posts on the creator's user_talk page (although it does not create the deletion page Wikipedia:Articles for deletion/$article_name).

Oct 30 2019, 1:37 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration
dom_walden added a comment to T236501: Autoblocks expands templates before storing in database.

@Tchanders Testing on beta, for autoblocks the comment_text still appears to be stored in the DB in the expanded form.

Oct 30 2019, 9:41 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Anti-Harassment (The Letter Song), MediaWiki-User-management

Oct 29 2019

dom_walden created T236831: WhoColor cannot parse invalid wikitext.
Oct 29 2019, 6:56 PM · Who-Wrote-That, Community-Tech
dom_walden updated the task description for T236830: Links which breaks across a line places the revision popup in the wrong place.
Oct 29 2019, 6:44 PM · Who-Wrote-That, Community-Tech
dom_walden created T236830: Links which breaks across a line places the revision popup in the wrong place.
Oct 29 2019, 6:39 PM · Who-Wrote-That, Community-Tech
dom_walden added a comment to T234483: WWT: Closing the information bar while it's pending results in a crash.

@Mooeypoo The revision popup isn't working for image thumbnails for me anymore. Did work in commit a50f43374005791b7683404ea58413e81ec4279e.

Oct 29 2019, 6:14 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden added a comment to T234483: WWT: Closing the information bar while it's pending results in a crash.

@Mooeypoo After this change (which I think is this) the revision summary animation does not appear for tokens you have already clicked. Instead, you see the revision summary blinking in and out.

Oct 29 2019, 4:21 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T232510: Add namespace filter to the interaction-timeline API from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

I used the namespace parameter to filter the results returned by the API.

Oct 29 2019, 1:41 PM · Anti-Harassment (The Letter Song), InteractionTimeline
dom_walden moved T188435: Bring consistency to visual design of Interaction Timeline from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Comparing my local version of InteractionTimeline running in docker with the production version, I am seeing very few differences except the content being narrower.

Oct 29 2019, 1:28 PM · Anti-Harassment (The Letter Song), Readers-Web-Backlog (Design), InteractionTimeline, Design
dom_walden moved T230616: Upgrade node.js to v10 from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

I have been able to run this locally with docker. I guess that means it is ok.

Oct 29 2019, 1:24 PM · InteractionTimeline, Anti-Harassment (The Letter Song)
dom_walden moved T234401: Password Reset: Update Preference to Require both username & email address [medium] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

For 3 users who all have the same email.

Oct 29 2019, 12:53 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Community-Tech (Kanban-Q2-2019-20), Password-Reset-Update
dom_walden added a comment to T233969: Update Temporary Password Email with Preference Info [x-small].

The password reset email now looks like (on Gmail's web client):

Oct 29 2019, 12:03 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Community-Tech (Kanban-Q2-2019-20), Password-Reset-Update

Oct 28 2019

dom_walden added a comment to T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority].

@HMonroy Just checking, because I didn't explain it very clearly in T230455#5541869, have you also investigated the weird behaviour where the articleinfo hook gets fired when you review/unreview, but only after first opening the "Page info" flyout?

Oct 28 2019, 5:19 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration
dom_walden moved T228950: Replace UserIsHidden with GetUserBlock in CentralAuth from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

A user who is "Account is hidden from the global users list" does not appear in Special:GlobalUsers, but the user is not blocked from doing anything.

Oct 28 2019, 4:30 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), MediaWiki-extensions-CentralAuth
dom_walden added a comment to T189362: ipblock-exempt does not allow account creation when blocked.

It should be noted that DatabaseBlock::newFromTarget (used here) chooses the most specific IP block. Blocking an IP range from creating accounts might not have the desired affect if there are more specific IP blocks which allow account creation. This is only in the case of wanting to block admins from creating accounts, which we may not want to do in the first place (as mentioned above).

Oct 28 2019, 3:42 PM · Patch-For-Review, MediaWiki-User-login-and-signup, MediaWiki-Authentication-and-authorization, MediaWiki-User-management
dom_walden moved T227110: Provide more informative block error message for Special:CreateAccount from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Comparing https://en.wikipedia.beta.wmflabs.org to https://test.wikipedia.org.

Oct 28 2019, 2:55 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Anti-Harassment (The Letter Song), MediaWiki-User-management, MediaWiki-User-login-and-signup

Oct 25 2019

dom_walden updated the task description for T236501: Autoblocks expands templates before storing in database.
Oct 25 2019, 5:26 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden updated the task description for T236501: Autoblocks expands templates before storing in database.
Oct 25 2019, 5:25 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden created T236501: Autoblocks expands templates before storing in database.
Oct 25 2019, 4:37 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden moved T231115: Implement Loading State Support for Revision Details Pop-up in WWT [small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

A loading animation now appears in the revision details popup, regardless of whether there is an edit summary associated with the revision.

Oct 25 2019, 2:45 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T226746: Add Hover Support to Who Wrote That from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

We now show the contributor name or IP in the infobar.

Oct 25 2019, 2:40 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T226990: Block messages are inconsistent if a user is blocked from email from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Block error message for Special:EmailUser now looks ok for composite blocks, including in non-default language (French).

Oct 25 2019, 1:52 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Anti-Harassment (The Letter Song), MediaWiki-Email
dom_walden moved T234874: Enable WWT to be turned on and off remotely from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

For testing, you can now use, in the console:

wwtDebug.launch();
wwtDebug.dismiss();
Oct 25 2019, 9:39 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden added a comment to T231508: WWT: Handle behavior with VisualEditor.

@MusikAnimal If you go directly to the VisualEditor (e.g. https://tr.wikipedia.org/w/index.php?title=%C4%B0Pad_Mini_4&veaction=edit), the "Who Wrote That?" link appears briefly and the guided tour popup appears and remains (unless you have previously dismissed it).
In the brief period in which the "Who Wrote That?" link appears, if you are quick enough you can click it and have the infobar appear. Leaves it in a weird state where model.enabled == false but model.active == true. This does not appear to interfere with VisualEditor.
I don't see these problems when I go first to the article and then click "Edit".

Oct 25 2019, 9:31 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden updated subscribers of T231508: WWT: Handle behavior with VisualEditor.

@MusikAnimal If you go directly to the VisualEditor (e.g. https://tr.wikipedia.org/w/index.php?title=%C4%B0Pad_Mini_4&veaction=edit), the "Who Wrote That?" link appears briefly and the guided tour popup appears and remains (unless you have previously dismissed it).

Oct 25 2019, 9:30 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Oct 23 2019

dom_walden added a comment to T231115: Implement Loading State Support for Revision Details Pop-up in WWT [small].

@MusikAnimal @ifried If the edit has no edit summary, do we still want to show the bytes difference? We did before

Oct 23 2019, 5:54 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T234406: Pass the relevant and necessary context information to UserBlockedError from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

As part of T227007#5598774 I tested how block error messages look in most of the places in the code that we changed, including in different languages. Missing, I think, SpecialRevisionDelete and SpecialUserrights.

Oct 23 2019, 2:05 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MediaWiki-User-management, Anti-Harassment (The Letter Song)
dom_walden added a comment to T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.

Note that I was unable to get the block action working for the AbuseFilter extension.

Happy to help! What exactly didn't work?

Oct 23 2019, 1:51 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden added a comment to T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.

It should be noted that in block messages now the name of the target of the block and the blocker are surrounded by \u202a and \u202c, which I believe are for bidirectional support (e.g. see https://en.wikipedia.org/wiki/Unicode_control_characters#Bidirectional_text_control and https://en.wikipedia.org/wiki/Bi-directional_text#Table_of_possible_BiDi_character_types).

Oct 23 2019, 1:51 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden added a comment to T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.
Oct 23 2019, 1:26 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden moved T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

We have made a change to how we get and set block reasons. Therefore, I tried to test as many places where blocks get created or displayed, comparing beta with test (before the train, that is) or on my local environment (where I don't have permission on beta).

Oct 23 2019, 1:26 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), MediaWiki-User-management

Oct 22 2019

dom_walden added a comment to T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.

@Tchanders On beta, with an autoblock like so:

Oct 22 2019, 11:42 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), MediaWiki-User-management

Oct 21 2019

Prtksxna awarded T232490: Highlighting cuts off font kerning a Mountain of Wealth token.
Oct 21 2019, 11:45 AM · Community-Tech, Who-Wrote-That
dom_walden added a comment to T231357: Page Curation should create a new AfD discussion page if one already exists.

Production templates are already prepared.

Oct 21 2019, 10:45 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Community-Tech (Kanban-Q2-2019-20), PageCuration, Growth-Team
dom_walden added a comment to T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.

@Tchanders On beta (1.35.0-alpha (c35f385) 06:57, 21 October 2019), attempting to create a block (happens on submit):

Oct 21 2019, 9:41 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden added a comment to T235906: Cannot access replica databases.

@dom_walden I verified that your account is now working again, please let us know if you're still unable to connect to the replica databases.

Oct 21 2019, 8:04 AM · Toolforge

Oct 18 2019

dom_walden created T235906: Cannot access replica databases.
Oct 18 2019, 5:22 PM · Toolforge
dom_walden moved T234276: Install CheckUser on thegoodplace wiki from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.
Oct 18 2019, 3:55 PM · Anti-Harassment (The Letter Song), CheckUser
dom_walden moved T231577: Deploy Special:Mute features from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Retested on https://commons.wikimedia.beta.wmflabs.org and https://wikidata.beta.wmflabs.org.

Oct 18 2019, 12:40 PM · Anti-Harassment (The Letter Song), Epic
dom_walden moved T232490: Highlighting cuts off font kerning from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

The problem in the description no longer occurs.

Oct 18 2019, 10:51 AM · Community-Tech, Who-Wrote-That
dom_walden moved T233164: Correct the display of user attribution percentages in the popup from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Acceptance Criteria:

  • Always display an integer value for percentage of page written by author (within the revision details pop-up)
Oct 18 2019, 10:32 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden added a comment to T234483: WWT: Closing the information bar while it's pending results in a crash.
  1. The user clicks on 'Who Wrote That?' link to load it again
Oct 18 2019, 9:13 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That