User Details
- User Since
- Oct 22 2018, 4:33 PM (267 w, 5 d)
- Availability
- Available
- LDAP User
- Dom Walden
- MediaWiki User
- DWalden (WMF) [ Global Accounts ]
Fri, Dec 1
See below output of successive runs of the WikimediaMaintenance/createExtensionTables.php script:
$ docker-compose exec mediawiki php extensions/WikimediaMaintenance/createExtensionTables.php mediamoderation
I cannot reproduce the exception either on beta (MariaDB) or locally (SQLite).
Wed, Nov 29
@tstarling Drawing attention to T352310. Is there a migration stage we have to do on beta?
Tue, Nov 28
Mon, Nov 27
I have raised T352028, but I wonder if we should just move the current bug back into In Development?
Thu, Nov 23
This also happens after you close and restore a tab (ctrl+shift+t). I am still investigating.
Wed, Nov 22
@STran @Tchanders We don't appear to be updating the tunnels if their type changes. This could affect what is returned by the /vpn endpoints. Is this OK?
I can no longer reproduce the error from the description.
Tue, Nov 21
Mon, Nov 20
I notice we are doing arrayCompare for client.countries, which seems wrong as they are integers. https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/blob/main/output-sql.js?ref_type=heads#L120
Fri, Nov 17
I tested this along with T349826.
Some examples of multiple block messages on beta and locally.
Thu, Nov 16
Tue, Nov 14
I think I have done with this for now.
Mon, Nov 13
@MusikAnimal I did a bit of testing of this on Friday and found a few potential bugs. In order of importance (in my opinion):
- There are circumstances where clicking on "Review link" will take you to the blocked url instead of opening the "Insert link" dialog.
- This happens when you move or delete the link you just inserted before clicking "Review link".
- e.g. type a link, see the popup, before the link type "[", click "Review link"
- Having the blocked url as the href of the "Review link" seems vulnerable to me. A user might open it in a new tab. I also don't know if all browsers/devices will behave the same way when you click on it.
- This happens when you move or delete the link you just inserted before clicking "Review link".
- If the blocked URL is not the first thing on the line, after clicking "Review link", the URL automatically entered in the "Insert link" dialog is incorrect.
- e.g. type foobar <blocked URL>, click "Review link", in the "Insert link" dialog the URL will be "foobar <blocked URL>"
- The popup only appears if the URL starts with http:// or https://, even if you add it after.
- You can make a legit link with just // (e.g. [//<blocked URL>]). If you try to publish this, AbuseFilter will stop you (at least on beta). Perhaps we should maintain functional parity.
- If there is already a popup and you trigger another popup, it flashes in the top left.
- If copy and pasting, only warns if the blocked URL is just before point.
- e.g. copy and paste foobar <blocked URL> foobaz, you will not see a popup
- If the text of the link is a blocked domain but the actual link is not, still see popup.
- e.g. [https://duckduckgo.com <blocked URL>]
- Arguably a popup here is not so bad as the edit does not seem in good faith.
- Does not always work well with find and replace.
- Not triggered if you do "Replace all".
- If you do "Find next" and "Replace" one by one, the "Review link" does not insert the link in the correct place.
Nov 8 2023
First time, I have to run node -e "require('./init-db.js')(true);". Any other combination of parameters returns the below exception. I guess this makes sense.
/srv/service/node_modules/mariadb/lib/misc/errors.js:64 return new SqlError(msg, sql, fatal, info, sqlState, errno, additionalStack, addHeader); ^
Nov 1 2023
So far, the only bug I have found is T348745. More testing will be done after the fix for that.
Probably no testing needed here. Will move to Done.
More testing of this will be done as part of T348992. I will move this to Done.
Oct 31 2023
Oct 30 2023
Oct 26 2023
Oct 25 2023
I can activate Phonos buttons with errors with enter and space.
Oct 18 2023
I have found cases where this bug happens for /vpns as well. Importing the Spur feed from 20231017 and comparing /vpns and /vpn/NORD_VPN the former has a smaller number of IPs compared to the latter.
Oct 17 2023
@HMonroy @TheresNoTime Did we want a tooltip or a help icon (i)? The task description and the user's comment suggests we want a tooltip.
Whitespace is trimmed when included in either the label or ipa parameter.
Oct 16 2023
Oct 13 2023
Oct 12 2023
Oct 10 2023
I think I found a way to reproduce the bug by setting this database trigger:
CREATE TRIGGER stop_insert BEFORE INSERT ON recentchanges FOR EACH ROW DELETE FROM logging WHERE log_id = new.rc_logid;
Every time a row is inserted into the recentchanges table, the associated row in the logging table is deleted. It might be a bit unrealistic, but it seems to reliably reproduce the bug in the parent commit.
Oct 3 2023
I tested all the different combinations of visibility for a log entry.
The Checks done by this user link does not appear for temporary users and IPs. It does for regular users.
Oct 2 2023
Current latest draft. I need help filling out the "Quickstart" section.
Another potential risk of this change is that every time an editor visits the Source Editor for a page Edit Recovery will save the current content (even if they don't make an edit).
@Samwilson I cannot get it to clear the indexeddb data when I click Cancel on the edit page, like it did before. Is that because it is triggering one of the events?
Special:CheckUser now correctly parses a variety of log parameters, including those that use the legacy log params such as global block and interwiki. I did not see any errors or warnings on the page or in the logs.
Sep 29 2023
When attempting to login as a temporary user, I don't see any emails or echo notifications, nothing new in echo_event database, and in the logs I see:
[LoginNotify] Skipping recording failure for user *Unregistered 232 - can't authenticate
I see I can download today and yesterday's feed. The files are different sizes, so I assume they are different files. I cannot verify that the files are for the correct date.
Sep 28 2023
Differences that I have observed so far between SCHEMA_COMPAT_READ_OLD and SCHEMA_COMPAT_READ_NEW:
- Usernames, temporary usernames and IPs are links, have mw-userlink class and are wrapped in <bdi>. Before they were plain text.
- Temp user links to special:contribs and has mw-tempuserlink class, so they are properly styled.
- Many entries now have two log links (log | logs), for the Special:Log&logid=<log id> and Special:Log&page=<page or user> respectively.
- Entries for group membership changes use the public(?) name for user groups, not their internal name. For example, it says administrator rather than sysop.
- Entries for blocks have the expiry in a <span class="blockExpiry" title="infinity">indefinite</span>, which means you get a tooltip.
- It recognises where a page is a redirect and adds redirect=no to the page's URL.
- Entries of page suppressions show in full. Before they showed as (username removed) (log details removed).
I compared the HTML output of "Get users" with SCHEMA_COMPAT_READ_OLD and SCHEMA_COMPAT_READ_NEW for all the IP addresses I had on my local wiki. There were no differences.
Sep 26 2023
Sep 22 2023
The Inline toggle now has aria-labelledby, which refers to the <label>Inline</label> element.