Page MenuHomePhabricator

dom_walden (Dom Walden)
Test Engineer for Community Tech and Anti-Harassment Tools

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2018, 4:33 PM (138 w, 4 d)
Availability
Available
LDAP User
Dom Walden
MediaWiki User
DWalden (WMF) [ Global Accounts ]

Recent Activity

Yesterday

dom_walden moved T281767: Wikisource OCR: Error handling for OCR button experience from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-2) board.
  • When the user encounters the warning message for already having text in field of page body text and started editing, and if they want to run OCR:
    • There should be a pop-up that tells them in 2 lines:
      • "Replace with new text transcription?" (bigger text)
      • "You will lose the current page body text and it will be replaced with the newly transcribed text."
Fri, Jun 18, 1:30 PM Β· MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Community-Tech (CommTech-Sprint-2), Design, Wikimedia OCR
dom_walden added a comment to T284971: Loading-state label is missing.

Label is appearing now on beta:

Fri, Jun 18, 12:13 PM Β· MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Community-Tech (CommTech-Sprint-2), ProofreadPage, Wikimedia OCR
dom_walden moved T282760: Add language-mapping data from QA πŸ› to Done 🏁 on the Community-Tech (CommTech-Sprint-2) board.
Fri, Jun 18, 7:48 AM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR

Mon, Jun 14

dom_walden moved T284827: Wikimedia OCR: 500 error with lang "equ" from QA πŸ› to Done 🏁 on the Community-Tech (CommTech-Sprint-2) board.

The language selector no longer lists equ.

Mon, Jun 14, 12:24 PM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden moved T278937: Update IPInfo panel to use CollapsibleFieldsetLayout from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

Testing for this was done as part of T278935.

Mon, Jun 14, 12:11 PM Β· MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Anti-Harassment (The Letter Song), IP Info
dom_walden moved T278935: Make CollapsibleFieldsetLayout more reusable from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

How Special:Contributions looks now:

Mon, Jun 14, 12:10 PM Β· Patch-For-Review, Anti-Harassment (The Letter Song), IP Info

Fri, Jun 11

dom_walden moved T281866: Wikimedia OCR: "-" and "_" being stripped from language codes from QA πŸ› to Done 🏁 on the Community-Tech (CommTech-Sprint-2) board.
Fri, Jun 11, 3:29 PM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden created T284827: Wikimedia OCR: 500 error with lang "equ".
Fri, Jun 11, 3:26 PM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR

Thu, Jun 10

dom_walden added a comment to T281866: Wikimedia OCR: "-" and "_" being stripped from language codes.

Should be fixed by https://github.com/wikimedia/wikimedia-ocr/commit/5013405a821b0875de15700ddab812eb273c13be, which I mistakenly just force-merged (sorry!)

@Daimona Does that regex need to include numbers as well now? We have just included the language ru-petr1708.

I'd say yes! I'm not sure if tesseract and google are following any standard with the language codes, so in doubt, it's probably a good idea to add whatever characters are currently used.

Thu, Jun 10, 9:55 AM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden added a comment to T283898: Turning on MVP on certain Wikis.

I have briefly tested this on all four wikis. I could see no major problems. We will await feedback.

Thu, Jun 10, 9:39 AM Β· Bengali-Sites, Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden moved T283898: Turning on MVP on certain Wikis from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-2) board.
Thu, Jun 10, 9:39 AM Β· Bengali-Sites, Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden moved T284654: Wikimedia OCR: Weird tooltip for language selector from QA πŸ› to Done 🏁 on the Community-Tech (CommTech-Sprint-2) board.

This looks good to me. The tooltip and the title attribute no longer have extraneous white-space.

Thu, Jun 10, 9:18 AM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden moved T282633: Investigate recent increase in downtime (May 2021) [8 HR] from QA πŸ› to Done 🏁 on the Community-Tech (CommTech-Sprint-2) board.

No code change here, so I will move straight to Done.

Thu, Jun 10, 9:06 AM Β· Community-Tech (CommTech-Sprint-2), Spike, IA Upload
dom_walden moved T284571: Enable phan-taint-check-plugin on wikimedia-ocr from QA πŸ› to Done 🏁 on the Community-Tech (CommTech-Sprint-2) board.

As this is a developer-facing change, I will move it straight into Done.

Thu, Jun 10, 9:03 AM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden added a comment to T282760: Add language-mapping data.

Thanks for looking into those for me @MusikAnimal.

Thu, Jun 10, 8:53 AM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden added a comment to T281866: Wikimedia OCR: "-" and "_" being stripped from language codes.

Should be fixed by https://github.com/wikimedia/wikimedia-ocr/commit/5013405a821b0875de15700ddab812eb273c13be, which I mistakenly just force-merged (sorry!)

Thu, Jun 10, 8:48 AM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR

Wed, Jun 9

dom_walden moved T282073: Add API endpoint to retrieve supported languages from QA πŸ› to Done 🏁 on the Community-Tech (CommTech-Sprint-2) board.

Testing for this was done as part of T282760.

Wed, Jun 9, 2:34 PM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden moved T282760: Add language-mapping data from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-2) board.

I compared our list from https://ocr-test.wmcloud.org/api/available_langs?engine=tesseract to what Tesseract claims to support in https://tesseract-ocr.github.io/tessdoc/Data-Files-in-different-versions.html.

Wed, Jun 9, 2:32 PM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden created T284654: Wikimedia OCR: Weird tooltip for language selector.
Wed, Jun 9, 2:29 PM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden created P16335 SecurePoll with Single Transferable Vote.
Wed, Jun 9, 9:00 AM
dom_walden added a comment to T284624: Testing of new OCR widget on Bengali Wikisource.
  1. No drop down menu to select OCR engine
  2. Jargon output in Latin script - Test page - https://bn.wikisource.org/s/6bee
Wed, Jun 9, 8:48 AM Β· Wikimedia OCR, Bengali-Sites, Community-Tech

Tue, Jun 8

dom_walden added a comment to T263617: Cannot login to beta cluster: "There seems to be a problem with your login session...".

@dom_walden I temporarily "fixed" this by manually creating /etc/cassandra/service-enabled, listed as ConditionPathExists in systemd file for cassandra. Then, starting cassandra manually worked as intended. Not sure a) is this file supposed to exist at beta b) if it is, did it exist before c) if it did, why it disappeared.

Tue, Jun 8, 12:08 PM Β· User-Ryasmeen, User-Majavah, User-zeljkofilipin, Beta-Cluster-reproducible, Beta-Cluster-Infrastructure
dom_walden added a comment to T281866: Wikimedia OCR: "-" and "_" being stripped from language codes.

Sending this over to Dom in case he wants to revisit it, but effectively I think this task is invalid now that we only accept ISO 639-1 codes (with a few extras specific to Tesseract). If you agree please feel free to close as invalid.

Tue, Jun 8, 7:58 AM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR

Mon, Jun 7

dom_walden reopened T263617: Cannot login to beta cluster: "There seems to be a problem with your login session..." as "Open".

We are seeing this problem again.

Mon, Jun 7, 2:39 PM Β· User-Ryasmeen, User-Majavah, User-zeljkofilipin, Beta-Cluster-reproducible, Beta-Cluster-Infrastructure

Thu, Jun 3

dom_walden moved T270623: Add checkbox to toggle autoblocks on Special:BlockList from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

We have a new checkbox on Special:BlockList, checking it appears to remove all autoblocks from the table.

Thu, Jun 3, 10:56 AM Β· MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Anti-Harassment (The Letter Song), MediaWiki-Blocks
dom_walden moved T282457: Use $wgEnablePartialActionBlocks feature flag for block list and block log [L] from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

Special:BlockList with $wgEnablePartialActionBlocks = true:

Thu, Jun 3, 9:34 AM Β· MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Anti-Harassment (The Letter Song), MediaWiki-Blocks

Thu, May 27

dom_walden added a comment to T282073: Add API endpoint to retrieve supported languages.

@MusikAnimal @Samwilson Is there anything more to be done here? You can move it into Product sign-off or Done if not.

Thu, May 27, 8:20 AM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden moved T280848: Implement MVP of OCR in Wikisource extension from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

This code change has already been tested on beta here: T282080#7085163.

Thu, May 27, 7:50 AM Β· Community-Tech (CommTech-Sprint-2), MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Patch-For-Review, Wikimedia OCR, All-and-every-Wikisource

Wed, May 26

dom_walden created T283722: Better error handling if clicking "Thank" fails in some way on Structured Discussions.
Wed, May 26, 1:43 PM Β· MediaWiki-Blocks, StructuredDiscussions, Thanks, Growth-Team, Anti-Harassment
dom_walden renamed T283720: "Thank" link should not show on Structured Discussions if user is blocked from sending thanks from "Thank" link should not show if user is blocked from sending thanks to "Thank" link should not show on Structured Discussions if user is blocked from sending thanks.
Wed, May 26, 1:32 PM Β· StructuredDiscussions, MediaWiki-Blocks, Thanks, Growth-Team, Anti-Harassment
dom_walden created T283720: "Thank" link should not show on Structured Discussions if user is blocked from sending thanks.
Wed, May 26, 1:28 PM Β· StructuredDiscussions, MediaWiki-Blocks, Thanks, Growth-Team, Anti-Harassment
dom_walden moved T282837: Cache OCR transcriptions from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

We now cache the extracted text, meaning subsequent (identical) requests complete within 100-300ms.

Wed, May 26, 7:34 AM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR

Tue, May 25

dom_walden created T283602: "Headings" menu appears to have no selection if you change formatting from "Block quote" to something else.
Tue, May 25, 3:50 PM Β· VisualEditor, Editing-team
dom_walden created T283601: Status of "Headings" menu not immediately updated when selecting/unselecting "Block quote".
Tue, May 25, 3:37 PM Β· VisualEditor, Editing-team
dom_walden created T283598: There is a div element which partially prevents interaction with the special character menu in Citation "basic form".
Tue, May 25, 3:08 PM Β· Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor
dom_walden added a comment to T280953: Allow images and requests to come from localhost.

Will wait to test on beta

Tue, May 25, 1:30 PM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR

Mon, May 24

dom_walden moved T242785: Allow a user to be blocked from sending thanks from Code Review πŸ” to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

While blocked only from sending Thanks, on a user_talk page with Flow/Structured Discussions enabled:

  • "Thank" still shows next to other people's comments
  • After clicking "Thank", see an error popup (Thank action failed (error code: blocked). Please try again.)
  • After refreshing the page, "Thank" becomes "Thanked"
    • I think just in cookie/browser storage. After I cleared cookies and cache it became "Thank" again. But I will probably raise a separate bug.
  • Also blocked when trying to submit Special:Thanks/Flow (which is the fallback if you don't have JS enabled)

This applies both to your own and to other people's user_talk pages, regardless of whether you are blocked from your own user_talk page.

Mon, May 24, 9:53 AM Β· MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), Patch-For-Review, Anti-Harassment (The Letter Song), Growth-Team-Filtering, User-DannyS712, MediaWiki-Blocks, Growth-Team, Thanks

May 17 2021

dom_walden moved T242785: Allow a user to be blocked from sending thanks from QA/Testing 🐞 to Code Review πŸ” on the Anti-Harassment (The Letter Song) board.

At the moment, when we block users from sending thanks, we are blocking:

  • Special:Thanks
  • Special:Thanks/Log
  • API:Thank (for both revisions and logs)
  • We don't show the (thank) button on the page's revision history or Special:Log
May 17 2021, 9:52 AM Β· MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), Patch-For-Review, Anti-Harassment (The Letter Song), Growth-Team-Filtering, User-DannyS712, MediaWiki-Blocks, Growth-Team, Thanks

May 14 2021

dom_walden closed T282459: Wikimedia OCR: Change "upload.beta.wmflabs.org" to "upload.wikimedia.beta.wmflabs.org" in .env as Resolved.

I haven't tested this, but it is such a minor change I am just going to move it into done.

May 14 2021, 12:20 PM Β· Community-Tech (CommTech-Sprint-1), Patch-For-Review, Wikimedia OCR

May 13 2021

dom_walden moved T282080: Enable new OCR UI on Beta Wikisource from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

I have experimented with a number of books on beta in different languages. For example:

(It does not seem to matter whether or not you are logged in).

May 13 2021, 2:03 PM Β· MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Community-Tech (CommTech-Sprint-1), Wikimedia OCR

May 12 2021

dom_walden moved T280566: Display action blocks properly in ApiQueryBlocks from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

Example entry in action=query&list=blocks&bkprop=id|user|by|timestamp|expiry|reason|flags|restrictions:

{
    "id": 22989,
    "user": "Drwpb",
    "by": "Dom walden",
    "timestamp": "2021-05-12T07:29:52Z",
    "expiry": "infinity",
    "reason": "",
    "allowusertalk": "",
    "partial": "",
    "restrictions": {
        "actions": [
            "upload",
            "move",
            "create"
        ]
    }
}

(More examples here: https://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&list=blocks&bkprop=id|user|by|timestamp|expiry|reason|flags|restrictions&bklimit=20)

May 12 2021, 8:38 AM Β· MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Anti-Harassment (The Letter Song), MediaWiki-Blocks
dom_walden created T282655: Hide action restrictions behind feature flag in ApiQueryBlocks.
May 12 2021, 8:25 AM Β· MediaWiki-Blocks, Anti-Harassment
dom_walden added a comment to T282586: Display partial action blocks properly in Special:CentralAuth.

Do we also want to hide this behind the feature flag, so it does not show when action restrictions are disabled?

May 12 2021, 8:02 AM Β· MediaWiki-extensions-CentralAuth, MediaWiki-Blocks, Anti-Harassment

May 11 2021

dom_walden added a comment to T269341: API:Block should validate page restrictions.

This is a fatal error, and blocks completion of the request. This is in contrast to trying to block a nonexistent namespace, which just returns a warning but otherwise completes the request (ignoring the nonexistent namespace).

From the Slack discussion, @Tchanders reckons the risk for disruption is quite low. We should start a task to fix this in the future for the sake of consistency, however. @dom_walden could you start a task for that? Thank you!

May 11 2021, 3:10 PM Β· MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Blocks
dom_walden created T282574: API:Block invalid page restriction should return warning rather than fatal error.
May 11 2021, 3:09 PM Β· MediaWiki-Blocks, Anti-Harassment
dom_walden moved T280953: Allow images and requests to come from localhost from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

I have been able to use this to successfully OCR files that were stored on a local mediawiki install.

May 11 2021, 2:34 PM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden moved T280798: Fix namespace blocks of removed extension namespaces (and actions) from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

Blocking someone from actions[1] and namespaces[2] which I then disable.

May 11 2021, 9:05 AM Β· MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Anti-Harassment (The Letter Song), MediaWiki-Blocks
dom_walden moved T280566: Display action blocks properly in ApiQueryBlocks from QA/Testing 🐞 to Code Review πŸ” on the Anti-Harassment (The Letter Song) board.

@STran @Tchanders Moving back into code review. There seems to be a CI test failure.

May 11 2021, 8:23 AM Β· MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Anti-Harassment (The Letter Song), MediaWiki-Blocks

May 10 2021

dom_walden created T282463: Special:AutoblockList shows regular blocks after block edited/reblocking.
May 10 2021, 2:56 PM Β· MediaWiki-Blocks, Anti-Harassment
dom_walden added a comment to T280275: Investigate why tallying a large, encrypted election did not complete on votewiki when kicked off via the tally page [8h].

If it helps, I have been able to reproduce this on beta with 1000 votes: https://vote.wikimedia.beta.wmflabs.org/wiki/Special:SecurePoll/tally/632

May 10 2021, 2:45 PM Β· Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T282459: Wikimedia OCR: Change "upload.beta.wmflabs.org" to "upload.wikimedia.beta.wmflabs.org" in .env.
May 10 2021, 2:40 PM Β· Community-Tech (CommTech-Sprint-1), Patch-For-Review, Wikimedia OCR
dom_walden created T282458: Special:Log confusing entry when namespaces removed.
May 10 2021, 2:35 PM Β· MediaWiki-Blocks, Anti-Harassment
dom_walden moved T199918: Allow a user to be blocked from creating pages only from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

When a user is blocked from creating new pages:

  • They cannot create new pages via web or API (I tested several different namespaces and subpages)
    • This includes not being able to create their own User_talk page. I wonder if we should do the same thing for editing where they are allowed unless we explicitly say so.
  • They can edit already existing pages
  • They can move a page, even though I think technically this creates a new page (with the same name as the old page IIRC)
  • They cannot upload a new file
  • They can reupload an existing file
  • They cannot successfully import (although they do not see a block error message)
May 10 2021, 1:30 PM Β· MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Anti-Harassment (The Letter Song), MediaWiki-Blocks, User-DannyS712

May 7 2021

dom_walden moved T280213: Wikisource OCR: Accept Tesseract options on the API from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

I've tested some combinations of the Tesseract options via the UI. I see variations in the returned OCR text, so I guess that means the options are being passed to Tesseract.

May 7 2021, 2:08 PM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR, All-and-every-Wikisource

May 6 2021

dom_walden created T282141: Wikimedia OCR: Validate Tesseract options.
May 6 2021, 1:55 PM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden updated subscribers of T281964: Wikimedia OCR: Validation errors throw 500 exception.

The cache apparently wasn't cleared after T280213: Wikisource OCR: Accept Tesseract options on the API was deployed to staging. I did it manually and the second example now captures the error properly.

May 6 2021, 1:45 PM Β· Wikimedia OCR, Community-Tech
dom_walden created T282135: Wikimedia OCR: Validate the OCR engine.
May 6 2021, 1:44 PM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden closed T279609: Setup error emails for Wikimedia OCR as Resolved.

We (the engineers and I) appear to be getting emails whenever there is a 500 error on the test or production sites.

May 6 2021, 1:32 PM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR
dom_walden moved T280617: Wikisource OCR: Validate language codes from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

If you enter an invalid language (like in this link), you get a nice error message such as:

The following language is not supported by the OCR engine: blah

The languages we accept varies depending on whether you choose Google or Tesseract.

May 6 2021, 12:58 PM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR
dom_walden moved T279560: Allow action blocks to be logged via block log parameters from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

I tested how blocks look in Special:Log/block and action=query&list=logevents.

May 6 2021, 9:39 AM Β· MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Anti-Harassment (The Letter Song), MediaWiki-Blocks
dom_walden moved T279559: Add action block parameters to Special:BlockList from QA/Testing 🐞 to Design Review πŸ”¬ on the Anti-Harassment (The Letter Song) board.

Moving to @Prtksxna if he wants to have a look.

May 6 2021, 8:33 AM Β· MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Anti-Harassment (The Letter Song), MediaWiki-Blocks

May 5 2021

dom_walden moved T280522: Allow partial action blocks to be performed via ApiBlock from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

I have been able to use the API to create blocks against the upload, move and create actions.

May 5 2021, 2:34 PM Β· MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Anti-Harassment (The Letter Song), MediaWiki-Blocks
dom_walden moved T280214: Wikisource OCR: Accept Google options on the API from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

Better UI is merged (single input with tag-style language codes). Live on the test site (only, so far). @dom_walden, not sure if you want to have another look at this.

May 5 2021, 8:37 AM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR, All-and-every-Wikisource
dom_walden created T281964: Wikimedia OCR: Validation errors throw 500 exception.
May 5 2021, 8:29 AM Β· Wikimedia OCR, Community-Tech

May 4 2021

dom_walden added a comment to T280617: Wikisource OCR: Validate language codes.

@HMonroy @NRodriguez For the Google OCR engine, we now only treat as valid what Google considers "Supported languages".

May 4 2021, 2:23 PM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR
dom_walden created T281866: Wikimedia OCR: "-" and "_" being stripped from language codes.
May 4 2021, 2:10 PM Β· Community-Tech (CommTech-Sprint-2), Wikimedia OCR
dom_walden moved T6995: Allow users to be blocked from uploading files only from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

Blocking a user from uploading files blocks them from:

  • Special:Upload
  • API:Upload
  • Visual Editor and Source Editor upload (although they appear to just use API:Upload)
  • Upload Wizard (tested on Commons beta)

But not from any other action (that I tested).

May 4 2021, 9:55 AM Β· MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Anti-Harassment (The Letter Song), MediaWiki-Blocks, User-DannyS712, Multimedia, MediaWiki-Uploading
dom_walden moved T279556: Introduce infrastructure for making partial blocks against actions from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

Testing this has been done as part of T6995. See T6995#7056374.

May 4 2021, 9:55 AM Β· Anti-Harassment (The Letter Song), MediaWiki-Blocks
dom_walden added a comment to T231075: [BUG] Deal more helpfully with users who do not have the reupload right.

Hello,

I want to upload a translated svg but cannot and get this same exact error ("A file with this name already exists, and cannot be overwritten. If you still want to upload your file, please go back and use a new name. ..."), and may account is well over 4 days old.

May 4 2021, 9:33 AM Β· SVG Translate Tool, Community-Tech
dom_walden moved T281129: Wikimedia OCR: "Call to a member function getText() on null" when image has no text from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

I cannot reproduce the bug in the description anymore, via the web page or API. Now, we just return an empty text box.

May 4 2021, 9:02 AM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR

May 3 2021

dom_walden moved T194529: Allow a user to be blocked from moving/renaming pages from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

I tested the behaviour of moving/renaming pages for a blocked user:

  • If blocked from moving pages (either single or composite) they cannot move any page (via Special:MovePage or Api:Move)
  • Otherwise, they cannot move to or from pages which they are blocked (I tested this for partial single and composite blocks, sitewide blocks I have tested a bit incidentally for T6995)
May 3 2021, 4:08 PM Β· MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Anti-Harassment (The Letter Song), MediaWiki-Blocks, User-DannyS712, MediaWiki-Page-rename

Apr 30 2021

dom_walden added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

I get a very similar error message when suppress deleting a page. Should I raise a separate ticket?

Apr 30 2021, 2:52 PM Β· MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
dom_walden moved T281395: Error on Special:BlockList if there's a partial block against a page that is deleted from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

I cannot reproduce this on https://en.wikipedia.beta.wmflabs.org MediaWiki 1.37.0-alpha (7ad7610) 05:22, 30 April 2021.

Apr 30 2021, 2:26 PM Β· MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-Blocks, Anti-Harassment (The Letter Song)
dom_walden moved T277129: Replace our Google Cloud Vision package with the official one from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

I am moving this along. This seems to be working fine.

Apr 30 2021, 1:44 PM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR
dom_walden moved T280214: Wikisource OCR: Accept Google options on the API from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

You can see the effect of passing multiple languages here in the returned text:

Apr 30 2021, 1:25 PM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR, All-and-every-Wikisource

Apr 29 2021

dom_walden added a comment to T281450: Exception: Table 'enwiki.wb_items_per_site' doesn't exist.

Slight note, mobile view works fine

Apr 29 2021, 9:17 AM Β· wdwb-tech, Wikibase (3rd party installations), Beta-Cluster-reproducible
dom_walden added a project to T281450: Exception: Table 'enwiki.wb_items_per_site' doesn't exist: Wikibase (3rd party installations).

Tagging wikibase as they might know about it.

Apr 29 2021, 9:05 AM Β· wdwb-tech, Wikibase (3rd party installations), Beta-Cluster-reproducible
dom_walden created T281450: Exception: Table 'enwiki.wb_items_per_site' doesn't exist.
Apr 29 2021, 9:02 AM Β· wdwb-tech, Wikibase (3rd party installations), Beta-Cluster-reproducible

Apr 28 2021

dom_walden added a comment to T277129: Replace our Google Cloud Vision package with the official one.

Some differences I am finding comparing Test (https://ocr-test.wmcloud.org) to Production (https://ocr.wmcloud.org):

(Bear in mind this is based on very little data. I suspect the above observations will not be true universally. The quality of the OCR tends to depend a lot on the quality of the image and of the original print.)

Apr 28 2021, 4:15 PM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR
dom_walden moved T281093: Wikisource OCR: Add version number to tool from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

QA notes: There is no version number yet so this shows up as just the SHA at https://ocr-test.wmcloud.org/. The link is broken...

Apr 28 2021, 1:47 PM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR
dom_walden added a comment to T279556: Introduce infrastructure for making partial blocks against actions.

Should these wait for T280719 as well, or be fixed separately?

That's the same bug, should also wait for the design fix - maybe we should raise the priority of this. If it's too inconvenient for testing we could put up a quick patch to remove the checking/unchecking, and the checkbox just won't have any effect on sitewide blocks?

Apr 28 2021, 12:49 PM Β· Anti-Harassment (The Letter Song), MediaWiki-Blocks
dom_walden added a comment to T279556: Introduce infrastructure for making partial blocks against actions.

@dom_walden This is enabled on all beta sites except es.wikipedia - just in case you wanted to do any testing with it not enabled (will leave that up to you!)

We've also enabled the config on testwiki, but the code changes won't make it there until the next train, so you won't see any changes yet.

There's a known bug (comment from the patch on gerrit):

There's a small bug with this patch: when re-blocking a blocked user, the "Upload" checkbox will check/uncheck according to whether the editing radios are partial/sitewide, instead of respecting the parameters of the existing block. Fixing this is a bit fiddly (see how the createaccount checkbox works) and the fix would just be immediately removed once the design is updated: T280719.

I suggest we move forward without fixing this bug, then it will magically disappear once we do T280719 (which should be imminently). I think that would be preferable to holding this patch up.

Apr 28 2021, 12:26 PM Β· Anti-Harassment (The Letter Song), MediaWiki-Blocks

Apr 27 2021

dom_walden added a comment to T263617: Cannot login to beta cluster: "There seems to be a problem with your login session...".

The mediawiki-config patch to switch over to sessionstore04 has not been merged or deployed yet, since I have not yet found anyone who can do that.

Apr 27 2021, 8:45 AM Β· User-Ryasmeen, User-Majavah, User-zeljkofilipin, Beta-Cluster-reproducible, Beta-Cluster-Infrastructure
dom_walden added a comment to T263617: Cannot login to beta cluster: "There seems to be a problem with your login session...".

@Majavah This seems to be happening again. Looking on deployment-sessionstore04, however, Cassandra appears to be running:

dwalden@deployment-sessionstore04:~$ systemctl status cassandra.service
● cassandra.service - distributed storage system for structured data
   Loaded: loaded (/lib/systemd/system/cassandra.service; static; vendor preset: enabled)
   Active: active (running) since Tue 2021-04-27 06:42:42 UTC; 1h 48min ago
    Tasks: 61 (limit: 4718)
   Memory: 1.2G
   CGroup: /system.slice/cassandra.service
...
Apr 27 2021, 8:34 AM Β· User-Ryasmeen, User-Majavah, User-zeljkofilipin, Beta-Cluster-reproducible, Beta-Cluster-Infrastructure

Apr 26 2021

dom_walden created T281129: Wikimedia OCR: "Call to a member function getText() on null" when image has no text.
Apr 26 2021, 1:37 PM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR
dom_walden created T281093: Wikisource OCR: Add version number to tool.
Apr 26 2021, 8:29 AM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR

Apr 23 2021

dom_walden added a comment to T279556: Introduce infrastructure for making partial blocks against actions.

@dom_walden Ahead of us merging this patch, would it be possible for you to do some regression testing on PatchDemo with the feature flag switched off?

Apr 23 2021, 2:07 PM Β· Anti-Harassment (The Letter Song), MediaWiki-Blocks
dom_walden moved T280284: Create prod VPS for Wikimedia OCR from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

I tested a few images on https://ocr.wmcloud.org/ with Google and Tesseract. I didn't see any problems. It seemed pretty quick to me, but I don't have much for comparison.

Apr 23 2021, 1:48 PM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR

Apr 21 2021

dom_walden added a comment to T279556: Introduce infrastructure for making partial blocks against actions.

@dom_walden Ahead of us merging this patch, would it be possible for you to do some regression testing on PatchDemo with the feature flag switched off?

Apr 21 2021, 11:33 AM Β· Anti-Harassment (The Letter Song), MediaWiki-Blocks

Apr 16 2021

dom_walden moved T275870: Ws export: failed to get subpages for work with colon in the name from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

@Samwilson It looks like the problem has been resolved. Thank you very much for your quick reaction and implementation of the solution (many people involved in promoting pl ws breathed a sigh of relief). We appreciate it.
I also checked the cases reported here - looks like zh is ok as well.

Apr 16 2021, 2:31 PM Β· Community-Tech (CommTech-Sprint-1), WS Export
dom_walden renamed T280329: Wikisource Export: Exports failing because subpages "could not be found" from Wikisource Export: Export fails when subpages are redirects to non-existent pages to Wikisource Export: Exports failing because subpages "could not be found".
Apr 16 2021, 2:26 PM Β· WS Export, Community-Tech
dom_walden created T280329: Wikisource Export: Exports failing because subpages "could not be found".
Apr 16 2021, 10:12 AM Β· WS Export, Community-Tech

Apr 15 2021

dom_walden moved T277277: Modernize icons used in SecurePoll ListPage and VotePage from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

How the icons on the list page look:
Before:


After:

Apr 15 2021, 1:52 PM Β· MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Apr 14 2021

dom_walden moved T279118: Wikisource OCR: add support for tesseract on wikimedia ocr from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

I have been able to use the tesseract option to do OCR, for example.

Apr 14 2021, 3:17 PM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR, All-and-every-Wikisource
dom_walden moved T279610: Adjust how we handle exceptions from QA πŸ› to Product sign-off 🀘 on the Community-Tech (CommTech-Sprint-1) board.

So for this ticket, I suppose all we've done is better validate the URL that was given.

Apr 14 2021, 2:27 PM Β· Community-Tech (CommTech-Sprint-1), Wikimedia OCR
dom_walden created T280141: Wikimedia OCR: 'https://upload.wikimeida.org' misspelled.
Apr 14 2021, 2:26 PM Β· User-Zabe, Wikimedia OCR, Community-Tech
dom_walden moved T269341: API:Block should validate page restrictions from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

I cannot reproduce the bug in the description. When I try to submit an API block with a nonexistent or deleted page, the API returns:

{
    "error": {
        "code": "cant-block-nonexistent-page",
        "info": "You cannot block a user from Nonexistentpage because the page does not exist",
        "*": "See https://en.wikipedia.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes."
    },
    "servedby": "deployment-mediawiki11"
}
Apr 14 2021, 11:53 AM Β· MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Blocks
dom_walden moved T273044: Convert SecurePoll VotePage to use OOUI from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

I tested a few different types of election, including Range voting (plurality) with comment and Range voting (histogram range) with comment.

Apr 14 2021, 8:51 AM Β· MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Apr 8 2021

dom_walden moved T273045: Convert SecurePoll TranslatePage to use OOUI from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.

I have tested submitting translations in a couple of different languages and seeing the database and SecurePoll:<id>/msg/<lang> being appropriately updated.

Apr 8 2021, 2:57 PM Β· MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden added a comment to T275870: Ws export: failed to get subpages for work with colon in the name.

... Anyway, how about we switch to using the title attribute instead, and check for whether it begins with [title]/?

Apr 8 2021, 2:44 PM Β· Community-Tech (CommTech-Sprint-1), WS Export