Page MenuHomePhabricator

dom_walden (Dom Walden)
Test Engineer for Community Tech and Anti-Harassment Teams

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2018, 4:33 PM (43 w, 33 m)
Availability
Available
LDAP User
Dom Walden
MediaWiki User
Dom walden [ Global Accounts ]

Recent Activity

Thu, Aug 15

dom_walden added a comment to T230357: SVG Translate does not handle tspan without coordinates.

Might this be another example of the issue discussed in this bug T216283#5133746?

Thu, Aug 15, 4:47 PM · Community-Tech, SVG Translate Tool
dom_walden created T230554: [BUG] SVGTranslate does not properly handle some characters in file names.
Thu, Aug 15, 1:35 PM · SVG Translate Tool, Community-Tech
dom_walden created T230547: [BUG] The authorization headers in your request are not valid: No approved grant was found for that authorization token..
Thu, Aug 15, 11:04 AM · SVG Translate Tool, Community-Tech
dom_walden created T230539: [BUG] 500 error uploading when user account does not exist locally on commons.
Thu, Aug 15, 10:30 AM · SVG Translate Tool, Community-Tech
dom_walden moved T215721: Remove extraneous space from username input from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

I see in the API calls any spaces at the start or end of input being removed.

Thu, Aug 15, 9:24 AM · Anti-Harassment (The Letter Song), InteractionTimeline
dom_walden moved T226657: Add a mechanism to determine if a namespace is a default MW namespace from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

The change appears to be functionally equivalent to what we had before.

Thu, Aug 15, 7:46 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-General

Wed, Aug 14

dom_walden added a comment to T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.

I am blocked from https://wikidata.beta.wmflabs.org/wiki/Special:NewLexeme even if I am only partially blocked.

Wed, Aug 14, 4:48 PM · Anti-Harassment (The Letter Song), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
dom_walden moved T229991: Upgrade dependencies and fix security alerts from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

SVGTranslate appears to still be working :). I am able to download, login, upload, switch translation, switch preferred language and search. I have not seen any JS errors in the browser console.

Wed, Aug 14, 3:59 PM · Community-Tech (Kanban (Q1 2019-20)), SVG Translate Tool
dom_walden moved T230085: Verify OAuth callback URL with registered prefix from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

The problematic URL:
https://tools.wmflabs.org/svgtranslate/login?callback=http%3A%2F%2Ftools.wmflabs.org%2Fsvgtranslate%2Foauth_callback%3Fredirect%3Dhttp%3A%2F%2Ftools.wmflabs.org%2Fsvgtranslate%2FFile%3ACloud_types_en.svg

Wed, Aug 14, 3:39 PM · Community-Tech (Kanban (Q1 2019-20)), SVG Translate Tool
dom_walden added a comment to T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.

I can access and submit the Special:NewItem and Special:NewProperty forms unless I am partially blocked from the Main or Property namespace (resp.)

Wed, Aug 14, 2:54 PM · Anti-Harassment (The Letter Song), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
dom_walden moved T206096: Inconsistent handling of missing Required values in TemplateWizard from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

I could not reproduce on Firefox, Chromium, IE11 or Safari 11.

Wed, Aug 14, 8:10 AM · Community-Tech (Kanban (Q1 2019-20)), Outreachy (Round 17), MediaWiki-extensions-TemplateWizard

Tue, Aug 13

dom_walden added a comment to T207452: Flag talk page feedback in toolbar .

...Does clicking on the other icon (i.e. the count of potential issues) result in opening the "Page Info" flyout?

Tue, Aug 13, 4:24 PM · Community-Tech (Kanban (Q1 2019-20)), PageCuration, Growth-Team
dom_walden moved T227527: Implement build steps for WhoWroteThat as a gadget from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

I was successful following the instructions above.

Tue, Aug 13, 1:20 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Mon, Aug 12

dom_walden added a comment to T223769: [BUG] Log-in https://tools.wmflabs.org/svgtranslate/ does not work.

I also have not been able to reproduce this bug on Production.

Mon, Aug 12, 4:11 PM · Community-Tech (Kanban (Q1 2019-20)), SVG Translate Tool
dom_walden moved T207452: Flag talk page feedback in toolbar from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

When the article's Talk page has an edit(s) with the tag "pagetriage"[1] the mail icon appears in the toolbar, with a count.

Mon, Aug 12, 4:08 PM · Community-Tech (Kanban (Q1 2019-20)), PageCuration, Growth-Team

Thu, Aug 8

dom_walden moved T227622: Deploy Commons deletion notification bot on fawiki from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.
  • Turn on the bot and make sure:
    • The text is all in Persian.
Thu, Aug 8, 4:45 PM · Community-Tech (Kanban (Q1 2019-20)), Commons
dom_walden created T230129: [BUG] Special:Block: Invalid expiration time error message does not appear when there are other validation errors.
Thu, Aug 8, 1:36 PM · MediaWiki-User-management, Anti-Harassment
dom_walden moved T220533: Special:Block without JavaScript: "Other" field in Expiration section is required even if "Other" is not selected from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Without JS, it is not longer required to enter a value into the "Other" field (unless the "Other" dropdown is selected).

Thu, Aug 8, 1:15 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden created T230125: [BUG] Special:Block: Page and Namespace selections not included in block after validation error on IE11.
Thu, Aug 8, 12:08 PM · MediaWiki-User-management, Anti-Harassment

Wed, Aug 7

dom_walden moved T229459: [BUG] SVG Translate reports read errors on some files from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

I used a script to load in SVGTranslate the most recent 500 images (of any type) uploaded to commons and check the error message that was returned.

Wed, Aug 7, 1:15 PM · Community-Tech (Kanban (Q1 2019-20)), SVG Translate Tool
dom_walden moved T229779: Toolbar: Don't show "Add a message for the creator" without a textbox from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

@dom_walden When this work is released to beta, can you verify that it's working as expected? Thank you!

Wed, Aug 7, 10:17 AM · Community-Tech (Kanban (Q1 2019-20)), User-DannyS712, Growth-Team, PageCuration
dom_walden added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

@dom_walden can you confirm that the issue is fixed tho? (Block list and log incorrectly report "cannot edit own talk page" for some blocks) I'll take a look at how the form displays the errors anyway

Wed, Aug 7, 8:31 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management

Mon, Aug 5

dom_walden added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

@dmaza Would it be better if the error message appeared underneath the "Editing their own talk page" checkbox?

Mon, Aug 5, 4:28 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden moved T223769: [BUG] Log-in https://tools.wmflabs.org/svgtranslate/ does not work from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

I am no longer able to reproduce this bug using the steps in T223769#5373460, on Chromium 73 and Safari 12.1.

Mon, Aug 5, 1:43 PM · Community-Tech (Kanban (Q1 2019-20)), SVG Translate Tool

Fri, Aug 2

dom_walden added a comment to T223769: [BUG] Log-in https://tools.wmflabs.org/svgtranslate/ does not work.

@Samwilson The other login link you see when logged out ("Log in to enable uploading") still links to https://tools.wmflabs.org/svgtranslate-test/login. Does that need to be changed as well?

Fri, Aug 2, 1:43 PM · Community-Tech (Kanban (Q1 2019-20)), SVG Translate Tool
dom_walden moved T228479: Autopromote is blocked by a Partial Block from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Concentrating on $wgAutopromote and $wgAutopromoteOnce.

Fri, Aug 2, 12:23 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Anti-Harassment (The Letter Song), Technical-Debt, MediaWiki-User-management
dom_walden added a comment to T216245: VisualEditor, MobileFrontend, and other tools using action=edit do not auto-block IP addresses.

I am not sure what is actually the expected behavior. Should autoblocks even be spread when opening the editor? If so, we might need a separate API action for doing that… (in VE we can add that code to action=visualeditor, but this doesn't fix the issue for mobile wikitext editor). Or maybe action=query&prop=revisions should also spread autoblocks?

What's the case for the classic editors at the moment? I think that they don't spread the block when the editor is opened, is that correct?

Fri, Aug 2, 10:41 AM · Core Platform Team, VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), MediaWiki-API

Thu, Aug 1

dom_walden added a comment to T229417: [BUG] Composite blocks do not block deleting pages.

A similar thing happens for the 'patrol' action (e.g. you can use pagetriage to mark a page as reviewed even if you have two sitewide blocks against you).

Thu, Aug 1, 12:54 PM · Anti-Harassment (The Letter Song), MediaWiki-User-management

Wed, Jul 31

dom_walden added a comment to T226789: Add a #pagetriage revision tag to every edit made by the PageTriage extension.

We are only missing the tag being added to entries in the Potential copyright violation log. I am not sure if this matters, but will raise a separate bug.

Wed, Jul 31, 5:30 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Community-Tech (Kanban (Q1 2019-20)), Growth-Team, PageCuration
dom_walden created T229417: [BUG] Composite blocks do not block deleting pages.
Wed, Jul 31, 1:47 PM · Anti-Harassment (The Letter Song), MediaWiki-User-management

Mon, Jul 29

dom_walden added a comment to T228736: [BUG] Drawer does not appear for block messages on mobile.

The only thing I notice is that the order of "Details" and "OK" are incorrect (compared to how they were previously). If you like, I can just raise a separate bug for this.

Please. :)

Mon, Jul 29, 5:30 PM · Readers-Web-Backlog (Tracking), VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Anti-Harassment, Regression, MediaWiki-User-management, MobileFrontend
dom_walden moved T228534: Users with partial access to change user rights should not be blocked with a partial block from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.
Not blockedPartially blockedSitewide blocked
beaurocratSuccessSuccessSuccess
sysopSuccessBlocked errorBlocked error
Mon, Jul 29, 4:53 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Anti-Harassment (The Letter Song), Technical-Debt, MediaWiki-User-management

Sat, Jul 27

dom_walden added a comment to T216245: VisualEditor, MobileFrontend, and other tools using action=edit do not auto-block IP addresses.

@dom_walden: Is it working for you now? :)

Sat, Jul 27, 7:53 PM · Core Platform Team, VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), MediaWiki-API
dom_walden added a comment to T228736: [BUG] Drawer does not appear for block messages on mobile.

@dom_walden: Could you check if the fix is working for you?

Sat, Jul 27, 4:12 PM · Readers-Web-Backlog (Tracking), VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Anti-Harassment, Regression, MediaWiki-User-management, MobileFrontend

Fri, Jul 26

dom_walden moved T228904: Clean up modules in PageTriage from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Did a variety of actions:

  • Review and unreview
  • Send message to creator
  • Add a tag
  • Mark for deletion (speedy and proposed)
Fri, Jul 26, 4:11 PM · Performance-Team (Radar), Community-Tech (Kanban (Q1 2019-20))
dom_walden added a comment to T179741: ApiGlobalBlock.php: Trying to get property 'gb_expiry' or 'gb_anon_only ' of non-object.

I can reproduce this by creating a GlobalBlock of an IP range via the API.

Fri, Jul 26, 2:05 PM · Wikimedia-production-error, GlobalBlocking
dom_walden moved T207847: 'Potential Issues' from ORES should be flagged in Page Curation Toolbar Page Info flyout from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Testing on my local environment, adding scores directly into the ores_classification table. I can see the tags 'Attack', 'Spam' or 'Vandalism' appear in the "Page info" as appropriate.

Fri, Jul 26, 1:55 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Community-Tech (Kanban (Q1 2019-20)), PageCuration
dom_walden moved T223380: [BUG] Previous translations sometimes appear in current translation from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

A user's current translations are cached in the browser until they:

  • Open another SVG (this is new),
  • Start editing a translation in another tab, or
  • Switch to another translation (in some circumstances; we do warn users of this)
Fri, Jul 26, 9:57 AM · Community-Tech (Kanban (Q1 2019-20)), SVG Translate Tool

Wed, Jul 24

dom_walden moved T212326: Overlapping blocks may display incorrect block notice from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Tested various combinations of database and system blocks. Behaviour is as Thalia describes above (T212326#5322341).

Wed, Jul 24, 8:00 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-User-management

Tue, Jul 23

dom_walden created T228736: [BUG] Drawer does not appear for block messages on mobile.
Tue, Jul 23, 9:45 AM · Readers-Web-Backlog (Tracking), VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Anti-Harassment, Regression, MediaWiki-User-management, MobileFrontend
dom_walden created P8782 JSON response attempting to edit on mobile while blocked.
Tue, Jul 23, 9:44 AM

Mon, Jul 22

dom_walden moved T221117: Special:Block checkboxes should remember checked state from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

On Special:Block, I changed the target back and forth between username, ip and range so different checkboxes became enabled/disabled, making sure the previous state was preserved.

Mon, Jul 22, 4:51 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), MediaWiki-User-management, Anti-Harassment (The Letter Song)
dom_walden moved T219882: Disabling JavaScript on Special:Block allows you to enter any positive number as a namespace from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

I tested that I could submit sitewide blocks and partial blocks with and without namespace restrictions. Both with and without JS.

Mon, Jul 22, 3:30 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden created T228669: Add #pagetriage tag to potential copyright violation log entries.
Mon, Jul 22, 2:40 PM · User-DannyS712, PageCuration, Growth-Team, Community-Tech

Sun, Jul 21

dom_walden moved T220163: Allow user to mute notifications from Special:Mute page from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Special:Mute adds and removes from the user_properties table (also visible in Special:Preferences#mw-prefsection-echo).

Sun, Jul 21, 3:53 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dom_walden added a comment to T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user.

Oh, you do also see the Special:Mute link on your own user, user_talk, etc., pages, taking you to Special:Mute for your own user. I don't know what happens when you mute yourself. Not sure if this is a problem.

Sun, Jul 21, 2:41 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team
dom_walden moved T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

On the side rail, I see the link for Special:Mute/$user on:

  • User:$user
  • User_talk:$user
  • Special:Contributions/$user
  • Special:Block/$user
  • Special:CentralAuth?target=$user
Sun, Jul 21, 2:36 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team

Jul 19 2019

dom_walden moved T227334: [BUG] wsexport cannot generate valid epub with svg images from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

On the test environment, I can generate and view the epub in the reproduction steps. The problematic SVG displays.

Jul 19 2019, 8:02 AM · Community-Tech (Kanban (Q1 2019-20)), E-Book-Export-Reliability

Jul 17 2019

dom_walden reopened T219882: Disabling JavaScript on Special:Block allows you to enter any positive number as a namespace as "Open".

Sorry, moving back as I missed something.

Jul 17 2019, 5:17 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden added a comment to T226789: Add a #pagetriage revision tag to every edit made by the PageTriage extension.

... Also, since (as far as I can tell) the log is only interacted with through the api, it appears that the tag is indeed added (see the logActivity function) but there simply haven't been any entries created since the patch was merged. If you want to give User:DannyS712 (on the beta cluster) copyvio-bot rights, I can test it out.

Jul 17 2019, 4:58 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Community-Tech (Kanban (Q1 2019-20)), Growth-Team, PageCuration
dom_walden moved T226789: Add a #pagetriage revision tag to every edit made by the PageTriage extension from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

The 'pagetriage' tag is added when...

Jul 17 2019, 3:47 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Community-Tech (Kanban (Q1 2019-20)), Growth-Team, PageCuration
dom_walden moved T219882: Disabling JavaScript on Special:Block allows you to enter any positive number as a namespace from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.
Jul 17 2019, 2:03 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden added a comment to T219882: Disabling JavaScript on Special:Block allows you to enter any positive number as a namespace.

With javascript disabled, I am only allowed to enter numbers of valid namespace. I checked that this included both the hardcoded/default namespaces and custom namespaces.

Jul 17 2019, 2:03 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-User-management

Jul 16 2019

dom_walden moved T227161: Add support for change tags to MessagePoster from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Using MessagePoster I was allowed to add a tags parameter to api.php?action=edit, which tags the edit (like so). The other POST parameters were the same as before. The parameter is optional; without it the POST is the same as before.

Jul 16 2019, 8:22 AM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Community-Tech (Kanban (Q1 2019-20)), MediaWiki-General, Growth-Team, PageCuration
dom_walden added a comment to T228021: Request access to deployment-prep.

What is your wikitech.wm.o username?

Jul 16 2019, 6:52 AM · Release-Engineering-Team (Other / Uncategorized), Release-Engineering-Team-TODO (201907), User-greg, Beta-Cluster-Infrastructure

Jul 15 2019

dom_walden added a comment to T227218: Surface copyvio as possible issue in Page Curation toolbar "Page info" flyout.

Yeah, I'd like to keep this in Dom's column until it has been tested - whether on Beta or in Prod. I believe it went out with the train today.

Jul 15 2019, 2:50 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Community-Tech (Kanban (Q1 2019-20)), PageCuration
dom_walden updated subscribers of T207442: Send Message to creator without needing to 'unreview'/'re-review' the article.
  • When user hits Mark as reviewed, that only marks the page as reviewed and does not send message to creator.
Jul 15 2019, 2:37 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Community-Tech (Kanban (Q1 2019-20)), Community-Tech-Sprint, PageCuration, Growth-Team
dom_walden created T228021: Request access to deployment-prep.
Jul 15 2019, 9:34 AM · Release-Engineering-Team (Other / Uncategorized), Release-Engineering-Team-TODO (201907), User-greg, Beta-Cluster-Infrastructure

Jul 14 2019

dom_walden updated the task description for T227892: [BUG] InvalidArgumentException "Blocker must be a local user or a name that cannot be a local user".
Jul 14 2019, 11:12 AM · Anti-Harassment, MediaWiki-User-management

Jul 12 2019

dom_walden created T227892: [BUG] InvalidArgumentException "Blocker must be a local user or a name that cannot be a local user".
Jul 12 2019, 2:59 PM · Anti-Harassment, MediaWiki-User-management
dom_walden added a comment to T227167: Block notice is not shown when editing from mobile for composite blocks.

@dom_walden Just to clarify - the beta has the generic message in your screenshot above - shouldn't it be the other way around? Beta should be running the more recent code.

Jul 12 2019, 1:46 PM · Anti-Harassment (The Letter Song)

Jul 9 2019

dom_walden added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

@dom_walden Does the state (when loading the Special:Mute page or via the API) reflect what it should? (i.e. if it's globally set to true but locally set to false does it display as true?)

Jul 9 2019, 7:42 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Community-Tech (Kanban (Q1 2019-20)), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-GlobalPreferences

Jul 8 2019

dom_walden moved T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Concentrating on Special:Mute and email-blacklist option.

Jul 8 2019, 4:13 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Community-Tech (Kanban (Q1 2019-20)), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-GlobalPreferences

Jul 5 2019

dom_walden moved T225686: Load issue with pdfs from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

...The book Les_Merveilles_de_la_science still doesn't work though, because it times out; that's better than failing I guess.

Jul 5 2019, 3:10 PM · Community-Tech (Kanban (Q1 2019-20)), E-Book-Export-Reliability
dom_walden created T227334: [BUG] wsexport cannot generate valid epub with svg images.
Jul 5 2019, 3:09 PM · Community-Tech (Kanban (Q1 2019-20)), E-Book-Export-Reliability
dom_walden moved T227167: Block notice is not shown when editing from mobile for composite blocks from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Actual:

  • You are allowed to progress to the editor. If you attempt to save an edit, you will see a generic error, with no block details
Jul 5 2019, 12:54 PM · Anti-Harassment (The Letter Song)
dom_walden moved T227168: Partial block notice is not shown when attempting to edit on mobile with a partial block from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

I have only been able to reproduce this when I:
a) am already on the edit page when my user is blocked, or
b) have unsaved edits

Jul 5 2019, 11:55 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song)
dom_walden moved T227218: Surface copyvio as possible issue in Page Curation toolbar "Page info" flyout from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Actually, there's no way to QA this unless you simulate the copyvio locally by adding the tag manually in the database. See T207847#5297073

Jul 5 2019, 7:11 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Community-Tech (Kanban (Q1 2019-20)), PageCuration

Jul 3 2019

dom_walden moved T225450: [BUG] Prevent preview errors when leaving page from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Cannot reproduce on Firefox, Chromium, IE11 or Safari.

Jul 3 2019, 4:21 PM · Community-Tech (Kanban (Q1 2019-20)), SVG Translate Tool
dom_walden moved T226790: Refactor external process-running from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

This is merged and on the staging site. There's no real QA required other than keeping an eye out for anything completely not working any more. There may be some changes in error display for some types of error.

Jul 3 2019, 9:19 AM · Community-Tech (Kanban (Q1 2019-20)), E-Book-Export-Reliability

Jun 29 2019

dom_walden moved T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

The email footer now appears fine for me. Including with RTL usernames (converting the username to url encoded hexadecimal in the Special:Mute link).

Jun 29 2019, 4:25 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dom_walden added a comment to T225293: [BUG][8 hours] Investigate why the SVGTranslate webservice needs to be restarted so often.

They look fine to me :O

Jun 29 2019, 2:24 PM · Community-Tech, Spike, SVG Translate Tool

Jun 28 2019

dom_walden added a comment to T207442: Send Message to creator without needing to 'unreview'/'re-review' the article.

@HMonroy After checking out your patch, when I click the "Mark as reviewed" button it becomes disabled and there is a little spinner, but nothing happens (in the UI) after this to indicate the action has been successful (which it has).

Jun 28 2019, 2:14 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Community-Tech (Kanban (Q1 2019-20)), Community-Tech-Sprint, PageCuration, Growth-Team
dom_walden added a comment to T225293: [BUG][8 hours] Investigate why the SVGTranslate webservice needs to be restarted so often.

@dom_walden, please poke me next time it malfunctions, I'll try debugging it live. Moving it from the kanban board until then.

Jun 28 2019, 6:53 AM · Community-Tech, Spike, SVG Translate Tool

Jun 27 2019

dom_walden updated the task description for T225450: [BUG] Prevent preview errors when leaving page.
Jun 27 2019, 12:21 PM · Community-Tech (Kanban (Q1 2019-20)), SVG Translate Tool
dom_walden added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dmaza The email footer I see now (in my MUA at least) is: To manage email preferences for Steve please visit <http://192.168.122.72/T218265/index.php/Special:Mute/Steve>.

Jun 27 2019, 7:55 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Jun 25 2019

dom_walden added a comment to T208895: Ensure that anywhere BlockDisablesLogin is used, it does not affect partial blocks.

@dbarratt @Krinkle I notice that if $wgBlockDisablesLogin = true and the user's IP is blocked (but not the username) they are prevented from sending emails, even if the IP block does not apply to emails.

Jun 25 2019, 7:22 AM · MediaWiki-User-management
dom_walden created T226468: [BUG] Block cookie interprets block expiry in local timezone: should be UTC.
Jun 25 2019, 6:42 AM · MediaWiki-User-management

Jun 24 2019

dom_walden moved T225675: Add OAuth to Citation bot from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

No QA involvement in this. Moving this on.

Jun 24 2019, 4:31 PM · Anti-Harassment (The Letter Song)
dom_walden moved T225919: Single blocks are sometimes interpreted as multiple blocks from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Issue in T225919#5272162 no longer reproducible.

Jun 24 2019, 4:30 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (The Letter Song)

Jun 21 2019

dom_walden moved T207439: Size improvements for Curation toolbar from QA to Product sign-off on the Community-Tech (Resolved 2018-19 Q4) board.

Retested briefly on beta with Firefox, Safari and IE11. This looks fine.

Jun 21 2019, 8:11 AM · Community-Tech (Kanban (Q1 2019-20)), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Community-Tech-Sprint, PageCuration
dom_walden moved T223337: Fix SVGTranslate's Docker from QA to Product sign-off on the Community-Tech (Resolved 2018-19 Q4) board.

There is nothing more I want to do with this.

Jun 21 2019, 7:59 AM · Community-Tech (Resolved 2018-19 Q4), SVG Translate Tool
dom_walden moved T208685: Page Curation toolbar: mark pages as 'reviewed' when adding AfD tags from QA to Product sign-off on the Community-Tech (Resolved 2018-19 Q4) board.

Just waiting for the above patch to be +2ed before moving this out of QA.

Jun 21 2019, 7:58 AM · Community-Tech (Kanban (Q1 2019-20)), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Community-Tech-Sprint, Growth-Team, PageCuration

Jun 20 2019

dom_walden added a comment to T212326: Overlapping blocks may display incorrect block notice.

I notice on test.wikipedia.org, when there is a composite block blocking email, Special:EmailUser includes: "Block ID #".

Jun 20 2019, 7:35 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-User-management

Jun 19 2019

dom_walden moved T166337: wsexport tool leaking files in /tmp from QA to Product sign-off on the Community-Tech (Resolved 2018-19 Q4) board.

There are files in /tmp/calibre_2.75.1_tmp_imITvt on tools-sgewebgrid-lighttpd-0921.tools.eqiad.wmflabs but it looks like they're being actively created/deleted so that's maybe fine... I don't see /tmp litter on other hosts.

Jun 19 2019, 9:58 AM · Community-Tech (Resolved 2018-19 Q4), E-Book-Export-Reliability, Tools, Toolforge
dom_walden added a comment to T208685: Page Curation toolbar: mark pages as 'reviewed' when adding AfD tags.

I checked that:
+ Marking a page with "Speedy deletion" or "Proposed deletion" will mark it as Unreviewed (or keep it marked Unreviewed if it was previously Unreviewed).
+ Marking a page with "Articles for deletion" will mark it as Reviewed (or keep it marked Reviewed it if was previously Reviewed).

Jun 19 2019, 8:17 AM · Community-Tech (Kanban (Q1 2019-20)), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Community-Tech-Sprint, Growth-Team, PageCuration

Jun 18 2019

dom_walden updated subscribers of T225919: Single blocks are sometimes interpreted as multiple blocks.

I am in the process of testing this, and so far so good. The issue raised in T225872 (user block cookies) no longer occurs. Nor does its counterpart for IP block cookies.

Jun 18 2019, 5:45 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (The Letter Song)
dom_walden added a comment to T166337: wsexport tool leaking files in /tmp.

@Andrew I don't think I have access to any of the lighttpd nodes. Would you be able to check that there are no old files belonging to tools.wsexport-test in /tmp, please?

Jun 18 2019, 11:21 AM · Community-Tech (Resolved 2018-19 Q4), E-Book-Export-Reliability, Tools, Toolforge
dom_walden closed T216178: [BUG] SVGTranslate does not render previews and shows error popup as Resolved.

I have not been able to reproduce this problem.

Jun 18 2019, 11:07 AM · SVG Translate Tool
dom_walden closed T216178: [BUG] SVGTranslate does not render previews and shows error popup, a subtask of T215835: [Epic] Problems with image rendering on SVG Translate, as Resolved.
Jun 18 2019, 11:07 AM · Epic, SVG Translate Tool
dom_walden added a comment to T207439: Size improvements for Curation toolbar.

I was not able to reproduce this problem. I tried in Firefox and Chromium. Could someone else confirm?

Jun 18 2019, 10:00 AM · Community-Tech (Kanban (Q1 2019-20)), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Community-Tech-Sprint, PageCuration
dom_walden moved T225020: Replace the logo on Eventmetrics to the non-BETA version from QA to Product sign-off on the Community-Tech (Resolved 2018-19 Q4) board.

Looks fine on https://eventmetrics-dev.wmflabs.org

Jun 18 2019, 6:56 AM · Community-Tech (Resolved 2018-19 Q4), Event Metrics

Jun 17 2019

dom_walden moved T206163: Restrictions of overlapping blocks should be merged on enforcement from QA/Testing to Done on the Anti-Harassment (Lāmed - ל) board.

Generating random combinations of blocks including:
+ Username, IP and IP ranges, autoblocks
+ System blocks (e.g. $wgProxyList, $wgDnsBlacklistUrls, $wgApplyIpBlocksToXff, Tor)
+ Global blocks
+ Blocks set from cookies
and testing different actions anonymously and while logged in (e.g. editing, account creation, sending email).

Jun 17 2019, 3:23 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
dom_walden moved T225141: Move cookie-related logic from User and Block to BlockManager from QA/Testing to Done on the Anti-Harassment (Lāmed - ל) board.

Testing IP and Autoblock cookies locally, looking at:
+ Does the cookie get set at the right time?
+ Do the cookies get cleared at the right time?
+ Is the block applied correctly from the cookie?

Jun 17 2019, 2:55 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
dom_walden moved T206163: Restrictions of overlapping blocks should be merged on enforcement from Done to QA/Testing on the Anti-Harassment (Lāmed - ל) board.

Sorry, wrong task.

Jun 17 2019, 2:54 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
dom_walden moved T206163: Restrictions of overlapping blocks should be merged on enforcement from QA/Testing to Done on the Anti-Harassment (Lāmed - ל) board.
Jun 17 2019, 2:54 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
dom_walden added a comment to T225748: Fix block message for CompositeBlocks.

Are we fixing the mobile message in this bug?

Jun 17 2019, 8:45 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management

Jun 12 2019

dom_walden moved T220642: Only show the feedback link on Special:Block to users who can access the page from QA/Testing to Done on the Anti-Harassment (Lāmed - ל) board.

I don't see the link when I am an anonymous user or a non-admin user. I do when I am logged in as an admin.

Jun 12 2019, 7:17 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management

Jun 11 2019

dom_walden moved T223828: Redirects not appearing in New Page Patrol from QA to Product sign-off on the Community-Tech (Resolved 2018-19 Q4) board.

For a redirect that has been created either as a result of a page move or someone adding "#REDIRECT [[other_page]]".

Jun 11 2019, 4:43 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Community-Tech (Resolved 2018-19 Q4), Regression, Growth-Team, PageCuration, English-Wikipedia-New-Pages-Patrol
dom_walden moved T219324: Update tools maintained by Community-Tech to use new actor storage from QA to Product sign-off on the Community-Tech (Resolved 2018-19 Q4) board.

Had their own tickets. Did not go into QA.

Jun 11 2019, 4:32 PM · Tools, Community-Tech (Resolved 2018-19 Q4), Community-Tech-Sprint