Page MenuHomePhabricator

dom_walden (Dom Walden)
Test Engineer for Community Tech and Anti-Harassment Teams

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2018, 4:33 PM (34 w, 15 h)
Availability
Available
LDAP User
Dom Walden
MediaWiki User
Dom walden [ Global Accounts ]

Recent Activity

Today

dom_walden moved T225020: Replace the logo on Eventmetrics to the non-BETA version from QA to Product sign-off on the Community-Tech (Community-Tech-Kanban) board.

Looks fine on https://eventmetrics-dev.wmflabs.org

Tue, Jun 18, 6:56 AM · Community-Tech (Community-Tech-Kanban), Event Metrics

Yesterday

dom_walden moved T206163: Restrictions of overlapping blocks should be merged on enforcement from QA/Testing to Done on the Anti-Harassment (Lāmed - ל) board.

Generating random combinations of blocks including:
+ Username, IP and IP ranges, autoblocks
+ System blocks (e.g. $wgProxyList, $wgDnsBlacklistUrls, $wgApplyIpBlocksToXff, Tor)
+ Global blocks
+ Blocks set from cookies
and testing different actions anonymously and while logged in (e.g. editing, account creation, sending email).

Mon, Jun 17, 3:23 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
dom_walden moved T225141: Move cookie-related logic from User and Block to BlockManager from QA/Testing to Done on the Anti-Harassment (Lāmed - ל) board.

Testing IP and Autoblock cookies locally, looking at:
+ Does the cookie get set at the right time?
+ Do the cookies get cleared at the right time?
+ Is the block applied correctly from the cookie?

Mon, Jun 17, 2:55 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
dom_walden moved T206163: Restrictions of overlapping blocks should be merged on enforcement from Done to QA/Testing on the Anti-Harassment (Lāmed - ל) board.

Sorry, wrong task.

Mon, Jun 17, 2:54 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
dom_walden moved T206163: Restrictions of overlapping blocks should be merged on enforcement from QA/Testing to Done on the Anti-Harassment (Lāmed - ל) board.
Mon, Jun 17, 2:54 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
dom_walden added a comment to T225748: Fix block message for CompositeBlocks.

Are we fixing the mobile message in this bug?

Mon, Jun 17, 8:45 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management

Wed, Jun 12

dom_walden moved T220642: Only show the feedback link on Special:Block to users who can access the page from QA/Testing to Done on the Anti-Harassment (Lāmed - ל) board.

I don't see the link when I am an anonymous user or a non-admin user. I do when I am logged in as an admin.

Wed, Jun 12, 7:17 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management

Tue, Jun 11

dom_walden moved T223828: Redirects not appearing in New Page Patrol from QA to Product sign-off on the Community-Tech (Community-Tech-Kanban) board.

For a redirect that has been created either as a result of a page move or someone adding "#REDIRECT [[other_page]]".

Tue, Jun 11, 4:43 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Community-Tech (Community-Tech-Kanban), Regression, Growth-Team, PageCuration, English-Wikipedia-New-Pages-Patrol
dom_walden moved T219324: Update tools to use new actor storage from QA to Product sign-off on the Community-Tech (Community-Tech-Kanban) board.

Had their own tickets. Did not go into QA.

Tue, Jun 11, 4:32 PM · Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint
dom_walden moved T223340: [Bug] Image fails to load but no error message shows and Leaflet pretends to continue loading from QA to Product sign-off on the Community-Tech (Community-Tech-Kanban) board.

I was not able to reproduce this before. I cannot confirm it has been fixed now.

Tue, Jun 11, 4:23 PM · Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, SVG Translate Tool

Mon, Jun 10

dom_walden created T225450: [BUG] Prevent preview errors when leaving page.
Mon, Jun 10, 5:59 PM · Community-Tech (Community-Tech-Kanban), SVG Translate Tool
dom_walden moved T222932: Make error messages resulting from failed requests state clearly that it's a MediaWiki's fault not wsexport's from QA to Product sign-off on the Community-Tech (Community-Tech-Kanban) board.

The PDF from the github issue - https://tools.wmflabs.org/wsexport-test/book.php?lang=fr&format=pdf-a5&page=Manuel_des_principes_de_musique_(F%C3%A9tis) - returns:

Wikisource servers returned an error: PHP fatal error:
entire web request took longer than 60 seconds and timed out

Which is consistent with the error format from the description.

Mon, Jun 10, 10:31 AM · Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, E-Book-Export-Reliability
dom_walden moved T223337: Fix SVGTranslate's Docker from QA to Product sign-off on the Community-Tech (Community-Tech-Kanban) board.

I have managed to launch SVGTranslate on:
+ docker-compose version 1.21.0
+ docker version 18.09.6
On Debian Stretch and Buster.

Mon, Jun 10, 8:26 AM · Community-Tech (Community-Tech-Kanban), SVG Translate Tool

Fri, Jun 7

dom_walden updated subscribers of T221783: [BUG] Errors when previewing and downloading translation of StressEnergyTensor contravariant.svg.

I can no longer provoke the "An error occurred when fetching the preview..." popup when clicking download mid-translation, on either Firefox or Safari.

Fri, Jun 7, 12:56 PM · Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, SVG Translate Tool
dom_walden created T225293: [BUG][8 hours] Investigate why the SVGTranslate webservice needs to be restarted so often.
Fri, Jun 7, 10:33 AM · Community-Tech (Community-Tech-Kanban), Spike, SVG Translate Tool
dom_walden moved T221783: [BUG] Errors when previewing and downloading translation of StressEnergyTensor contravariant.svg from QA to Product sign-off on the Community-Tech (Community-Tech-Kanban) board.

I can no longer provoke the "An error occurred when fetching the preview..." popup when clicking download mid-translation, on either Firefox or Safari.

Fri, Jun 7, 10:08 AM · Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, SVG Translate Tool
dom_walden moved T222510: [BUG] Cannot download SVG if translation inputs are empty from QA to Product sign-off on the Community-Tech (Community-Tech-Kanban) board.

We can now download when no translation language is chosen and when there are no unsaved translations.

Fri, Jun 7, 9:56 AM · Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, SVG Translate Tool

Thu, Jun 6

dom_walden moved T207439: Size improvements for Curation toolbar from QA to Product sign-off on the Community-Tech (Community-Tech-Kanban) board.

Note for QA: In this iteration, I only changed the textareas auto-resize to a max of 12 lines. No other logic beyond that; the auto-resizing does not stop if it exceeds the viewport.

Thu, Jun 6, 4:09 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, PageCuration

Wed, Jun 5

dom_walden moved T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock from QA/Testing to Done on the Anti-Harassment (Kaf - כ) board.

Smoke testing on https://en.wikipedia.beta.wmflabs.org, including:

  • Blocking and unblocking via web and API.
  • Editing via API while partial blocked.
  • Moving title via API.
  • Looking at blocked user's (deleted) contrib.
  • Tested file upload while partially blocked from File.
Wed, Jun 5, 2:12 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-User-management
dom_walden added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

An anonymous IP block appears to block a logged in user from Special:CreateAccount. Not from any other action (that I have seen so far).

Wed, Jun 5, 1:06 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
dom_walden moved T222510: [BUG] Cannot download SVG if translation inputs are empty from Needs Review/Feedback to QA on the Community-Tech (Community-Tech-Kanban) board.
Wed, Jun 5, 12:10 PM · Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, SVG Translate Tool

Tue, Jun 4

dom_walden added a comment to T222932: Make error messages resulting from failed requests state clearly that it's a MediaWiki's fault not wsexport's.

@MaxSem I am seeing a few new errors on wsexport-test. Are they related to this work?

Tue, Jun 4, 9:27 AM · Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, E-Book-Export-Reliability
dom_walden created P8588 T222932: class not found.
Tue, Jun 4, 9:26 AM · E-Book-Export-Reliability
dom_walden created P8587 T222932: 414.
Tue, Jun 4, 9:25 AM · E-Book-Export-Reliability
dom_walden created P8586 T222932: 431.
Tue, Jun 4, 9:23 AM · E-Book-Export-Reliability

Mon, Jun 3

dom_walden moved T221371: 'Thanks' are completely blocked when a user is partially blocked from QA/Testing to Done on the Anti-Harassment (Kaf - כ) board.

While sitewide blocked I do not see any "Thank" links on the revision history of any page nor on Special:Log. I can thank revisions on my own User_talk, unless I am explicitly blocked.

Mon, Jun 3, 1:20 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Anti-Harassment (Kaf - כ), Growth-Team, Thanks
dom_walden moved T224613: Update Interaction Timeline to use the new actor table from QA/Testing to Done on the Anti-Harassment (Kaf - כ) board.

I tested the interaction timeline on test.wikipedia for some of my own test accounts and IP addresses (incl. IPv6). It returned the correct revisions (compared to the revision history on the wiki).

Mon, Jun 3, 10:35 AM · InteractionTimeline, Anti-Harassment (Kaf - כ)

Wed, May 29

dom_walden added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

Attempting to unblock an auto block (the IP that was autoblocked, not the username that was blocked):

Error from line 365 of /var/www/html/T206163/includes/Block.php: Call to a member function getType() on string
#0 /var/www/html/T206163/includes/Block.php(1143): Block::chooseMostSpecificBlock(Block)
#1 /var/www/html/T206163/includes/specials/SpecialUnblock.php(183): Block::newFromTarget(string)
#2 /var/www/html/T206163/includes/specials/SpecialUnblock.php(166): SpecialUnblock::processUnblock(array, RequestContext)
#3 /var/www/html/T206163/includes/htmlform/HTMLForm.php(675): SpecialUnblock::processUIUnblock(array, OOUIHTMLForm)
#4 /var/www/html/T206163/includes/htmlform/HTMLForm.php(567): HTMLForm->trySubmit()
#5 /var/www/html/T206163/includes/htmlform/HTMLForm.php(582): HTMLForm->tryAuthorizedSubmit()
#6 /var/www/html/T206163/includes/specials/SpecialUnblock.php(68): HTMLForm->show()
#7 /var/www/html/T206163/includes/specialpage/SpecialPage.php(570): SpecialUnblock->execute(NULL)
#8 /var/www/html/T206163/includes/specialpage/SpecialPageFactory.php(575): SpecialPage->run(NULL)
#9 /var/www/html/T206163/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#10 /var/www/html/T206163/includes/MediaWiki.php(865): MediaWiki->performRequest()
#11 /var/www/html/T206163/includes/MediaWiki.php(515): MediaWiki->main()
#12 /var/www/html/T206163/index.php(42): MediaWiki->run()

My guess:
newFromTarget() gets the list of blocks it passes to chooseMostSpecificBlock() from newListFromTarget(), but the latter does not return a list (as far as I can see).

Wed, May 29, 1:52 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
dom_walden added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

@Tchanders If there is an anonymous IP block and I am logged in on that IP, when I go to Special:CreateAccount I get a fatal error:

Error from line 1379 of /var/www/html/T206163/includes/user/User.php: Call to a member function getBlockForCookie() on null
Wed, May 29, 7:57 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management

Tue, May 28

dom_walden moved T224032: [BUG] Blocking from action "Editing their own talk page" is not effective unless "Editing" is also checked from QA/Testing to Done on the Anti-Harassment (Kaf - כ) board.

@dom_walden I agree - filed as T224468

Tue, May 28, 12:13 PM · MediaWiki-User-management, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Kaf - כ)
dom_walden moved T224294: Target language inputs should be dir=rtl when the language is RTL from QA to Product sign-off on the Community-Tech-Sprint board.

So since the fix touches only the tool's UX, and the file is rendered correctly, I think that this is probably fine, like you're saying.

Tue, May 28, 12:09 PM · Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, SVG Translate Tool

Mon, May 27

dom_walden added a comment to T224294: Target language inputs should be dir=rtl when the language is RTL.

Switched my keyboard mapping to Hebrew (il) and checked that it behaves appropriately (as far as my limited understanding of RTL goes[1]) for things like Hebrew mixed with numbers, times, parentheses, punctuation, whitespace and Hebrew mixed with English.

Mon, May 27, 10:31 AM · Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, SVG Translate Tool

Fri, May 24

dom_walden moved T189929: Add "previously deleted" as a possible issue in the New Pages Feed from QA to Product sign-off on the Community-Tech-Sprint board.

My guess is you checked before update.php was ran. It appears to be loading properly now.

Fri, May 24, 3:05 PM · Community-Tech (Community-Tech-Kanban), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Community-Tech-Sprint, Growth-Team, PageCuration, Collaboration-Team-Triage
dom_walden added a comment to T224032: [BUG] Blocking from action "Editing their own talk page" is not effective unless "Editing" is also checked.

Without JavaScript, this behaves similarly to making a partial block against editing a page: the admin can check the user talk checkbox, but it won't have an effect.

I guess the form has quite a few checkbox options that are ignored for certain combinations of parameters, which is made obvious for users with JS but not without. They can at least follow the Help link at the top of the page.

Fri, May 24, 10:48 AM · MediaWiki-User-management, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Kaf - כ)

Thu, May 23

dom_walden added a comment to T224032: [BUG] Blocking from action "Editing their own talk page" is not effective unless "Editing" is also checked.

How will this behave without JavaScript?

Thu, May 23, 8:36 AM · MediaWiki-User-management, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Kaf - כ)
dom_walden added a comment to T216245: VisualEditor, MobileFrontend, and other tools using action=edit do not auto-block IP addresses.

@dom_walden is T196575 a duplicate of this task or a different issue?

Thu, May 23, 8:31 AM · Editing QA, VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), MediaWiki-API

Wed, May 22

dom_walden added a comment to T189929: Add "previously deleted" as a possible issue in the New Pages Feed.

@MusikAnimal Going to https://en.wikipedia.beta.wmflabs.org/wiki/Special:NewPagesFeed the feed doesn't load and I get "ReferenceError: recreated is not defined".

Wed, May 22, 6:02 PM · Community-Tech (Community-Tech-Kanban), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Community-Tech-Sprint, Growth-Team, PageCuration, Collaboration-Team-Triage
dom_walden moved T221493: Reduce memory usage during e-book generation from QA to Product sign-off on the Community-Tech-Sprint board.

I did some load testing of wsexport-test, using ab to simulate concurrent requests (20, 30, 40, 50 concurrent requests at a time).

Wed, May 22, 3:04 PM · Community-Tech-Sprint, Community-Tech, E-Book-Export-Reliability
dom_walden added a comment to T213490: Takedown tools: Datepicker picking wrong dates, submitting totally different figures.

@dbarratt When the "Time" input is empty, if I click on it and select hour "14" it puts "13:26" (or whatever minute it is) into the input box. Perhaps it is converting to UTC, I think. But then, when I click "14" again it actually puts "14:26" into the input box.

Wed, May 22, 2:32 PM · Anti-Harassment (Lāmed - ל), Wikimedia-Takedown-Tools

Tue, May 21

dom_walden created T224046: $wgProxyList allows account create.
Tue, May 21, 5:06 PM · MediaWiki-User-management, MediaWiki-User-login-and-signup
dom_walden created T224032: [BUG] Blocking from action "Editing their own talk page" is not effective unless "Editing" is also checked.
Tue, May 21, 3:16 PM · MediaWiki-User-management, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Kaf - כ)
dom_walden closed T216279: [BUG] SVG Translate does not display all labels in the file as Resolved.

I cannot reproduce this. It looks very similar to what was fixed in T216283, as "Stapes" is not inside a <tspan>.

Tue, May 21, 12:31 PM · SVG Translate Tool
dom_walden moved T221335: Ensure wsexport logs all exceptions from QA to Product sign-off on the Community-Tech-Sprint board.

A little difficult to test. There is not much I can do.

Tue, May 21, 11:01 AM · Community-Tech-Sprint, Community-Tech, E-Book-Export-Reliability

Mon, May 20

dom_walden added a comment to T157046: Redirects with RfD tags should display in the feed under 'Nominated for deletion'.

@Niharika @joeroe @Insertcleverphrasehere Just to check I have understood the problem and that you are happy with our solution:

Mon, May 20, 1:09 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, Growth-Team, PageCuration

May 17 2019

dom_walden moved T216071: Namespaces multiselect widget selects an item on input change *before* filtering the items according to the changed input from QA/Testing to Done on the Anti-Harassment (Yōd - י) board.

Retesting on Firefox 60, Chromium 73, Edge and Safari 12. On https://en.wikipedia.beta.wmflabs.org.

May 17 2019, 11:38 AM · Anti-Harassment (Yōd - י), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26)

May 16 2019

dom_walden moved T208685: Page Curation toolbar: mark pages as 'reviewed' when adding AfD tags from QA to Product sign-off on the Community-Tech-Sprint board.

I have checked that articles get marked as unreviewed when tagging with one of "Speedy deletion", "Proposed deletion" or "Articles for deletion".

May 16 2019, 6:25 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, Growth-Team, PageCuration
dom_walden moved T209004: Deprecate User::isBlocked() from QA/Testing to Done on the Anti-Harassment (Yōd - י) board.

All the code changes appear to be replacing "$user->isBlocked()" with "$user->getBlock()", which should behave the same.

May 16 2019, 12:20 PM · Anti-Harassment (Yōd - י), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-User-management
dom_walden moved T214937: [BUG] Leaflet and image z-index is higher than the pop-up box from QA to Product sign-off on the Community-Tech-Sprint board.

I tested that the Translation/ULS dropdown and error popups appear over all other elements on the page (including the SVG image) on:

  • Mojave; Safari 12
  • High Sierra; Safari 11.1.2
  • Sierra; Safari 10.1.2
  • El Capitan; Safari 9.1.3
  • Win7 IE11
May 16 2019, 11:50 AM · Community-Tech-Sprint, Browser-Support-Apple-Safari, SVG Translate Tool
dom_walden moved T222330: Add environment configuration file from QA to Product sign-off on the Community-Tech-Sprint board.

Everything seems to be functioning correctly. The only QA here is to see if anything's broken (beyond normal).

May 16 2019, 10:35 AM · Community-Tech-Sprint, Community-Tech, E-Book-Export-Reliability
dom_walden moved T222510: [BUG] Cannot download SVG if translation inputs are empty from QA to In Development on the Community-Tech-Sprint board.

My reproduction steps may have confused things.

May 16 2019, 9:42 AM · Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, SVG Translate Tool
dom_walden moved T216283: [BUG] SVG translate does not recognize labels in text elements rather than tspan from QA to Product sign-off on the Community-Tech-Sprint board.

@dom_walden Good catch! @MaxSem Do you know if we deliberate limit the number of inputs based on number of tspan elements in the default translation and if it's possible to change it based on the number of tspans in the currently selected From translation?

May 16 2019, 9:14 AM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech
dom_walden moved T216209: [BUG] Do not upload file if there are no translations added from QA to Product sign-off on the Community-Tech-Sprint board.

As for T216209#5140591, if those are still happening, I think they might be unrelated and deserving of separate tickets.

May 16 2019, 9:02 AM · Community-Tech-Sprint, Community-Tech, SVG Translate Tool

May 15 2019

dom_walden added a comment to T208685: Page Curation toolbar: mark pages as 'reviewed' when adding AfD tags.

@Niharika Already reviewed pages which are marked for deletion now become unreviewed. I'm guessing that is good?

May 15 2019, 6:02 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, Growth-Team, PageCuration
dom_walden added a comment to T222855: Curl error setting certificate verify locations.

I have seen this for a couple of ebook exports:
https://tools.wmflabs.org/wsexport/tool/book.php?lang=fr&format=pdf-a5&page=Les_Merveilles_de_la_science
https://tools.wmflabs.org/wsexport/tool/book.php?lang=fr&format=pdf-a5&page=Dictionnaire_infernal/6e_%C3%A9d.,_1863

May 15 2019, 2:46 PM · tool-wscontest
dom_walden moved T213045: Preserve in-progress translations if user logs in or navigates away after adding translations from QA to Product sign-off on the Community-Tech-Sprint board.

@dom_walden Dropping this in the QA column for you in case there's any further QA work you want to do here. :) Thank you!

May 15 2019, 1:38 PM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech
dom_walden created T223380: [BUG] Previous translations sometimes appear in current translation.
May 15 2019, 1:35 PM · Community-Tech (Community-Tech-Kanban), SVG Translate Tool
dom_walden moved T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP from QA/Testing to Done on the Anti-Harassment (Yōd - י) board.

The BlockManager gets the block appropriate for the user or IP, including setting from cookies, XFF headers, etc.

May 15 2019, 11:36 AM · Anti-Harassment (Yōd - י), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Backlog (Watching / External), MediaWiki-User-management
dom_walden moved T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock from QA/Testing to Done on the Anti-Harassment (Yōd - י) board.

Are Blocks stored correctly in DB?

May 15 2019, 11:33 AM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-User-management

May 8 2019

dom_walden added a comment to T209599: Show block notices on mobile visual editor.

If I try to load visual editor on a page from which I am blocked, I get:

Error loading data from server: HTTP 500. Would you like to retry?

May 8 2019, 5:34 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Editing QA, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki

May 4 2019

dom_walden created T222510: [BUG] Cannot download SVG if translation inputs are empty.
May 4 2019, 1:43 PM · Community-Tech (Community-Tech-Kanban), Community-Tech-Sprint, SVG Translate Tool
dom_walden moved T220522: [BUG] "Argument 1 passed to App\Model\Svg\SvgFile::replaceIndicesRecursive() must be of the type string, null given" when Downloading from QA to Product sign-off on the Community-Tech-Sprint board.

I have not see this error in the last few weeks.

May 4 2019, 1:08 PM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech
dom_walden moved T221336: Undefined index: pages in Api.php from QA to Product sign-off on the Community-Tech-Sprint board.

Looking at the error and access logs on wsexport prod, I found a way to reproduce on production by navigating to: https://tools.wmflabs.org/wsexport-test/book.php?lang=ru&page=%D0%90%D0%BB%D0%B5%D0%BA%D1%81%D0%B0%D0%BD%D0%B4%D1%80_%D0%A1%D0%B5%D1%80%D0%B3%D0%B5%D0%B5%D0%B2%D0%B8%D1%87_%D0%9F%D1%83%D1%88%D0%BA%D0%B8%D0%BD&format=epub-3&fonts=freeserif

May 4 2019, 12:29 PM · Community-Tech-Sprint, Community-Tech, E-Book-Export-Reliability
dom_walden moved T221334: Cannot modify header information - headers already sent from QA to Product sign-off on the Community-Tech-Sprint board.

Going to https://tools.wmflabs.org/wsexport-test/book.php?refresh=true&lang= shows the form only once and there is no error in /data/project/wsexport-test/error.log.

May 4 2019, 10:39 AM · Community-Tech-Sprint, Community-Tech, E-Book-Export-Reliability

May 1 2019

dom_walden moved T220689: [BUG] Some translations not recognised from QA to Product sign-off on the Community-Tech-Sprint board.

I can no longer reproduce the bug in the description, https://tools.wmflabs.org/svgtranslate-test/File:USCG_Sentinel_class_cutter_poster.svg returns the appropriate translations.

May 1 2019, 2:52 PM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech
dom_walden moved T221334: Cannot modify header information - headers already sent from QA to In Development on the Community-Tech-Sprint board.
May 1 2019, 2:02 PM · Community-Tech-Sprint, Community-Tech, E-Book-Export-Reliability
dom_walden added a comment to T221334: Cannot modify header information - headers already sent.

@MaxSem I think the repro steps for this bug (or one way of reproducing this at least) is to navigate to https://tools.wmflabs.org/wsexport-test/book.php?refresh=true&lang=

May 1 2019, 1:57 PM · Community-Tech-Sprint, Community-Tech, E-Book-Export-Reliability
dom_walden moved T169120: Allow filtering by no citations in page curation from QA to Product sign-off on the Community-Tech-Sprint board.

Change appears very basic, relying on an existing SQL query.

May 1 2019, 12:59 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Community-Tech-Sprint, Community-Tech, Growth-Team, Collaboration-Team-Triage, PageCuration
dom_walden added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

@Tchanders I cherry-picked the two changesets in T206163#5110429 and T206163#5110430 on my local environment, and I have noticed that anonymous only blocks seem to get applied to users who are logged in. Not sure why.

May 1 2019, 11:55 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management

Apr 26 2019

dom_walden added a comment to T216209: [BUG] Do not upload file if there are no translations added.

A few more observations/potential bugs:

  1. Sometimes, if I have an unsaved translation, after logging in I cannot upload the translation to Commons (even after reloading the page or switching translation languages back and forth). I have seen this happen on FF60, FF66, Chromium 57.
  2. After successfully uploading a translation to Commons, I sometimes cannot upload a modified translation of the same language. I have seen this on FF60, FF66 and Chromium 57.

I have found can only get around the above two problems reliably by doing a hard refresh on the browser.

  1. If I switch to a translation which already exists in the SVG, without modifying it I can upload to Commons.
Apr 26 2019, 1:49 PM · Community-Tech-Sprint, Community-Tech, SVG Translate Tool
dom_walden created T221966: [BUG] Uncaught ReferenceError using the File search.
Apr 26 2019, 1:30 PM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech

Apr 25 2019

dom_walden added a comment to T213045: Preserve in-progress translations if user logs in or navigates away after adding translations.

=== Requirements

  • If a user navigates away (or their tab crashes etc) from the translate tab in the middle of adding translations, their translations for the image should be temporarily preserved (15 minutes is good enough). In case they had multiple in-progress translations, preserve translations for all of those.
Apr 25 2019, 12:27 PM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech

Apr 24 2019

dom_walden added a comment to T221425: Design studies for dark mode styles/color scheme.

I noticed on en.wikivoyage this use of colour in a legend.

Apr 24 2019, 4:24 PM · Dark-Mode

Apr 19 2019

dom_walden added a comment to T209004: Deprecate User::isBlocked().

I looked at https://codesearch.wmflabs.org/deployed/?q=isBlocked%5C(%5C)&i=nope&files=&repos=, which contains a subset of what @Reedy mentions.

Apr 19 2019, 2:39 PM · Anti-Harassment (Yōd - י), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-User-management
dom_walden added a comment to T208895: Ensure that anywhere BlockDisablesLogin is used, it does not affect partial blocks.

In passing, during T209004, I have found a couple of uses which might need to be changed:

Apr 19 2019, 2:19 PM · MediaWiki-User-management
dom_walden updated the task description for T221444: Partially blocked users cannot tag revisions on unrelated pages, nor add, deactive or delete tags.
Apr 19 2019, 12:44 PM · Patch-For-Review, MediaWiki-User-management, MediaWiki-Change-tagging
dom_walden updated the task description for T221444: Partially blocked users cannot tag revisions on unrelated pages, nor add, deactive or delete tags.
Apr 19 2019, 12:44 PM · Patch-For-Review, MediaWiki-User-management, MediaWiki-Change-tagging
dom_walden moved T208547: Just clicking on the empty space around should not change the type of block radio button selection from QA/Testing to Done on the Anti-Harassment (Heth - ח) board.

One line CSS change.

Apr 19 2019, 12:39 PM · User-Ryasmeen, OOUI (OOUI-0.31.4), Anti-Harassment (Heth - ח), MediaWiki-User-management
dom_walden moved T191549: Allow users to filter Special:BlockList on include/exclude partial blocks from QA/Testing to Done on the Anti-Harassment (Heth - ח) board.

I checked that filters were applied correctly for a combination of conditions (sitewide/partial, temporary, IP/Range/User).

Apr 19 2019, 12:31 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management
dom_walden updated the task description for T221444: Partially blocked users cannot tag revisions on unrelated pages, nor add, deactive or delete tags.
Apr 19 2019, 10:18 AM · Patch-For-Review, MediaWiki-User-management, MediaWiki-Change-tagging
dom_walden updated the task description for T221444: Partially blocked users cannot tag revisions on unrelated pages, nor add, deactive or delete tags.
Apr 19 2019, 10:16 AM · Patch-For-Review, MediaWiki-User-management, MediaWiki-Change-tagging
dom_walden created T221444: Partially blocked users cannot tag revisions on unrelated pages, nor add, deactive or delete tags.
Apr 19 2019, 10:15 AM · Patch-For-Review, MediaWiki-User-management, MediaWiki-Change-tagging

Apr 18 2019

dom_walden created T221382: [BUG] Some CSS selectors break translation input.
Apr 18 2019, 3:44 PM · SVG Translate Tool, Community-Tech
dom_walden moved T216568: [BUG] Image doesn't render and "Language settings" link disappears from QA to Product sign-off on the Community-Tech-Sprint board.

I have not seen this happen on staging so far this morning.

Apr 18 2019, 8:22 AM · Community-Tech-Sprint, Community-Tech, SVG Translate Tool
dom_walden added a comment to T220954: [BUG] Both "English" and "Simple English" translations appear in language dropdown as "English".

I don't know how to check :/ Is https://commons.wikimedia.org/wiki/File:Chemnitz_Verkehr.svg an example? SVG Translate sees "simple" as one of the source languages. I did notice there's no dropdown on the File page to change the language from English to Simple English, as you would see with other multilingual SVGs, e.g. https://commons.wikimedia.org/wiki/File:Scheme_ant_worker_anatomy-en.svg

Apr 18 2019, 7:54 AM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech

Apr 17 2019

dom_walden moved T220618: [BUG] TypeError: appConfig.translations[a][o.getValue(...)] is undefined from QA to Product sign-off on the Community-Tech-Sprint board.

I have not seen this error anymore on staging or production.

Apr 17 2019, 3:24 PM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech
dom_walden added a comment to T216209: [BUG] Do not upload file if there are no translations added.

When entering or removing text, I find a 1-2 second delay before the state of "Upload to commons" is updated. This gives me a window in which I can upload a duplicate image, giving the same error as T216209#5107613.

Apr 17 2019, 11:46 AM · Community-Tech-Sprint, Community-Tech, SVG Translate Tool
dom_walden moved T220562: Add link to indicate users need to login before they can upload from QA to Product sign-off on the Community-Tech-Sprint board.

When logged out, there is a link "Log in to enable uploading". This takes a user to /svgtranslate-test/login.

Apr 17 2019, 10:18 AM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech
dom_walden moved T220560: [BUG] Font doesn't render on SVG Translate from QA to Product sign-off on the Community-Tech-Sprint board.

Checked the image in the description and a couple of others I have seen this problem with previously (here, here and here).

Apr 17 2019, 10:12 AM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech

Apr 16 2019

dom_walden closed T215690: [BUG] Labels appear in different font size than the image on Commons as Resolved.
Apr 16 2019, 4:11 PM · Community-Tech-Sprint, Community-Tech, SVG Translate Tool
dom_walden closed T215690: [BUG] Labels appear in different font size than the image on Commons, a subtask of T215835: [Epic] Problems with image rendering on SVG Translate, as Resolved.
Apr 16 2019, 4:11 PM · Epic, SVG Translate Tool
dom_walden added a project to T215690: [BUG] Labels appear in different font size than the image on Commons: Community-Tech-Sprint.
Apr 16 2019, 4:10 PM · Community-Tech-Sprint, Community-Tech, SVG Translate Tool
dom_walden moved T215690: [BUG] Labels appear in different font size than the image on Commons from To be estimated/discussed to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.

I was not able to reproduce this on staging or production, using the SVGs in the description.

Apr 16 2019, 4:10 PM · Community-Tech-Sprint, Community-Tech, SVG Translate Tool
dom_walden closed T213939: [BUG] Fix weird color changing issues with PNGs generated in SVG Translate as Resolved.
Apr 16 2019, 4:08 PM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech
dom_walden closed T213939: [BUG] Fix weird color changing issues with PNGs generated in SVG Translate, a subtask of T215835: [Epic] Problems with image rendering on SVG Translate, as Resolved.
Apr 16 2019, 4:08 PM · Epic, SVG Translate Tool
dom_walden moved T213939: [BUG] Fix weird color changing issues with PNGs generated in SVG Translate from Ready to Done on the Community-Tech-Sprint board.
Apr 16 2019, 4:07 PM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech
dom_walden moved T213939: [BUG] Fix weird color changing issues with PNGs generated in SVG Translate from Backlog to Done on the SVG Translate Tool board.
Apr 16 2019, 4:07 PM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech
dom_walden moved T213939: [BUG] Fix weird color changing issues with PNGs generated in SVG Translate from To be estimated/discussed to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.

I was not able to reproduce this on staging or production, using the svg in the description. I also compared the SVG downloaded from svgtranslate with the one from Commons. The <tspan> style attribute is being preserved correctly.

Apr 16 2019, 4:06 PM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech
dom_walden moved T215580: [BUG] Labels for image keep jumping outside the image frame from QA to Product sign-off on the Community-Tech-Sprint board.

On staging, I did not notice any dramatic differences in rendering of text between svgtranslate and Commons, or anything that looked obviously wrong (like the image in the description).

Apr 16 2019, 3:59 PM · Community-Tech-Sprint, Community-Tech, SVG Translate Tool
dom_walden moved T218747: Fix database-reports tool from QA to Product sign-off on the Community-Tech-Sprint board.

Looking at the revision history of the reports in https://en.wikipedia.org/wiki/User:Community_Tech_bot, I see all the reports have been updated in the last 7 days. I guess that means the cron is working.

Apr 16 2019, 8:07 AM · Community-Tech-Sprint, Community-Tech

Apr 15 2019

dom_walden created T220954: [BUG] Both "English" and "Simple English" translations appear in language dropdown as "English".
Apr 15 2019, 10:48 AM · Community-Tech-Sprint, SVG Translate Tool, Community-Tech