Page MenuHomePhabricator

dom_walden (Dom Walden)
Test Engineer for Community Tech and Anti-Harassment Teams

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2018, 4:33 PM (51 w, 7 h)
Availability
Available
LDAP User
Dom Walden
MediaWiki User
Dom walden [ Global Accounts ]

Recent Activity

Thu, Oct 10

dom_walden moved T232215: WWT: Support Hidden Contributor Names from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

For hidden contributors, the revision details popup now looks like:

Thu, Oct 10, 11:53 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Wed, Oct 9

dom_walden moved T234073: Don't allow requeueing main page from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

With my Admin user ("Dom walden") on both https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page and https://test.wikipedia.org/wiki/Main_Page I cannot see the "Add to the New Pages Feed" link.

Wed, Oct 9, 4:57 PM · Community-Tech (Kanban-Q2-2019-20), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), User-DannyS712, PageCuration, Growth-Team
dom_walden moved T234574: Enqueue: Don't allow enqueueing pages in unsupported namespaces from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

On beta, using the API I am able to enqueue pages in the Article, User and Draft namespaces. These are the only supported namespaces on beta.

Wed, Oct 9, 4:44 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Community-Tech (Kanban-Q2-2019-20), User-DannyS712, PageCuration, Growth-Team
dom_walden moved T234587: Enqueue: Don't allow enqueueing a page already in the queue from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Using the API, I cannot requeue pages in the Article, User or Draft namespaces that are already in the queue.

Wed, Oct 9, 3:58 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), User-DannyS712, Community-Tech (Kanban-Q2-2019-20), PageCuration, Growth-Team
dom_walden moved T232694: Turn the PasswordReset class into a service from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

I am not sure I can do much here to test this. However, as I tested T232512 and PasswordReset appears to be working fine, I am going to say this task is OK as well.

Wed, Oct 9, 12:17 PM · MW-1.34-notes, Community-Tech (Kanban-Q2-2019-20), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Password-Reset-Update
dom_walden moved T232512: Password Reset: Inform Users of Preference on Special:PasswordReset [small] from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

Acceptance Criteria:

  • If a user attempts to enter information in one field (i.e. username or email address) rather than both fields when the password reset preference is enabled for the associated account, a message should appear at the top of the page: "Both username and email address are required to receive a temporary password via email."
Wed, Oct 9, 12:15 PM · Community-Tech (Kanban-Q2-2019-20), Password-Reset-Update
dom_walden moved T233594: Allow cookie-block tracking from any uncached web request from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Comparing the headers returned by https://en.wikipedia.beta.wmflabs.org and http://test.wikipedia.org/ for as many pages as I could find (mostly special pages).

Wed, Oct 9, 10:54 AM · Performance-Team (Radar), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, Anti-Harassment (The Letter Song)
dom_walden created T235050: RawAction not setting block cookies.
Wed, Oct 9, 10:39 AM · MediaWiki-User-management, Anti-Harassment
dom_walden created T235047: RedirectSpecialPage not setting block cookies.
Wed, Oct 9, 10:34 AM · MediaWiki-User-management, Anti-Harassment

Tue, Oct 8

dom_walden added a comment to T233594: Allow cookie-block tracking from any uncached web request.

It looks like instances of RedirectSpecialPage and ActionRaw are not getting the block cookies. For RedirectSpecialPage I'm not sure this is an issue because the user will get the cookies after the redirect is complete...

Tue, Oct 8, 5:58 PM · Performance-Team (Radar), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, Anti-Harassment (The Letter Song)
dom_walden added a comment to T233594: Allow cookie-block tracking from any uncached web request.

For logged in users with autoblocks against their accounts

Is the block against the user or against the IP address? I was under the impression that logging in would bypass the autoblock (unless your user account is the target of the block).

Tue, Oct 8, 3:22 PM · Performance-Team (Radar), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, Anti-Harassment (The Letter Song)
dom_walden updated subscribers of T233594: Allow cookie-block tracking from any uncached web request.

@Krinkle @Tchanders @dbarratt For logged in users with autoblocks against their accounts, I think there are a few places we are missing setting block cookies:

  • Special:AllMyUploads
  • Special:MyContributions
  • Special:MyLanguage
  • Special:MyTalk
  • Special:MyPage
  • action=raw
Tue, Oct 8, 3:05 PM · Performance-Team (Radar), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, Anti-Harassment (The Letter Song)
dom_walden added a comment to T231357: Page Curation should create a new AfD discussion page if one already exists.

@MaxSem I cannot get this to work on beta for Miscellany for Deletion (for User namespace pages).

Tue, Oct 8, 2:03 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Community-Tech (Kanban-Q2-2019-20), Growth-Team, PageCuration
dom_walden moved T234861: Enable password reset improvements in betalabs from QA to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.

The new checkbox appears in Special:Preferences in https://en.wikipedia.beta.wmflabs.org.

Tue, Oct 8, 10:12 AM · Community-Tech (Kanban-Q2-2019-20), Password-Reset-Update

Mon, Oct 7

dom_walden added a comment to T231577: Deploy Special:Mute features.
Mon, Oct 7, 6:54 PM · Anti-Harassment (The Letter Song), Epic
dom_walden added a comment to T233594: Allow cookie-block tracking from any uncached web request.

@Krinkle After this change, on my local machine I am seeing more pages return Cache-Control: no-cache, no-store, max-age=0, must-revalidate (where before they would return something like private, must-revalidate, max-age=0).

Mon, Oct 7, 4:24 PM · Performance-Team (Radar), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, Anti-Harassment (The Letter Song)

Wed, Oct 2

dom_walden added a comment to T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets.

Which hooks get fired for which actions:

Actionarticleinfomarktagsdelete
Opening "Page info" flyoutx
Reviewed or unreviewedxx
Adding Tagxx
Speedy deletionx
Proposed deletionx
Article for deletion
Miscellany for deletion
WikiLove
"Add a message for the creator"
Wed, Oct 2, 5:55 PM · Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration
dom_walden added a comment to T233164: Correct the display of user attribution percentages in the popup.

Great, thanks for the update, @HMonroy! I'm tagging @dom_walden, so he's aware of the status as well.

Wed, Oct 2, 5:49 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T231577: Deploy Special:Mute features from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Testing on:

Wed, Oct 2, 4:47 PM · Anti-Harassment (The Letter Song), Epic

Tue, Oct 1

dom_walden added a comment to T232093: Investigate: Curation toolbar not advancing [4 hours].

This suggests to me that perhaps the problem is the missing metadata. I have tried to find pages in the queue with missing metadata, but have yet to be able to reproduce the problem.

Tue, Oct 1, 2:32 PM · Community-Tech (Kanban-Q2-2019-20), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-DannyS712, English-Wikipedia-New-Pages-Patrol, Growth-Team, PageCuration

Thu, Sep 26

dom_walden moved T233509: Enqueueing a page marks it as unreviewed without logging it as such from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Now, when enqueuing an article (clicking Add to the New Pages Feed), in Special:Log we log the fact that the article's state is unreviewed:

Thu, Sep 26, 4:58 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Community-Tech (Kanban (Q1 2019-20)), User-DannyS712, Growth-Team, PageCuration

Wed, Sep 25

dom_walden added a comment to T231595: Implement Proper Link Support for WWT.

@dom_walden & @Samwilson:
When I tested links in templates, they seemed to (at least sometimes) still work. For example, on this page (https://en.wikipedia.org/wiki/SOLRAD_2). I clicked on " Solar X-Ray," and I was redirected to the https://en.wikipedia.org/wiki/X-ray_astronomy#Stellar_X-ray_astronomy. Was this because it was not only a new page, but it was also a jump within the page (so perhaps the code didn't recognize it in the same way)?

Wed, Sep 25, 6:37 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Mon, Sep 23

dom_walden added a comment to T232460: [BUG] Unresponsive script when loading articles in non-default language [8 hours].

@dom_walden I just re-tested this in an effort to figure out what's going on, and I can no longer reproduce it...
Can you retest? I tested both the extension and user script.

Mon, Sep 23, 11:35 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden added a comment to T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets.

@MusikAnimal @Mooeypoo There is an odd behaviour I cannot understand. After opening the "Page info" flyout the articleinfo hook fires, which is fine. But afterwards, each time I mark the page reviewed/unreviewed (without refreshing), the articleinfo hook also fires. First time once, second time twice, third time 4 times, then 8, etc.

Mon, Sep 23, 10:58 AM · Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration

Fri, Sep 20

dom_walden added a comment to T231990: Spike: Internal links, Files, etc. may not show accurate contributor information [4 hours].

A particularly bad example is the link [[Olympia]] in the fourth sentence here: https://tr.wikipedia.org/w/index.php?title=%C3%89douard_Manet. In the revision details we attribute that link to a revision which does not even include the word "Olympia".

Fri, Sep 20, 12:24 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T231595: Implement Proper Link Support for WWT from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Acceptance Criteria:

  • Links in the article content should not work (i.e. they do not redirect users to other pages)
  • Links in the templates should not work (i.e. they do not redirect users to other pages)
Fri, Sep 20, 12:09 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
dom_walden moved T232211: IPv6 contributions get cut off in revision details popup from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Wrapping looks good for IPv6 and long usernames as well.

Fri, Sep 20, 11:32 AM · Community-Tech (Kanban (Q1 2019-20)), IPv6, Who-Wrote-That

Thu, Sep 19

dom_walden moved T226070: Move usage logs from Sqlite to MariaDB from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

As Sam has tested the import script in T226070#5466961, and the latest patch only affects import, there is no more testing I can think of doing.

Thu, Sep 19, 3:19 PM · Community-Tech (Kanban (Q1 2019-20)), E-Book-Export-Reliability

Wed, Sep 18

dom_walden updated the task description for T232131: [BUG] WWT breaks or removes some article elements.
Wed, Sep 18, 4:52 PM · Who-Wrote-That, Community-Tech
dom_walden added a comment to T232460: [BUG] Unresponsive script when loading articles in non-default language [8 hours].

@ifried Are you using the gadget? I was using the extension. I tried briefly with the gadget, but could not reproduce either.

Wed, Sep 18, 4:47 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T228941: Add Edit Summary to Revision Details Pop-up (WWT) from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

The edit summary and number of bytes changed is now shown in the Revision Details Popup.

Wed, Sep 18, 4:23 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
dom_walden added a comment to T232232: Spike: Investigate Errors Upon First Load in WWT [8 hours].

Also, I am not sure what happens when we hit WikiWho API's request limit. From https://api.wikiwho.net/:

Currently, there is a limit of 2000 requests/day for unregistered users, and also a 60 requests/minute limit for all users.

Wed, Sep 18, 2:20 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T231959: Image thumbnails show "undefined" as the author from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Bug in description no longer appears to occurs.

Wed, Sep 18, 12:57 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Tue, Sep 17

dom_walden moved T167475: Allow filtering by date range in Special:NewPagesFeed from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Acceptance Criteria:

  • Create a new section entitled "Date range" (in bold) in the filters view, which should appear below "Potential Issues"
Tue, Sep 17, 2:33 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Community-Tech (Kanban (Q1 2019-20)), Growth-Team, PageCuration
dom_walden created T233091: Revision Details Pop-up sometimes in wrong place .
Tue, Sep 17, 9:54 AM · Who-Wrote-That, Community-Tech

Mon, Sep 16

dom_walden updated the task description for T232215: WWT: Support Hidden Contributor Names.
Mon, Sep 16, 3:43 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden added a comment to T232232: Spike: Investigate Errors Upon First Load in WWT [8 hours].

One other error condition I have seen is where WhoColor identifies a revision as vandalism, returning a 200 response with payload like:

{
info: Requested revision (777478614) is detected as vandalism by WikiWho.
success: false
...
}
Mon, Sep 16, 3:26 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T207452: Flag talk page feedback in toolbar from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Now both the badges for number of possible issues and the number of previous comments don't get in the way of the Page info icon.

Mon, Sep 16, 2:45 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Community-Tech (Kanban (Q1 2019-20)), PageCuration, Growth-Team
dom_walden added a comment to T232093: Investigate: Curation toolbar not advancing [4 hours].

Okay, so I did some debugging:
Steps to reproduce: sort by oldest first in the feed, view the oldest, and try to advance

Mon, Sep 16, 1:33 PM · Community-Tech (Kanban-Q2-2019-20), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-DannyS712, English-Wikipedia-New-Pages-Patrol, Growth-Team, PageCuration
dom_walden moved T221682: Improve Block handling where User::isBlocked() was used previously from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

There does not appear to be any testing necessary for this task on its own.

Mon, Sep 16, 10:04 AM · Epic, Anti-Harassment (The Letter Song), Technical-Debt, MediaWiki-User-management
dom_walden moved T231919: Don't pass global request object into BlockManager::getUserBlock constructor from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

I have briefly retested some blocking functionality, just in case regressions have been introduced.

Mon, Sep 16, 10:03 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-User-management, Anti-Harassment (The Letter Song)
dom_walden moved T228486: Partially blocked users cannot delete revisions from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Admin (who has blocked themself) can delete and undelete revisions via Special:RevisionDelete if partially blocked.

Mon, Sep 16, 9:45 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, Patch-For-Review, Anti-Harassment (The Letter Song), Technical-Debt, MediaWiki-User-management

Sep 13 2019

dom_walden moved T231359: Update Exit Functionality of WWT from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

I tested closing from the sidebar and from the Infobar on Firefox 60, Chromium 73 and Safari 12.

Sep 13 2019, 8:39 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Sep 12 2019

dom_walden updated the task description for T232131: [BUG] WWT breaks or removes some article elements.
Sep 12 2019, 4:51 PM · Who-Wrote-That, Community-Tech
dom_walden created T232758: Infobar covers up article coordinates.
Sep 12 2019, 4:33 PM · Who-Wrote-That, Community-Tech
dom_walden added a comment to T207485: Enable page curation tools to be loaded on any page (optionally).

@Niharika, @Mooeypoo - Note that at one point there was a cron-jobbed maintenance script (updatePageTriageQueue.php) running on the production servers that automatically removed any pages from the pagetriage_page table...

Sep 12 2019, 1:46 PM · Community-Tech (Kanban-Q2-2019-20), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), PageCuration, Growth-Team

Sep 11 2019

dom_walden moved T221444: Partially blocked users cannot tag revisions on unrelated pages, nor add, deactive or delete tags from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Special:EditTags (or the action=editchangetags from the revision history page)

  • Can add tags to revisions of pages unless blocked from that page or its namespace
  • If sitewide blocked, cannot tag a revision unless it is of user's own User_talk (and user is not blocked from latter)
Sep 11 2019, 5:01 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management, MediaWiki-Change-tagging
dom_walden created T232568: Should hidden users' group memberships be shown in Special:UserRights?.
Sep 11 2019, 7:50 AM · MediaWiki-User-management
dom_walden added a comment to T231417: [BUG] Article content removed the second time a user closes the tool.

@dom_walden I was able to reproduce the bug on English Wikipedia. Should I be testing on some other environment?

Sep 11 2019, 7:04 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Sep 10 2019

dom_walden created T232490: Highlighting cuts off font kerning.
Sep 10 2019, 3:40 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden added a comment to T228941: Add Edit Summary to Revision Details Pop-up (WWT).

I am seeing a difference in how popups position themselves on the page, possibly related to this change.

Sep 10 2019, 3:22 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
dom_walden updated the task description for T231424: WWT: Original article HTML not necessarily preserved (was: Images have their links changed from Commons to local) [medium].
Sep 10 2019, 11:21 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden created T232460: [BUG] Unresponsive script when loading articles in non-default language [8 hours].
Sep 10 2019, 11:18 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T231417: [BUG] Article content removed the second time a user closes the tool from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

I can no longer reproduce the original bug, even if closing and opening the tool multiple times.

Sep 10 2019, 10:28 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
dom_walden updated the task description for T231424: WWT: Original article HTML not necessarily preserved (was: Images have their links changed from Commons to local) [medium].
Sep 10 2019, 10:20 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden renamed T231424: WWT: Original article HTML not necessarily preserved (was: Images have their links changed from Commons to local) [medium] from [BUG] Images have their links changed from Commons to local to Original article HTML not necessarily preserved (was: Images have their links changed from Commons to local).
Sep 10 2019, 10:05 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden moved T226761: Add Ability to Toggle on/off WhoWroteThat from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

• The "Who Wrote That" link should be the last in the order of tools (i.e. do not change the current order)

Except on https://tr.wikipedia.org/wiki/, where it is second last...
...Do we mind?

Sep 10 2019, 7:47 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
dom_walden moved T226772: Add "Guided Tour" Pop-Up (first time users) for Who Wrote That from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Requirements:

  • Add a Guided tour style pop-up (first-time use only until dismissal)
  • The pop-up should appear after the extension is installed
  • Include the following header text in the pop-up: "Who Wrote That? installed!"
Sep 10 2019, 7:46 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Sep 9 2019

dom_walden moved T228539: Partially blocked users should not be prevented from using the importImages maintenance script from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

I tested calling php maintenance/importImages.php from the command-line with the --check-userblock parameter (which tells it to check if the user is blocked) and --user $user, where $user had a variety of blocks.

Sep 9 2019, 1:51 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Epic, Anti-Harassment (The Letter Song), Technical-Debt, MediaWiki-User-management
dom_walden moved T232004: NamespaceInfo::$canonicalNames is missing NS_MAIN from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Checking out the WIP patches from T200938, after this change blocks including the Main namespace are displayed in Special:CentralAuth as a separate bullet point (Main).

Sep 9 2019, 12:51 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Anti-Harassment (The Letter Song), MediaWiki-General

Sep 6 2019

dom_walden moved T231960: IP contributions are prefixed with 0| and the links are broken from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

IP addresses display correctly in the revision details popup. The "talk" and "contribs" links are correct.

Sep 6 2019, 2:08 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
dom_walden created T232215: WWT: Support Hidden Contributor Names.
Sep 6 2019, 1:45 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden created T232211: IPv6 contributions get cut off in revision details popup.
Sep 6 2019, 12:01 PM · Community-Tech (Kanban (Q1 2019-20)), IPv6, Who-Wrote-That

Sep 5 2019

dom_walden created T232131: [BUG] WWT breaks or removes some article elements.
Sep 5 2019, 5:47 PM · Who-Wrote-That, Community-Tech
dom_walden moved T228803: Add Revision Details Pop-up (WWT) from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Acceptance Criteria:

  • When WWT is activated, disable all links in the content area.
Sep 5 2019, 4:45 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
dom_walden created T232097: Add support for templates.
Sep 5 2019, 1:30 PM · Who-Wrote-That, Community-Tech
dom_walden moved T228948: PermissionManager::isBlockedFrom() can return true even if the user does not have a block from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Regression (testing changes made to AbstractBlock and DatabaseBlock):

  • Can create a hidden block, gets applied to user correctly when editing an article.
Sep 5 2019, 11:34 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden added a comment to T231990: Spike: Internal links, Files, etc. may not show accurate contributor information [4 hours].

Also affects Category tags.

Sep 5 2019, 9:23 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden added a comment to T232064: Gallery tag broken by WWT.

I believe this is due to this bug I raised: https://github.com/wikiwho/WhoColor/issues/17

Sep 5 2019, 9:22 AM · Who-Wrote-That
dom_walden added a comment to T231959: Image thumbnails show "undefined" as the author.

It also appears to affect Category tags (bottom of https://de.wikipedia.org/w/index.php?title=Totem_Pole_(Monument_Valley)&oldid=191968433, #token-1797).

Sep 5 2019, 9:20 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Sep 4 2019

dom_walden moved T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Thanks @dom_walden for explaining. I agree that it seems like we have fixed a bug here. I think we should make a note that we found the behavior wasn't as expected and we fixed it with this ticket on the extension talk page (https://www.mediawiki.org/wiki/Extension_talk:TorBlock) so third party users who might be active there can see it.

Sep 4 2019, 3:06 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-TorBlock, MediaWiki-User-management
dom_walden created T231990: Spike: Internal links, Files, etc. may not show accurate contributor information [4 hours].
Sep 4 2019, 1:44 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Sep 3 2019

dom_walden created T231867: [BUG] CentralAuth hide/suppress does not block Special:EmailUser.
Sep 3 2019, 12:37 PM · MediaWiki-Email, MediaWiki-User-management, MediaWiki-extensions-CentralAuth

Sep 2 2019

dom_walden added a comment to T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension.

But, it will change the behaviour of default installs.

@dom_walden It was our intention to keep the conditions for removing a block the same with this patch (so IP blocks are removed because they were removed before). Is there something that we've inadvertently changed?

Sep 2 2019, 4:39 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-TorBlock, MediaWiki-User-management
dom_walden moved T226760: Support Loading State & Error Behavior for Who Wrote That from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.
  • The text (in white) should read (as default) "API Error: Please refresh the page or try again later."
  • For 200 OK, the text should read: "API Error: Please try again later."
Sep 2 2019, 4:33 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
dom_walden updated subscribers of T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension.

By setting $wgTorDisableAdminBlocks = true (which is default), any IP blocks that coincide with Tor exit nodes will not get applied, including System blocks.

Sep 2 2019, 3:44 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-TorBlock, MediaWiki-User-management

Aug 30 2019

dom_walden updated subscribers of T228950: Replace UserIsHidden with GetUserBlock in CentralAuth.

If a user is hidden via Special:CentralAuth, any blocks they have (unless they are hidden blocks) will be overridden by a system block.

Aug 30 2019, 6:31 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), MediaWiki-extensions-CentralAuth

Aug 29 2019

dom_walden added a comment to T231541: Add a #pagetriage revision tag to wikilove edits made using PageTriage.

Good catch.

Aug 29 2019, 11:52 AM · patch-welcome, User-DannyS712, PageCuration, WikiLove, Growth-Team
dom_walden moved T228669: Add #pagetriage tag to potential copyright violation log entries from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

The changes above bring copyright violation logging in alignment with how we log other PageTriage actions.

Aug 29 2019, 11:09 AM · Community-Tech (Kanban (Q1 2019-20)), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), User-DannyS712, PageCuration, Growth-Team
dom_walden moved T207452: Flag talk page feedback in toolbar from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Testing on Firefox 60, Safari 12 and IE11, Sam's latest patch looks fine. If you click on the part of the mail icon which overlaps the round "i" button will open the "Page Info" flyout.

Aug 29 2019, 10:41 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Community-Tech (Kanban (Q1 2019-20)), PageCuration, Growth-Team

Aug 28 2019

dom_walden moved T226743: Use the WhoColor API to gather necessary data from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

• Query the WhoColor API for the new DOM (marked up)

Aug 28 2019, 4:46 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
dom_walden updated the task description for T231424: WWT: Original article HTML not necessarily preserved (was: Images have their links changed from Commons to local) [medium].
Aug 28 2019, 1:32 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden created T231427: [BUG] Internal error "Invalid option newbies" on Special:NewFiles.
Aug 28 2019, 10:37 AM · User-DannyS712, Beta-Cluster-reproducible, MediaWiki-Special-pages
dom_walden added a comment to T226761: Add Ability to Toggle on/off WhoWroteThat.

Requirement:
• Add a link/button to toggle WhoWroteThat view on/off on the sidebar, under "Tools"

Aug 28 2019, 9:44 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
dom_walden created T231424: WWT: Original article HTML not necessarily preserved (was: Images have their links changed from Commons to local) [medium].
Aug 28 2019, 9:41 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
dom_walden created T231417: [BUG] Article content removed the second time a user closes the tool.
Aug 28 2019, 8:12 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Aug 27 2019

dom_walden updated the task description for T231285: [BUG] cURL error 18: transfer closed with outstanding read data remaining.
Aug 27 2019, 9:40 AM · SVG Translate Tool, Community-Tech
dom_walden updated the task description for T231285: [BUG] cURL error 18: transfer closed with outstanding read data remaining.
Aug 27 2019, 9:40 AM · SVG Translate Tool, Community-Tech
dom_walden created T231285: [BUG] cURL error 18: transfer closed with outstanding read data remaining.
Aug 27 2019, 9:38 AM · SVG Translate Tool, Community-Tech

Aug 23 2019

dom_walden moved T226468: [BUG] Block cookie interprets block expiry in local timezone: should be UTC from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

Expiry date of block cookies (when looked at in the browser) is the same as the blocks expiry date (after normalising the timezone).

Aug 23 2019, 3:25 PM · Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden updated the task description for T231075: [BUG] Deal more helpfully with users who do not have the reupload right.
Aug 23 2019, 12:37 PM · SVG Translate Tool, Community-Tech
dom_walden created T231075: [BUG] Deal more helpfully with users who do not have the reupload right.
Aug 23 2019, 12:30 PM · SVG Translate Tool, Community-Tech

Aug 22 2019

dom_walden moved T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

thanks @dom_walden ! So are we fine to conclude this is now resolved?

Aug 22 2019, 2:58 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), User-Noarave, Anti-Harassment (The Letter Song), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, MediaWiki-extensions-WikibaseRepository, Wikidata
dom_walden moved T227678: Clear block cookie if the value is invalid from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

If I attempt to modify a block cookie (e.g. changing the hash value, block id, invalid format) it gets cleared when I attempt to edit a page (either using VisualEditor or source editor) or create an account.

Aug 22 2019, 1:49 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Anti-Harassment (The Letter Song), MediaWiki-User-management
dom_walden added a comment to T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.

Oversight on my part, it looks like the creation code (in both patches) is using AbstractBlock::isSitewide() instead of AbstractBlock::appliesToNamespace() (as is outlined in the task description). Using the former means that someone who is blocked from a namespace will be allowed to create an item in that namespace, using the latter will ensure they are blocked properly from that namespace.

Aug 22 2019, 11:21 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), User-Noarave, Anti-Harassment (The Letter Song), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, MediaWiki-extensions-WikibaseRepository, Wikidata
dom_walden moved T224958: Instrument Special:Mute from QA/Testing to Done on the Anti-Harassment (The Letter Song) board.

When I submit the Special:Mute page on beta, on deployment-eventlog05.deployment-prep.eqiad.wmflabs I see the event logged in /srv/log/eventlogging/all-events.log as:

{
  "dt": "2019-08-21T15:27:53Z",
  "event": {
    "emailsAfter": true,
    "emailsBefore": false,
    "notificationsAfter": true,
    "notificationsBefore": false
  },
  "ip": "172.16.4.119",
  "recvFrom": "deployment-cache-text05.deployment-prep.eqiad.wmflabs",
  "revision": 19265572,
  "schema": "SpecialMuteSubmit",
  "seqId": 6204900,
  "userAgent": {
    "browser_family": "Firefox",
    "browser_major": "60",
    "browser_minor": "0",
    "device_family": "Other",
    "is_bot": false,
    "is_mediawiki": false,
    "os_family": "Linux",
    "os_major": null,
    "os_minor": null,
    "wmf_app_version": "-"
  },
  "uuid": "d52b1f9858bf5ff59e00d58f151cee20",
  "webHost": "en.wikipedia.beta.wmflabs.org",
  "wiki": "enwiki"
}
Aug 22 2019, 9:32 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, Anti-Harassment (The Letter Song)

Aug 20 2019

dom_walden moved T226771: Implement Information Bar for Who Wrote That from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Requirements:

  • When WWT is activated, a blue information bar should appear at the top of the article.
  • The information bar should be displayed below the links ("Read," "Edit," "View History," "Article," or "Talk") and above the article title.
Aug 20 2019, 7:36 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
dom_walden moved T207443: Feedback for creator should also be posted to article talk page from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.

Testing on https://en.wikipedia.beta.wmflabs.org/wiki/

Aug 20 2019, 2:26 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Community-Tech (Kanban (Q1 2019-20)), PageCuration, Growth-Team
dom_walden updated subscribers of T226070: Move usage logs from Sqlite to MariaDB.

On wsexport-test, I created a number of pdf/epubs/etc. and saw the statistics rise as appropriate.

Aug 20 2019, 10:36 AM · Community-Tech (Kanban (Q1 2019-20)), E-Book-Export-Reliability

Aug 15 2019

dom_walden added a comment to T230357: SVG Translate: Provide Error Message (no support for tspan without coordinates).

Might this be another example of the issue discussed in this bug T216283#5133746?

Aug 15 2019, 4:47 PM · Community-Tech (Kanban-Q2-2019-20), SVG Translate Tool