Page MenuHomePhabricator

dom_walden (Dom Walden)
Test Engineer for Community Tech and Anti-Harassment Tools

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2018, 4:33 PM (152 w, 2 d)
Availability
Available
LDAP User
Dom Walden
MediaWiki User
DWalden (WMF) [ Global Accounts ]

Recent Activity

Today

dom_walden moved T288782: Fonts not working in the PDF output, included but not applied in epubs from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-9) board.

I downloaded ebooks (1 in English, 1 in Hindi) with several different fonts selected in both EPUB and PDF formats.

Wed, Sep 22, 1:14 PM · Community-Tech (CommTech-Sprint-9), WS Export

Yesterday

dom_walden moved T288421: Solution for "Copy and paste from diffs" introduced text selection issues from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-9) board.

I can no longer reproduce issues 1 and 2 from the description. I did not test issue 3 because apparently it has already been fixed.

Tue, Sep 21, 10:52 AM · Community-Tech (CommTech-Sprint-9), MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), MediaWiki-Page-diffs

Mon, Sep 20

dom_walden created T291393: Incorrect anchorNode when using shift and selection goes above diff area on Firefox.
Mon, Sep 20, 2:42 PM · MediaWiki-Page-diffs, wikidiff2, Community-Tech

Fri, Sep 10

dom_walden moved T288361: SecurePoll: Tallying an encrypted election on votewiki produces no results from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

If we are not going to be doing UI tallying in the future, we can safely close this ticket.

Fri, Sep 10, 1:12 PM · MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden moved T283728: Implement STV tallying in STVTallier::finishTally [XL] from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

Most of the testing of this has been recorded in https://www.mediawiki.org/wiki/Anti-Harassment_Tools/SecurePoll_Improvements/Test_Results and other tickets.

Fri, Sep 10, 1:10 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T290731: Support diffs copy and paste for RTL languages.
Fri, Sep 10, 12:53 PM · MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), MW-1.37-release, Patch-For-Review, Community-Tech (CommTech-Sprint-9), I18n, RTL, MediaWiki-Page-diffs, wikidiff2
dom_walden updated subscribers of T286662: Display block and contribs info in popup [S].

@Niharika @phuedx A couple of few questions about which blocks we should count (I think related to work done in T270318 but that has already been resolved):

  • We only count expired blocks as "past" blocks. Blocks which have been explicitly unblocked are not counted. For example, this IP has been blocked 3 times but only counts 1 past block (you'll need to open the network tab of your browser tools to see the response).
  • We don't seem to count range blocks for "active" or "past" blocks. For example, this IP has a range block but IPInfo lists no active blocks.
  • I couldn't get System Blocks to be counted (including $wgProxyList and $wgSoftBlockRanges, tested locally).
Fri, Sep 10, 8:10 AM · Anti-Harassment (The Letter Song), IP Info

Thu, Sep 9

dom_walden added a project to T290640: Undefined variable: wgFileBlacklist: MediaWiki-Uploading.
Thu, Sep 9, 9:59 AM · Patch-For-Review, MediaWiki-Uploading, Beta-Cluster-reproducible
dom_walden created T290640: Undefined variable: wgFileBlacklist.
Thu, Sep 9, 9:56 AM · Patch-For-Review, MediaWiki-Uploading, Beta-Cluster-reproducible

Tue, Sep 7

dom_walden moved T289347: SecurePoll: Decide how we test for equality when eliminating candidates from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

The bugs in the description and T289347#7299771 are no longer reproducible.

Tue, Sep 7, 9:50 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Mon, Sep 6

dom_walden moved T290134: SecurePoll: Numbers less than 0.0001 appear as 0 on tally page from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

We now display numbers as small as 0.000001 (see round 13 of https://vote.wikimedia.beta.wmflabs.org/wiki/Special:SecurePoll/tally/1691).

Mon, Sep 6, 3:45 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden moved T290000: SecurePoll: Tally page display issues when numbers are above 1000 from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

I rechecked all the examples in the description, all the stackoverflow moderator elections on beta and the Irish general election locally, concentrating on the numbers over 1000.

Mon, Sep 6, 1:20 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Thu, Sep 2

dom_walden moved T288783: SecurePoll doing DB writes to securepoll_log on HTTP GET [M] from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

According to logstash, I see that these errors stopped on https://vote.wikimedia.org on 1st Sept at ~17:21, which I think corresponds to when the train deployed to votewiki.

Thu, Sep 2, 2:29 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll, Wikimedia-production-error
dom_walden moved T288740: SecurePoll: Inconsistencies in how we calculate and display small numbers from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

Further testing of this will be done in T290000 and T290134.

Thu, Sep 2, 2:01 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden moved T288154: Ensure job queued page always shows something from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

After clicking "Create tally", you either see the results immediately or the This election is being (re-)tallied. Please check back later for the results message. You can then refresh the page without it trying to resubmit the tally.

Thu, Sep 2, 1:58 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden moved T289186: Write cli tally output to database from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

QA has been using this to test the tallies on beta.

Thu, Sep 2, 1:25 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden updated subscribers of T290001: SecurePoll: Disallow elimination of already elected candidates.

@STran Could you check @phuedx's comment in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/715196/4#message-14424b9e3a217a9baed0d1078b8c2a45212122e9?

Thu, Sep 2, 11:05 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Wed, Sep 1

dom_walden assigned T290134: SecurePoll: Numbers less than 0.0001 appear as 0 on tally page to phuedx.
Wed, Sep 1, 3:39 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden moved T290134: SecurePoll: Numbers less than 0.0001 appear as 0 on tally page from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Wed, Sep 1, 3:39 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden added a comment to T288740: SecurePoll: Inconsistencies in how we calculate and display small numbers.

Also raised T290134, numbers less than 0.0001 appear as 0.

Wed, Sep 1, 9:45 AM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T290134: SecurePoll: Numbers less than 0.0001 appear as 0 on tally page.
Wed, Sep 1, 9:44 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden added a comment to T290000: SecurePoll: Tally page display issues when numbers are above 1000.

This does not affect the way results appear when they are written to the database or dump file.

Here is an example of how it looks when you extract the results from the dump file and pretty print them: https://www.mediawiki.org/wiki/Anti-Harassment_Tools/SecurePoll_Improvements/Test_Results/5_2_5000_956342267/dump

@dom_walden does this happen when the result is written to the database and the Tally page reads it from the database? Ref T289186

Wed, Sep 1, 8:15 AM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Tue, Aug 31

dom_walden added a comment to T290027: SecurePoll: Make sure tied candidates really are tied.

I tested this against an updated definition of surplus (using number of votes * number of tied candidates + surplus) and we still see 9-12 eliminated at the same time https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/715711/4

image.png (892×1 px, 136 KB)

Tue, Aug 31, 12:18 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden added a comment to T290000: SecurePoll: Tally page display issues when numbers are above 1000.

This does not affect the way results appear when they are written to the database or dump file.

Tue, Aug 31, 11:04 AM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden updated the task description for T290027: SecurePoll: Make sure tied candidates really are tied.
Tue, Aug 31, 10:35 AM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Mon, Aug 30

dom_walden added a comment to T290027: SecurePoll: Make sure tied candidates really are tied.

Further notes and examples.

Mon, Aug 30, 6:58 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden updated the task description for T290027: SecurePoll: Make sure tied candidates really are tied.
Mon, Aug 30, 6:43 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden updated the task description for T290027: SecurePoll: Make sure tied candidates really are tied.
Mon, Aug 30, 6:43 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T290027: SecurePoll: Make sure tied candidates really are tied.
Mon, Aug 30, 6:39 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden moved T290001: SecurePoll: Disallow elimination of already elected candidates from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Mon, Aug 30, 1:10 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden edited projects for T290001: SecurePoll: Disallow elimination of already elected candidates, added: Anti-Harassment (The Letter Song); removed Anti-Harassment.
Mon, Aug 30, 1:10 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden updated the task description for T290001: SecurePoll: Disallow elimination of already elected candidates.
Mon, Aug 30, 1:06 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden added a comment to T290001: SecurePoll: Disallow elimination of already elected candidates.

There is already a patch for this: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/715196

Mon, Aug 30, 1:04 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T290001: SecurePoll: Disallow elimination of already elected candidates.
Mon, Aug 30, 1:04 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden added a comment to T288740: SecurePoll: Inconsistencies in how we calculate and display small numbers.

I raised T290000 (woo!) to track T288740#7311757.

Mon, Aug 30, 12:53 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T290000: SecurePoll: Tally page display issues when numbers are above 1000.
Mon, Aug 30, 12:52 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Thu, Aug 26

dom_walden moved T288748: SecurePoll: "gpg: decryption failed: No secret key" when tallying via CLI from In Progress 💪 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

We decided this wasn't important enough to spend anymore time on this. No one else could reproduce this.

Thu, Aug 26, 5:57 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden added a comment to T288740: SecurePoll: Inconsistencies in how we calculate and display small numbers.

@STran I don't think it likes numbers over 1000.

Thu, Aug 26, 12:52 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Wed, Aug 25

dom_walden added a comment to T288748: SecurePoll: "gpg: decryption failed: No secret key" when tallying via CLI.

@dom_walden does the file you are using have gpg-sign-key ? after removing it I am getting an error though not exactly the same but I think it might be related

Wed, Aug 25, 12:09 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Tue, Aug 24

dom_walden added a comment to T288740: SecurePoll: Inconsistencies in how we calculate and display small numbers.

@STran The issue I mentioned in standup.

Tue, Aug 24, 5:16 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden removed a project from T230689: Preload the next page's image on proofreading view: QTE-TestingOverview.
Tue, Aug 24, 2:13 PM · Community-Tech (CommTech-Sprint-7), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), ProofreadPage
dom_walden added a comment to T288748: SecurePoll: "gpg: decryption failed: No secret key" when tallying via CLI.

At least it sounds like cleanup even if error is now working? 😅 If it's replicable, you can set an early return in GpgCrypt->cleanup() and that should give you a folder to investigate?

Tue, Aug 24, 1:06 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden updated subscribers of T288888: SecurePoll: vote_current not updated when vote struck.

@Niharika We should check with T&S whether this behaviour is expected or not.

Tue, Aug 24, 11:45 AM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden added a comment to T289186: Write cli tally output to database.

After this change, the election results will be available in the dump file after the CLI tally has been run. I don't know whether or not you want people to be able to see this.

To clarify, your concern is that the results are potentially visible between decryption and posting? ...

Tue, Aug 24, 11:39 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden moved T280798: Fix namespace blocks of removed extension namespaces (and actions) from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

I can no longer reproduce the bug in T280798#7214861 on beta.

Tue, Aug 24, 9:09 AM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Anti-Harassment (The Letter Song), MediaWiki-Blocks
dom_walden moved T230689: Preload the next page's image on proofreading view from Parking to Dom on the QTE-TestingOverview board.
Tue, Aug 24, 8:07 AM · Community-Tech (CommTech-Sprint-7), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), ProofreadPage
dom_walden added a project to T230689: Preload the next page's image on proofreading view: QTE-TestingOverview.
Tue, Aug 24, 8:07 AM · Community-Tech (CommTech-Sprint-7), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), ProofreadPage

Aug 23 2021

dom_walden added a comment to T289347: SecurePoll: Decide how we test for equality when eliminating candidates.

@STran helped me understand this better. We discussed in Slack about the possibility of adding BC and I am hesitant about us doing that at this point. We should go with whatever PHP's default is. If candidates 9, 10, 11 and 12 all achieved the same votes in a round according to PHP, we should eliminate them all. If 9 got more votes (by however much), we should not eliminate them.
We can probably not display this well in the UI but we can attempt to document this in all the necessary places and inform the election admins about this possibility.

Aug 23 2021, 1:29 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden moved T289347: SecurePoll: Decide how we test for equality when eliminating candidates from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
Aug 23 2021, 7:31 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden edited projects for T289347: SecurePoll: Decide how we test for equality when eliminating candidates, added: Anti-Harassment (The Letter Song); removed Anti-Harassment.
Aug 23 2021, 7:31 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Aug 22 2021

dom_walden added a comment to T289347: SecurePoll: Decide how we test for equality when eliminating candidates.

Change 713963 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/SecurePoll@master] Fix the elimination check in the STV algo

https://gerrit.wikimedia.org/r/713963

Aug 22 2021, 11:54 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created P17058 testDeclareEliminated_STVTallierTest.patch.
Aug 22 2021, 11:52 AM

Aug 20 2021

dom_walden added a comment to T289185: Use bc in STV algorithm.

@STran Checking out this change locally, I am not sure I am seeing the correct results.

Aug 20 2021, 2:19 PM · Patch-For-Review, MediaWiki-extensions-SecurePoll
dom_walden updated the task description for T289347: SecurePoll: Decide how we test for equality when eliminating candidates.
Aug 20 2021, 12:46 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T289347: SecurePoll: Decide how we test for equality when eliminating candidates.
Aug 20 2021, 12:39 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden added a comment to T289186: Write cli tally output to database.

@Niharika @jrbs Just a note, I believe once the results are written to the database they will be visible in the dump file.

If the election does not have the voter-privacy property set, this dump file is visible to anyone.

Before we do this ticket, we might want to decide whether we want to:

  1. Remove the results from the dump file (like was done with the private key in T288924), or
  2. Rely on the election admins to appropriately set the voter-privacy property when creating an election

I think this is by design - the dump file is intended to be publicly available, iirc. Is there any sensitive information in the dump file beyond the private key?

Aug 20 2021, 11:45 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Aug 19 2021

dom_walden updated subscribers of T289186: Write cli tally output to database.

@Niharika @jrbs Just a note, I believe once the results are written to the database they will be visible in the dump file.

Aug 19 2021, 9:00 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Aug 18 2021

dom_walden created T289128: SecurePoll: "Registered before" input automatically populated on Voter eligibility form.
Aug 18 2021, 9:51 AM · patch-welcome, MediaWiki-extensions-SecurePoll

Aug 16 2021

dom_walden created T288989: beta logstash servers run out of disk space.
Aug 16 2021, 7:31 PM · Release-Engineering-Team (Radar), SRE Observability (FY2021/2022-Q2), Beta-Cluster-Infrastructure
dom_walden added a comment to T288748: SecurePoll: "gpg: decryption failed: No secret key" when tallying via CLI.

You might be able to investigate the temp folder (/tmp/securepoll-55dbaf2a56a8c7b2f947a4eaca87897c8c9fa39a/) if the election failed and didn't clean up after itself. You should see a key and an input file and maybe cating one of those would provide more data? It sounds like it might be a bad input somewhere if it took a long time (presumably successfully decrypting other inputs) to fail.

Aug 16 2021, 11:48 AM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Aug 14 2021

dom_walden created T288888: SecurePoll: vote_current not updated when vote struck.
Aug 14 2021, 2:28 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T288887: SecurePoll: not-centrally-blocked does not distinguish partial and sitewide blocks.
Aug 14 2021, 2:06 PM · MediaWiki-extensions-SecurePoll

Aug 13 2021

dom_walden created T288839: SecurePoll: You must log in to vote in this election [Timebox: 8h].
Aug 13 2021, 4:42 PM · MediaWiki-extensions-SecurePoll
dom_walden created T288831: SecurePoll: Fatal exception of type "Wikimedia\Rdbms\DBTransactionSizeError" when submitting a translation.
Aug 13 2021, 2:58 PM · MediaWiki-extensions-SecurePoll
dom_walden added a comment to T288748: SecurePoll: "gpg: decryption failed: No secret key" when tallying via CLI.

I ran this on local and the script completed without errors
Script finished in 402 s

  • local docker
  • gpg (GnuPG) 2.1.18
  • libgcrypt 1.7.6-beta
Aug 13 2021, 11:51 AM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Aug 12 2021

dom_walden updated the task description for T288748: SecurePoll: "gpg: decryption failed: No secret key" when tallying via CLI.
Aug 12 2021, 3:55 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden updated the task description for T288748: SecurePoll: "gpg: decryption failed: No secret key" when tallying via CLI.
Aug 12 2021, 3:48 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T288748: SecurePoll: "gpg: decryption failed: No secret key" when tallying via CLI.
Aug 12 2021, 3:46 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T288740: SecurePoll: Inconsistencies in how we calculate and display small numbers.
Aug 12 2021, 2:19 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Aug 11 2021

dom_walden created T288624: PHP Warning: curl_multi_remove_handle(): supplied resource is not a valid cURL Multi Handle resource.
Aug 11 2021, 2:18 PM · MediaWiki-libs-HTTP, Beta-Cluster-reproducible
dom_walden moved T279540: Instrument IP address copy action metric from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

We tested this on test.wikipedia.org.

Aug 11 2021, 2:07 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Anti-Harassment (The Letter Song), IP Info
dom_walden added a comment to T287549: Introduce change tag to surface edits that add links to disambiguation pages.

QA notes: This hopefully should be easy to test. When you edit a page and add a link to one of the pages listed at Special:DisambiguationPages, it should have a tag next to it in the revision history that reads "Disambiguation links".

Aug 11 2021, 1:22 PM · Community-Tech (CommTech-Sprint-8), MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, User-notice, MediaWiki-extensions-Disambiguator, Disambiguation-Wish-2021-Jul-Sept
dom_walden added a comment to T277222: Create job to tally elections [M].

I started 4 tallying jobs one after the other, but they all appear to be stuck:

(they are all unencrypted, 5000 votes).

I started them while https://vote.wikimedia.beta.wmflabs.org/wiki/Special:SecurePoll/tally/632 still had tally-job-enqueued=1 in the DB (tally-ongoing was not set). I have deleted that row from the DB but the jobs still appear stuck.

@dom_walden do they also fail to tally if we try to tally them from the cli?

Aug 11 2021, 8:28 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Aug 10 2021

dom_walden added a comment to T283280: Special:SecurePoll makes primary database connections on GET requests when getting UI messages or checking for election admins.

@Zabe Further to your comment https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/709533/1#message-dd40e9955064e53f6d6eaaea03533aaebed5d6e3, will this patch actually change anything? Are you planning a follow up patch? Thanks.

Aug 10 2021, 2:35 PM · MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Anti-Harassment, MediaWiki-extensions-SecurePoll, Wikimedia-Rdbms, Performance-Team (Radar)
dom_walden closed T279855: Ws-export: Hide export menu in edit mode as Resolved.

With the editor open on https://en.wikisource.org, the sidebar does not contain the "Download/print" options. I tested both Source and Visual editor, on every skin.

Aug 10 2021, 1:31 PM · Community-Tech (CommTech-Sprint-6), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), WS Export
dom_walden moved T276891: Wikisource Export: UX changes for language dropdown from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-6) board.

We list the Wikisource languages in their own language, or in the user's interface language if the language cannot be found on Wikidata.

Aug 10 2021, 1:10 PM · Community-Tech (CommTech-Sprint-6), WS Export
dom_walden moved T285956: Lock selection to a single side in TableDiffFormatter from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-6) board.

I have tested this very briefly on https://test.wikipedia.org (e.g. https://test.wikipedia.org/w/index.php?title=Main_Page&action=historysubmit&type=revision&diff=470140&oldid=448939).

Aug 10 2021, 12:33 PM · Community-Tech (CommTech-Sprint-6), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), MediaWiki-Page-diffs
dom_walden added a comment to T277222: Create job to tally elections [M].

I started 4 tallying jobs one after the other, but they all appear to be stuck:

(they are all unencrypted, 5000 votes).

Aug 10 2021, 10:22 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Aug 9 2021

dom_walden moved T287894: SecurePoll: allow STV elections to be tallied from the cli from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

I have been able to tally elections from the CLI on beta, including encrypted elections with 1000 votes and (small) encrypted STV elections.

Aug 9 2021, 12:49 PM · MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden moved T277222: Create job to tally elections [M] from QA/Testing 🐞 to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

For greater visibility, I am moving this back into In Progress.

Aug 9 2021, 12:07 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden added a comment to T288361: SecurePoll: Tallying an encrypted election on votewiki produces no results.

For comparison, this election is also encrypted but only has 1 vote, and it finished almost immediately: https://vote.wikimedia.org/wiki/Special:SecurePoll/tally/1055

Aug 9 2021, 8:14 AM · MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Aug 6 2021

dom_walden moved T287738: SecurePoll: generateTestElection cannot create elections on beta from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

For now, I think this is good enough. I may raise another bug in the future, but not right now.

Aug 6 2021, 2:32 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Aug 5 2021

dom_walden moved T287739: SecurePoll: allow user to tally immediately and let user set election admins in the generateTestElection script from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

Testing on beta, I can now set the admins via the CLI and the election is immediately tallyable.

Aug 5 2021, 9:10 AM · MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden added a comment to T287738: SecurePoll: generateTestElection cannot create elections on beta.

@dom_walden Does it work for you now?

Aug 5 2021, 9:05 AM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T288199: Login link missing on votewiki and loginwiki.
Aug 5 2021, 8:30 AM · Beta-Cluster-reproducible, Vector, Desktop Improvements

Aug 3 2021

dom_walden closed T286270: CodeMirror does not set a default for "usecodemirror" preference, causing user_properties bloat as Resolved.

In the source editor, if I click the "syntax highlighting" button a row gets written to the user_properties table in the database to reflect the CodeMirror feature being enabled for my user. When I click it again, the row is removed.

Aug 3 2021, 11:10 AM · Community-Tech (CommTech-Sprint-6), MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Performance Issue, MediaWiki-extensions-CodeMirror

Aug 2 2021

dom_walden updated the task description for T287894: SecurePoll: allow STV elections to be tallied from the cli.
Aug 2 2021, 5:22 PM · MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T287894: SecurePoll: allow STV elections to be tallied from the cli.
Aug 2 2021, 5:22 PM · MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden added a comment to T287782: Can't add or edit translations in SecurePoll.

@dom_walden Want to try again please? :)

Aug 2 2021, 1:34 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Regression, Anti-Harassment, Wikimedia-production-error, MediaWiki-extensions-SecurePoll
dom_walden added a comment to T287780: SecurePoll CreatePage can no longer correctly select "remote" wiki databases that aren't in the same cluster.

I had the same error, but on a second try I was able to create https://test.wikipedia.org/wiki/SecurePoll:828.

Aug 2 2021, 12:37 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), User-Majavah, Regression, MW-1.36-release, MediaWiki-extensions-SecurePoll, Wikimedia-production-error
dom_walden added a comment to T287780: SecurePoll CreatePage can no longer correctly select "remote" wiki databases that aren't in the same cluster.

@Reedy @Zabe @Majavah Trying to create an election with "All wiki" selected on votewiki and testwiki, get some sort of timeout:

[19e3148a-a7d9-4c40-9aa2-bf5e49d774e1] /wiki/Special:SecurePoll/create Wikimedia\Rdbms\DBTransactionSizeError: Transaction spent 4.2640490531921 second(s) in writes, exceeding the limit of 3
Aug 2 2021, 12:24 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), User-Majavah, Regression, MW-1.36-release, MediaWiki-extensions-SecurePoll, Wikimedia-production-error

Aug 1 2021

dom_walden added a comment to T287782: Can't add or edit translations in SecurePoll.

@Reedy Trying to submit a translation on testwiki, error:

[8fbb6604-7aca-43ee-bf6a-0ed067cb9c08] /w/index.php?title=Special:SecurePoll/translate/821/fr&action=submit TypeError: Argument 1 passed to MediaWiki\Storage\PageUpdater::saveRevision() must be an instance of CommentStoreComment, instance of MediaWiki\Extensions\SecurePoll\SecurePollContent given, called in /srv/mediawiki/php-1.37.0-wmf.16/extensions/SecurePoll/includes/Pages/TranslatePage.php on line 336
Aug 1 2021, 7:18 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Regression, Anti-Harassment, Wikimedia-production-error, MediaWiki-extensions-SecurePoll
dom_walden added a comment to T287780: SecurePoll CreatePage can no longer correctly select "remote" wiki databases that aren't in the same cluster.

Leaving open for now until fix is tested in WMF prod

Aug 1 2021, 6:34 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), User-Majavah, Regression, MW-1.36-release, MediaWiki-extensions-SecurePoll, Wikimedia-production-error

Jul 30 2021

dom_walden updated the task description for T287738: SecurePoll: generateTestElection cannot create elections on beta.
Jul 30 2021, 9:19 AM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T287739: SecurePoll: allow user to tally immediately and let user set election admins in the generateTestElection script.
Jul 30 2021, 9:00 AM · MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
dom_walden created T287738: SecurePoll: generateTestElection cannot create elections on beta.
Jul 30 2021, 8:53 AM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Jul 27 2021

dom_walden updated the language for P16903 20_6_5000_2048397232_expected from php to text.
Jul 27 2021, 11:57 AM · MediaWiki-extensions-SecurePoll, Anti-Harassment
dom_walden created P16913 20_9_5200_2038025507_expected.
Jul 27 2021, 11:57 AM · MediaWiki-extensions-SecurePoll, Anti-Harassment
dom_walden created P16912 20_9_5200_2038025507_actual.
Jul 27 2021, 11:56 AM · MediaWiki-extensions-SecurePoll, Anti-Harassment
dom_walden created P16911 20_6_5100_1116366364_actual.
Jul 27 2021, 10:47 AM · MediaWiki-extensions-SecurePoll, Anti-Harassment