Page MenuHomePhabricator

Create special page to list all recovery data
Open, Needs TriagePublicFeature

Assigned To
Authored By
Samwilson
Sep 29 2023, 9:04 AM
Referenced Files
F41522492: Edit-Recovery-Dev-wiki1.png
Tue, Nov 21, 4:00 AM
F41509364: 2023-11-15_16-45-44.png
Thu, Nov 16, 12:57 AM
F41509371: 2023-11-15_16-51-02.png
Thu, Nov 16, 12:57 AM
F41509324: image.png
Thu, Nov 16, 12:57 AM
F41509321: 2023-11-15_16-30-49.png
Thu, Nov 16, 12:57 AM
F41509319: 2023-11-15_16-30-02.png
Thu, Nov 16, 12:57 AM
F41509317: 2023-11-15_16-27-07.png
Thu, Nov 16, 12:57 AM
F41509347: 2023-11-15_16-29-34.png
Thu, Nov 16, 12:57 AM

Description

Feature summary (what you would like to be able to do and where):

Add Special:EditRecovery to list all pages that have saved edit recovery data.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):

  • Give users an overview of what data is stored on their device.
  • Have an option for deleting each item, or all at once (may be decided based on tracking information if this feature is required)
  • The special page can also have general information about the Edit Recovery feature, such as the fact that it is per-device (because the listed pages will differ between devices and this may not be clear to people).

Benefits (why should this be implemented?):

  • We need to provide a clear entry point for people to verify and discard any stored data.
  • Users may not remember which pages they had edits in progress for, and this special page will provide an overview of these.

QA Results - Beta

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 972933 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Edit Recovery: add new special page to list unsaved changes

https://gerrit.wikimedia.org/r/972933

The first part of this is ready for review. It's a very basic list of pages, but mainly is about setting up the structure and getting ready for when the design's ready.

Change 972933 merged by jenkins-bot:

[mediawiki/core@master] Edit Recovery: add new special page to list unsaved changes

https://gerrit.wikimedia.org/r/972933

@Samwilson Data does store per browser on Special:EditRecovery. This could just be as designed but on the Timeless skin, it shows Special Page twice. Should it just all be under Wiki Tools just like the other skins are under Tools? In the Minerva Skin, there are no Tools section to choose from. Also regarding having an option for deleting each item, or all at once. Are you talking from the Developer Tool under unsaved-page-data on how to remove them all at once or is that still being worked on? Besides the ones I mentioned previously, it looks to be fine. I

Status:❓NMI
Environment: Beta: 1.42.0-alpha (d5ff499)
OS: macOS Sonoma 14.0
Browser: Chrome 119, Firefox 119, Safari 17.0
Skins. Vector 2022, 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.beta.wmflabs.org/wiki/Special:EditRecovery
https://en.wikipedia.beta.wmflabs.org/wiki/Special:EditRecovery?uselang=es
https://en.wikipedia.beta.wmflabs.org/wiki/Special:EditRecovery?uselang=en-rtl

❓AC1: https://phabricator.wikimedia.org/T347673

Browsers

ChromeSafariFirefox
2023-11-15_16-19-29.png (920×1 px, 166 KB)
2023-11-15_16-23-48.png (812×1 px, 131 KB)
2023-11-15_16-23-40.png (980×1 px, 176 KB)

Skins

Vector 2022Vector 2010MonobookTimelessMinerva
2023-11-15_16-36-03.png (981×2 px, 196 KB)
2023-11-15_16-26-31.png (725×3 px, 208 KB)
2023-11-15_16-27-38.png (811×3 px, 235 KB)
2023-11-15_16-29-34.png (970×2 px, 177 KB)
2023-11-15_16-27-07.png (635×2 px, 104 KB)

Languages

EsEn-rtlHe
2023-11-15_16-30-02.png (987×2 px, 178 KB)
2023-11-15_16-30-49.png (1×2 px, 198 KB)
image.png (1×2 px, 182 KB)

Misc.

Delete at once- If you delete the entries from the unsaved-page-data and refresh it, your Edit Recovery will be empty

2023-11-15_16-51-02.png (1×3 px, 280 KB)

Chrome Incognito
2023-11-15_16-45-44.png (679×3 px, 132 KB)

This could just be as designed but on the Timeless skin, it shows Special Page twice.

This is fine, one is a link to the special pages' overview, and one is a link to the current special page. It's similar on Vector:

Edit-Recovery-Dev-wiki1.png (497×618 px, 71 KB)

Should it just all be under Wiki Tools just like the other skins are under Tools? In the Minerva Skin, there are no Tools section to choose from.

Sorry about this I should've been clearer: the work so far doesn't include the tools link. I'm moving this back to in-dev to address the remaining parts (the tools link, and we've still got to sort out the actual proper design for the list of pages). Good point about Minerva; maybe the link should go in the personal menu, near Contributions (will get design input on this too).

Also regarding having an option for deleting each item, or all at once. Are you talking from the Developer Tool under unsaved-page-data on how to remove them all at once or is that still being worked on?

Yep, still being worked on! Sorry for not adding QA notes earlier. Thanks for testing everything so far, it's good to confirm that nothing's massively wrong. The remaining work will come soon.

Based on the discussion with @Samwilson on December 5th 2023, the following will be part of MVP:

  • A page with numbered list of all the edit recoveries that are currently stored on a device for a user. Entry point to this page will be a link (placement varies based on skin) with a tooltip that will show the number of edit recoveries saved on the current device
  • When no edit recovery is saved, there will be an empty state of the page with proper messaging. The entry point will be greyed out and the tooltip will show that there is no edit recovery saved
  • The format of each line item (pages) will be as following
    • Page:Section:Section name (view | edit) - no link on the Page:Section:...
    • Recovered on <Date & Time>

Design will be updated in this ticket