Page MenuHomePhabricator

Nardog
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jan 30 2019, 8:58 PM (271 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Nardog [ Global Accounts ]

Recent Activity

Today

Nardog added a comment to T362467: Section link should be added to the edit summary when editing the lead section.

FWIW AWB also adds /* top */ if only the lead section was modified.

Sat, Apr 13, 5:58 PM · Mobile
Nardog added a comment to T362467: Section link should be added to the edit summary when editing the lead section.

https://en.wikipedia.org/wiki/Example?useskin=vector-2022#top goes to the absolute top of the page since there is no such anchor on the page. The html does not say id="top" anywhere so #top is ignored.

It's not ignored. If you focus the address bar and press Enter/Return it scrolls to the top of the page. That doesn't happen with #foo or whatever.

Sat, Apr 13, 5:44 PM · Mobile
Nardog added a comment to T362467: Section link should be added to the edit summary when editing the lead section.

summary=/*%20top%20*/ prefills the edit summary with "/* top */ " which makes a link like https://en.wikipedia.org/wiki/Example#top to an anchor called "top". This anchor is near the top of the page in Vector Legacy but is not present in Vector 2022.
Compare https://en.wikipedia.org/wiki/Example?useskin=vector#top
and https://en.wikipedia.org/wiki/Example?useskin=vector-2022#top

But a link to #top scrolls to the top of the page, even if there's no element with the anchor/ID top, which is a legacy/non-standardized browser feature. The default signature links to #top when inserted on your own user talk page (presumably to avoid the selflink bolding).

Sat, Apr 13, 5:11 PM · Mobile
Nardog added a comment to T362467: Section link should be added to the edit summary when editing the lead section.
Sat, Apr 13, 4:15 PM · Mobile
Nardog updated the task description for T362470: Sidebar link not added in large articles.
Sat, Apr 13, 4:11 PM · Patch-For-Review, JavaScript, PageTriage
Nardog renamed T362470: Sidebar link not added in large articles from TypeError: sideBarLink is null to Sidebar link not added in large articles.
Sat, Apr 13, 4:08 PM · Patch-For-Review, JavaScript, PageTriage
Nardog created T362470: Sidebar link not added in large articles.
Sat, Apr 13, 4:05 PM · Patch-For-Review, JavaScript, PageTriage

Yesterday

Nardog added a comment to T146393: The CodeEditor interface (options available from toolbar) should be translatable.

Ace supports i18n since v1.20.0 (and improved in the just released v1.33.0) so we can just propagate wgUserLanguage to Ace when CodeEditor sets it up, though the translations need to be submitted and merged into Ace first, of course, and propagating the fallback chain can be a challenge (another option is to build it into CodeEditor and make it translatable via TranslateWiki). (And I wonder if it works with RTL...)

Fri, Apr 12, 10:27 AM · CodeEditor, I18n

Thu, Apr 11

Nardog added a comment to T354494: Can’t discard changes after showing changes.

If we enable it only for the notification button, then we still have the problem of what to do for the normal button when non-live preview is enabled.

I don't understand how this is a problem at all. We can just leave the normal preview/diff buttons alone (i.e. no handler attached).

Thu, Apr 11, 6:48 AM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Community-Tech (CommTech-Kanban), Edit Recovery

Wed, Apr 10

Nardog added a comment to T347864: Handle switching between Visual and Source Editor.

Does the patch cover T354186: Don't recover edits on form submission?

Wed, Apr 10, 8:09 AM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), Community-Tech (CommTech-Kanban), Edit Recovery

Tue, Apr 9

Nardog added a project to T354107: Aborting search with "Stop" button renders the search input de facto immutable: Advanced-Search.
Tue, Apr 9, 2:54 PM · Advanced-Search, Web-Team-Backlog, CirrusSearch, Discovery-Search

Mon, Apr 8

IKhitron awarded T353996: Allow deleting data from Special:EditRecovery a Burninate token.
Mon, Apr 8, 9:12 AM · Community-Tech, Edit Recovery

Fri, Apr 5

Nardog updated subscribers of T361775: Iconless toggle buttons on diff of the first revision of a page.

@Esanders The patch does not seem to address the problem, which is not that the icons are missing but that these toggles appear at all.

Fri, Apr 5, 12:49 PM · Patch-For-Review, VisualEditor, VisualEditor-VisualDiffs, MediaWiki-Page-diffs, Better-Diffs-2023

Thu, Apr 4

Nardog updated the task description for T361775: Iconless toggle buttons on diff of the first revision of a page.
Thu, Apr 4, 5:22 AM · Patch-For-Review, VisualEditor, VisualEditor-VisualDiffs, MediaWiki-Page-diffs, Better-Diffs-2023
Nardog attached a referenced file: F44434310: image.png.
Thu, Apr 4, 5:20 AM · Patch-For-Review, VisualEditor, VisualEditor-VisualDiffs, MediaWiki-Page-diffs, Better-Diffs-2023
Nardog created T361775: Iconless toggle buttons on diff of the first revision of a page.
Thu, Apr 4, 5:19 AM · Patch-For-Review, VisualEditor, VisualEditor-VisualDiffs, MediaWiki-Page-diffs, Better-Diffs-2023

Wed, Apr 3

Nardog added a comment to T342200: Add JS hook(s) for extensions and gadgets to interact with the edit recovery process.

Related: T353998: Allow scripts to pause/"restart" EditRecovery

Wed, Apr 3, 5:54 AM · Edit Recovery

Thu, Mar 28

Nardog merged T361183: "Reply", "(Un)subscribe" buttons all gone after replying into T360863: Reply buttons disappear after replying once, until reloading the page.
Thu, Mar 28, 11:01 AM · Verified, MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), Editing QA, Editing-team (Kanban Board), DiscussionTools
Nardog merged task T361183: "Reply", "(Un)subscribe" buttons all gone after replying into T360863: Reply buttons disappear after replying once, until reloading the page.
Thu, Mar 28, 11:00 AM · Regression, DiscussionTools

Fri, Mar 22

Nardog added a comment to T360258: Previewing global.js with "<script>" returns MediaWiki internal error "DomainException".

What about Editing-team? GlobalCssJs may have no maintainer but preview certainly does, no?

Fri, Mar 22, 3:53 AM · Unstewarded-production-error, MediaWiki-Page-editing, Wikimedia-production-error, GlobalCssJs

Sun, Mar 17

Nardog updated the task description for T360258: Previewing global.js with "<script>" returns MediaWiki internal error "DomainException".
Sun, Mar 17, 10:50 AM · Unstewarded-production-error, MediaWiki-Page-editing, Wikimedia-production-error, GlobalCssJs
Nardog updated the task description for T360258: Previewing global.js with "<script>" returns MediaWiki internal error "DomainException".
Sun, Mar 17, 10:48 AM · Unstewarded-production-error, MediaWiki-Page-editing, Wikimedia-production-error, GlobalCssJs
Nardog created T360258: Previewing global.js with "<script>" returns MediaWiki internal error "DomainException".
Sun, Mar 17, 10:47 AM · Unstewarded-production-error, MediaWiki-Page-editing, Wikimedia-production-error, GlobalCssJs

Mar 10 2024

Nardog updated the task description for T359281: Settle on `mw` vs `mediawiki`.
Mar 10 2024, 2:15 AM · JSDoc WMF theme

Mar 8 2024

Nardog added a comment to T358391: Clarify stability of mw.loader.addStyleTag() in documentation.

Thank you! The link in addCSS() is still broken, but I assume cross-references just haven't been got around to.

Mar 8 2024, 1:23 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, JSDoc WMF theme

Mar 7 2024

Nardog added a comment to T358391: Clarify stability of mw.loader.addStyleTag() in documentation.
Mar 7 2024, 11:59 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, JSDoc WMF theme
Nardog updated the task description for T359280: Move duplicate hooks to Events.
Mar 7 2024, 8:07 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), JSDoc WMF theme

Mar 6 2024

Nardog closed T359285: Label for list of transclusions is not consistent between live and non-live preview, a subtask of T41272: Bugs in "Live preview" feature (tracking), as Resolved.
Mar 6 2024, 12:44 PM · JavaScript, MediaWiki-Page-editing, Tracking-Neverending
Nardog closed T359285: Label for list of transclusions is not consistent between live and non-live preview as Resolved.
Mar 6 2024, 12:44 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Page-editing, Realtime Preview
Nardog updated the task description for T359285: Label for list of transclusions is not consistent between live and non-live preview.
Mar 6 2024, 9:58 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Page-editing, Realtime Preview
Nardog added a project to T359285: Label for list of transclusions is not consistent between live and non-live preview: MediaWiki-Page-editing.
Mar 6 2024, 9:26 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Page-editing, Realtime Preview
Nardog added a subtask for T41272: Bugs in "Live preview" feature (tracking): T359285: Label for list of transclusions is not consistent between live and non-live preview.
Mar 6 2024, 9:25 AM · JavaScript, MediaWiki-Page-editing, Tracking-Neverending
Nardog added a parent task for T359285: Label for list of transclusions is not consistent between live and non-live preview: T41272: Bugs in "Live preview" feature (tracking).
Mar 6 2024, 9:25 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Page-editing, Realtime Preview
Nardog updated the task description for T359285: Label for list of transclusions is not consistent between live and non-live preview.
Mar 6 2024, 7:58 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Page-editing, Realtime Preview
Nardog updated the task description for T359285: Label for list of transclusions is not consistent between live and non-live preview.
Mar 6 2024, 7:50 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Page-editing, Realtime Preview
Nardog created T359285: Label for list of transclusions is not consistent between live and non-live preview.
Mar 6 2024, 7:37 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Page-editing, Realtime Preview
Nardog created T359281: Settle on `mw` vs `mediawiki`.
Mar 6 2024, 6:26 AM · JSDoc WMF theme
Nardog added a project to T359280: Move duplicate hooks to Events: JSDoc WMF theme.
Mar 6 2024, 6:23 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), JSDoc WMF theme
Nardog created T359280: Move duplicate hooks to Events.
Mar 6 2024, 6:23 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), JSDoc WMF theme
Nardog created T359279: External links are broken.
Mar 6 2024, 6:16 AM · JSDoc WMF theme

Mar 2 2024

Nardog added a comment to T358733: [Design Spike 4 hours] Reconsider design for expand all button.

Would a site-wide preference similar to how we do night mode / font size be more appropriate for this and save the user from having to click the link (and it not persisting on each page load).

Mar 2 2024, 11:12 AM · Web-Team-Backlog, Moderator-Tools-Team, Spike
Nardog added a comment to T358290: JSDoc textSelection methods being marked as private.

Do the functions even need to be documented? They're anonymous functions inside a public method after all. (But also: do they need to be initialized from scratch on every call?)

Mar 2 2024, 10:53 AM · JSDoc WMF theme

Mar 1 2024

Nardog added a comment to T358391: Clarify stability of mw.loader.addStyleTag() in documentation.

The stability of this method is ambiguous as in the code it hasn't been marked as @stable or @private (it hasn't even been documented).

It was documented until you removed it in rMW9f2e4faea3ff. Before that, it was explicitly non-private, as evident by comparing it to the other "add..." methods under mw.loader.

Mar 1 2024, 7:49 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, JSDoc WMF theme
Nardog added a comment to T358733: [Design Spike 4 hours] Reconsider design for expand all button.

@Jdlrobson Can you make the files (screenshots?) public?

Mar 1 2024, 7:14 AM · Web-Team-Backlog, Moderator-Tools-Team, Spike
Nardog updated the task description for T354186: Don't recover edits on form submission.
Mar 1 2024, 6:54 AM · Community-Tech (CommTech-Kanban), Edit Recovery
Nardog added a comment to T358391: Clarify stability of mw.loader.addStyleTag() in documentation.

Wow, you can do that? If you could mark as private what was marked as stable (and thus make it possible to make breaking changes to it without going through the deprecation process), wouldn't that provide a loophole to the stable interface policy?

Mar 1 2024, 12:05 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, JSDoc WMF theme

Feb 26 2024

Nardog closed T358464: Changes made after discarding changes are not saved as Invalid.

Nvm, more likely T351821: Edit Recovery interaction with browser data recovery.

Feb 26 2024, 6:06 AM · Community-Tech, Edit Recovery
Nardog created T358464: Changes made after discarding changes are not saved.
Feb 26 2024, 6:01 AM · Community-Tech, Edit Recovery
Nardog added a comment to T354494: Can’t discard changes after showing changes.

I wouldn't characterize it as "forcing" a live diff because the popup is already a JS component and "Show changes" in the edit form would remain unaffected. Rather, it would be more of a surprise if a button on an interactive popup sent you to a different page. A one-time live diff is the less astonishing approach.

Feb 26 2024, 5:29 AM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Community-Tech (CommTech-Kanban), Edit Recovery
Nardog added a comment to T354494: Can’t discard changes after showing changes.

By using mediawiki.page.preview but NOT mediawiki.action.edit.preview you can do a live diff just for once. That's what I was suggesting, and it's different from the patch you abandoned.

Feb 26 2024, 4:29 AM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Community-Tech (CommTech-Kanban), Edit Recovery

Feb 24 2024

Nardog reopened T336863: Show diff for rollback action on confirmation prompt page as "Open".

This is certainly not "when missing information has not been provided, or when an acceptable workaround exists to achieve a similar outcome as requested" or "when there's a consensus that implementing a particular task would be a bad idea".

Feb 24 2024, 12:27 AM · MediaWiki-Page-history, Confirmation prompt for rollback action

Feb 23 2024

Nardog added a comment to T358290: JSDoc textSelection methods being marked as private.

It's not just encapsulateSelection(), it's all methods under fn (getContents, setContents, getSelection...).

Feb 23 2024, 10:24 PM · JSDoc WMF theme
Nardog added a comment to T130888: Category addition/removal should be displayed in the watchlist independently of further edits on articles.

I think this effectively qualifies as a new feature. very similar if not the same as T130134: Watching (only) categorization (additions and removals) of an arbitrary category.

Feb 23 2024, 5:54 PM · Growth-Team, MediaWiki-Watchlist, CatWatch
Nardog updated the task description for T358290: JSDoc textSelection methods being marked as private.
Feb 23 2024, 2:58 AM · JSDoc WMF theme
Nardog added a comment to T352308: Port remaining files to jsdoc in MediaWiki core.

Can you re-surface mw.loader.addStyleTag()? It's been quite handy, it's used a lot, and the doc for mw.util.addCSS() even mentions it as an alternative.

Feb 23 2024, 2:57 AM · MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), JSDoc WMF theme, Patch-For-Review, MediaWiki CodeJam Dec 2023, Tech-Docs-Team, Epic, Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, Documentation
Nardog added a comment to T357693: Show patrol link regardless of whether preview is shown (Was: Edits can't be patrolled on Commons by users who have the user preference "Do not show page content below diffs" enabled).

Indeed, if it's present in mobile diff then we might as well show it always.

Feb 23 2024, 12:17 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Regression, MediaWiki-Patrolling, Commons

Feb 22 2024

Nardog added a comment to T358121: Phonos- Missing file error links for Safari.

Are you sure you're missing the URL only when hovering over a missing file link and not when hovering over any link? Safari apparently does not show the URL by default and you have to enable "Show status bar" to see it. Have you done that?

Feb 22 2024, 10:24 PM · Community-Tech, MediaWiki-extensions-Phonos
Nardog added a comment to T354494: Can’t discard changes after showing changes.

a sort-of unnecessary page load in the case of live preview

I would find that disorienting. Now that live preview has an API (require( 'mediawiki.page.preview' )), why not let "Show changes" in the notification do an ad hoc live diff, without touching "Show changes" in the edit form?

Feb 22 2024, 8:42 AM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Community-Tech (CommTech-Kanban), Edit Recovery
Nardog added a comment to T352308: Port remaining files to jsdoc in MediaWiki core.

The textSelection methods are marked as private and thus not showing up in the documentation. They should be surfaced one way or another as they are APIs meant to be used by consumers.

Feb 22 2024, 7:24 AM · MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), JSDoc WMF theme, Patch-For-Review, MediaWiki CodeJam Dec 2023, Tech-Docs-Team, Epic, Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, Documentation

Feb 21 2024

Nardog added a comment to T355636: CategoryTree toggles cannot be reached by keyboard.

<button> comes with its own quirks so I used <a>, but I wouldn't stop anyone from trying. In the meantime I suggest Cat-a-lot be patched anyway, as even if they did it wouldn't be deployed immediately.

Feb 21 2024, 10:06 AM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Accessibility, MediaWiki-extensions-CategoryTree

Feb 19 2024

Nardog closed T354184: Can't locally disable live preview as Invalid.

My bad, my prototype for T136907 was loading the module. Not reproducible with safemode=1. Apologies for taking your time 😳

Feb 19 2024, 4:47 PM · Community-Tech (CommTech-Kanban), Regression, MediaWiki-extensions-GlobalPreferences, MediaWiki-Core-Preferences, MediaWiki-Page-editing

Feb 16 2024

Nardog added a comment to T357724: [Regression] Users are getting the incorrect default mobile font size.

Is there a CSS snippet intadmins can instate temporarily so the issue is fixed, at least locally, until a fix is created and propagated, like T356928 last week?

Feb 16 2024, 4:44 AM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Verified, Unplanned-Sprint-Work, FY2023-24-WE 2.1 Typography and palette customizations, MinervaNeue, Web-Team-Backlog (FY2023-24 Q3 Sprint 3)

Feb 15 2024

Nardog added a comment to T357222: Wikitext-related toolbar buttons are visible even when CodeEditor is on.

It appears the template insertion button doesn't get added for those who can't edit the page.

Feb 15 2024, 11:32 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Community-Tech (CommTech-Kanban), Regression, WikiEditor, CodeEditor

Feb 11 2024

Nardog renamed T357222: Wikitext-related toolbar buttons are visible even when CodeEditor is on from Format and insert toolbar buttons are visible even when CodeEditor is on to Wikitext-related toolbar buttons are visible even when CodeEditor is on.
Feb 11 2024, 3:41 AM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Community-Tech (CommTech-Kanban), Regression, WikiEditor, CodeEditor
Nardog updated the task description for T357222: Wikitext-related toolbar buttons are visible even when CodeEditor is on.
Feb 11 2024, 3:05 AM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Community-Tech (CommTech-Kanban), Regression, WikiEditor, CodeEditor
Nardog updated subscribers of T351487: Gutter doesn't disappear after disabling code editor.

@jpxg said on Discord:

it's the same as before -- it loads something, it's just that this thing is not the code editor and ctrl+, does nothing and there's no line numbers and no highlighting
{F41847334}

That is, the gutter made them think Ace was loading, just not fully. Because that's exactly what it looks like. It looks like the loading of Ace failed halfway through.

Feb 11 2024, 2:52 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), CodeEditor
Nardog added a comment to T308423: Double border in toolbar on narrow screens.

Change 994391 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Use flexbox for toolbar group items

https://gerrit.wikimedia.org/r/994391

Feb 11 2024, 12:04 AM · MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), WikiEditor, Community-Tech (CommTech-Kanban), VisualEditor, WMF-Internships-2023, Realtime Preview
Nardog created T357222: Wikitext-related toolbar buttons are visible even when CodeEditor is on.
Feb 11 2024, 12:03 AM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Community-Tech (CommTech-Kanban), Regression, WikiEditor, CodeEditor

Feb 10 2024

Nardog added a project to T347151: Clicking Phonos button first time sends focus to <body>: Accessibility.
Feb 10 2024, 8:12 PM · Accessibility, MediaWiki-extensions-Phonos, Community-Tech
Nardog added a comment to T357213: [Mobile regression] Patrol link does not show up on diffs in diffonly mode.

The status quo is the desired behavior. You shouldn't be marking pages you haven't seen in parsed whole as patrolled.

Feb 10 2024, 6:47 PM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Patrolling, Regression, MediaWiki-Page-diffs
Nardog updated the task description for T357212: Regression: Can't toggle advanced mode on Special:MobileOptions.
Feb 10 2024, 6:42 PM · Verified, MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), Web-Team-Backlog (FY2023-24 Q3 Sprint 3), Advanced Mobile Contributions, Regression, MobileFrontend
Nardog added a comment to T357212: Regression: Can't toggle advanced mode on Special:MobileOptions.

It seems on Chromium the request does go through, so the toggling does occur. On Firefox it doesn't.

Feb 10 2024, 6:37 PM · Verified, MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), Web-Team-Backlog (FY2023-24 Q3 Sprint 3), Advanced Mobile Contributions, Regression, MobileFrontend
Nardog added a project to T357212: Regression: Can't toggle advanced mode on Special:MobileOptions: Advanced Mobile Contributions.
Feb 10 2024, 6:10 PM · Verified, MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), Web-Team-Backlog (FY2023-24 Q3 Sprint 3), Advanced Mobile Contributions, Regression, MobileFrontend
Nardog created T357212: Regression: Can't toggle advanced mode on Special:MobileOptions.
Feb 10 2024, 6:08 PM · Verified, MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), Web-Team-Backlog (FY2023-24 Q3 Sprint 3), Advanced Mobile Contributions, Regression, MobileFrontend
Nardog added a comment to T357202: Thanks button missing from mobile diff.

Other buttons are not showing up either, i.e. "Mark as patrolled" (for users with the "patrol" user right in wikis with $wgUseRCPatrol set to true).

Feb 10 2024, 5:15 PM · Verified, MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), patch-welcome, Web-Team-Backlog (Needs Prioritization (Tech)), Regression, Moderator-Tools-Team, MinervaNeue, Growth-Team, Thanks, MobileFrontend
Nardog added a comment to T357202: Thanks button missing from mobile diff.

If I click use desktop site in browser it shows.

It gets hidden when the viewport is <720px wide. The z-index here is too low.

Feb 10 2024, 5:12 PM · Verified, MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), patch-welcome, Web-Team-Backlog (Needs Prioritization (Tech)), Regression, Moderator-Tools-Team, MinervaNeue, Growth-Team, Thanks, MobileFrontend
Nardog added a comment to T240624: Style desktop Minerva diff page to look like Special:MobileDiff .

Seems to have caused T357202: Thanks button missing from mobile diff

Feb 10 2024, 8:58 AM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Patch-For-Review, Moderator-Tools-Team, Web-Team-Backlog (Needs Prioritization (Tech)), MinervaNeue, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Jdlrobson, Technical-Debt (RW-Tech-Debt)
Nardog added projects to T357202: Thanks button missing from mobile diff: MinervaNeue, Moderator-Tools-Team.
Feb 10 2024, 8:56 AM · Verified, MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), patch-welcome, Web-Team-Backlog (Needs Prioritization (Tech)), Regression, Moderator-Tools-Team, MinervaNeue, Growth-Team, Thanks, MobileFrontend
Nardog renamed T357202: Thanks button missing from mobile diff from Thanks button missing - contribution mobile view to Thanks button missing from mobile diff.
Feb 10 2024, 8:54 AM · Verified, MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), patch-welcome, Web-Team-Backlog (Needs Prioritization (Tech)), Regression, Moderator-Tools-Team, MinervaNeue, Growth-Team, Thanks, MobileFrontend
Nardog renamed T357202: Thanks button missing from mobile diff from Thanks button missing from mobile diff to Thanks button missing - contribution mobile view.
Feb 10 2024, 8:52 AM · Verified, MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), patch-welcome, Web-Team-Backlog (Needs Prioritization (Tech)), Regression, Moderator-Tools-Team, MinervaNeue, Growth-Team, Thanks, MobileFrontend
Nardog renamed T357202: Thanks button missing from mobile diff from Thanks button missing - contribution mobile view to Thanks button missing from mobile diff.
Feb 10 2024, 8:50 AM · Verified, MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), patch-welcome, Web-Team-Backlog (Needs Prioritization (Tech)), Regression, Moderator-Tools-Team, MinervaNeue, Growth-Team, Thanks, MobileFrontend
Nardog added a project to T357202: Thanks button missing from mobile diff: Thanks.
Feb 10 2024, 8:49 AM · Verified, MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), patch-welcome, Web-Team-Backlog (Needs Prioritization (Tech)), Regression, Moderator-Tools-Team, MinervaNeue, Growth-Team, Thanks, MobileFrontend
Nardog added a project to T357202: Thanks button missing from mobile diff: MobileFrontend.
Feb 10 2024, 8:48 AM · Verified, MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), patch-welcome, Web-Team-Backlog (Needs Prioritization (Tech)), Regression, Moderator-Tools-Team, MinervaNeue, Growth-Team, Thanks, MobileFrontend

Feb 7 2024

Nardog closed T355636: CategoryTree toggles cannot be reached by keyboard as Resolved.
Feb 7 2024, 2:42 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Accessibility, MediaWiki-extensions-CategoryTree

Feb 1 2024

Nardog added a comment to T352308: Port remaining files to jsdoc in MediaWiki core.

What would also be nice that was present in JSDuck is the ability to toggle private/protected items.

Feb 1 2024, 12:44 AM · MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), JSDoc WMF theme, Patch-For-Review, MediaWiki CodeJam Dec 2023, Tech-Docs-Team, Epic, Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, Documentation

Jan 31 2024

Jdlrobson awarded T356186: "Uncaught DOMException: Element.closest: '' is not a valid selector" a Love token.
Jan 31 2024, 6:28 PM · Reference Previews, JavaScript, Wikimedia-production-error, Page-Previews
Nardog removed a project from T356186: "Uncaught DOMException: Element.closest: '' is not a valid selector": Navigation-Popups-Gadget.
Jan 31 2024, 5:00 AM · Reference Previews, JavaScript, Wikimedia-production-error, Page-Previews
Nardog added a comment to T356186: "Uncaught DOMException: Element.closest: '' is not a valid selector".

I didn't have the Navigation Popups gadget enabled and I still got the error.

Jan 31 2024, 4:48 AM · Reference Previews, JavaScript, Wikimedia-production-error, Page-Previews
Nardog renamed T356186: "Uncaught DOMException: Element.closest: '' is not a valid selector" from "Uncaught DOMException: Element.closest: '' is not a valid selector" when Page Previews is disabled but Navigation Popups gadget is enabled to "Uncaught DOMException: Element.closest: '' is not a valid selector".
Jan 31 2024, 4:46 AM · Reference Previews, JavaScript, Wikimedia-production-error, Page-Previews

Jan 30 2024

Nardog updated the task description for T356186: "Uncaught DOMException: Element.closest: '' is not a valid selector".
Jan 30 2024, 3:22 PM · Reference Previews, JavaScript, Wikimedia-production-error, Page-Previews
Nardog added a comment to T356186: "Uncaught DOMException: Element.closest: '' is not a valid selector".
Uncaught DOMException: Element.closest: '' is not a valid selector
    Me https://en.wikipedia.org/w/extensions/Popups/src/preview/model.js:127
    EventListener.handleEvent* https://en.wikipedia.org/w/extensions/Popups/src/index.js:299
    <anonymous> https://en.wikipedia.org/w/extensions/Popups/src/index.js:178
    <anonymous> https://en.wikipedia.org/w/extensions/Popups/resources/dist/index.js?51e95:1
    <anonymous> https://en.wikipedia.org/w/extensions/Popups/resources/dist/index.js?51e95:1
Jan 30 2024, 3:15 PM · Reference Previews, JavaScript, Wikimedia-production-error, Page-Previews
Nardog added a comment to T356186: "Uncaught DOMException: Element.closest: '' is not a valid selector".

Does it happen with safemode on for you (i.e. on https://en.wikipedia.org/wiki/Main_Page?safemode=1)?

Jan 30 2024, 3:10 PM · Reference Previews, JavaScript, Wikimedia-production-error, Page-Previews
Nardog added a comment to T355933: Reference Previews not showing when users disable page previews in settings.

Is this going to fix T356186: "Uncaught DOMException: Element.closest: '' is not a valid selector"?

Jan 30 2024, 3:05 PM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-01-17, Page-Previews, Reference Previews
Nardog created T356186: "Uncaught DOMException: Element.closest: '' is not a valid selector".
Jan 30 2024, 2:55 PM · Reference Previews, JavaScript, Wikimedia-production-error, Page-Previews
Nardog lowered the priority of T356157: Unable to fetch Parsoid HTML from Unbreak Now! to Needs Triage.
Jan 30 2024, 8:24 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Content-Transform-Team, Essential-Work, MediaWiki-REST-API, MediaWiki-Engineering, DiscussionTools, Parsoid, VisualEditor
Nardog triaged T356157: Unable to fetch Parsoid HTML as Unbreak Now! priority.
Jan 30 2024, 8:00 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Content-Transform-Team, Essential-Work, MediaWiki-REST-API, MediaWiki-Engineering, DiscussionTools, Parsoid, VisualEditor
Nardog created T356157: Unable to fetch Parsoid HTML.
Jan 30 2024, 8:00 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Content-Transform-Team, Essential-Work, MediaWiki-REST-API, MediaWiki-Engineering, DiscussionTools, Parsoid, VisualEditor

Jan 29 2024

Nardog closed T296197: Rename `getSaneType`, a subtask of T254646: Reconsidering how we name things, as Resolved.
Jan 29 2024, 4:57 AM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), User-brennen, MediaWiki-extensions-General, WMF-General-or-Unknown, MediaWiki-General, Patch-For-Review, Voice & Tone
Nardog closed T296197: Rename `getSaneType` as Resolved.
Jan 29 2024, 4:57 AM · OOUI

Jan 28 2024

Nardog updated the task description for T259059: Upgrade to CodeMirror 6.
Jan 28 2024, 7:11 AM · Community-Tech (CommTech-Kanban), Epic, MediaWiki-extensions-CodeMirror, WMDE-TechWish, User-thiemowmde, WMDE-Templates-FocusArea, WMDE-TechWish-Maintenance