| • alexhollender_WMF | |
| Sep 23 2021, 5:44 PM |
| F41547421: Screenshot 2023-11-29 at 4.15.14 PM.png | |
| Nov 30 2023, 12:17 AM |
| F41547425: Screenshot 2023-11-29 at 4.15.44 PM.png | |
| Nov 30 2023, 12:17 AM |
| F41547419: Screenshot 2023-11-29 at 4.14.37 PM.png | |
| Nov 30 2023, 12:17 AM |
| F41547417: Screenshot 2023-11-29 at 4.14.16 PM.png | |
| Nov 30 2023, 12:17 AM |
There is a setting within preferences called Enable responsive mode. As the description within the setting says this setting "May have no effect on some skins". In order to keep preferences as clutter-free as possible, and also to avoid confusion (in the case where someone doesn't read the description), I wonder if we should:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T291656 Don't show "Enable responsive mode" setting on Vector 2010 | |||
| Open | BUG REPORT | None | T352485 Inconsistency in skin responsive preference when $wgVectorResponsive is false. | ||
| Resolved | BUG REPORT | Func | T352358 Skin preferences section shows/hides based on the previous skin selection |
Vecotr is the only skin that doesn't support this currently and Vector /could/ support it if we wanted.
The skins that support this are currently MonoBook, Minerva and Timeless.
The skins that don't are CologneBlue and Modern and are hidden.
I think the real problem here is the wording is not right.
Perhaps the preference could be made less confusing. All skins have a desktop version, so perhaps that could be repurposed as "Always give me desktop-mode when using my skin" and made an opt out.
That still wouldn't have any effect on Vector but it would still be true so wouldn't need that confusing text.
Change 726001 had a related patch set uploaded (by Ammarpad; author: Ammarpad):
[mediawiki/core@master] Reword responsive skin option help message
Backing up and trying to clarify what this setting does: if you turn the setting on, then access Wikipedia on your mobile phone, then request the Desktop version of the site, the setting will have turned viewport optimizing so you will see a different version of the site than you otherwise would have. If that understanding is correct I'm not sure "adapt layout to screen size makes sense" — that makes me think "give me the responsive version of this skin" (which should/does(?) happen by default...there's no non-responsive version of a skin?), but it's actually more specific/nuanced than that. It seems more like "When requesting the desktop site from a mobile device, don't optimize the viewport".
To further clarify, this setting will have no affect on your desktop experience, it is only relevant for mobile devices? If that's the case then the setting should probably mention mobile devices.
Higher level, unless we do a better job of establishing that some settings only apply to some skins I don't think we can rely on the setting description to clarify that. I think we're just setting people up for confusion.
Change 726001 merged by jenkins-bot:
[mediawiki/core@master] Reword responsive skin option help message
@ovasileva I chatted with Alex about this and there was some confusion. I think we decided this was not a high priority and a possible distraction from desktop improvements. If that's changed maybe the three of us should sync to come up with a plan here ?
The only skins that this preference doesn't apply to are Vector, Modern and CologneBlue (and the latter two are hidden by default). It would be trivial to make this preference apply to modern Vector (not legacy) but it would also make the Vector skin responsive on mobile (which the user can opt-out of). On https://test.wikipedia.org/ all the skins abide to this preference. Personally I think this is how this should work.
To hide the preference for Vector would incur technical debt, and I don't think that would be acceptable without a plan to address this problem. There is no way to easily determine which skins this setting applies to.
We might want to think a bit more about preferences that apply to some skins as I can imagine this list growing. For example, a dark mode preference presumably would only apply to skins where a dark mode is available. I would imagine this being presented as "Use dark mode if available [] "
Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:
Change 881816 had a related patch set uploaded (by Func; author: Func):
[mediawiki/core@master] preferences: Only show the "responsive mode" setting for relevant skins
Change 881816 merged by jenkins-bot:
[mediawiki/core@master] preferences: Only show the "responsive mode" setting for relevant skins
Working as advertised on https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering
Note: it currently still shows for Modern Vector given isResponsive is declared dynamically which will be fixed as part of T106463.
Apologies for bumping, but I do notice a problem.
Is it just me, or is Vector 2022 still not displaying in responsive mode despite checking the relevant box?
Feel free to delegate to a new task if this is in fact the problem.
@Awesome_Aasim: Hard to tell without any URL provided. Please always provide clear steps to reproduce, plus try safemode. Thanks.
Is it just me, or is Vector 2022 still not displaying in responsive mode despite checking the relevant box?
Hey @Awesome_Aasim thanks for the bump!
Vector 2022 is currently not officially a responsive skin. It's not supported below 500px. The issues for this are mainly political.
We're tracking making it responsive inside T106463. The most helpful thing to move this along would be if the community drove this by approving an RFC on enwiki. Enabling this feature would mean that people who don't want a responsive skin (similar to Timeless) would need to go to Special:Preferences and uncheck the box which might be a one time disruption to their workflow.
If V22 responsive mode isn't completely ready yet, shouldn't it be declared as *not* responsive for now?
@aliu I'm not sure I understand the question:
The "responsive" setting should not show up for Vector 2022 or Vector
but should show up for Timeless, Monobook and Minerva:
For me, on selecting V10 from anything, there's an empty Skin preferences section. When I switch to another radio button after selecting v10, there is no Skin preferences section at all (as you demonstrate in your first screenshot), even though V22 has a limited width mode option. When I switch to selecting V22 from any option that isn't V10, both checkboxes are visible.
Hmmm yeh this sounds like a new bug. I wonder what changed. Could you open a new ticket for us? (If not I can do this later in the week!)
Not quite a new bug though, but it seems more reproducible than half a year ago.
Now I have a patch for it, so I created T352358 to attach to.