Page MenuHomePhabricator

Skin preferences section shows/hides based on the previous skin selection
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The skin preferences section show/hide based on the previous selection, to be specific:

  • Select Vector 2010 from anything, there's an empty Skin preferences section.
  • Switch to another radio button after selecting Vector 2010, there is no Skin preferences section at all, even though Vector 2022 has a limited width mode option.
  • Switch to selecting Vector 2022 from any option that isn't Vector 2010, both checkboxes are visible.

What should have happened instead?:

The skin preferences section show/hide based on the current selection.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Associated code: resources/src/mediawiki.special.preferences.ooui/skinPrefs.js

Event Timeline

Change 978650 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] skinPrefs: Show/hide the skin prefs section after hide-if executed

https://gerrit.wikimedia.org/r/978650

aliu renamed this task from Skin preferences section show/hide based on the previous selection to Skin preferences section shows/hides based on the previous skin selection.Nov 30 2023, 3:04 PM
aliu subscribed.

Change 978650 merged by jenkins-bot:

[mediawiki/core@master] skinPrefs: Show/hide the skin prefs section after hide-if executed

https://gerrit.wikimedia.org/r/978650

matmarex assigned this task to Func.