Page MenuHomePhabricator

Func (Func)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 15 2020, 3:00 PM (26 w, 5 d)
Availability
Available
LDAP User
Func
MediaWiki User
Func86 [ Global Accounts ]

Recent Activity

Mon, Jun 14

Func created T284894: MobileFrontend editor not compatible with ConfirmEdit/reCAPTCHA.
Mon, Jun 14, 7:52 AM · Editing-team, ConfirmEdit (CAPTCHA extension), MobileFrontend

Apr 26 2021

Func committed rEMEU8c864e9d7092: Handle EditFilterMergedContent hook properly to break hook chains and display… (authored by Func).
Handle EditFilterMergedContent hook properly to break hook chains and display…
Apr 26 2021, 8:07 AM

Apr 21 2021

Func added a comment to T272302: Even if set as global and not checking "set a local exception", "Allow emails from brand-new users" preference can still be locally changed.

I will test this after patch of T279256 get deployed.

Apr 21 2021, 3:29 PM · Patch-For-Review, Community-Tech, MediaWiki-extensions-GlobalPreferences, MediaWiki-User-preferences
Func committed rECNS571a707b3b99: Query for array of join with ActorMigration::getJoin() to improve performance (authored by Func).
Query for array of join with ActorMigration::getJoin() to improve performance
Apr 21 2021, 12:02 PM

Apr 17 2021

Func added a comment to T279942: Why the type of values in mCategories in serialized data for ParserOutputTest::testDeserialization is int?.

Maybe we should add more comments to define parameter type and provide document for ParserOutput so that phan and other CI tests can take part in.

Apr 17 2021, 1:13 PM · MediaWiki-Parser
Func updated subscribers of T278639: Add language redirects or backwards fallbacks for Special:MyLanguage.

In Change 675291, @Nikerabbit wrote:
From product perspective this should just work out of the box and not require any configuration.

The underlying cause, which makes Chinese not work here, is that none of the Chinese languages include zh in their fallbacks. Adding zh to their fallback chains should be a simple fix, assuming there aren't any negative side effects.

Apr 17 2021, 1:00 PM · MediaWiki-Internationalization, I18n, Patch-For-Review
Func renamed T278639: Add language redirects or backwards fallbacks for Special:MyLanguage from Add language redirects for Special:MyLanguage to Add language redirects or backwards fallbacks for Special:MyLanguage.
Apr 17 2021, 12:43 PM · MediaWiki-Internationalization, I18n, Patch-For-Review
Func added a comment to T273354: Set $status->value in EditFilterMergedContentHookConstraint::checkConstraint() properly to display error message.

In Change 680687, @Umherirrender wrote:
Returning false with that value acts the same as returning true with a fatal Status?

Why this change? What does this change fix? Is there an error with the hook to fix?

If this is for the deprecation of the fatal Status usage here, that should be done with a deprecation cycles.

Apr 17 2021, 12:29 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MediaWiki-Core-Hooks, MediaWiki-Page-editing
Func added a comment to T279942: Why the type of values in mCategories in serialized data for ParserOutputTest::testDeserialization is int?.

@daniel and @Pchelolo: I found you are authors of files under \tests\phpunit\data\ParserCache, could you please check this out? Thanks!

Apr 17 2021, 5:06 AM · MediaWiki-Parser

Apr 16 2021

Func added a comment to T280312: Handle EditFilterMergedContent hook properly to display error message.

https://codesearch.wmcloud.org/extensions/?q=EditFilterMergedContent

Apr 16 2021, 3:39 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Patch-For-Review
Func renamed T280312: Handle EditFilterMergedContent hook properly to display error message from Handle EditFilterMergedContent hook porperly to display error message to Handle EditFilterMergedContent hook properly to display error message.
Apr 16 2021, 3:12 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Patch-For-Review
Func created T280312: Handle EditFilterMergedContent hook properly to display error message.
Apr 16 2021, 5:27 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Patch-For-Review

Apr 15 2021

Func added a comment to T279256: Checkbox of "Allow emails from brand-new users" is modifiable for user without email.

This checkbox is enabled by Js.

Apr 15 2021, 3:53 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MediaWiki-User-preferences

Apr 13 2021

Func added a project to T279256: Checkbox of "Allow emails from brand-new users" is modifiable for user without email: OOUI.

I found there is oo-ui-fieldLayout-disabled class in the outer div, but the inputbox has aria-disabled="false" attitude.
Maybe a problem related to OOUI.

Apr 13 2021, 3:26 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MediaWiki-User-preferences
Func moved T279942: Why the type of values in mCategories in serialized data for ParserOutputTest::testDeserialization is int? from Backlog to ParserOutput on the MediaWiki-Parser board.
Apr 13 2021, 5:43 AM · MediaWiki-Parser
Func renamed T279942: Why the type of values in mCategories in serialized data for ParserOutputTest::testDeserialization is int? from Why the type of mCategories in serialized data for ParserOutputTest::testDeserialization is int? to Why the type of values in mCategories in serialized data for ParserOutputTest::testDeserialization is int?.
Apr 13 2021, 5:42 AM · MediaWiki-Parser
Func added a comment to T278658: Code break shown when searching "-{" on Wikidata.

Very good idea! It seems not to break, but the form is now prefilled with -{ (not a big problem)...

Apr 13 2021, 5:25 AM · Wikidata

Apr 12 2021

Func created T279942: Why the type of values in mCategories in serialized data for ParserOutputTest::testDeserialization is int?.
Apr 12 2021, 4:00 PM · MediaWiki-Parser
Func added a comment to T278658: Code break shown when searching "-{" on Wikidata.

Oh, the problem is that title with big quote isn't a valid title, and unpaired big quotes broke the parsing process. Maybe we can check the title in lua module, with mw.title.new and check the return value...

Apr 12 2021, 3:47 PM · Wikidata
Func added a comment to T278658: Code break shown when searching "-{" on Wikidata.

Oh, the problem is that title with big quote isn't a valid title, and unpaired big quotes broke the parsing process. Maybe we can check the title in lua module, with mw.title.new and check the return value...

Apr 12 2021, 3:37 PM · Wikidata

Apr 10 2021

Func added a comment to T249268: Reduce size of artifacts stored on the CI Jenkins master.

@hashar: Are there any problematic backend changes? The mediawiki-fresnel-patch-docker didn't work properly still.

13:12:57 INFO:quibble.commands:<<< Finish: User commands: mediawiki-fresnel-patch, in 52.834 s
13:12:57 INFO:backend.ChromeWebDriver:Terminating ChromeWebDriver
13:12:57 INFO:backend.PhpWebserver:Terminating PhpWebserver
13:12:57 INFO:backend.MySQL:Terminating MySQL
13:12:59 Traceback (most recent call last):
13:12:59   File "/usr/local/bin/quibble", line 11, in <module>
13:12:59     load_entry_point('quibble==0.0.46', 'console_scripts', 'quibble')()
13:12:59   File "/usr/local/lib/python3.5/dist-packages/quibble/cmd.py", line 639, in main
13:12:59     cmd.execute(plan, dry_run=args.dry_run)
13:12:59   File "/usr/local/lib/python3.5/dist-packages/quibble/cmd.py", line 402, in execute
13:12:59     quibble.commands.execute_command(command)
13:12:59   File "/usr/local/lib/python3.5/dist-packages/quibble/commands.py", line 22, in execute_command
13:12:59     command.execute()
13:12:59   File "/usr/local/lib/python3.5/dist-packages/quibble/commands.py", line 838, in execute
13:12:59     subprocess.check_call(cmd, shell=True, cwd=self.mw_install_path)
13:12:59   File "/usr/lib/python3.5/subprocess.py", line 271, in check_call
13:12:59     raise CalledProcessError(retcode, cmd)
13:12:59 subprocess.CalledProcessError: Command 'mediawiki-fresnel-patch' returned non-zero exit status 1
13:13:00 Build step 'Execute shell' marked build as failure
Apr 10 2021, 5:22 AM · Release-Engineering-Team (Doing), Patch-For-Review, Technical-Debt, Continuous-Integration-Infrastructure
Func added a comment to T269341: API:Block should validate page restrictions.

Some warnings appeared on later changes, I found it related to this task.

23:19:51 Running "banana:core" (banana) task
23:19:57 >> 1 message lacks documentation in qqq.json.
23:19:57 >> Message "cant-block-nonexistent-page" lacks documentation in qqq.json.
23:19:57 Warning: Task "banana:core" failed. Use --force to continue.
Apr 10 2021, 5:20 AM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Blocks

Apr 9 2021

Func added a comment to T269341: API:Block should validate page restrictions.

Some warnings appeared on later changes, I found it related to this task.

23:19:51 Running "banana:core" (banana) task
23:19:57 >> 1 message lacks documentation in qqq.json.
23:19:57 >> Message "cant-block-nonexistent-page" lacks documentation in qqq.json.
23:19:57 Warning: Task "banana:core" failed. Use --force to continue.
Apr 9 2021, 4:06 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Blocks

Apr 8 2021

Func added a comment to T278658: Code break shown when searching "-{" on Wikidata.

Reopening because I don't know how to solve it locally (other than by reverting T263258 or even T132729).

Apr 8 2021, 3:17 PM · Wikidata

Apr 6 2021

Func created T279444: Single revision would be marked for translation multiple times by Translate extension.
Apr 6 2021, 3:27 PM · MediaWiki-extensions-Translate
Func renamed T278639: Add language redirects or backwards fallbacks for Special:MyLanguage from Add extra fallbacks for Special:MyLanguage to Add language redirects for Special:MyLanguage.
Apr 6 2021, 5:40 AM · MediaWiki-Internationalization, I18n, Patch-For-Review
Func added a comment to T278639: Add language redirects or backwards fallbacks for Special:MyLanguage.

I think because the fallback chains are mainly for system message and title lookup.
Chinese have two major scripts, zh-hans and zh-hant, there are many different character between them, so mediawiki maintained them in the center of fallback chains, and others(e.g. zh-hk) which slightly different from one of them can fallback to them.
Maybe according to population of zh-hans and zh-hant users, zh-hant and zh fallback to zh-hans.
So, message storage file of zh is empty, should't be a fallback target.
This fallback method works well in message display, but not fit for wiki subpages.

Apr 6 2021, 5:39 AM · MediaWiki-Internationalization, I18n, Patch-For-Review

Apr 5 2021

Func added a comment to T278639: Add language redirects or backwards fallbacks for Special:MyLanguage.

In fact users of almost all languages(variants) in $wgTranslateBlacklist (CommonSettings.php#2902) would face this problem.

Apr 5 2021, 5:38 AM · MediaWiki-Internationalization, I18n, Patch-For-Review

Apr 4 2021

Func created T279256: Checkbox of "Allow emails from brand-new users" is modifiable for user without email.
Apr 4 2021, 3:48 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MediaWiki-User-preferences

Apr 3 2021

Func added a comment to T249268: Reduce size of artifacts stored on the CI Jenkins master.

https://gerrit.wikimedia.org/r/676291
Did this change make anything wrong with mediawiki-fresnel-patch-docker?
See: https://integration.wikimedia.org/ci/job/mediawiki-fresnel-patch-docker/37231/consoleFull

15:02:28 + find log/ -name '*trace.json' -exec gzip '{}' +
15:02:28 gzip: log/fresnel_records/before/scenario-View recent changes-run-3/trace--trace.json.gz: Permission denied
15:02:28 gzip: log/fresnel_records/before/scenario-View recent changes-run-5/trace--trace.json.gz: Permission denied
15:02:28 gzip: log/fresnel_records/before/scenario-View history of a page-run-3/trace--trace.json.gz: Permission denied
...
15:02:28 gzip: log/fresnel_records/after/scenario-Read a page-run-6/trace--trace.json.gz: Permission denied
15:02:28 gzip: log/fresnel_records/after/scenario-Read a page-run-4/trace--trace.json.gz: Permission denied
15:02:28 Build step 'Execute scripts' changed build result to FAILURE
15:02:28 Build step 'Execute scripts' marked build as failure
Apr 3 2021, 10:11 AM · Release-Engineering-Team (Doing), Patch-For-Review, Technical-Debt, Continuous-Integration-Infrastructure

Mar 28 2021

Func created T278639: Add language redirects or backwards fallbacks for Special:MyLanguage.
Mar 28 2021, 5:33 AM · MediaWiki-Internationalization, I18n, Patch-For-Review

Mar 21 2021

Func claimed T278030: Improve performance of ContributionScores extension.
Mar 21 2021, 4:47 AM · Patch-For-Review, Performance Issue, ContributionScores
Func created T278030: Improve performance of ContributionScores extension.
Mar 21 2021, 1:19 AM · Patch-For-Review, Performance Issue, ContributionScores

Mar 20 2021

Func created T278001: Prepare for 'comment' option which will be introduced into RevisionStore::getQueryInfo().
Mar 20 2021, 10:56 AM · Patch-For-Review, MediaWiki-Revision-backend
Func created T277997: Make join with comment table optional in RevisionStore::getQueryInfo().
Mar 20 2021, 5:32 AM · Patch-For-Review, Performance Issue, MediaWiki-Revision-backend

Mar 18 2021

Func removed a project from T274122: Number of pages of category which relate with LanguageConverter can't update properly in category table: Patch-For-Review.
Mar 18 2021, 3:15 PM · Chinese-Sites, MediaWiki-Categories
Func updated subscribers of T274048: Pages written in Traditional Chinese for category didn't show up in category page in Simplified Chinese which created AFTER the article.
Mar 18 2021, 3:14 PM · MediaWiki-Parser, Patch-For-Review, MediaWiki-Categories, Chinese-Sites
Func added a project to T274048: Pages written in Traditional Chinese for category didn't show up in category page in Simplified Chinese which created AFTER the article: MediaWiki-Parser.
Mar 18 2021, 3:12 PM · MediaWiki-Parser, Patch-For-Review, MediaWiki-Categories, Chinese-Sites

Mar 17 2021

Func closed T180561: Setting temporary user rights change to an exclusionary group (i.e. bots) doesn't update score table when permission expires as Resolved.
Mar 17 2021, 3:18 PM · ContributionScores
Func closed T160020: Update ContributionScores for expiring user groups, a subtask of T157015: Update extensions for expiring user groups, as Resolved.
Mar 17 2021, 3:17 PM · MW-1.29-release-notes, Stewards-and-global-tools (Temporary-UserRights), good first task, MediaWiki-extensions-General
Func closed T160020: Update ContributionScores for expiring user groups as Resolved.
Mar 17 2021, 3:17 PM · ContributionScores
Func committed rECNS4dc3f4fc3e19: Update ContributionScores for expiring user groups (authored by Func).
Update ContributionScores for expiring user groups
Mar 17 2021, 12:26 PM

Feb 19 2021

Func committed rECNS9f53a1eba9bf: Set descriptionmsg in extension.json correctly (authored by Func).
Set descriptionmsg in extension.json correctly
Feb 19 2021, 4:02 PM

Feb 17 2021

Func added a comment to T273354: Set $status->value in EditFilterMergedContentHookConstraint::checkConstraint() properly to display error message.

@matmarex Thanks! And would you like help to check the problem below?

And maybe use $status->fatal() without returning false in this hook should be deprecated? There is a bug with this undocumented usage: T271037

Feb 17 2021, 4:26 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MediaWiki-Core-Hooks, MediaWiki-Page-editing

Feb 12 2021

Func added a project to T273354: Set $status->value in EditFilterMergedContentHookConstraint::checkConstraint() properly to display error message: MediaWiki-Core-Hooks.
Feb 12 2021, 12:39 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MediaWiki-Core-Hooks, MediaWiki-Page-editing
Func added a comment to T273354: Set $status->value in EditFilterMergedContentHookConstraint::checkConstraint() properly to display error message.

Acording to codesearch, up to now, NO extension returning false will "display an error message on its own", so user can see nothing about their mistake.
See:

  1. TranslateHooks.php#1153
  2. NewsletterHooks.php#359
  3. GadgetHooks.php#329
  4. AkismetKlik.php#39
Feb 12 2021, 12:31 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MediaWiki-Core-Hooks, MediaWiki-Page-editing

Feb 11 2021

Func added a comment to T273354: Set $status->value in EditFilterMergedContentHookConstraint::checkConstraint() properly to display error message.

After looking into it, I don't think the proposed change is correct… I believe that with the AS_HOOK_ERROR status, it's expected that your extension has already displayed an error message on its own. Changing it to AS_HOOK_ERROR_EXPECTED could break compatibility.

Feb 11 2021, 5:08 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MediaWiki-Core-Hooks, MediaWiki-Page-editing

Feb 8 2021

Func placed T274122: Number of pages of category which relate with LanguageConverter can't update properly in category table up for grabs.
Feb 8 2021, 2:56 PM · Chinese-Sites, MediaWiki-Categories
Func claimed T274048: Pages written in Traditional Chinese for category didn't show up in category page in Simplified Chinese which created AFTER the article.
Feb 8 2021, 2:54 PM · MediaWiki-Parser, Patch-For-Review, MediaWiki-Categories, Chinese-Sites
Func added a project to T274048: Pages written in Traditional Chinese for category didn't show up in category page in Simplified Chinese which created AFTER the article: Patch-For-Review.
Feb 8 2021, 2:54 PM · MediaWiki-Parser, Patch-For-Review, MediaWiki-Categories, Chinese-Sites
Func placed T274048: Pages written in Traditional Chinese for category didn't show up in category page in Simplified Chinese which created AFTER the article up for grabs.
Feb 8 2021, 2:54 PM · MediaWiki-Parser, Patch-For-Review, MediaWiki-Categories, Chinese-Sites
Func claimed T274048: Pages written in Traditional Chinese for category didn't show up in category page in Simplified Chinese which created AFTER the article.
Feb 8 2021, 2:48 PM · MediaWiki-Parser, Patch-For-Review, MediaWiki-Categories, Chinese-Sites
Func merged task T274122: Number of pages of category which relate with LanguageConverter can't update properly in category table into T274048: Pages written in Traditional Chinese for category didn't show up in category page in Simplified Chinese which created AFTER the article.
Feb 8 2021, 2:48 PM · Chinese-Sites, MediaWiki-Categories
Func merged T274122: Number of pages of category which relate with LanguageConverter can't update properly in category table into T274048: Pages written in Traditional Chinese for category didn't show up in category page in Simplified Chinese which created AFTER the article.
Feb 8 2021, 2:47 PM · MediaWiki-Parser, Patch-For-Review, MediaWiki-Categories, Chinese-Sites
Func added a comment to T274048: Pages written in Traditional Chinese for category didn't show up in category page in Simplified Chinese which created AFTER the article.

Haha, the patchset I created for T274122 can also solve this problem...Surprise...

Feb 8 2021, 2:46 PM · MediaWiki-Parser, Patch-For-Review, MediaWiki-Categories, Chinese-Sites
Func claimed T274122: Number of pages of category which relate with LanguageConverter can't update properly in category table.
Feb 8 2021, 1:18 PM · Chinese-Sites, MediaWiki-Categories
Func created T274122: Number of pages of category which relate with LanguageConverter can't update properly in category table.
Feb 8 2021, 11:38 AM · Chinese-Sites, MediaWiki-Categories
Func closed T174046: Convert ContributionScores to use extension registration, a subtask of T98668: Convert all extensions and skins on gerrit to use extension registration, as Resolved.
Feb 8 2021, 8:49 AM · Patch-For-Review, Google-Code-in-2019, Google-Code-in-2018, User-Kizule, MediaWiki-extensions-General, Goal, MediaWiki-Configuration
Func closed T174046: Convert ContributionScores to use extension registration as Resolved.
Feb 8 2021, 8:49 AM · Patch-For-Review, ContributionScores
Func committed rECNSb8a91c673168: Convert ContributionScores to use extension registration (authored by Func).
Convert ContributionScores to use extension registration
Feb 8 2021, 7:52 AM

Feb 7 2021

Func added a project to T274048: Pages written in Traditional Chinese for category didn't show up in category page in Simplified Chinese which created AFTER the article: Chinese-Sites.
Feb 7 2021, 2:48 AM · MediaWiki-Parser, Patch-For-Review, MediaWiki-Categories, Chinese-Sites
Func created T274048: Pages written in Traditional Chinese for category didn't show up in category page in Simplified Chinese which created AFTER the article.
Feb 7 2021, 2:35 AM · MediaWiki-Parser, Patch-For-Review, MediaWiki-Categories, Chinese-Sites

Feb 5 2021

Func added a comment to T273354: Set $status->value in EditFilterMergedContentHookConstraint::checkConstraint() properly to display error message.

Can you explain what are the consequences of this change? What extensions are affected?

Feb 5 2021, 3:23 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MediaWiki-Core-Hooks, MediaWiki-Page-editing

Jan 30 2021

Func created T273354: Set $status->value in EditFilterMergedContentHookConstraint::checkConstraint() properly to display error message.
Jan 30 2021, 10:27 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MediaWiki-Core-Hooks, MediaWiki-Page-editing