Page MenuHomePhabricator

APCU cache mixup across wikis (Incorrect namespace displayed as title on a zh.wikivoyage page)
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
It shows <title>维基教科书:互助客栈 - 来自维基导游的旅行指南</title> in Zh-CN and <title>维基语录:互助客栈 - 维基导游</title> in en.
The name is wikibook or other projects not wikivoyage.

What should have happened instead?:
Shows <title>维基导游:互助客栈 - 来自维基导游的旅行指南</title> in Zh-CN and <title>维基导游:互助客栈 - 维基导游</title> in en.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Screenshot_20240328_111333_mark.via.jpg (186×1 px, 45 KB)

Event Timeline

I can confirm this issue on zh-cn, zh-hk and zh-hant, but it shows different title for me, and maybe a little randomness.
It seems this issue doesn't affect another zh variants, it's weird.

Can you explain how that patch is causing the problem? I fail to see the connection.

daniel triaged this task as High priority.Thu, Mar 28, 12:16 PM

Can you explain how that patch is causing the problem? I fail to see the connection.

I have commented on gerrit, I will explain further below.

Previously, the wikiId (WikiMap::getCurrentWikiDbDomain()->getId()) would be used as the fallback for cache keyspace in case the wgCachePrefix config is an empty string. Without a keyspace, the message cache was messed up across sites, so this is a regression of T247562/T247493.

Previously, the wikiId (WikiMap::getCurrentWikiDbDomain()->getId()) would be used as the fallback for cache keyspace in case the wgCachePrefix config is an empty string. Without a keyspace, the message cache was messed up across sites, so this is a regression of T247562/T247493.

So the fix would be this line? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1013392/9/includes/objectcache/ObjectCacheFactory.php#106

Aklapper renamed this task from A problem with the title of a page in zh.wikivoyage to Incorrect namespace displayed as title on a zh.wikivoyage page.Thu, Mar 28, 3:29 PM

Change #1013392 had a related patch set uploaded (by Gergő Tisza; author: Derick Alangi):

[mediawiki/core@master] objectcache: Dependency inject the wiki ID & some improvements

https://gerrit.wikimedia.org/r/1013392

Krinkle renamed this task from Incorrect namespace displayed as title on a zh.wikivoyage page to APCU cache mixup across wikis (Incorrect namespace displayed as title on a zh.wikivoyage page).Thu, Mar 28, 3:59 PM
Krinkle raised the priority of this task from High to Unbreak Now!.

Can this have some regression tests please?

Indeed. I've amended the patch to include a high-level regression test.

Change #1015204 had a related patch set uploaded (by Gergő Tisza; author: Derick Alangi):

[mediawiki/core@wmf/1.42.0-wmf.24] objectcache: Restore default keyspace for LocalServerCache service

https://gerrit.wikimedia.org/r/1015204

Can this have some regression tests please?

Indeed. I've amended the patch to include a high-level regression test.

Correct link: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/580577/1#message-2878732bc9cf7aaffabdac144196cb155784d678

I've been officially promoted to the position of Senior Cassandra in Residence.

Change #1015204 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.24] objectcache: Restore default keyspace for LocalServerCache service

https://gerrit.wikimedia.org/r/1015204

Mentioned in SAL (#wikimedia-operations) [2024-03-28T18:54:24Z] <jhuneidi@deploy1002> Started scap: Backport for [[gerrit:1015204|objectcache: Restore default keyspace for LocalServerCache service (T358346 T361177)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-28T18:56:52Z] <jhuneidi@deploy1002> tgr and jhuneidi: Backport for [[gerrit:1015204|objectcache: Restore default keyspace for LocalServerCache service (T358346 T361177)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-03-28T19:28:24Z] <jhuneidi@deploy1002> Finished scap: Backport for [[gerrit:1015204|objectcache: Restore default keyspace for LocalServerCache service (T358346 T361177)]] (duration: 34m 00s)

Change #1013392 merged by jenkins-bot:

[mediawiki/core@master] objectcache: Restore default keyspace for LocalServerCache service

https://gerrit.wikimedia.org/r/1013392

Tgr claimed this task.

Seems fixed.