1.42.0-wmf.24 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Assigned To

Authored By

	thcipriani
	Mar 14 2024, 10:32 PM

Details

Backup Train Conductor: dancy
Release Version: 1.42.0-wmf.24
Release Date: Mar 25 2024, 12:00 AM

2024 week 13 1.42-wmf.24 Changes wmf/1.42.0-wmf.24

This MediaWiki Train Deployment is scheduled for the week of Monday, March 25th:

Monday March 25th	Tuesday, March 26th	Wednesday, March 27th	Thursday, March 28th	Friday
Backports only.	Branch `wmf.24` and deploy to Group 0 Wikis.	Deploy `wmf.24` to Group 1 Wikis.	Deploy `wmf.24` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.24 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.42.0-wmf.23

Next: 1.42.0-wmf.25

Subject	Repo	Branch	Lines +/-
group2 wikis to 1.42.0-wmf.24	operations/mediawiki-config	master	+333 -333
group1 wikis to 1.42.0-wmf.24	operations/mediawiki-config	master	+549 -549
group0 wikis to 1.42.0-wmf.24	operations/mediawiki-config	master	+132 -132
testwikis wikis to 1.42.0-wmf.24	operations/mediawiki-config	master	+681 -681
group1 wikis to 1.42.0-wmf.24	operations/mediawiki-config	master	+549 -549
group0 wikis to 1.42.0-wmf.24	operations/mediawiki-config	master	+132 -132
testwikis wikis to 1.42.0-wmf.24	operations/mediawiki-config	master	+4 -4
Branch commit for wmf/1.42.0-wmf.24	mediawiki/core	wmf/1.42.0-wmf.24	+1 K -3

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	jeena	T360156 1.42.0-wmf.24 deployment blockers
Resolved	BUG REPORT	Ladsgroup	T361166 All (or almost all) pages in plwikisource are displayed as "pending review"
Resolved	BUG REPORT	Tgr	T361177 APCU cache mixup across wikis (Incorrect namespace displayed as title on a zh.wikivoyage page)

Event Timeline

thcipriani created this task.Mar 14 2024, 10:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2024, 10:32 PM

thcipriani assigned this task to jeena.Mar 14 2024, 10:37 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: dancy.

thcipriani set the point value for this task to 5.

thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).

Jdlrobson mentioned this in T360464: Verify 1.42.0-wmf.24 deployment.Mar 19 2024, 7:13 PM

Risky Patch! 🚂🔥

Change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1012702
Summary: Major clean up of flaggedrevs. As the usual joys of working on FR, it has a lot of configuration freedom leading to weird stuff in random wikis, not very testable nor tested in CI, old unmaintained code, low quality, etc.
Test plan: Manual verification
Places to monitor:
Revert plan: Ping me, if I'm not around, revert the patch.
Affected wikis: flaggedrevs.dblist.
IRC contact: Amir1/@Ladsgroup
UBN Task Projects/tags: MediaWiki-extensions-FlaggedRevs
Would you like to backport this change rather than ride the train?: Testing wouldn't be really possible.

Risky Patch! 🚂🔥

Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/955771
Summary: Major refactor in how we construct and obtain our cache instances with $wgObjectCaches. We've centralized everything to go via MediaWiki service wiring.
Test plan: Ensure infra/sites doesn't go down.
Revert plan: Ping me or Daniel Kinzler, if we're not around, revert the patch.
Affected wikis: dblists/all.dblist and dblists/all-labs.dblist.
IRC contact: xSavitar / duesen
UBN Task Projects/tags: MediaWiki-libs-BagOStuff
Would you like to backport this change rather than ride the train?: Ride the train

Risky Patch! 🚂🔥

Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1004792 and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1004792
Summary: A full refactor of how db replicas are chosen based on the load on them (so called the LoadMonitor class): T314020: LoadMonitor connection weighting reimagined
Test plan: Check the load on db clusters
Places to monitor:
Revert plan: Ping me, if I'm not around, ping Tim
Affected wikis: all.dblist.
IRC contact: Amir1/@Ladsgroup
UBN Task Projects/tags: MediaWiki-libs-Rdbms
Would you like to backport this change rather than ride the train?: Tim simulated this in an event simulator (https://tstarling.com/blog/2024/03/a-discrete-event-simulator-in-php/ and https://phabricator.wikimedia.org/T314020#9652716)

Jdlrobson added a subtask: T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer().Mar 22 2024, 5:33 PM

Fix for T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer() now merged, removing as a blocker

ovasileva removed a subtask: T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer().Mar 25 2024, 5:13 PM

Change #1014051 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.42.0-wmf.24] Branch commit for wmf/1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1014051

gerritbot added a project: Patch-For-Review.Mar 26 2024, 2:07 AM

Change #1014051 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.24] Branch commit for wmf/1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1014051

Change #1014150 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1014150

Change #1014150 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1014150

Mentioned in SAL (#wikimedia-operations) [2024-03-26T03:06:21Z] <mwpresync@deploy1002> Started scap: testwikis wikis to 1.42.0-wmf.24 refs T360156

Mentioned in SAL (#wikimedia-operations) [2024-03-26T05:24:49Z] <dancy@deploy1002> Started scap: testwikis wikis to 1.42.0-wmf.24 refs T360156

Mentioned in SAL (#wikimedia-operations) [2024-03-26T05:51:41Z] <dancy@deploy1002> Finished scap: testwikis wikis to 1.42.0-wmf.24 refs T360156 (duration: 26m 52s)

Change #1014579 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1014579

Change #1014579 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1014579

Mentioned in SAL (#wikimedia-operations) [2024-03-26T18:34:24Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.42.0-wmf.24 refs T360156

Change #1015089 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1015089

Change #1015089 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1015089

Mentioned in SAL (#wikimedia-operations) [2024-03-27T18:25:33Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.42.0-wmf.24 refs T360156

Mentioned in SAL (#wikimedia-operations) [2024-03-27T18:38:11Z] <jhuneidi@deploy1002> Synchronized php: group1 wikis to 1.42.0-wmf.24 refs T360156 (duration: 12m 38s)

Ladsgroup added a subtask: T361166: All (or almost all) pages in plwikisource are displayed as "pending review".Mar 27 2024, 11:58 PM

Ladsgroup closed subtask T361166: All (or almost all) pages in plwikisource are displayed as "pending review" as Resolved.Mar 28 2024, 12:39 AM

Func added a subtask: T361177: APCU cache mixup across wikis (Incorrect namespace displayed as title on a zh.wikivoyage page).Mar 28 2024, 12:30 PM

Change #1015350 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1015350

Change #1015350 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1015350

Mentioned in SAL (#wikimedia-operations) [2024-03-28T16:03:15Z] <brennen@deploy1002> Started scap: testwikis wikis to 1.42.0-wmf.24 refs T360156

Mentioned in SAL (#wikimedia-operations) [2024-03-28T16:17:33Z] <brennen@deploy1002> Finished scap: testwikis wikis to 1.42.0-wmf.24 refs T360156 (duration: 14m 17s)

Change #1015376 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1015376

Change #1015376 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1015376

Mentioned in SAL (#wikimedia-operations) [2024-03-28T19:45:05Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.42.0-wmf.24 refs T360156

Change #1015378 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1015378

Change #1015378 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1015378

Mentioned in SAL (#wikimedia-operations) [2024-03-28T20:06:03Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.42.0-wmf.24 refs T360156

Mentioned in SAL (#wikimedia-operations) [2024-03-28T20:18:37Z] <jhuneidi@deploy1002> Synchronized php: group1 wikis to 1.42.0-wmf.24 refs T360156 (duration: 12m 33s)

In T360156#9670036, @Stashbot wrote:

Mentioned in SAL (#wikimedia-operations) [2024-03-28T16:03:15Z] <brennen@deploy1002> Started scap: testwikis wikis to 1.42.0-wmf.24 refs T360156

Aside, it would be helpful if there would be a mention of rolling back versions somewhere in the log or commit message.

Change #1015385 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1015385

Change #1015385 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.24

https://gerrit.wikimedia.org/r/1015385

Mentioned in SAL (#wikimedia-operations) [2024-03-28T20:58:09Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.42.0-wmf.24 refs T360156

Tgr closed subtask T361177: APCU cache mixup across wikis (Incorrect namespace displayed as title on a zh.wikivoyage page) as Resolved.Mar 28 2024, 9:04 PM

thcipriani closed this task as Resolved.Fri, Mar 29, 6:08 PM

SD_hehua reopened subtask T361177: APCU cache mixup across wikis (Incorrect namespace displayed as title on a zh.wikivoyage page) as Open.Thu, Apr 25, 12:46 PM

Func closed subtask T361177: APCU cache mixup across wikis (Incorrect namespace displayed as title on a zh.wikivoyage page) as Resolved.Thu, Apr 25, 1:14 PM

Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 6:52 PM