Page MenuHomePhabricator
Create Task
Maniphest T360157

1.42.0-wmf.25 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jeena
Release Version
1.42.0-wmf.25
Release Date
Mon, Apr 1, 12:00 AM

2024 week 14 1.42-wmf.25 Changes wmf/1.42.0-wmf.25

This MediaWiki Train Deployment is scheduled for the week of Monday, April 1st:

Monday April 1stTuesday, April 2ndWednesday, April 3rdThursday, April 4thFriday
Backports only.Branch wmf.25 and deploy to Group 0 Wikis.Deploy wmf.25 to Group 1 Wikis.Deploy wmf.25 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.25 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.42.0-wmf.24
Next: 1.42.0-wmf.26
SubjectRepoBranchLines +/-
group2 wikis to 1.42.0-wmf.25operations/mediawiki-configmaster+333 -333
testwikis wikis to 1.42.0-wmf.25operations/mediawiki-configmaster+4 -4
group1 wikis to 1.42.0-wmf.25operations/mediawiki-configmaster+549 -549
group0 wikis to 1.42.0-wmf.25operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.42.0-wmf.25operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.42.0-wmf.25mediawiki/corewmf/1.42.0-wmf.25+996 -3
Customize query in gerrit

Related Objects

Event Timeline

thcipriani created this task.Mar 14 2024, 10:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2024, 10:32 PM
thcipriani assigned this task to jnuche.Mar 14 2024, 10:38 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jeena.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
Jdlrobson mentioned this in T360465: Verify 1.42.0-wmf.25 deployment.Mar 19 2024, 7:14 PM
Jdforrester-WMF subscribed.Mar 28 2024, 2:09 PM
Risky Patch! 🚂🔥
matmarex added subscribers: Dreamy_Jazz, matmarex.Mon, Apr 1, 8:18 PM
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1013374
  • Summary: This change may result in some messages being logged to the 'error' channel. They warn about translations and on-wiki overrides that break the functionality of some special pages, but do not require immediate action and should not block the train. (see T360326)
  • Test plan: n/a
  • Places to monitor:
  • Revert plan: Should not be necessary, please just file a task if you see them and tag @matmarex / @Dreamy_Jazz. If the volume of errors is too much, revert the patch.
  • Affected wikis: all
  • IRC contact: MatmaRex, DreamyJazz
  • UBN Task Projects/tags: MediaWiki-Internationalization
  • Would you like to backport this change rather than ride the train?: No

For reference, the potential error messages look like this:

The option that uses the message key redirect-page has the same translation as another option in en. This means that redirect-page will not be used as an option.
The group flood has the same translation as bot for en. flood will not be displayed in group dropdown of the UsersPager.
The log type merge has the same translation as import for en. merge will not be displayed in the drop down menu on Special:Log.
matmarex mentioned this in T360326: Raise warning on duplicate internationalization key value for the options-messages key of HTMLFormField.Mon, Apr 1, 8:18 PM
Dreamy_Jazz added a comment.Mon, Apr 1, 9:58 PM
In T360157#9677661, @matmarex wrote:
  • IRC contact: MatmaRex, DreamyJazz

My IRC username is Dreamy_Jazz if you need to contact me over IRC.

gerritbot added a comment.Tue, Apr 2, 1:07 AM

Change #1015460 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.42.0-wmf.25] Branch commit for wmf/1.42.0-wmf.25

https://gerrit.wikimedia.org/r/1015460

gerritbot added a project: Patch-For-Review.Tue, Apr 2, 1:07 AM
gerritbot added a comment.Tue, Apr 2, 1:28 AM

Change #1015460 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.25] Branch commit for wmf/1.42.0-wmf.25

https://gerrit.wikimedia.org/r/1015460

gerritbot added a comment.Tue, Apr 2, 3:04 AM

Change #1016069 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.25

https://gerrit.wikimedia.org/r/1016069

gerritbot added a comment.Tue, Apr 2, 8:10 AM

Change #1016291 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.25

https://gerrit.wikimedia.org/r/1016291

gerritbot added a comment.Tue, Apr 2, 8:11 AM

Change #1016291 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.25

https://gerrit.wikimedia.org/r/1016291

Stashbot added a comment.Tue, Apr 2, 9:02 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-02T09:02:53Z] <jnuche@deploy1002> Finished scap: testwikis wikis to 1.42.0-wmf.25 refs T360157 (duration: 51m 03s)

gerritbot added a comment.Tue, Apr 2, 9:07 AM

Change #1016300 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.25

https://gerrit.wikimedia.org/r/1016300

gerritbot added a comment.Tue, Apr 2, 9:08 AM

Change #1016300 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.25

https://gerrit.wikimedia.org/r/1016300

Stashbot added a comment.Tue, Apr 2, 9:22 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-02T09:22:24Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.42.0-wmf.25 refs T360157

TheDJ subscribed.Tue, Apr 2, 11:05 AM
jnuche added a subtask: T361577: Error: Typed property MediaWiki\Rest\RequestBase::$parsedBody must not be accessed before initialization.Tue, Apr 2, 11:19 AM
TheresNoTime removed a subtask: T361577: Error: Typed property MediaWiki\Rest\RequestBase::$parsedBody must not be accessed before initialization.Tue, Apr 2, 4:08 PM
Ladsgroup subscribed.Tue, Apr 2, 9:41 PM
gerritbot added a comment.Wed, Apr 3, 8:04 AM

Change #1016707 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.25

https://gerrit.wikimedia.org/r/1016707

gerritbot added a comment.Wed, Apr 3, 8:05 AM

Change #1016707 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.25

https://gerrit.wikimedia.org/r/1016707

Stashbot added a comment.Wed, Apr 3, 8:33 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-03T08:33:25Z] <jnuche@deploy1002> Synchronized php: group1 wikis to 1.42.0-wmf.25 refs T360157 (duration: 13m 00s)

jnuche mentioned this in T361695: The log type {log_type_one} has the same translation as {log_type_two} for {lang}. {log_type_one} will not be displayed in the drop down menu on Special:Log..Wed, Apr 3, 11:06 AM
jnuche added a comment.Wed, Apr 3, 11:12 AM

Making a note here for T361695. If the error rate climbs up once we deploy to group2 it can possibly require a revert of the patch.

jnuche added a subtask: T361697: TypeError: Argument 2 passed to MediaWiki\TimedMediaHandler\TimedTextPage::getTimedTextHTML() must be of the type string, null given.Wed, Apr 3, 12:06 PM
jnuche removed a subtask: T361697: TypeError: Argument 2 passed to MediaWiki\TimedMediaHandler\TimedTextPage::getTimedTextHTML() must be of the type string, null given.Wed, Apr 3, 12:29 PM
gerritbot added a comment.Wed, Apr 3, 8:14 PM

Change #1016069 abandoned by Jforrester:

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.25

Reason:

Overtaken by events.

https://gerrit.wikimedia.org/r/1016069

gerritbot added a comment.Thu, Apr 4, 8:04 AM

Change #1017015 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.25

https://gerrit.wikimedia.org/r/1017015

gerritbot added a comment.Thu, Apr 4, 8:05 AM

Change #1017015 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.25

https://gerrit.wikimedia.org/r/1017015

taavi subscribed.Fri, Apr 5, 9:34 AM

The timing of T361918: "Reverted" tag no longer applied in reviewable namespaces on wikis with FlaggedRevs since 2024-04-04 suggests a possible issue introduced with this train.

Count_Count subscribed.Fri, Apr 5, 9:47 AM
jnuche closed this task as Resolved.Mon, Apr 8, 8:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL