Page MenuHomePhabricator
Create Task
Maniphest T360158

1.42.0-wmf.26 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jnuche
Release Version
1.42.0-wmf.26
Release Date
Mon, Apr 8, 12:00 AM

2024 week 15 1.42-wmf.26 Changes wmf/1.42.0-wmf.26

This MediaWiki Train Deployment is scheduled for the week of Monday, April 8th:

Monday April 8thTuesday, April 9thWednesday, April 10thThursday, April 11thFriday
Backports only.Branch wmf.26 and deploy to Group 0 Wikis.Deploy wmf.26 to Group 1 Wikis.Deploy wmf.26 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.26 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.42.0-wmf.25
Next: 1.43.0-wmf.1
SubjectRepoBranchLines +/-
group2 wikis to 1.42.0-wmf.26operations/mediawiki-configmaster+333 -333
group1 wikis to 1.42.0-wmf.26operations/mediawiki-configmaster+549 -549
group0 wikis to 1.42.0-wmf.26operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.42.0-wmf.26operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.42.0-wmf.26mediawiki/corewmf/1.42.0-wmf.26+996 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Mar 14 2024, 10:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2024, 10:32 PM
thcipriani assigned this task to hashar.Mar 29 2024, 6:12 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jnuche.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
Jdlrobson mentioned this in T361455: Verify 1.42.0-wmf.26 deployment.Apr 1 2024, 1:04 AM
ihurbain mentioned this in T361858: CTT tasks week of 2024-04-05.Mon, Apr 8, 7:46 AM
SecurityPatchBot added a subtask: Restricted Task.Tue, Apr 9, 12:00 AM
gerritbot added a comment.Tue, Apr 9, 1:07 AM

Change #1017460 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.42.0-wmf.26] Branch commit for wmf/1.42.0-wmf.26

https://gerrit.wikimedia.org/r/1017460

gerritbot added a project: Patch-For-Review.Tue, Apr 9, 1:07 AM
gerritbot added a comment.Tue, Apr 9, 1:29 AM

Change #1017460 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.26] Branch commit for wmf/1.42.0-wmf.26

https://gerrit.wikimedia.org/r/1017460

gerritbot added a comment.Tue, Apr 9, 8:02 AM

Change #1018187 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.26

https://gerrit.wikimedia.org/r/1018187

gerritbot added a comment.Tue, Apr 9, 8:03 AM

Change #1018187 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.26

https://gerrit.wikimedia.org/r/1018187

Stashbot added a comment.Tue, Apr 9, 8:28 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-09T08:28:15Z] <hashar@deploy1002> Started scap: testwikis wikis to 1.42.0-wmf.26 refs T360158

Stashbot added a comment.Tue, Apr 9, 9:18 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-09T09:18:26Z] <hashar@deploy1002> Finished scap: testwikis wikis to 1.42.0-wmf.26 refs T360158 (duration: 50m 11s)

gerritbot added a comment.Tue, Apr 9, 9:27 AM

Change #1018202 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.26

https://gerrit.wikimedia.org/r/1018202

gerritbot added a comment.Tue, Apr 9, 9:27 AM

Change #1018202 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.26

https://gerrit.wikimedia.org/r/1018202

Stashbot added a comment.Tue, Apr 9, 9:40 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-09T09:40:56Z] <hashar@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.42.0-wmf.26 refs T360158

hashar removed a subtask: Restricted Task.Wed, Apr 10, 4:09 AM
abi_ added a subtask: T362210: Error: Unable to stash Parsoid HTML when editing pages on MediaWiki.org.Wed, Apr 10, 5:21 AM
hashar removed a subtask: T362210: Error: Unable to stash Parsoid HTML when editing pages on MediaWiki.org.Wed, Apr 10, 6:08 AM
gerritbot added a comment.Wed, Apr 10, 8:06 AM

Change #1018638 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.26

https://gerrit.wikimedia.org/r/1018638

gerritbot added a comment.Wed, Apr 10, 8:07 AM

Change #1018638 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.26

https://gerrit.wikimedia.org/r/1018638

Stashbot added a comment.Wed, Apr 10, 8:21 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-10T08:21:27Z] <hashar@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.42.0-wmf.26 refs T360158

Stashbot added a comment.Wed, Apr 10, 8:34 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-10T08:34:32Z] <hashar@deploy1002> Synchronized php: group1 wikis to 1.42.0-wmf.26 refs T360158 (duration: 13m 05s)

daniel subscribed.EditedWed, Apr 10, 2:50 PM
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/969369
  • Summary:
    • This refactors the code that delivers all thumbnail images to readers, namely the thumb.php and thumb_handler.php enry points. The patch aims to just move the code without structural changes, but we may have inadvertedly introduced subtle changes. Extensive tests were added, but it is hard to be 100% sure, since the code has many conditionals, which means that there are dozens or maybe hundreds of paths through the code. Some aspects that might be affected:
      • response headers, including cache-control and content-type
      • the point at which output is flushed to the client
      • if and when database transactions are committed
      • if and when defered updates are executed
  • Test plan:
  • Places to monitor:
  • Revert plan:
    • Revert the patch, it's safe. No persisted artifacts should be affected
    • If that fails, roll back the train
  • Affected wikis:
    • All, but particularly commons.wikimedia.org and upload.wikimedia.org
  • IRC contact: duesen (Daniel Kinzler, UTC+2), AaronSchulz (timezone UTC-7)
  • UBN Task Projects/tags: MW-Interfaces-Team, MediaWiki-Engineering
  • Would you like to backport this change rather than ride the train?: It's already riding the train.
hashar added a comment.Wed, Apr 10, 3:33 PM

@daniel I have deployed MediaWiki this morning ~ 8:30am UTC and thus it is already deployed on commons!

ovasileva subscribed.Thu, Apr 11, 6:54 AM

Blocker

We have a new train blocker T362297: [Bug] Mobile watchlist broken. The mobile watchlist is broken.

ovasileva added a subtask: T362297: [Bug] Mobile watchlist broken.Thu, Apr 11, 6:54 AM
Dreamy_Jazz added a subtask: T362284: Logs without a defined title or page_id cause an exception in CheckUser.Thu, Apr 11, 12:09 PM
Dreamy_Jazz closed subtask T362284: Logs without a defined title or page_id cause an exception in CheckUser as Resolved.Thu, Apr 11, 2:11 PM
ovasileva added a comment.Thu, Apr 11, 3:59 PM

Blocker

We detected another issue with the watchlist: T362338: [Bug] Mobile watchlist automatically redirecting to "view and edit"

hashar added a subtask: T362338: [Bug] Mobile watchlist automatically redirecting to "view and edit".Thu, Apr 11, 4:37 PM
ovasileva added a comment.Thu, Apr 11, 5:05 PM

Identified that T362338: [Bug] Mobile watchlist automatically redirecting to "view and edit" is an old bug, not related to the train. Removing from blocker list.

ovasileva removed a subtask: T362338: [Bug] Mobile watchlist automatically redirecting to "view and edit".Thu, Apr 11, 5:05 PM
ovasileva removed a subtask: T362297: [Bug] Mobile watchlist broken.
hashar added a subscriber: dancy.Thu, Apr 11, 5:09 PM

Train is unblocked (thank you @ovasileva!).

Given it is running late here in Europe, @dancy offered to continue running the train for today :)

gerritbot added a comment.Thu, Apr 11, 5:35 PM

Change #1019097 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.26

https://gerrit.wikimedia.org/r/1019097

gerritbot added a comment.Thu, Apr 11, 5:36 PM

Change #1019097 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.26

https://gerrit.wikimedia.org/r/1019097

Stashbot added a comment.Thu, Apr 11, 5:50 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T17:50:47Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.42.0-wmf.26 refs T360158

hashar closed this task as Resolved.Fri, Apr 12, 7:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL