Page MenuHomePhabricator

The skins.minerva.mainPage.styles module is preloading desktop icon unexpectedly
Closed, DuplicatePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

A big portion of unused CSS from the logo feature of SkinModule is loaded

.firstHeading::before{content:url(/static/images/mobile/copyright/wikipedia-wordmark-en.svg);display:block;height:18px;left:-9999px;line-height:0;margin-bottom:20px;position:absolute;width:120px}.mw-wiki-logo{background-image:url(/static/images/project-logos/enwiki.png)}@media print{.firstHeading::before{left:auto;position:relative}}@media (-webkit-min-device-pixel-ratio:1.5),(min-resolution:1.5dppx),(min-resolution:144dpi){.mw-wiki-logo{background-image:url(/static/images/project-logos/enwiki-1.5x.png);background-size:135px auto}}@media (-webkit-min-device-pixel-ratio:2),(min-resolution:2dppx),(min-resolution:192dpi){.mw-wiki-logo{background-image:url(/static/images/project-logos/enwiki-2x.png);background-size:135px auto}}

A Link header preloading desktop icon is present

Link:
</static/images/project-logos/enwiki.png>;rel=preload;as=image;media=not all and (min-resolution: 1.5dppx),</static/images/project-logos/enwiki-1.5x.png>;rel=preload;as=image;media=(min-resolution: 1.5dppx) and (max-resolution: 1.999999dppx),</static/images/project-logos/enwiki-2x.png>;rel=preload;as=image;media=(min-resolution: 2dppx)

What should have happened instead?:

No desktop icon is preloaded, and no extra unused CSS.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change #1031588 had a related patch set uploaded (by Func; author: Func):

[mediawiki/skins/MinervaNeue@master] styles: Avoid loading logo in skins.minerva.mainPage.styles

https://gerrit.wikimedia.org/r/1031588