| hubaishan | |
| Mar 26 2024, 8:50 AM |
| F53406383: screenshot 350.png | |
| May 16 2024, 12:22 AM |
| F51826369: Screenshot 2024-05-10 at 10.16.43 AM.png | |
| May 10 2024, 2:24 PM |
| F45161259: image.png | |
| Apr 8 2024, 7:57 AM |
| F44459774: Screenshot 2024-04-04 at 10.41.19.png | |
| Apr 4 2024, 8:42 AM |
Steps to replicate the issue (include links if applicable):
Expected: No horizontal scroll
Actual: Horizontal scroll
What happens?:
there is a large white blank block in the right side.
Thanks for the report @hubaishan! Is there a chance you can attach a screenshot of the issue. This is what I'm seeing with Firefox on desktop on arwiki:
Thanks for the report @hubaishan! Is there a chance you can attach a screenshot of the issue. This is what I'm seeing with Firefox on desktop on arwiki:
You must be logged in and use any mobile device emulator see this screenshoot from fawiki
This bug is caused by `.firstHeading::before` I can't locate it in code . It has rule:
right: -9999px;
I think no need for `.firstHeading::before` the page run perfectly without it.
Change #1019846 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] skins.minerva.mainPage.styles should not be a ResourceLoader/SkinModule
The style is coming from skins.minerva.mainPage.styles and that seems to be loading styles that are not needed on this apply.
I'm not able to reproduce this using firefox on any android devices (on browserstack), including the galaxy note that @hubaishan suggested. We might want to wait until Jon gets back, or the author responds with further instructions on how to reproduce
I'm no longer able to reproduce either, logged in to fawiki, with ?uselang=fa e.g:
https://fa.m.wikipedia.org/wiki/%D8%B5%D9%81%D8%AD%D9%87%D9%94_%D8%A7%D8%B5%D9%84%DB%8C?uselang=fa
However, the code in question, right: -9999px; comes from mediawiki/core/resources/src/mediawiki.skinning/logo.less which is being loaded erroneously like Jon points out.
I did notice if I switch the rule from right: -9999px; to left: -9999px; then I am able to reproduce this issue:
So I'm willing to bet that although I can't reproduce it personally, that probably some people can, and not loading that code will resolve it. I'm going to go ahead and merge Jon's patch and we'll see if we can verify this in QA or if it'll be resolved in production next week.
You must be logged in and using RTL interface. (note: do not try in arwiki or arwikisource or wikidata because I fixed it there)
FWIW I don't think this is actually impacting any real devices - this seems to be an issue in the Firefox emulator - but the CSS code causing this error shouldn't be here so we should definitely remove it. I have added some clearer replication steps in the description. Edward - I can replicate so feel free to reach out if you can't.
Change #1019846 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] skins.minerva.mainPage.styles should not load feature styles
Change #1031588 had a related patch set uploaded (by Jdlrobson; author: Func):
[mediawiki/skins/MinervaNeue@master] styles: Stop using SkinModule in skins.minerva.mainPage.styles
Change #1031588 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] styles: Stop using SkinModule in skins.minerva.mainPage.styles
