Steps to replicate the issue:
- Open https://meta.wikimedia.org/w/index.php?title=Special:MyPage/global.js&action=edit
- Enter '<script>' or "<script>"
- Click "Show preview"
What happens?:
MediaWiki internal error.
Original exception: [b3766e42-894a-44bc-bf04-31f11b3d6c8d] 2024-03-17 10:36:39: Fatal exception of type "DomainException"
What should have happened instead?:
The preview is shown.
Other information:
The error seems to occur as long as the page is a valid JS and '<script>' or "<script>" is included anywhere in someone's User/global.js script. Edit diff and saving edit works fine. You can even edit the saved global.js with '<script>' or "<script>", even if "Show preview when starting to edit" is on (but preview fails).
Note that the bug does not affect User/common.js, only the global.js powered by the GlobalCssJs extension is affected. This is because the User/common.js feature in core still uses "eval" and thus transports code as an escaped string. The GlobalCssJs extension uses modern module scope, and thus is subject to the Html.php restriction.
Error
- mwversion: 1.42.0-wmf.22
- reqId: b0014cd3-1b21-46c8-a8ea-1006af6e4b64
- Find reqId in Logstash
normalized_message
[{reqId}] {exception_url} DomainException: Prefix must match valueexception.trace
from /srv/mediawiki/php-1.42.0-wmf.22/vendor/wikimedia/wrappedstring/src/WrappedString.php(49)
#0 /srv/mediawiki/php-1.42.0-wmf.22/includes/ResourceLoader/ResourceLoader.php(1795): Wikimedia\WrappedString->__construct(string, string, string)
#1 /srv/mediawiki/php-1.42.0-wmf.22/includes/ResourceLoader/ClientHtml.php(478): MediaWiki\ResourceLoader\ResourceLoader::makeInlineScript(string)
#2 /srv/mediawiki/php-1.42.0-wmf.22/includes/ResourceLoader/ClientHtml.php(396): MediaWiki\ResourceLoader\ClientHtml::makeLoad(MediaWiki\ResourceLoader\DerivativeContext, array, string, array)
#3 /srv/mediawiki/php-1.42.0-wmf.22/includes/ResourceLoader/ClientHtml.php(335): MediaWiki\ResourceLoader\ClientHtml->getLoad(array, string)
#4 /srv/mediawiki/php-1.42.0-wmf.22/includes/Output/OutputPage.php(3567): MediaWiki\ResourceLoader\ClientHtml->getHeadHtml(string)
#5 /srv/mediawiki/php-1.42.0-wmf.22/includes/skins/SkinMustache.php(98): MediaWiki\Output\OutputPage->headElement(MediaWiki\Skins\Vector\SkinVectorLegacy)
#6 /srv/mediawiki/php-1.42.0-wmf.22/includes/skins/SkinTemplate.php(176): SkinMustache->generateHTML()
#7 /srv/mediawiki/php-1.42.0-wmf.22/includes/Output/OutputPage.php(3004): SkinTemplate->outputPage()
#8 /srv/mediawiki/php-1.42.0-wmf.22/includes/actions/ActionEntryPoint.php(162): MediaWiki\Output\OutputPage->output(boolean)
#9 /srv/mediawiki/php-1.42.0-wmf.22/includes/MediaWikiEntryPoint.php(199): MediaWiki\Actions\ActionEntryPoint->execute()
#10 /srv/mediawiki/php-1.42.0-wmf.22/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}normalized_message
[{reqId}] {exception_url} PHP Warning: MediaWiki\Html\Html::inlineScript: Illegal character sequence found in inline script. [Called from MediaWiki\Html\Html::inlineScript in /srv/mediawiki/php-1.42.0-wmf.22/includes/Html/Html.php at line 579]exception.trace
from /srv/mediawiki/php-1.42.0-wmf.22/includes/debug/MWDebug.php(492)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.42.0-wmf.22/includes/debug/MWDebug.php(492): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.42.0-wmf.22/includes/debug/MWDebug.php(203): MWDebug::sendMessage(string, string, integer)
#3 /srv/mediawiki/php-1.42.0-wmf.22/includes/GlobalFunctions.php(825): MWDebug::warning(string, integer, integer, string)
#4 /srv/mediawiki/php-1.42.0-wmf.22/includes/Html/Html.php(579): wfLogWarning(string)
#5 /srv/mediawiki/php-1.42.0-wmf.22/includes/ResourceLoader/ResourceLoader.php(1793): MediaWiki\Html\Html::inlineScript(string)
#6 /srv/mediawiki/php-1.42.0-wmf.22/includes/ResourceLoader/ClientHtml.php(478): MediaWiki\ResourceLoader\ResourceLoader::makeInlineScript(string)
#7 /srv/mediawiki/php-1.42.0-wmf.22/includes/ResourceLoader/ClientHtml.php(396): MediaWiki\ResourceLoader\ClientHtml::makeLoad(MediaWiki\ResourceLoader\DerivativeContext, array, string, array)
#8 /srv/mediawiki/php-1.42.0-wmf.22/includes/ResourceLoader/ClientHtml.php(335): MediaWiki\ResourceLoader\ClientHtml->getLoad(array, string)
#9 /srv/mediawiki/php-1.42.0-wmf.22/includes/Output/OutputPage.php(3567): MediaWiki\ResourceLoader\ClientHtml->getHeadHtml(string)
#10 /srv/mediawiki/php-1.42.0-wmf.22/includes/skins/SkinMustache.php(98): MediaWiki\Output\OutputPage->headElement(MediaWiki\Skins\Vector\SkinVectorLegacy)
#11 /srv/mediawiki/php-1.42.0-wmf.22/includes/skins/SkinTemplate.php(176): SkinMustache->generateHTML()
#12 /srv/mediawiki/php-1.42.0-wmf.22/includes/Output/OutputPage.php(3004): SkinTemplate->outputPage()
#13 /srv/mediawiki/php-1.42.0-wmf.22/includes/exception/MWExceptionRenderer.php(189): MediaWiki\Output\OutputPage->output()
#14 /srv/mediawiki/php-1.42.0-wmf.22/includes/exception/MWExceptionRenderer.php(106): MWExceptionRenderer::reportHTML(DomainException)
#15 /srv/mediawiki/php-1.42.0-wmf.22/includes/exception/MWExceptionHandler.php(133): MWExceptionRenderer::output(DomainException, integer)
#16 /srv/mediawiki/php-1.42.0-wmf.22/includes/exception/MWExceptionHandler.php(237): MWExceptionHandler::report(DomainException)
#17 /srv/mediawiki/php-1.42.0-wmf.22/includes/MediaWikiEntryPoint.php(220): MWExceptionHandler::handleException(DomainException, string)
#18 /srv/mediawiki/php-1.42.0-wmf.22/includes/actions/ActionEntryPoint.php(82): MediaWiki\MediaWikiEntryPoint->handleTopLevelError(DomainException)
#19 /srv/mediawiki/php-1.42.0-wmf.22/includes/MediaWikiEntryPoint.php(204): MediaWiki\Actions\ActionEntryPoint->handleTopLevelError(DomainException)
#20 /srv/mediawiki/php-1.42.0-wmf.22/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#21 /srv/mediawiki/w/index.php(3): require(string)
#22 {main}