Page MenuHomePhabricator
Create Task
Maniphest T364093

GlobalPreferences test makes TheWikipediaLibrary gate pipeline build fail
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TheWikipediaLibrary/+/1026795

12:23:13 1) phpunit\ApiGlobalPreferencesTest::testExecute with data set "set userjs" (array('userjs-foo=bar'), array(), array('bar'))
12:23:13 ApiUsageException: Current user is not global.
12:23:13 
12:23:13 /workspace/src/includes/api/ApiUsageException.php:73
12:23:13 /workspace/src/includes/api/ApiBase.php:1543
12:23:13 /workspace/src/extensions/GlobalPreferences/includes/ApiGlobalPreferences.php:52
12:23:13 /workspace/src/includes/api/ApiMain.php:1948
12:23:13 /workspace/src/includes/api/ApiMain.php:893
12:23:13 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:183
12:23:13 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:223
12:23:13 /workspace/src/extensions/GlobalPreferences/tests/phpunit/ApiGlobalPreferencesTest.php:46
12:23:13 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:334
12:23:13 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ApiGlobalPreferencesTest: do local CentralIdLookupJsn.shermanmediawiki/extensions/GlobalPreferencesmaster+4 -0
ApiGlobalPreferencesTest: attach central auth userJsn.shermanmediawiki/extensions/GlobalPreferencesmaster+11 -2
Customize query in gerrit

Event Timeline

• taavi created this task.May 3 2024, 9:52 AM
Herald added a project: Community-Tech. · View Herald TranscriptMay 3 2024, 9:52 AM
Samwalton9-WMF edited projects, added: Moderator-Tools-Team; removed: The-Wikipedia-Library.May 3 2024, 9:55 AM
• taavi added a subscriber: Samwalton9-WMF.May 3 2024, 9:55 AM

@Samwalton9-WMF is there a separate tag for the library extension?

Samwalton9-WMF added a comment.May 3 2024, 9:57 AM
In T364093#9766654, @taavi wrote:

@Samwalton9-WMF is there a separate tag for the library extension?

No, it's so small we never bothered.

Samwalton9-WMF moved this task from Inbox to Maintenance priorities on the Moderator-Tools-Team board.May 4 2024, 10:52 AM
jsn.sherman claimed this task.May 6 2024, 1:18 PM
jsn.sherman triaged this task as Unbreak Now! priority.
jsn.sherman edited projects, added: Moderator-Tools-Team (Kanban); removed: Moderator-Tools-Team.
jsn.sherman moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
jsn.sherman added a comment.May 6 2024, 1:28 PM

@taavi I do not believe that our extension is the source of the issue. In my local environment, I commented out TheWikipediaLibrary extension

// wfLoadExtension( 'TheWikipediaLibrary' );

and moved the repo out of ./mediawiki/extensions.

When I run the GlobalPreferences tests, I still get the same error.

$ docker compose exec mediawiki composer phpunit:entrypoint -- --filter "GlobalPreferences"
> phpunit '--filter' 'GlobalPreferences'
Using PHP 8.1.20
Running with MediaWiki settings because there might be integration tests
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

........EEEEEE...........................................         57 / 57 (100%)

Time: 00:01.130, Memory: 363.00 MB

There were 6 errors:

1) phpunit\ApiGlobalPreferencesTest::testExecute with data set "set userjs" (array('userjs-foo=bar'), array(), array('bar'))
ApiUsageException: Current user is not global.
[...]
Func renamed this task from TheWikipediaLibrary makes GlobalPreferences tests fail to GlobalPreferences makes TheWikipediaLibrary tests fail.May 6 2024, 2:02 PM
jsn.sherman added a comment.EditedMay 6 2024, 2:03 PM

I think I can fix the GlobalPreferences test; working up a patch now!

Func renamed this task from GlobalPreferences makes TheWikipediaLibrary tests fail to GlobalPreferences test makes TheWikipediaLibrary gate pipeline build fail.May 6 2024, 2:06 PM
gerritbot added a comment.May 6 2024, 7:47 PM

Change #1028591 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/GlobalPreferences@master] ApiGlobalPreferencesTest: attach central auth user

https://gerrit.wikimedia.org/r/1028591

gerritbot added a project: Patch-For-Review.May 6 2024, 7:47 PM
jsn.sherman moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.May 6 2024, 7:50 PM
TheresNoTime subscribed.May 6 2024, 8:12 PM
jsn.sherman moved this task from Eng review to In Progress on the Moderator-Tools-Team (Kanban) board.May 7 2024, 11:41 AM
Ladsgroup subscribed.May 7 2024, 2:02 PM
gerritbot added a comment.May 8 2024, 11:57 AM

Change #1029172 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/GlobalPreferences@master] ApiGlobalPreferencesTest: do local CentralIdLookup

https://gerrit.wikimedia.org/r/1029172

gerritbot added a comment.May 8 2024, 11:58 AM

Change #1028591 abandoned by Jsn.sherman:

[mediawiki/extensions/GlobalPreferences@master] ApiGlobalPreferencesTest: attach central auth user

Reason:

abandoned in favor of I531731027c9a8fb63c39a1a9bf0da94c6fe412da

https://gerrit.wikimedia.org/r/1028591

jsn.sherman moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.May 8 2024, 12:20 PM
gerritbot added a comment.May 8 2024, 1:16 PM

Change #1029172 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] ApiGlobalPreferencesTest: do local CentralIdLookup

https://gerrit.wikimedia.org/r/1029172

Maintenance_bot removed a project: Patch-For-Review.May 8 2024, 1:30 PM
jsn.sherman closed this task as Resolved.May 8 2024, 1:43 PM
jsn.sherman moved this task from Eng review to Done on the Moderator-Tools-Team (Kanban) board.

Verified fixed via successful merge of https://gerrit.wikimedia.org/r/1026795

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 8 2024, 2:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits