Page MenuHomePhabricator

Inconsistency in skin responsive preference when $wgVectorResponsive is false.
Open, LowPublicBUG REPORT

Description

NOTE: Previously in T291656 we updated Special:Preferences to limit the display of the "responsive mode" option to only skins where it had an effect. This does not appear to Vector 2022. See also related issue T352358)

Steps to replicate the issue (include links if applicable):

What happens?:
Enable responsive mode is listed:

Screenshot 2023-11-30 at 12.51.52 PM.png (404×1 px, 65 KB)

What should have happened instead?:
It shouldn't be listed

Other information (browser name/version, screenshots, etc.):

This appears to be because Vector2022 defines responsive true in its skin.json and then overrides this inside SkinVector2022 and Special:Preferences uses the static skin.json version.

If we set to false, any projects where $wgVectorResponsive is set of false wouldn't be able to disable the setting.

Vector 2022 could workaround this by adding its own code for hiding the Vector 2022 option in this case.

Event Timeline