Page MenuHomePhabricator

Damaging edits are not readable in contributions page in dark mode due to ORES highlight
Open, HighPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Screenshot 2024-06-27 at 3.09.23 PM.png (563×1 px, 176 KB)

What should have happened instead?:
Highlighted row should be readable

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

https://gerrit.wikimedia.org/g/mediawiki/extensions/ORES/+/a68ff2b15317534b56af779ec454a7022a86ef2e/modules/ext.ores.styles.css#7 is the culprit - this should be disabled in dark mode or use a different color or add a notheme
The notheme class should be added to all li elements here: https://gerrit.wikimedia.org/g/mediawiki/extensions/ORES/+/a68ff2b15317534b56af779ec454a7022a86ef2e/includes/Hooks/ChangesListHooksHandler.php#627

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson added a subscriber: Ebrahim.

@Ebrahim would you be interested in helping me with this one too?

Change #1050501 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/core@master] Make damaging edits readable in contributions page in dark mode

https://gerrit.wikimedia.org/r/1050501

@Ebrahim would you be interested in helping me with this one too?

Sure! Just uploaded a patch, https://gerrit.wikimedia.org/r/1050501

How the purposed solution supposed to look,

image.png (356×474 px, 55 KB)

image.png (400×670 px, 76 KB)

Sure better workarounds can be possible but they need more intervening on the code (search highlight-results to see what I mean) that's why I believe this can be considered a temporarily but hopefully in a correct direction patch.

Hi @Ebrahim the issue I was referring to is actually with the ORES highlights in Contributions page (not to be confused with highlights in RecentChanges). While the highlights in RCFilters are also not great -they are readable as they use the notheme class unlike the ORES ones here:
https://gerrit.wikimedia.org/g/mediawiki/extensions/ORES/+/a68ff2b15317534b56af779ec454a7022a86ef2e/modules/ext.ores.highlighter.css#2

Change #1050668 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/extensions/ORES@master] Adopt Special:Contributions mark with night mode

https://gerrit.wikimedia.org/r/1050668

Ah I missed that but are you sure they are readable as it doesn't seem to be in Persian Wikipedia at least,

image.png (336×1 px, 152 KB)

Anyway I've uploaded a patch for that part also.

Ah I missed that but are you sure they are readable as it doesn't seem to be in Persian Wikipedia at least,

We merged a patch this week. It should be fixed on the beta cluster if you want to verify: https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges
Thanks for the new patch!

Change #1050501 abandoned by Ebrahim:

[mediawiki/core@master] Make damaging edits readable in contributions page in dark mode

Reason:

Makes sense

https://gerrit.wikimedia.org/r/1050501