Page MenuHomePhabricator
Create Task
Maniphest T368680

Damaging edits are not readable in contributions page in dark mode due to ORES highlight
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Jun 27 2024, 10:09 PM
Tags
Referenced Files
F57488375: A.webm
Sep 9 2024, 8:56 AM
F56318744: 2024-07-09_14-53-30.png
Jul 9 2024, 9:55 PM
F56138454: 2024-07-01_11-33-17.png
Jul 1 2024, 7:17 PM
F55977796: image.png
Jun 28 2024, 7:07 PM
F55951684: image.png
Jun 28 2024, 7:30 AM
F55951638: image.png
Jun 28 2024, 7:30 AM
F55932637: Screenshot 2024-06-27 at 3.09.23 PM.png
Jun 27 2024, 10:09 PM
Subscribers
Aklapper
Ebrahim
GMikesell-WMF
Jdlrobson
Nardog

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Screenshot 2024-06-27 at 3.09.23 PM.png (563×1 px, 176 KB)

What should have happened instead?:
Highlighted row should be readable

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

https://gerrit.wikimedia.org/g/mediawiki/extensions/ORES/+/a68ff2b15317534b56af779ec454a7022a86ef2e/modules/ext.ores.styles.css#7 is the culprit - this should be disabled in dark mode or use a different color or add a notheme
The notheme class should be added to all li elements here: https://gerrit.wikimedia.org/g/mediawiki/extensions/ORES/+/a68ff2b15317534b56af779ec454a7022a86ef2e/includes/Hooks/ChangesListHooksHandler.php#627

QA Results - Beta

ACStatusDetails
1✅T368680#9941801

QA Results - PROD

ACStatusDetails
1✅T368680#9967420

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make one last color of ORES dark mode compatiblemediawiki/extensions/ORESmaster+4 -2
Adopt Special:Contributions marks with night modemediawiki/extensions/ORESmaster+17 -13
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jun 27 2024, 10:09 PM
Restricted Application added a project: Machine-Learning-Team. · View Herald TranscriptJun 27 2024, 10:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson triaged this task as High priority.Jun 27 2024, 10:10 PM
Jdlrobson added a project: Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1).
Jdlrobson added a subscriber: Ebrahim.

@Ebrahim would you be interested in helping me with this one too?

Jdlrobson mentioned this in T366371: [Config] Enable night theme on diff and change list pages.Jun 27 2024, 10:13 PM
Jdlrobson added a project: patch-welcome.Jun 28 2024, 3:02 AM
Jdlrobson moved this task from Backlog to Web (MediaWiki) on the dark-mode board.
gerritbot added a comment.Jun 28 2024, 7:20 AM

Change #1050501 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/core@master] Make damaging edits readable in contributions page in dark mode

https://gerrit.wikimedia.org/r/1050501

gerritbot added a project: Patch-For-Review.Jun 28 2024, 7:20 AM
Ebrahim added a comment.Jun 28 2024, 7:30 AM

@Ebrahim would you be interested in helping me with this one too?

Sure! Just uploaded a patch, https://gerrit.wikimedia.org/r/1050501

How the purposed solution supposed to look,

image.png (356×474 px, 55 KB)

image.png (400×670 px, 76 KB)

Sure better workarounds can be possible but they need more intervening on the code (search highlight-results to see what I mean) that's why I believe this can be considered a temporarily but hopefully in a correct direction patch.

Jdlrobson added a comment.Jun 28 2024, 5:38 PM

Hi @Ebrahim the issue I was referring to is actually with the ORES highlights in Contributions page (not to be confused with highlights in RecentChanges). While the highlights in RCFilters are also not great -they are readable as they use the notheme class unlike the ORES ones here:
https://gerrit.wikimedia.org/g/mediawiki/extensions/ORES/+/a68ff2b15317534b56af779ec454a7022a86ef2e/modules/ext.ores.highlighter.css#2

gerritbot added a comment.Jun 28 2024, 7:06 PM

Change #1050668 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/extensions/ORES@master] Adopt Special:Contributions mark with night mode

https://gerrit.wikimedia.org/r/1050668

Ebrahim added a comment.Jun 28 2024, 7:07 PM

Ah I missed that but are you sure they are readable as it doesn't seem to be in Persian Wikipedia at least,

image.png (336×1 px, 152 KB)

Anyway I've uploaded a patch for that part also.

Jdlrobson added a comment.Jun 28 2024, 7:44 PM

Ah I missed that but are you sure they are readable as it doesn't seem to be in Persian Wikipedia at least,

We merged a patch this week. It should be fixed on the beta cluster if you want to verify: https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges
Thanks for the new patch!

gerritbot added a comment.Jun 28 2024, 7:48 PM

Change #1050501 abandoned by Ebrahim:

[mediawiki/core@master] Make damaging edits readable in contributions page in dark mode

Reason:

Makes sense

https://gerrit.wikimedia.org/r/1050501

Jdlrobson assigned this task to GMikesell-WMF.Jun 28 2024, 8:00 PM
Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1) board.
gerritbot added a comment.Jul 1 2024, 11:14 AM

Change #1050668 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] Adopt Special:Contributions marks with night mode

https://gerrit.wikimedia.org/r/1050668

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2024, 11:32 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Jul 1 2024, 12:00 PM
GMikesell-WMF added a comment.Jul 1 2024, 7:17 PM

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special%3AContributions&target=Jdlrobson&namespace=all&tagfilter=&start=&end=&hidenondamaging=1

2024-07-01_11-33-17.png (1×1 px, 573 KB)

GMikesell-WMF updated the task description. (Show Details)Jul 1 2024, 7:18 PM
GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1) board.
Jdlrobson reassigned this task from GMikesell-WMF to ovasileva.Jul 1 2024, 7:39 PM
Jdlrobson moved this task from Ready for Signoff to QA on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1) board.
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1) board.
Jdlrobson added a subscriber: GMikesell-WMF.
ovasileva closed this task as Resolved.Jul 2 2024, 2:01 PM
GMikesell-WMF mentioned this in T368686: Verify 1.43.0-wmf.12 deployment.Jul 3 2024, 9:38 PM
Nardog subscribed.Jul 4 2024, 1:45 PM

Now the CSS has a rule for .damaging.damaging.mw-changeslist-damaging-verylikelybad, with two .damaging, which thus overrode my custom CSS.

isarantopoulos moved this task from Unsorted to 2025-2026 Q1 Done on the Machine-Learning-Team board.Jul 9 2024, 2:37 PM
GMikesell-WMF added a comment.Jul 9 2024, 9:55 PM

@Jdlrobson please review T368680#9953930 regarding the custom CSS, thanks!

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

https://en.wikipedia.org/w/index.php?title=Special%3AContributions&target=Jdlrobson&namespace=all&tagfilter=&start=&end=&limit=50

2024-07-09_14-53-30.png (812×2 px, 336 KB)

GMikesell-WMF added a project: Verified.Jul 9 2024, 9:55 PM
GMikesell-WMF updated the task description. (Show Details)
gerritbot added a comment.Sep 8 2024, 2:31 PM

Change #1071357 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/extensions/ORES@master] Make one last color of ORES dark mode compatible

https://gerrit.wikimedia.org/r/1071357

gerritbot added a project: Patch-For-Review.Sep 8 2024, 2:31 PM
gerritbot added a comment.Sep 8 2024, 3:41 PM

Change #1071357 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] Make one last color of ORES dark mode compatible

https://gerrit.wikimedia.org/r/1071357

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.22; 2024-09-10); removed MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Sep 8 2024, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 8 2024, 4:30 PM
gerritbot added a comment.Sep 9 2024, 7:46 AM

Change #1050501 restored by Ebrahim:

[mediawiki/core@master] Make damaging edits readable in contributions page in dark mode

https://gerrit.wikimedia.org/r/1050501

gerritbot added a project: Patch-For-Review.Sep 9 2024, 7:46 AM
gerritbot added a comment.Sep 9 2024, 7:52 AM

Change #1050501 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/core@master] Make damaging edits readable in contributions page in dark mode

https://gerrit.wikimedia.org/r/1050501

Ebrahim added a comment.Sep 9 2024, 8:56 AM
This comment was removed by Ebrahim.
Ebrahim added a comment.EditedSep 9 2024, 11:38 AM

Recent comments and patches weren't related to this issue, sorry for the noise

isarantopoulos moved this task from 2025-2026 Q1 Done to Task Archive on the Machine-Learning-Team board.Nov 4 2024, 8:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits