Page MenuHomePhabricator
Create Task
Maniphest T370695

Temporary accounts are treated as registered users in non-JavaScript RecentChanges/Watchlist
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Tchanders
Authored By
Nardog
Jul 22 2024, 6:42 PM
Tags
Referenced Files
F56683587: image.png
Jul 26 2024, 5:36 AM
F56683560: image.png
Jul 26 2024, 5:36 AM
F56683535: image.png
Jul 26 2024, 5:36 AM
F56683317: image.png
Jul 26 2024, 5:36 AM
F56683636: image.png
Jul 26 2024, 5:36 AM
F56683108: image.png
Jul 26 2024, 5:36 AM
Subscribers
Aklapper
Djackson-ctr
JJMC89
kostajh
Nardog
Tchanders
Xaosflux

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Edits by temporary accounts are hidden when unregistered users are hidden, and they are shown when only registered users are shown.

What should have happened instead?:
The behavior is consistent with the JavaScript interface, i.e. temporary accounts are shown if unregistered users are shown, and are hidden if unregistered users are hidden.

Other information:
Similar results on Special:Watchlist.

Details

SubjectRepoBranchLines +/-
ChangesListSpecialPage: Fix user type filters for temporary accountsmediawiki/coremaster+36 -4
Customize query in gerrit

Related Objects

Event Timeline

Nardog created this task.Jul 22 2024, 6:42 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 22 2024, 6:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Nardog updated the task description. (Show Details)Jul 22 2024, 6:43 PM
JJMC89 subscribed.Jul 22 2024, 6:44 PM

Is this for JS or non-JS? The title says non-JS, but the first step is disable non-JS (use JS).

Nardog updated the task description. (Show Details)Jul 22 2024, 6:55 PM
Nardog updated the task description. (Show Details)

Fixed, the double negative failed me.

kostajh added a project: Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)).Jul 22 2024, 7:11 PM
Tchanders claimed this task.Jul 23 2024, 6:50 AM
Tchanders moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
Tchanders added a comment.EditedJul 23 2024, 6:57 AM

The problem is the conditions that get added here: https://gerrit.wikimedia.org/g/mediawiki/core/+/b30ac0000dc18765b729a5792c30d51c55d24cb8/includes/specialpage/ChangesListSpecialPage.php#134

gerritbot added a comment.Jul 23 2024, 10:01 AM

Change #1056128 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] WIP ChangesListSpecialPage: Fix user type filters for temporary accounts

https://gerrit.wikimedia.org/r/1056128

gerritbot added a project: Patch-For-Review.Jul 23 2024, 10:01 AM
Tchanders moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 23 2024, 12:49 PM
Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 23 2024, 1:32 PM
gerritbot added a comment.Jul 23 2024, 2:27 PM

Change #1056128 merged by jenkins-bot:

[mediawiki/core@master] ChangesListSpecialPage: Fix user type filters for temporary accounts

https://gerrit.wikimedia.org/r/1056128

Maintenance_bot removed a project: Patch-For-Review.Jul 23 2024, 2:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 23 2024, 3:00 PM
Tchanders mentioned this in T370676: "hide registered users" filter should not hide temporary accounts.Jul 23 2024, 3:39 PM
Tchanders merged a task: T370676: "hide registered users" filter should not hide temporary accounts.
Tchanders added subscribers: Xaosflux, Tchanders.
Tchanders mentioned this in T370801: Filter temporary accounts correctly on Special:NewPages.Jul 23 2024, 5:59 PM
Tchanders mentioned this in T370803: Filter temporary accounts correctly on ApiQueryRecentChanges.Jul 23 2024, 6:04 PM
Tchanders added a subscriber: kostajh.

As @kostajh pointed out, there are a couple more similar features to fix. Filed as separate tasks:

Nardog updated the task description. (Show Details)Jul 23 2024, 6:57 PM
Djackson-ctr subscribed.Jul 26 2024, 5:36 AM

I have verified the new code has been implemented and is functioning and displaying as expected.

When user initially reaches Recent Changes:

image.png (741×1 px, 88 KB)

When user selects Hide Registered Users:

image.png (492×1 px, 47 KB)

When user selects Hide Anonymous Users:

image.png (614×988 px, 70 KB)

When user initially reaches Watchlist:

image.png (566×990 px, 57 KB)

When user selects Hide Registered Users:

image.png (495×979 px, 45 KB)

When user selects Hide Anonymous Users:

image.png (486×996 px, 45 KB)

Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 26 2024, 5:39 AM
kostajh closed this task as Resolved.Jul 26 2024, 9:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits