Page MenuHomePhabricator

Update TemporaryAccountHandler for CheckUser event table migration
Closed, ResolvedPublic2 Estimated Story Points

Description

The /checkuser/v0/temporaryaccount/{name} REST API endpoint returns all the IP addresses used by a given temporary account. The TemporaryAccountHandler class which implements this endpoint selects the IP addresses from the cu_changes table. However, when event table migration is set to no longer write to cu_changes this will no longer include all the IP addresses that were previously included in the results.

As such, TemporaryAccountHandler::getData should be updated to read the IP addresses from all three CheckUser result tables depending on the migration stage for event table migration.

Acceptance criteria
  • TemporaryAccountHandler::getData reads from cu_log_event and cu_private_event if $wgCheckUserEventTablesMigrationStage includes SCHEMA_COMPAT_READ_NEW

Related Objects

StatusSubtypeAssignedTask
ResolvedFeatureDreamy_Jazz
ResolvedFeatureDreamy_Jazz
OpenNone
ResolvedSecurityZabe
ResolvedSecurityDreamy_Jazz
ResolvedSecurityDreamy_Jazz
ResolvedSecurityDreamy_Jazz
ResolvedBUG REPORTDreamy_Jazz
ResolvedBUG REPORTDreamy_Jazz
ResolvedBUG REPORTDreamy_Jazz
ResolvedDreamy_Jazz
OpenNone
OpenNone
OpenNone
OpenFeatureDreamy_Jazz
DuplicateNone
OpenFeatureNone
ResolvedFeatureDreamy_Jazz
ResolvedFeatureDreamy_Jazz
ResolvedFeatureDreamy_Jazz
ResolvedFeatureDreamy_Jazz
ResolvedFeatureDreamy_Jazz
ResolvedBUG REPORTDreamy_Jazz
DeclinedFeatureNone
OpenFeatureNone
ResolvedGlaisher
ResolvedFeatureDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedFeatureDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
DeclinedNone
ResolvedFeatureDreamy_Jazz
ResolvedGlaisher
ResolvedNiharika
ResolvedNone
ResolvedFeatureDreamy_Jazz
DeclinedNone
ResolvedFeatureDreamy_Jazz
ResolvedFeatureDreamy_Jazz
DuplicateNone
OpenNone
DuplicateNone
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
OpenFeatureNone
ResolvedDreamy_Jazz
ResolvedBUG REPORTDreamy_Jazz
ResolvedBUG REPORTDreamy_Jazz
OpenNone
OpenFeatureNone
DeclinedFeatureNone
OpenFeatureNone
ResolvedDreamy_Jazz
Resolvedkostajh
OpenNone
OpenNone
Resolvedtstarling
OpenNone
ResolvedTchanders
OpenBUG REPORTNone
OpenNone
OpenNone
OpenFeatureDreamy_Jazz
OpenNone
OpenNone
OpenNone
OpenNone
OpenDreamy_Jazz
OpenNone
OpenNone
ResolvedDreamy_Jazz

Event Timeline

Change #1017879 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use cu_log_event and cu_private_event in TemporaryAccountHandler

https://gerrit.wikimedia.org/r/1017879

Change #1017879 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use cu_log_event and cu_private_event in TemporaryAccountHandler

https://gerrit.wikimedia.org/r/1017879

Tchanders subscribed.

Testing notes

This should just need regression testing with $wgCheckUserEventTablesMigrationStage = SCHEMA_COMPAT_WRITE_NEW | SCHEMA_COMPAT_READ_NEW; set.

dom_walden subscribed.

Testing notes

This should just need regression testing with $wgCheckUserEventTablesMigrationStage = SCHEMA_COMPAT_WRITE_NEW | SCHEMA_COMPAT_READ_NEW; set.

The IPs returned by /checkuser/v0/temporaryaccount/ match those found by querying cu_changes.

Test environment: local docker CheckUser 2.5 (fafed4d) 12:26, 16 April 2024.