Page MenuHomePhabricator
Create Task
Maniphest T361924

Update TemporaryAccountHandler for CheckUser event table migration
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The /checkuser/v0/temporaryaccount/{name} REST API endpoint returns all the IP addresses used by a given temporary account. The TemporaryAccountHandler class which implements this endpoint selects the IP addresses from the cu_changes table. However, when event table migration is set to no longer write to cu_changes this will no longer include all the IP addresses that were previously included in the results.

As such, TemporaryAccountHandler::getData should be updated to read the IP addresses from all three CheckUser result tables depending on the migration stage for event table migration.

Acceptance criteria
  • TemporaryAccountHandler::getData reads from cu_log_event and cu_private_event if $wgCheckUserEventTablesMigrationStage includes SCHEMA_COMPAT_READ_NEW

Details

SubjectRepoBranchLines +/-
Use cu_log_event and cu_private_event in TemporaryAccountHandlermediawiki/extensions/CheckUsermaster+150 -27
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedFeatureDreamy_JazzT311375 Instead of not showing any results on too many results show the results to the truncation point with a pager that allows generation of more results
 OpenFeatureDreamy_JazzT313446 Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder
Restricted Task
Restricted Task
Restricted Task
 ResolvedSecurityZabeT311337 CVE-2022-39193: Edits with the performer suppressed still show the performer in results from the CheckUser extension
 ResolvedSecurityDreamy_JazzT316414 CVE-2022-39193: Special:Investigate can expose supressed information in check results
 ResolvedSecurityDreamy_JazzT318166 CVE-2022-39193: CheckUser API can expose the suppressed performer
 ResolvedSecurityDreamy_JazzT316360 Oversighted action text is shown in Special:CheckUser when the checkuser does not have the right to see it
Restricted Task
 OpenBUG REPORTNoneT326866 Special:Investigate can expose suppressed information for log events
 ResolvedBUG REPORTDreamy_JazzT326867 CheckUser API can expose suppressed information for log events
 ResolvedBUG REPORTDreamy_JazzT326865 Special:CheckUser can expose suppressed information for log events
 ResolvedDreamy_JazzT253796 Make CheckUser record the log_id of logged actions
 OpenNoneT139810 RFC: Overhaul the CheckUser extension
 OpenNoneT132892 CheckUser UI revamp
 OpenNoneT69811 CheckUsers "Get users" design needs improvements
 OpenFeatureDreamy_JazzT24120 Enhance Blocking and tagging from checkuser interface: add dropdowns
 DuplicateNoneT145340 Split CheckUser mass-block interface to separate special page
 OpenFeatureNoneT324709 Allow the HTMLForm Select and other field to have a minimum length set
 ResolvedFeatureDreamy_JazzT316441 Enforce minimum length of the tag on the client side for the checkuser block form
 ResolvedFeatureDreamy_JazzT321427 Allow HTMLForm text based elements to specify a minimum length
 ResolvedFeatureDreamy_JazzT321439 Allow TextInputWidget to specify the "minlength" attribute
 OpenFeatureNoneT316444 The CheckUser block form should explain why users were not blocked or tagged
 OpenFeatureNoneT314700 Restore the bottom paging links on 'Get users'
 ResolvedBUG REPORTDreamy_JazzT314217 Checkuserblock form is broken when paging links are shown on 'Get users'
 DeclinedFeatureNoneT313451 Separate out when the blocks are made for IPs and users in Special:CheckUser 'get users' mode
 OpenFeatureNoneT18306 Allow user to specify block settings from CU form
 ResolvedGlaisherT41213 Block interface after "Get users" check should allow talk page/send email blocking
 OpenFeatureNoneT329493 Replace Special:CheckUser's 'get users' block form with a usage of Special:InvestigateBlock
 ResolvedDreamy_JazzT339914 Remove CheckUserEnableSpecialInvestigate config
 ResolvedFeatureDreamy_JazzT318458 Add dropdown options for the reason in Special:InvestigateBlock (like Special:Block has)
 ResolvedDreamy_JazzT362569 Test SpecialInvestigateBlock
 OpenNoneT27053 Replace user / talk pages feature of "Get users" creates a user/talk page if it doesnt exist
 ResolvedFeatureDreamy_JazzT318459 Make a clearer visual distinction between the UA and IP list in 'get users'
 ResolvedGlaisherT49505 CheckUser results (userlinks) cannot be customized
 ResolvedNiharikaT24119 Enhance Blocking and tagging from checkuser interface: add new page
 ResolvedNoneT14808 Blocking and tagging from checkuser interface
 ResolvedFeatureDreamy_JazzT16699 More versatile searching in CheckUser log
 DeclinedNoneT15789 Restore the global CheckUser log
 ResolvedFeatureDreamy_JazzT309924 Add check links for both the target and performer in Special:CheckUserLog
 ResolvedFeatureDreamy_JazzT309925 Implement User:Amalthea/culoghelper.js into the CheckUser extension
 DuplicateNoneT140345 Userlinks in CheckUser should be customizable
 OpenNoneT21964 Provide a link to the user on account creation
 DuplicateNoneT144099 Make CheckUser unit-testable
 ResolvedDreamy_JazzT309815 Use OOUI in Special:CheckUser
 ResolvedDreamy_JazzT310019 The Special:CheckUser block form should use OOUI
 ResolvedDreamy_JazzT266586 Use OOUI in SpecialCheckUserLog
Restricted Task
 OpenFeatureNoneT26231 Allow CheckUsers to filter checks for account creations only
 ResolvedDreamy_JazzT139809 Bad output of AbuseFilter blocks in CU get edits
 ResolvedBUG REPORTDreamy_JazzT41013 Incomplete i18n for log entries in CheckUser
 ResolvedBUG REPORTDreamy_JazzT268156 Partial blocks from namespaces are displayed odd
 OpenNoneT311354 Make CheckUser results easier to parse by userscripts
 OpenFeatureNoneT311380 Make certain types of edits in 'Get edits' highlightable for ease of parsing the results
 DeclinedFeatureNoneT54849 Checkuser option "get users" should point out when user password is changed
 OpenFeatureNoneT315488 Show failed login attempts in the results list for the user
Restricted Task
 ResolvedDreamy_JazzT145265 Store check user data action text in structured format
 ResolvedkostajhT257893 [EPIC] Support User-Agent Client Hints header in CheckUser
 OpenNoneT341094 Create client hint mapping rows for CheckUser-worthy events
 OpenNoneT248926 Performance review of checkuser database queries [NOT READY]
 ResolvedtstarlingT342613 CompareService::getTotalEditsFromIp queries exceeding TransactionProfiler limits
 OpenNoneT301992 Insert CheckUser row events during certain 2FA actions
 ResolvedTchandersT326393 IP Address Reveal on Log page
 OpenBUG REPORTNoneT28843 CheckUser results do not appear cleanly for AbuseFilter modifications
 OpenFeatureDreamy_JazzT324907 Create separate tables for log events in CheckUser
 OpenDreamy_JazzT341830 Create maintenance script to delete entries only for read old
 OpenNoneT346022 Remove wgCheckUserLogAdditionalRights
 OpenDreamy_JazzT360685 Stop writing old for event table migration on WMF wikis
 ResolvedDreamy_JazzT361924 Update TemporaryAccountHandler for CheckUser event table migration

Event Timeline

Dreamy_Jazz created this task.Fri, Apr 5, 10:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Apr 5, 10:23 AM
Dreamy_Jazz updated the task description. (Show Details)Fri, Apr 5, 10:29 AM
Dreamy_Jazz added a parent task: T360685: Stop writing old for event table migration on WMF wikis.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Mon, Apr 8, 12:51 PM
gerritbot added a comment.Mon, Apr 8, 3:44 PM

Change #1017879 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use cu_log_event and cu_private_event in TemporaryAccountHandler

https://gerrit.wikimedia.org/r/1017879

gerritbot added a project: Patch-For-Review.Mon, Apr 8, 3:44 PM
Dreamy_Jazz claimed this task.Mon, Apr 8, 3:46 PM
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Dreamy_Jazz updated the task description. (Show Details)Mon, Apr 8, 4:05 PM
gerritbot added a comment.Mon, Apr 15, 2:48 PM

Change #1017879 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use cu_log_event and cu_private_event in TemporaryAccountHandler

https://gerrit.wikimedia.org/r/1017879

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Mon, Apr 15, 3:00 PM
Tchanders moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Mon, Apr 15, 4:26 PM
Tchanders subscribed.

Testing notes

This should just need regression testing with $wgCheckUserEventTablesMigrationStage = SCHEMA_COMPAT_WRITE_NEW | SCHEMA_COMPAT_READ_NEW; set.

dom_walden moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Wed, Apr 17, 7:51 AM
dom_walden subscribed.
In T361924#9714387, @Tchanders wrote:

Testing notes

This should just need regression testing with $wgCheckUserEventTablesMigrationStage = SCHEMA_COMPAT_WRITE_NEW | SCHEMA_COMPAT_READ_NEW; set.

The IPs returned by /checkuser/v0/temporaryaccount/ match those found by querying cu_changes.

Test environment: local docker CheckUser 2.5 (fafed4d) 12:26, 16 April 2024.

Dreamy_Jazz closed this task as Resolved.Wed, Apr 17, 9:13 AM
Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 6:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL