Use OOUI in SpecialCheckUserLog
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	Oct 27 2020, 5:53 PM

Description

The form at the top of Special:CheckUserLog should be updated to use OOUI.

What needs doing
The following changes should be made in SpecialCheckUserLog::displaySearchForm:

The call to HTMLForm::factory should be updated to pass in 'ooui' as the type, instead of 'table'
The monthyear form field should be updated to be type 'date' instead of 'info'
The new date field should have the label "From date (and earlier):"

The new date field will also need to submit data that is compatible with what the CheckUserLogPager expects. Either the field or the CheckUserLogPager will need to be adapted.

Details

	Subject	Repo	Branch	Lines +/-
	Use OOUI in SpecialCheckUserLog	mediawiki/extensions/CheckUser	master	+214 -95
	CheckUser: Use OOUI in SpecialCheckUserLog	mediawiki/extensions/CheckUser	master	+13 -11

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T139810 RFC: Overhaul the CheckUser extension
Open	None	T132892 CheckUser UI revamp
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Resolved	Dreamy_Jazz	T266586 Use OOUI in SpecialCheckUserLog

Event Timeline

Tchanders created this task.Oct 27 2020, 5:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2020, 5:53 PM

Tchanders updated the task description. (Show Details)Apr 1 2021, 7:17 PM

TheresNoTime claimed this task.Jul 18 2021, 1:01 PM

TheresNoTime added a project: User-TheresNoTime.

Change 705185 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/CheckUser@master] CheckUser: Use OOUI in SpecialCheckUserLog

https://gerrit.wikimedia.org/r/705185

gerritbot added a project: Patch-For-Review.Jul 18 2021, 2:21 PM

TheresNoTime moved this task from Backlog to Patch for review on the User-TheresNoTime board.Jul 18 2021, 2:24 PM

Ammarpad added a project: CheckUser.Mar 25 2022, 7:13 PM

Change 705185 abandoned by Samtar:

[mediawiki/extensions/CheckUser@master] CheckUser: Use OOUI in SpecialCheckUserLog

Reason:

https://gerrit.wikimedia.org/r/705185

TheresNoTime removed TheresNoTime as the assignee of this task.May 4 2022, 1:40 PM

TheresNoTime removed projects: Patch-For-Review, User-TheresNoTime.

TheresNoTime subscribed.

TheresNoTime unsubscribed.

Change 800182 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use OOUI in SpecialCheckUserLog

https://gerrit.wikimedia.org/r/800182

gerritbot added a project: Patch-For-Review.May 26 2022, 5:23 PM

Change 800182 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use OOUI in SpecialCheckUserLog

https://gerrit.wikimedia.org/r/800182

Dreamy_Jazz moved this task from General / Unsorted to Patches for review on the CheckUser board.May 29 2022, 10:23 PM

TheresNoTime assigned this task to Dreamy_Jazz.May 29 2022, 10:40 PM

TheresNoTime added a project: Stewards-and-global-tools.

Change 800182 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use OOUI in SpecialCheckUserLog

https://gerrit.wikimedia.org/r/800182

TheresNoTime closed this task as Resolved.May 29 2022, 10:43 PM

TheresNoTime removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).May 29 2022, 11:00 PM

Dreamy_Jazz mentioned this in T309815: Use OOUI in Special:CheckUser.Jun 2 2022, 9:04 PM

Izno added parent tasks: T132892: CheckUser UI revamp, T100270: Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core.Jun 2 2022, 11:39 PM

Hey, sorry to be the grouch, but reposting what I posted to the CU list here in case there's something that can be done:

If this a needed update on the technical side, it has to be done, but from a UI standpoint it seems like a step backwards to me.

What you used to be able to do in three keystrokes (Recent checks->Initiator->Search) has turned into 6 (Recent checks->highlight CU name->Ctrl+X->move to initiator box->Ctrl+V->Search.) Not sure if there is a way to reduce that.

This is being discussed on checkuser-l as to what is the best option to address this, but the options are (multiple could be chosen):

Convert the OOUI form to use radio buttons (i.e. what was there before as radio buttons but using OOUI)
Add links from the contributions page of CUs that show the checks performed by that CU.
Add links to the checks performed on and by each log entry.

I did not notice this would be an issue at the time as this is not part of my workflow when doing CU.

Dreamy_Jazz mentioned this in T309924: Add check links for both the target and performer in Special:CheckUserLog.Jun 4 2022, 5:43 PM

Tasks and commits that address some of the above ideas created since the issue was raised: