Page MenuHomePhabricator
Create Task
Maniphest T349506

Set temporary user pattern configuration on production ahead of testwiki deployment
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The config will be:

$wgAutoCreateTempUser['genPattern'] = '~$1';
$wgAutoCreateTempUser['matchPattern'] = '~2$1';
$wgAutoCreateTempUser['reservedPattern'] = '~2$1';

Notes:

  • We can do this before deployment, as long as we don't set 'enabled' to true
  • This means no new accounts can be registered starting with ~2
  • The 'matchPattern' means we only have to rename 2 accounts ahead of test wiki deployment
  • We may set the match pattern and reserved pattern to ~ ahead of pilot wiki deployment, if we choose to rename all users starting with ~. Being discussed in T345678.

Details

SubjectRepoBranchLines +/-
Define 'useYear' as true for temp user serial mapping configoperations/mediawiki-configmaster+4 -0
Add wgAutoCreateTempUser configuration for productionoperations/mediawiki-configmaster+30 -18
Scope temp user reserved pattern to temp usersoperations/mediawiki-configmaster+1 -1
Prevent new user names matching the temporary account patternoperations/mediawiki-configmaster+6 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Oct 23 2023, 12:50 PM
Tchanders updated the task description. (Show Details)Oct 23 2023, 12:53 PM
Tchanders added a project: Trust and Safety Product Sprint.Nov 13 2023, 3:33 PM
Tchanders mentioned this in T349501: Update temporary user names to start their counter again each year.Dec 15 2023, 6:03 PM
Tchanders updated the task description. (Show Details)Dec 20 2023, 4:34 PM
Tchanders mentioned this in T345678: Don't let people register accounts that look like temporary accounts.Feb 7 2024, 2:22 PM
Tchanders mentioned this in T326929: [SPIKE] Investigate TitleBlacklist extension to see if changes are required for IP Masking.Mar 25 2024, 3:30 PM
Dreamy_Jazz claimed this task.Mar 26 2024, 1:58 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)); removed Trust and Safety Product Sprint.
Dreamy_Jazz set the point value for this task to 1.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.
gerritbot added a comment.Mar 26 2024, 2:32 PM

Change #1014526 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Add wgAutoCreateTempUser configuration for production

https://gerrit.wikimedia.org/r/1014526

gerritbot added a project: Patch-For-Review.Mar 26 2024, 2:32 PM
gerritbot added a comment.Mar 26 2024, 4:48 PM

Change #1014559 had a related patch set uploaded (by Dreamy Jazz; author: Tchanders):

[operations/mediawiki-config@master] Prevent new user names matching the temporary account pattern

https://gerrit.wikimedia.org/r/1014559

gerritbot added a comment.Mar 27 2024, 2:02 PM

Change #1014559 merged by jenkins-bot:

[operations/mediawiki-config@master] Prevent new user names matching the temporary account pattern

https://gerrit.wikimedia.org/r/1014559

Stashbot added a comment.Mar 27 2024, 2:02 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-27T14:02:53Z] <dreamyjazz@deploy1002> Started scap: Backport for [[gerrit:1014559|Prevent new user names matching the temporary account pattern (T361021 T349506)]]

Stashbot mentioned this in T361021: New accounts with names beginning with ~2 are created.Mar 27 2024, 2:02 PM
Stashbot added a comment.Mar 27 2024, 2:05 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-27T14:05:56Z] <dreamyjazz@deploy1002> dreamyjazz and tchanders: Backport for [[gerrit:1014559|Prevent new user names matching the temporary account pattern (T361021 T349506)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mar 27 2024, 2:17 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-27T14:17:21Z] <dreamyjazz@deploy1002> Finished scap: Backport for [[gerrit:1014559|Prevent new user names matching the temporary account pattern (T361021 T349506)]] (duration: 14m 28s)

gerritbot added a comment.Mar 27 2024, 3:52 PM

Change #1015072 had a related patch set uploaded (by Tchanders; author: Tchanders):

[operations/mediawiki-config@master] Scope temp user reserved pattern to temp users

https://gerrit.wikimedia.org/r/1015072

Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 27 2024, 5:30 PM
Dreamy_Jazz moved this task from Needs review to Ready on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.
gerritbot added a comment.Mar 27 2024, 8:07 PM

Change #1015072 merged by jenkins-bot:

[operations/mediawiki-config@master] Scope temp user reserved pattern to temp users

https://gerrit.wikimedia.org/r/1015072

Stashbot mentioned this in T360628: Deploy Vector 2022 skin to Wikisource wikis, internal wikis, and wikipedias.Mar 27 2024, 8:08 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-27T20:07:58Z] <jhuneidi@deploy1002> Started scap: Backport for [[gerrit:1015072|Scope temp user reserved pattern to temp users (T361021 T349506)]], [[gerrit:1015095|Updates config to deploy vector 2022 (T360628)]]

Stashbot added a comment.Mar 27 2024, 8:10 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-27T20:10:30Z] <jhuneidi@deploy1002> ksarabia and jhuneidi and tchanders: Backport for [[gerrit:1015072|Scope temp user reserved pattern to temp users (T361021 T349506)]], [[gerrit:1015095|Updates config to deploy vector 2022 (T360628)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mar 27 2024, 8:26 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-27T20:26:56Z] <jhuneidi@deploy1002> Finished scap: Backport for [[gerrit:1015072|Scope temp user reserved pattern to temp users (T361021 T349506)]], [[gerrit:1015095|Updates config to deploy vector 2022 (T360628)]] (duration: 18m 57s)

Tchanders added a subscriber: Madalina.Mar 28 2024, 5:59 PM

$wgAutoCreateTempUser['matchPattern'] = '~2$1';
$wgAutoCreateTempUser['reservedPattern'] = '~$1';

This configuration was suggested so that:

  • Users with names starting '~' do not have to be renamed (unless the second character is '2'). So we only match a temp user if the name starts with '~2'.
  • No more users get created whose names start with '~', in case they get confused with temp accounts.

However, we can't use this configuration. That's because it will prevent users whose names start with '~' from autocreating new accounts for themselves on other wikis.

Instead, in https://gerrit.wikimedia.org/r/1015072 we set:

$wgAutoCreateTempUser['reservedPattern'] = '~2$1';

This still allows new users starting with '~', but not with '~2'. Temp accounts are highlighted in most places they are displayed in the UI, so should be easily distinguishable.

@Niharika @Madalina Does this sound acceptable?

Tchanders updated the task description. (Show Details)Mar 28 2024, 6:00 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)); removed Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)).Mon, Apr 1, 4:15 PM
Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Tue, Apr 2, 9:09 AM
Dreamy_Jazz added a subtask: T359335: Update $wgAutoCreateTempUser defaults with production settings.Tue, Apr 2, 1:23 PM
Tchanders moved this task from Needs Review to Ready on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Thu, Apr 4, 8:40 AM
Dreamy_Jazz closed subtask T359335: Update $wgAutoCreateTempUser defaults with production settings as Resolved.Fri, Apr 5, 10:31 AM
Dreamy_Jazz moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Mon, Apr 15, 12:10 PM
gerritbot added a comment.Mon, Apr 15, 1:02 PM

Change #1014526 merged by jenkins-bot:

[operations/mediawiki-config@master] Add wgAutoCreateTempUser configuration for production

https://gerrit.wikimedia.org/r/1014526

Stashbot mentioned this in T337090: Disallow certain numbers from being generated in the temporary account creation process.Mon, Apr 15, 1:06 PM
Stashbot mentioned this in T356169: MUL - Phased rollout on Wikidata.org (Stage 1 of 3: Test release).

Mentioned in SAL (#wikimedia-operations) [2024-04-15T13:06:04Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:1014526|Add wgAutoCreateTempUser configuration for production (T349506 T337090)]], [[gerrit:1019694|Change mul deployment on beta to limited version (T356169)]]

Stashbot added a comment.Mon, Apr 15, 1:08 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-15T13:08:01Z] <urbanecm@deploy1002> urbanecm and arthurtaylor and dreamyjazz: Backport for [[gerrit:1014526|Add wgAutoCreateTempUser configuration for production (T349506 T337090)]], [[gerrit:1019694|Change mul deployment on beta to limited version (T356169)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mon, Apr 15, 1:58 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-15T13:58:16Z] <urbanecm@deploy1002> sync-world aborted: Backport for [[gerrit:1014526|Add wgAutoCreateTempUser configuration for production (T349506 T337090)]], [[gerrit:1019694|Change mul deployment on beta to limited version (T356169)]] (duration: 52m 11s)

Stashbot added a comment.Mon, Apr 15, 2:01 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-15T14:01:23Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:1014526|Add wgAutoCreateTempUser configuration for production (T349506 T337090)]], [[gerrit:1019694|Change mul deployment on beta to limited version (T356169)]]

Stashbot added a comment.Mon, Apr 15, 2:14 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-15T14:14:15Z] <urbanecm@deploy1002> urbanecm and dreamyjazz and arthurtaylor: Backport for [[gerrit:1014526|Add wgAutoCreateTempUser configuration for production (T349506 T337090)]], [[gerrit:1019694|Change mul deployment on beta to limited version (T356169)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

gerritbot added a comment.Mon, Apr 15, 2:31 PM

Change #1019821 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Define 'useYear' as true for temp user serial mapping config

https://gerrit.wikimedia.org/r/1019821

Stashbot added a comment.Mon, Apr 15, 2:31 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-15T14:31:35Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:1014526|Add wgAutoCreateTempUser configuration for production (T349506 T337090)]], [[gerrit:1019694|Change mul deployment on beta to limited version (T356169)]] (duration: 30m 12s)

gerritbot added a comment.Mon, Apr 15, 2:33 PM

Change #1019821 merged by jenkins-bot:

[operations/mediawiki-config@master] Define 'useYear' as true for temp user serial mapping config

https://gerrit.wikimedia.org/r/1019821

Stashbot added a comment.Mon, Apr 15, 2:34 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-15T14:34:09Z] <dreamyjazz@deploy1002> Started scap: Backport for [[gerrit:1019821|Define 'useYear' as true for temp user serial mapping config (T349506)]]

Stashbot added a comment.Mon, Apr 15, 2:36 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-15T14:36:40Z] <dreamyjazz@deploy1002> dreamyjazz: Backport for [[gerrit:1019821|Define 'useYear' as true for temp user serial mapping config (T349506)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mon, Apr 15, 2:50 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-15T14:50:26Z] <dreamyjazz@deploy1002> Finished scap: Backport for [[gerrit:1019821|Define 'useYear' as true for temp user serial mapping config (T349506)]] (duration: 16m 16s)

Dreamy_Jazz moved this task from In Progress to Needs QA on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Mon, Apr 15, 2:53 PM
Dreamy_Jazz added a comment.Mon, Apr 15, 3:01 PM

For QA please check that temporary accounts on beta wikis still works as expected. For example:

  1. The format for temporary account usernames is ~YYYY-X, where X is an integer and YYYY is the current year
  2. Users which start with ~2 or * are marked as temporary users.
dom_walden edited projects, added Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)); removed Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)).Tue, Apr 23, 10:50 AM
dom_walden moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)) board.
dom_walden moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)) board.Tue, Apr 23, 3:44 PM
dom_walden subscribed.
In T349506#9713787, @Dreamy_Jazz wrote:

For QA please check that temporary accounts on beta wikis still works as expected. For example:

  1. The format for temporary account usernames is ~YYYY-X, where X is an integer and YYYY is the current year
  2. Users which start with ~2 or * are marked as temporary users.

I can confirm on https://de.wikipedia.beta.wmflabs.org.

Dreamy_Jazz closed this task as Resolved.Tue, Apr 23, 4:34 PM
Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 6:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL