Page MenuHomePhabricator

Deploy Vector 2022 skin to Wikisource wikis, internal wikis, and wikipedias
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

  • After removing necessary blockers, we are now ready to proceed with remaining wikisource deployments for the Vector 2022 skin

User story

  • As a reader, I want to use the same skin across all wikis so that my experience is cohesive

Requirements

  • The default skin on Wikisource is Vector 2022

Acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Ensure change is announced

Event Timeline

ovasileva renamed this task from Deploy Vector 2022 skin to Wikisource wikis to Deploy Vector 2022 skin to Wikisource wikis, internal wikis, and wikipedias.Mar 25 2024, 4:25 PM
ovasileva updated the task description. (Show Details)

Change #1015095 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[operations/mediawiki-config@master] Updates config to deploy vector 2022

https://gerrit.wikimedia.org/r/1015095

Change #1015095 merged by jenkins-bot:

[operations/mediawiki-config@master] Updates config to deploy vector 2022

https://gerrit.wikimedia.org/r/1015095

Mentioned in SAL (#wikimedia-operations) [2024-03-27T20:07:58Z] <jhuneidi@deploy1002> Started scap: Backport for [[gerrit:1015072|Scope temp user reserved pattern to temp users (T361021 T349506)]], [[gerrit:1015095|Updates config to deploy vector 2022 (T360628)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-27T20:10:30Z] <jhuneidi@deploy1002> ksarabia and jhuneidi and tchanders: Backport for [[gerrit:1015072|Scope temp user reserved pattern to temp users (T361021 T349506)]], [[gerrit:1015095|Updates config to deploy vector 2022 (T360628)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-03-27T20:26:56Z] <jhuneidi@deploy1002> Finished scap: Backport for [[gerrit:1015072|Scope temp user reserved pattern to temp users (T361021 T349506)]], [[gerrit:1015095|Updates config to deploy vector 2022 (T360628)]] (duration: 18m 57s)

As a reader, I want to use the same skin across all wikis so that my experience is cohesive

Was there a Wikisource reader survery to back this user story up, or is the change implemented purely to prolong funding for the team behind the "improved" Vector?

Change #1015146 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[operations/mediawiki-config@master] Revert donatewiki and thankyouwiki for fundraising

https://gerrit.wikimedia.org/r/1015146

A user is reporting that nv.wikipedia.org should have stayed on vector legacy (which the patch today removed) and that now there are issues with headlines.

They are asking to revert this for nvwiki.

23:52 < Guest82> wellyeah... without warning when tech was clearly told that this leads to a mess
..
23:55 < Guest82> and it was removed without fixing the font-setup
23:55 < Guest82> now all the headlines are a mess
23:55 < Guest82> see here: https://nv.wikipedia.org/wiki/Bi%CA%BC%C3%A9%C3%A9%CA%BC_%C5%81ich%C3%AD%C3%AD%CA%BC%C3%AD_Bik%C3%A9yahd%C4%99%CC%81%C4%99%CC%81%CA%BC_g%C3%B3goo%CA%BCii
23:56 < Guest82> ę́ doe not work... neither does į́

Change #1015146 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert donatewiki and thankyouwiki for fundraising

https://gerrit.wikimedia.org/r/1015146

Mentioned in SAL (#wikimedia-operations) [2024-03-28T13:02:36Z] <mabualruz@deploy1002> Started scap: Backport for [[gerrit:1015146|Revert donatewiki and thankyouwiki for fundraising (T360628)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-28T13:05:11Z] <mabualruz@deploy1002> ksarabia and mabualruz: Backport for [[gerrit:1015146|Revert donatewiki and thankyouwiki for fundraising (T360628)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-03-28T13:18:31Z] <mabualruz@deploy1002> Finished scap: Backport for [[gerrit:1015146|Revert donatewiki and thankyouwiki for fundraising (T360628)]] (duration: 15m 55s)

hi @Dzahn, could you ask the user to elaborate on the headline/font issues on nv.wikipedia.org? If there's special consideration required for that wiki we'd like to know about it. On my computer, I can't see the issue: " ę́ doe not work... neither does į́" or how "all the headlines are a mess" . If possible, a screenshot would be great (below is what I see).

Screenshot 2024-03-28 at 1.02.42 PM.png (1×2 px, 1 MB)
Screenshot 2024-03-28 at 1.02.48 PM.png (1×2 px, 1 MB)
legacy VectorVector 2022

@Jdrewniak They have left the chat channel meanwhile. But they said they also have a Phabricator account and would comment here. So I'm hoping for that.

scrn-mess-nv.png (189×590 px, 18 KB)

it's forcing linux libertine (ą is also wrong, the hook needs to be center, not right.)

Only correct font is Noto Sans/Noto Serif.

hi @Seb_az86556 I've looked into it and I know what the font issue is. Vector 2022 has slightly different HTML markup than legacy Vector.

The line that changes the font for legacy Vector on https://nv.wikipedia.org/wiki/MediaWiki:Common.css#L-10

div#content h1, div#content h2, div#content h3, div#content #firstHeading {
    font-family: "Noto Serif", "Noto Sans", serif !important;
}

doesn't apply to Vector 2022 because we use a <main> element instead of a <div> for the #content container.
The following change would solve this issue:

#content h1, #content h2, #content h3, #content #firstHeading {
    font-family: "Noto Serif", "Noto Sans", serif !important;
}

My WMF account has template editing rights for situations like this. Let me know if you'd like me to go ahead and make that edit, or if you'd prefer someone from the community do it instead.

No-one there has the rights ever since they were revoked from us. So yeah, do it if that's the fix. (will this work for both skins though?)

Also, common.js needs to be made to work as well, to give the correct headers in categories.

@Seb_az86556 I went ahead and made the change to common.js. It looks like it fixed the heading issue. It still works on legacy Vector. Regarding common.js, it seems to be working for me, e.g changing "C" to "Ch'":

Screenshot 2024-03-28 at 3.05.50 PM.png (1×2 px, 1 MB)

correct, it suddenly works. didnʼt yesterday.

This comment was removed by Ladsgroup.
This comment was removed by SCP-2000.
This comment was removed by Ladsgroup.
NBaca-WMF subscribed.

All deploys have gone through at this point, except for donate.wikipedia and thankyou.wikimedia - we will handle these with a separate ticket