Page MenuHomePhabricator

Support modifying the status of global blocks on accounts using Special:GlobalBlockStatus
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
Dreamy_Jazz
Feb 7 2024, 10:22 PM
Referenced Files
F43371688: image.png
Wed, Mar 27, 12:55 AM
F43370164: image.png
Wed, Mar 27, 12:55 AM
F43370400: image.png
Wed, Mar 27, 12:55 AM
F43370098: image.png
Wed, Mar 27, 12:55 AM
F43367972: image.png
Wed, Mar 27, 12:55 AM
F43367103: image.png
Wed, Mar 27, 12:55 AM
F43367085: image.png
Wed, Mar 27, 12:55 AM
F42988261: image.png
Wed, Mar 27, 12:55 AM

Description

Special:GlobalBlockStatus allows a user with appropriate permissions to see what wikis have applied a local override to a global block and modify the override. This special page should support doing this for global blocks on accounts if it is made possible to override a global block on an account.

Related Objects

StatusSubtypeAssignedTask
In Progress Niharika
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenSkizzerz
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
Resolved Marostegui
Resolved Marostegui
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz

Event Timeline

Dreamy_Jazz renamed this task from Support displaying the status of global blocks on accounts in Special:GlobalBlockStatus to Support modifying the status of global blocks on accounts using Special:GlobalBlockStatus.Feb 27 2024, 11:57 AM

Change 1006911 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Update GlobalBlockLocalStatusLookup for account blocks

https://gerrit.wikimedia.org/r/1006911

Change 1012667 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Use the GlobalBlockLocalStatusManager service in special page

https://gerrit.wikimedia.org/r/1012667

Change 1012707 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Test SpecialGlobalBlockStatus

https://gerrit.wikimedia.org/r/1012707

Change 1012714 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockLocalStatusLookup for account blocks

https://gerrit.wikimedia.org/r/1012714

Change 1012798 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Deprecate looking up local status by target username

https://gerrit.wikimedia.org/r/1012798

Change 1012707 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Test SpecialGlobalBlockStatus

https://gerrit.wikimedia.org/r/1012707

Change 1012667 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Use the GlobalBlockLocalStatusManager service in GlobalBlockStatus

https://gerrit.wikimedia.org/r/1012667

Change 1012798 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Deprecate GlobalBlockLocalStatusLookup::getLocalWhitelistInfoByIP

https://gerrit.wikimedia.org/r/1012798

Change #1012714 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update Special:GlobalBlockStatus for account blocks

https://gerrit.wikimedia.org/r/1012714

Suggested QA steps:

  1. Create global blocks on an account, IP and IP range for testing
  2. For each of these blocks use the Special:GlobalBlockStatus form to locally disable and then re-enable the block, making sure that the page does not error out and when the block is disabled locally is listed as such on Special:GlobalBlockList
  3. Enter an invalid username (such as #) into Special:GlobalBlockStatus and expect that it gives you an error indicating that the target is invalid and expect that it gives an error that no global block exists for that username
  4. Try to use the form for a target that is not globally blocked and assert that the form gives you an error detailing that no global block exists

I cannot change the global block status of Drwpb1 on enwiki beta: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:GlobalBlockWhitelist&address=Drwpb1

Instead, on form submission, it says: The IP address (0.0.0.0) you entered is not globally blocked.

I have been able to successfully change the status of global account blocks locally.

I cannot change the global block status of Drwpb1 on enwiki beta: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:GlobalBlockWhitelist&address=Drwpb1

Instead, on form submission, it says: The IP address (0.0.0.0) you entered is not globally blocked.

I have been able to successfully change the status of global account blocks locally.

It looks like the beta wikis have not been updated since 21st of March due to T360595. That would explain this as some of the changes in this ticket were not merged until after the updates started failing.

I have verified the new code has been implemented and is functioning and displaying as expected... Thank You @Dreamy_Jazz!!!


Before New Code Change:

Before New Code Change.jpg (529×1 px, 78 KB)


After New Code Change:

After New Code Change.jpg (457×1 px, 72 KB)


Error Handling Validation-- Error Message detailing Username specifically:

image.png (481×1 px, 49 KB)


Confirmation message detailing Username specifically:

image.png (393×1 px, 34 KB)


image.png (849×437 px, 212 KB)

image.png (867×474 px, 190 KB)


image.png (850×702 px, 113 KB)


image.png (612×1 px, 166 KB)

image.png (568×1 px, 198 KB)

image.png (442×1 px, 144 KB)

image.png (874×1 px, 477 KB)