Page MenuHomePhabricator
Create Task
Maniphest T356931

Support modifying the status of global blocks on accounts using Special:GlobalBlockStatus
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Dreamy_Jazz
Authored By
Dreamy_Jazz
Feb 7 2024, 10:22 PM
Tags
Referenced Files
F43371688: image.png
Mar 27 2024, 12:55 AM
F43370164: image.png
Mar 27 2024, 12:55 AM
F43370400: image.png
Mar 27 2024, 12:55 AM
F43370098: image.png
Mar 27 2024, 12:55 AM
F43367972: image.png
Mar 27 2024, 12:55 AM
F43367103: image.png
Mar 27 2024, 12:55 AM
F43367085: image.png
Mar 27 2024, 12:55 AM
F42988261: image.png
Mar 27 2024, 12:55 AM
View All 11 Files
Subscribers
Aklapper
Djackson-ctr
dom_walden
Dreamy_Jazz

Description

Special:GlobalBlockStatus allows a user with appropriate permissions to see what wikis have applied a local override to a global block and modify the override. This special page should support doing this for global blocks on accounts if it is made possible to override a global block on an account.

Details

SubjectRepoBranchLines +/-
Update Special:GlobalBlockStatus for account blocksmediawiki/extensions/GlobalBlockingmaster+146 -50
Deprecate GlobalBlockLocalStatusLookup::getLocalWhitelistInfoByIPmediawiki/extensions/GlobalBlockingmaster+6 -15
Test SpecialGlobalBlockStatusmediawiki/extensions/GlobalBlockingmaster+138 -1
Use the GlobalBlockLocalStatusManager service in GlobalBlockStatusmediawiki/extensions/GlobalBlockingmaster+33 -81
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 In Progress• NiharikaT324492 Temporary accounts - MVP
 OpenNoneT326816 Update features for IP Masking
 OpenNoneT355286 [Epic] Globally blocking a temporary account should prevent further account creations
 OpenNoneT19929 CentralAuth account locks should trigger global autoblocks
 DuplicateNoneT340275 Allow GlobalBlocking to block temporary accounts
 OpenSkizzerzT17294 Allow blocking of global accounts
 OpenNoneT358777 Rename messages with the '-new' suffix to remove this suffix
 OpenNoneT358776 Remove old versions of GlobalBlocking i18n messages
 OpenNoneT358773 Remove the global accounts block configuration flag
 OpenNoneT356924 Deploy global account blocks to WMF wikis
 ResolvedDreamy_JazzT356931 Support modifying the status of global blocks on accounts using Special:GlobalBlockStatus
 ResolvedDreamy_JazzT356936 Update GlobalBlocking services to support global block on accounts
 ResolvedDreamy_JazzT358150 Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts
 ResolvedDreamy_JazzT358157 Update the GlobalBlockManager service to support global blocks on accounts
 ResolvedDreamy_JazzT358155 Update GlobalBlockLookup service to support global blocks on accounts
 ResolvedDreamy_JazzT356876 Add a column to store central ID in globalblocks and global_block_whitelist tables
 Resolved• MarosteguiT356987 Add gb_target_central_id to the globalblocks table on the centralauth DB
 Resolved• MarosteguiT356988 Add gbw_target_central_id to global_block_whitelist table on WMF wikis
 ResolvedDreamy_JazzT356922 Deprecate unnecessary GlobalBlocking hooks
 ResolvedDreamy_JazzT359091 Create GlobalBlockLocalStatusManager service
 ResolvedDreamy_JazzT358865 Use non-legacy log parameters for log entries for global blocking and unblocking
 ResolvedDreamy_JazzT358725 Update the GlobalBlockingLinkBuilder service for global account blocks
 ResolvedDreamy_JazzT356923 Create a configuration value to control whether global account blocks are enabled
 ResolvedDreamy_JazzT356925 Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts
 ResolvedDreamy_JazzT357385 Refactor the GlobalBlocking utility class into services
 ResolvedDreamy_JazzT357399 Create GlobalBlockingConnectionProvider
 ResolvedDreamy_JazzT357443 Create GlobalBlockingBlockPurger service
 ResolvedDreamy_JazzT357506 Create GlobalBlockLocalStatusLookup service
 ResolvedDreamy_JazzT357675 Create GlobalBlockLookup service
 ResolvedDreamy_JazzT357925 Create the GlobalBlockManager service

Event Timeline

Dreamy_Jazz created this task.Feb 7 2024, 10:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2024, 10:22 PM
Dreamy_Jazz added a parent task: T356924: Deploy global account blocks to WMF wikis.Feb 7 2024, 10:22 PM
Dreamy_Jazz added a subtask: T356936: Update GlobalBlocking services to support global block on accounts.Feb 7 2024, 10:34 PM
Dreamy_Jazz renamed this task from Support displaying the status of global blocks on accounts in Special:GlobalBlockStatus to Support modifying the status of global blocks on accounts using Special:GlobalBlockStatus.Feb 27 2024, 11:57 AM
gerritbot added a comment.Feb 27 2024, 11:58 AM

Change 1006911 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Update GlobalBlockLocalStatusLookup for account blocks

https://gerrit.wikimedia.org/r/1006911

gerritbot added a project: Patch-For-Review.Feb 27 2024, 11:58 AM
Dreamy_Jazz claimed this task.Mar 5 2024, 4:00 PM
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)).
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)); removed Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)).Mar 11 2024, 2:49 PM
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.
gerritbot added a comment.Mar 19 2024, 1:17 PM

Change 1012667 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Use the GlobalBlockLocalStatusManager service in special page

https://gerrit.wikimedia.org/r/1012667

gerritbot added a comment.Mar 19 2024, 4:04 PM

Change 1012707 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Test SpecialGlobalBlockStatus

https://gerrit.wikimedia.org/r/1012707

gerritbot added a comment.Mar 19 2024, 4:39 PM

Change 1012714 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockLocalStatusLookup for account blocks

https://gerrit.wikimedia.org/r/1012714

gerritbot added a comment.Mar 20 2024, 12:38 AM

Change 1012798 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Deprecate looking up local status by target username

https://gerrit.wikimedia.org/r/1012798

gerritbot added a comment.Mar 20 2024, 6:32 AM

Change 1012707 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Test SpecialGlobalBlockStatus

https://gerrit.wikimedia.org/r/1012707

gerritbot added a comment.Mar 20 2024, 6:35 AM

Change 1012667 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Use the GlobalBlockLocalStatusManager service in GlobalBlockStatus

https://gerrit.wikimedia.org/r/1012667

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Mar 20 2024, 7:00 AM
gerritbot added a comment.Mar 21 2024, 1:45 PM

Change 1012798 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Deprecate GlobalBlockLocalStatusLookup::getLocalWhitelistInfoByIP

https://gerrit.wikimedia.org/r/1012798

gerritbot added a comment.Mar 21 2024, 8:39 PM

Change #1012714 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update Special:GlobalBlockStatus for account blocks

https://gerrit.wikimedia.org/r/1012714

Dreamy_Jazz moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 21 2024, 10:52 PM
Dreamy_Jazz added a comment.EditedMar 22 2024, 2:05 AM

Suggested QA steps:

  1. Create global blocks on an account, IP and IP range for testing
  2. For each of these blocks use the Special:GlobalBlockStatus form to locally disable and then re-enable the block, making sure that the page does not error out and when the block is disabled locally is listed as such on Special:GlobalBlockList
  3. Enter an invalid username (such as #) into Special:GlobalBlockStatus and expect that it gives you an error indicating that the target is invalid and expect that it gives an error that no global block exists for that username
  4. Try to use the form for a target that is not globally blocked and assert that the form gives you an error detailing that no global block exists
dom_walden subscribed.Mar 22 2024, 11:07 AM

I cannot change the global block status of Drwpb1 on enwiki beta: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:GlobalBlockWhitelist&address=Drwpb1

Instead, on form submission, it says: The IP address (0.0.0.0) you entered is not globally blocked.

I have been able to successfully change the status of global account blocks locally.

Dreamy_Jazz added a comment.Mar 25 2024, 2:00 PM
In T356931#9653587, @dom_walden wrote:

I cannot change the global block status of Drwpb1 on enwiki beta: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:GlobalBlockWhitelist&address=Drwpb1

Instead, on form submission, it says: The IP address (0.0.0.0) you entered is not globally blocked.

I have been able to successfully change the status of global account blocks locally.

It looks like the beta wikis have not been updated since 21st of March due to T360595. That would explain this as some of the changes in this ticket were not merged until after the updates started failing.

Djackson-ctr subscribed.Mar 27 2024, 12:55 AM

I have verified the new code has been implemented and is functioning and displaying as expected... Thank You @Dreamy_Jazz!!!

Before New Code Change:

Before New Code Change.jpg (529×1 px, 78 KB)

After New Code Change:

After New Code Change.jpg (457×1 px, 72 KB)

Error Handling Validation-- Error Message detailing Username specifically:

image.png (481×1 px, 49 KB)

Confirmation message detailing Username specifically:

image.png (393×1 px, 34 KB)

image.png (849×437 px, 212 KB)

image.png (867×474 px, 190 KB)

image.png (850×702 px, 113 KB)

image.png (612×1 px, 166 KB)

image.png (568×1 px, 198 KB)

image.png (442×1 px, 144 KB)

image.png (874×1 px, 477 KB)

Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 27 2024, 12:59 AM
Dreamy_Jazz closed this task as Resolved.Mar 27 2024, 9:36 AM
Dreamy_Jazz mentioned this in T358150: Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts.
Dreamy_Jazz closed subtask T356936: Update GlobalBlocking services to support global block on accounts as Resolved.Mar 27 2024, 9:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL