Create GlobalBlockLocalStatusLookup service
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Feb 14 2024, 11:14 AM

Description

A service is needed that allows callers to lookup the local status of a global block either by the associated target or global block ID. This will be done by moving the static methods GlobalBlocking::getLocalWhitelistInfo and GlobalBlocking::getLocalWhitelistInfoByIP into this new service.

Acceptance criteria

Create the GlobalBlockLocalStatusLookup service by using copies of GlobalBlocking::getLocalWhitelistInfo and GlobalBlocking::getLocalWhitelistInfoByIP as the sole methods
Update the methods to use DI and SQL query builders
Replace the usage of wfGetDb (T357644)
Fully test this service

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T357506 here

Details

	Subject	Repo	Branch	Lines +/-
	Create GlobalBlockLocalStatusLookup service	mediawiki/extensions/GlobalBlocking	master	+217 -25

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Dreamy_Jazz	T357385 Refactor the GlobalBlocking utility class into services
Resolved	Dreamy_Jazz	T357644 Replace usage of wfGetDB() in GlobalBlocking before the 1.42 cut so it can be hard-deprecated
Resolved	Dreamy_Jazz	T358150 Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts
Resolved	Dreamy_Jazz	T357506 Create GlobalBlockLocalStatusLookup service
		· · ·

Event Timeline

Dreamy_Jazz created this task.Feb 14 2024, 11:14 AM

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)).

Dreamy_Jazz set the point value for this task to 2.

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.

Change 1003391 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockLocalStatusLookup service

https://gerrit.wikimedia.org/r/1003391

gerritbot added a project: Patch-For-Review.Feb 14 2024, 11:25 AM

Dreamy_Jazz updated the task description. (Show Details)Feb 14 2024, 11:31 AM

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.Feb 14 2024, 11:41 AM

Dreamy_Jazz added a parent task: T357644: Replace usage of wfGetDB() in GlobalBlocking before the 1.42 cut so it can be hard-deprecated.Feb 15 2024, 2:48 PM

Dreamy_Jazz updated the task description. (Show Details)

Change 1003391 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockLocalStatusLookup service

https://gerrit.wikimedia.org/r/1003391

Dreamy_Jazz updated the task description. (Show Details)Feb 16 2024, 4:57 PM

Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.

Suggested QA steps:

Install GlobalBlocking, if required
Find the IP address you are using to connect to the wiki (you can find this by editing a page while logged out)
Log into an account with the globalblock right
Globally block the IP address found in step 2 with it configured to be targeting anonymous users only
In an incognito tab try to make an edit while logged out and it should prevent you from doing so
Load Special:GlobalBlockList and click the local status link for the global block you performed in step 4
Fill out the form to disable the block on the local wiki
Go back to the incognito tab and try to make an edit while logged out. This should succeed.
Load Special:GlobalBlockList and there should be the text local disabled next to the block you performed in step 4
Click on the local status link again and fill out the form on that page to re-enable the global block on the wiki
Load Special:GlobalBlockList and verify that the block performed in step 4 no longer shows as locally disabled.

As with T357443 and T357399 there should be no functionality changes made by this ticket and it's patch, so you may wish to do these steps on a wiki with a version of the code before this patch to verify this.

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2024, 5:30 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)); removed Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)).Feb 20 2024, 12:05 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.

@Dreamy_Jazz There are no functionality changes made from the current patch compared to an older patch. This will be moved to Done. Thanks for all your work and steps!

Status: ✅PASS
Environment: Local: 1.42.0-alpha (ba6da7d)17:55, 20 February 2024
OS: macOS Sonoma 14.2.1
Browser: Chrome 121, Safari 14.3
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
Special:GlobalBlock
Special:GlobalBlockList

✅AC1: https://phabricator.wikimedia.org/T357506

GlobalBlocking Current- commit 8d46d991a32e2a3c3575112659641c3532c742ac: Wed Feb 21 08:16:51 2024

Steps 1-8	Steps 9-11

GlobalBlocking Old- commit bffe54f3cbc809dd36389ea26e9ca05f631b3414: Fri Feb 9 15:16:07 2024

Steps 1-8	Steps 9-11

GMikesell-WMF updated the task description. (Show Details)Feb 21 2024, 8:57 PM

GMikesell-WMF moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.

Thanks for the QA testing!

Dreamy_Jazz mentioned this in T357675: Create GlobalBlockLookup service.Feb 22 2024, 1:31 PM

Dreamy_Jazz mentioned this in T357925: Create the GlobalBlockManager service.

Dreamy_Jazz added a parent task: T358150: Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts.Feb 22 2024, 4:14 PM

	F42027758: T357506_GBLocalStatusLookup_9_11_Old.webm
	Feb 21 2024, 8:57 PM

	F42027755: T357506_GBLocalStatusLookup_1_8_Old.webm
	Feb 21 2024, 8:57 PM

	F42027889: T357506_GBLocalStatusLookup_1_8_New.webm
	Feb 21 2024, 8:57 PM

	F42027887: T357506_GBLocalStatusLookup_9_11_New.webm
	Feb 21 2024, 8:57 PM

Create GlobalBlockLocalStatusLookup serviceClosed, ResolvedPublic2 Estimated Story PointsActions