Create GlobalBlockingConnectionProvider
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Feb 13 2024, 12:22 PM

Project Tags

Referenced Files

	F41938404: T357399_GB_OldPatch.webm
	Feb 17 2024, 2:44 AM

	F41938377: 2024-02-16_18-34-10.png
	Feb 17 2024, 2:44 AM

	F41935603: T357399_GlobalBlock_Regression.webm
	Feb 17 2024, 2:44 AM

	F41935568: 2024-02-16_10-44-17.png
	Feb 17 2024, 2:44 AM

	F41935561: 2024-02-16_10-43-46.png
	Feb 17 2024, 2:44 AM

	F41935545: 2024-02-16_10-41-18.png
	Feb 17 2024, 2:44 AM

	F41935536: 2024-02-16_10-30-07.png
	Feb 17 2024, 2:44 AM

	F41935531: 2024-02-16_10-28-17.png
	Feb 17 2024, 2:44 AM

Subscribers

Description

A service is needed that allows callers to get a database connection to the virtual-globalblocking database domain. This will replace the methods in the GlobalBlocking.php static utility class.

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T357399 here

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Create GlobalBlockingConnectionProvider	Dreamy Jazz	mediawiki/extensions/GlobalBlocking	master	+87 -28

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Dreamy_Jazz	T357385 Refactor the GlobalBlocking utility class into services
Resolved	Dreamy_Jazz	T357399 Create GlobalBlockingConnectionProvider
		· · ·

Event Timeline

Dreamy_Jazz created this task.Feb 13 2024, 12:22 PM

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)).

Dreamy_Jazz set the point value for this task to 1.

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.

Change 1002970 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockingConnectionProvider

https://gerrit.wikimedia.org/r/1002970

gerritbot added a project: Patch-For-Review.Feb 13 2024, 12:39 PM

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.Feb 13 2024, 12:52 PM

Dreamy_Jazz claimed this task.Feb 14 2024, 11:11 AM

Change 1002970 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockingConnectionProvider

https://gerrit.wikimedia.org/r/1002970

Suggested steps for QA:

Install GlobalBlocking, if not already installed
Log into an account with steward rights if you have MediaWiki-extensions-CentralAuth installed or an account that has the globalblock right (you can give this right to admins using $wgGroupPermissions['sysop']['globalblock'] = true; in LocalSettings.php)
Use Special:GlobalBlock to make a global block on an IP address
Load Special:GlobalBlockList
Verify that the global block you applied appears in the list of global blocks.

These steps were designed to verify that no changes to the on-wiki interface have been made by this patch (as this ticket and patch refactored existing code without changing functionality). You may wish to test that nothing changed compared to running these steps on a wiki which does not have this change applied.

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2024, 11:30 PM

Dreamy_Jazz mentioned this in T357443: Create GlobalBlockingBlockPurger service.Feb 14 2024, 11:42 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 15 2024, 2:01 AM

Dreamy_Jazz mentioned this in T357506: Create GlobalBlockLocalStatusLookup service.Feb 16 2024, 5:16 PM

@Dreamy_Jazz Nothing changed as previously and has the same functions as seen in screenshots and .webm. This will be moved to Done. Thanks for all your work!

Status: ✅PASS
Environment: Local: 1.42.0-alpha (f3389a3)23:25, 16 February 2024; GlobalBlocking: commit 093123a6b8b990b96061450874cfac5235d347e8 & bffe54f3cbc809dd36389ea26e9ca05f631b3414
OS: macOS Sonoma 14.2.1
Browser: Chrome 121
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog#