Page MenuHomePhabricator

Update the GlobalBlockManager service to support global blocks on accounts
Closed, ResolvedPublic2 Estimated Story Points

Description

The GlobalBlockManager service needs to be updated to support global blocks on accounts.

This includes (but is not limited to):

  • Updating mentions of IP addresses / address with target or similar in the GlobalBlockManager service to make it clear this can also be an account
  • Updating the validation code for the target to accept registered users (including temporary accounts)
  • Making limited updates to the special pages to make it possible to e2e test the service

Related Objects

StatusSubtypeAssignedTask
In Progress Niharika
OpenNone
OpenNone
OpenNone
OpenDreamy_Jazz
OpenNone
DuplicateNone
OpenSkizzerz
OpenDreamy_Jazz
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedDreamy_Jazz
OpenNone
OpenDreamy_Jazz
OpenNone
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedMarostegui
ResolvedMarostegui
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz

Event Timeline

Change 1005816 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [Very WIP] Update GlobalBlockManager for global account blocks

https://gerrit.wikimedia.org/r/1005816

Dreamy_Jazz set the point value for this task to 2.Feb 28 2024, 10:20 PM

Change 1009780 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Partially SpecialGlobalBlock for global account blocks

https://gerrit.wikimedia.org/r/1009780

Change 1005816 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockManager for global account blocks

https://gerrit.wikimedia.org/r/1005816

Change 1009780 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Partially update SpecialGlobalBlock for global account blocks

https://gerrit.wikimedia.org/r/1009780

Suggested QA steps (for beta wikis or a local wiki):

  1. Load Special:GlobalBlock and perform global blocks on multiple accounts using a variety of parameters
  2. Go to Special:GlobalBlockList and verify that these blocks appear there
  3. Modify one of the global blocks using Special:GlobalBlock (a modify link should be present on Special:GlobalBlockList which takes you to the correct page)
    1. When using the form, make sure to verify that red text appears in the form to indicate that a global block is already applied to the target of the block. Also ensure that a banner is shown below the form with the global block log extracts which just shows the global block on the account you are now modifying,
  4. Use Special:GlobalUnblock to remove a block on at least one of the accounts you blocked (a remove link hould be present on Special:GlobalBlockList which takes you to the correct page)
Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning and displaying as expected... Thank You @Dreamy_Jazz!!!

image.png (653×1 px, 69 KB)

image.png (563×1 px, 71 KB)

image.png (784×1 px, 92 KB)