Page MenuHomePhabricator
Create Task
Maniphest T358157

Update the GlobalBlockManager service to support global blocks on accounts
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The GlobalBlockManager service needs to be updated to support global blocks on accounts.

This includes (but is not limited to):

  • Updating mentions of IP addresses / address with target or similar in the GlobalBlockManager service to make it clear this can also be an account
  • Updating the validation code for the target to accept registered users (including temporary accounts)
  • Making limited updates to the special pages to make it possible to e2e test the service

Details

SubjectRepoBranchLines +/-
Partially update SpecialGlobalBlock for global account blocksmediawiki/extensions/GlobalBlockingmaster+170 -41
Update GlobalBlockManager for global account blocksmediawiki/extensions/GlobalBlockingmaster+219 -49
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 In ProgressNiharikaT324492 Temporary accounts - MVP
 OpenNoneT326816 Update features for temporary accounts
 OpenDreamy_JazzT355286 [Epic] Globally blocking a temporary account should prevent further account creations
 OpenDreamy_JazzT368949 Implement global autoblocks from global user blocks
 OpenNoneT350075 Migrate raw SQL building in conditions to expression builder in WMF-deployed extensions
 ResolvedDreamy_JazzT350972 Use expression builder instead of raw SQL in GlobalBlocking
 OpenNoneT19929 CentralAuth account locks should trigger global autoblocks
 DuplicateNoneT340275 Allow GlobalBlocking to block temporary accounts
 ResolvedFeatureDreamy_JazzT17294 Allow globally blocking of accounts
 ResolvedDreamy_JazzT356990 GlobalBlocking extension has poor test coverage
 ResolvedDreamy_JazzT358777 Rename messages with the '-new' suffix to remove this suffix
 ResolvedDreamy_JazzT358776 Remove old versions of GlobalBlocking i18n messages
 ResolvedDreamy_JazzT358773 Remove the global accounts block configuration flag
 ResolvedDreamy_JazzT356924 Deploy global account blocks to WMF wikis
 ResolvedDreamy_JazzT356926 Add support to block global accounts using the globalblock API
 ResolvedDreamy_JazzT356929 Allow SpecialRemoveGlobalBlock to remove a global block on an account
 ResolvedDreamy_JazzT356931 Support modifying the status of global blocks on accounts using Special:GlobalBlockStatus
 ResolvedDreamy_JazzT356932 Allow Special:GlobalBlockList to show global blocks for accounts
 ResolvedDreamy_JazzT356934 Allow a user to perform global blocks on accounts using Special:GlobalBlock
 ResolvedDreamy_JazzT356935 The 'globalblocks' API should support listing global blocks for accounts
 ResolvedDreamy_JazzT366386 Update GlobalBlockingHooks to support global account blocks
 ResolvedDreamy_JazzT356936 Update GlobalBlocking services to support global block on accounts
 ResolvedDreamy_JazzT358157 Update the GlobalBlockManager service to support global blocks on accounts
 ResolvedDreamy_JazzT358155 Update GlobalBlockLookup service to support global blocks on accounts
 ResolvedDreamy_JazzT356876 Add a column to store central ID in globalblocks and global_block_whitelist tables
 Resolved• MarosteguiT356987 Add gb_target_central_id to the globalblocks table on the centralauth DB
 Resolved• MarosteguiT356988 Add gbw_target_central_id to global_block_whitelist table on WMF wikis
 ResolvedDreamy_JazzT356922 Deprecate unnecessary GlobalBlocking hooks
 ResolvedDreamy_JazzT359091 Create GlobalBlockLocalStatusManager service
 ResolvedDreamy_JazzT358865 Use non-legacy log parameters for log entries for global blocking and unblocking
 ResolvedDreamy_JazzT358725 Update the GlobalBlockingLinkBuilder service for global account blocks
 ResolvedDreamy_JazzT356923 Create a configuration value to control whether global account blocks are enabled
 ResolvedDreamy_JazzT356925 Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts
 ResolvedDreamy_JazzT357385 Refactor the GlobalBlocking utility class into services
 ResolvedDreamy_JazzT357399 Create GlobalBlockingConnectionProvider
 ResolvedDreamy_JazzT357443 Create GlobalBlockingBlockPurger service
 ResolvedDreamy_JazzT357506 Create GlobalBlockLocalStatusLookup service
 ResolvedDreamy_JazzT357675 Create GlobalBlockLookup service
 ResolvedDreamy_JazzT357925 Create the GlobalBlockManager service

Event Timeline

Dreamy_Jazz created this task.Feb 21 2024, 10:41 PM
Dreamy_Jazz added a subtask: T356923: Create a configuration value to control whether global account blocks are enabled.
Dreamy_Jazz added a subtask: T357925: Create the GlobalBlockManager service.Feb 21 2024, 10:54 PM
Dreamy_Jazz removed a subtask: T357925: Create the GlobalBlockManager service.
Dreamy_Jazz added a subtask: T356876: Add a column to store central ID in globalblocks and global_block_whitelist tables.Feb 21 2024, 10:58 PM
Dreamy_Jazz added a subtask: T357925: Create the GlobalBlockManager service.Feb 22 2024, 4:15 PM
gerritbot added a comment.Feb 22 2024, 6:43 PM

Change 1005816 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [Very WIP] Update GlobalBlockManager for global account blocks

https://gerrit.wikimedia.org/r/1005816

gerritbot added a project: Patch-For-Review.Feb 22 2024, 6:43 PM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 22 2024, 8:09 PM
Dreamy_Jazz closed subtask T357925: Create the GlobalBlockManager service as Resolved.Feb 27 2024, 2:20 PM
Dreamy_Jazz closed subtask T356923: Create a configuration value to control whether global account blocks are enabled as Resolved.Feb 28 2024, 2:02 PM
Dreamy_Jazz set the point value for this task to 2.Feb 28 2024, 10:20 PM
Dreamy_Jazz added a subtask: T358155: Update GlobalBlockLookup service to support global blocks on accounts.Feb 29 2024, 10:57 PM
Dreamy_Jazz mentioned this in T163607: The links to the IPs of the "Global IP block log" go to the user page and not the contributions special page.Mar 1 2024, 1:26 PM
Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Mar 4 2024, 5:36 PM
gerritbot added a comment.Mar 8 2024, 5:12 PM

Change 1009780 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Partially SpecialGlobalBlock for global account blocks

https://gerrit.wikimedia.org/r/1009780

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)); removed Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)).Mar 11 2024, 2:47 PM
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.
gerritbot added a comment.Mar 18 2024, 4:53 PM

Change 1005816 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockManager for global account blocks

https://gerrit.wikimedia.org/r/1005816

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 18 2024, 5:00 PM
gerritbot added a comment.Mar 18 2024, 6:08 PM

Change 1009780 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Partially update SpecialGlobalBlock for global account blocks

https://gerrit.wikimedia.org/r/1009780

• Tchanders moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 18 2024, 6:10 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 18 2024, 6:30 PM
Dreamy_Jazz added a comment.Mar 19 2024, 11:20 AM

Suggested QA steps (for beta wikis or a local wiki):

  1. Load Special:GlobalBlock and perform global blocks on multiple accounts using a variety of parameters
  2. Go to Special:GlobalBlockList and verify that these blocks appear there
  3. Modify one of the global blocks using Special:GlobalBlock (a modify link should be present on Special:GlobalBlockList which takes you to the correct page)
    1. When using the form, make sure to verify that red text appears in the form to indicate that a global block is already applied to the target of the block. Also ensure that a banner is shown below the form with the global block log extracts which just shows the global block on the account you are now modifying,
  4. Use Special:GlobalUnblock to remove a block on at least one of the accounts you blocked (a remove link hould be present on Special:GlobalBlockList which takes you to the correct page)
Dreamy_Jazz updated the task description. (Show Details)Mar 19 2024, 11:24 AM
Dreamy_Jazz closed subtask T358155: Update GlobalBlockLookup service to support global blocks on accounts as Resolved.
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 20 2024, 2:32 AM
Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning and displaying as expected... Thank You @Dreamy_Jazz!!!

image.png (653×1 px, 69 KB)

image.png (563×1 px, 71 KB)

image.png (784×1 px, 92 KB)

Dreamy_Jazz closed this task as Resolved.Mar 20 2024, 9:49 AM
Dreamy_Jazz closed subtask T358865: Use non-legacy log parameters for log entries for global blocking and unblocking as Resolved.Mar 27 2024, 9:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits