Page MenuHomePhabricator
Create Task
Maniphest T356935

The 'globalblocks' API should support listing global blocks for accounts
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Dreamy_Jazz
Authored By
Dreamy_Jazz
Feb 7 2024, 10:28 PM
Project Tags
Referenced Files
F56471728: image.png
Jul 17 2024, 3:27 AM
F56471720: image.png
Jul 17 2024, 3:27 AM
F56471397: image.png
Jul 17 2024, 3:27 AM
F56471330: image.png
Jul 17 2024, 3:27 AM
F56471184: image.png
Jul 17 2024, 3:27 AM
F56471197: image.png
Jul 17 2024, 3:27 AM
F56471195: image.png
Jul 17 2024, 3:27 AM
F56471187: image.png
Jul 17 2024, 3:27 AM
View All 11 Files
Subscribers
Aklapper
Djackson-ctr
Dreamy_Jazz
Tchanders

Description

The globalblocks API allows a user to get a list of active global blocks in a similar way to how the Special:GlobalBlockList special page but through an API call.

This API should support displaying and filtering for global blocks made on accounts. The API description, help messages, and probably also parameters need updating to indicate support for global account blocks.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update ApiQueryGlobalBlocks to support global account blocksDreamy Jazzmediawiki/extensions/GlobalBlockingmaster+258 -113
Test ApiQueryGlobalBlocksDreamy Jazzmediawiki/extensions/GlobalBlockingmaster+247 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 Resolved• NiharikaT324492 Temporary accounts - MVP
 ResolvedMadalinaT326816 [Epic] Update features for temporary accounts
 ResolvedDreamy_JazzT355286 [Epic] Globally blocking a temporary account should prevent further account creations
 ResolvedDreamy_JazzT368949 [Epic] Implement global autoblocks from global user blocks
 DeclinedNoneT19929 CentralAuth account locks should trigger global autoblocks
 DuplicateNoneT340275 Allow GlobalBlocking to block temporary accounts
 ResolvedFeatureDreamy_JazzT17294 Allow globally blocking of accounts
 ResolvedDreamy_JazzT358777 Rename messages with the '-new' suffix to remove this suffix
 ResolvedDreamy_JazzT358776 Remove old versions of GlobalBlocking i18n messages
 ResolvedDreamy_JazzT358773 Remove the global accounts block configuration flag
 ResolvedDreamy_JazzT356924 Deploy global account blocks to WMF wikis
 ResolvedDreamy_JazzT356935 The 'globalblocks' API should support listing global blocks for accounts
 ResolvedDreamy_JazzT356936 Update GlobalBlocking services to support global block on accounts
 ResolvedDreamy_JazzT358150 Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts
 ResolvedDreamy_JazzT358157 Update the GlobalBlockManager service to support global blocks on accounts
 ResolvedDreamy_JazzT358155 Update GlobalBlockLookup service to support global blocks on accounts
 ResolvedDreamy_JazzT356876 Add a column to store central ID in globalblocks and global_block_whitelist tables
 ResolvedMarosteguiT356987 Add gb_target_central_id to the globalblocks table on the centralauth DB
 ResolvedMarosteguiT356988 Add gbw_target_central_id to global_block_whitelist table on WMF wikis
 ResolvedDreamy_JazzT356922 Deprecate unnecessary GlobalBlocking hooks
 ResolvedDreamy_JazzT359091 Create GlobalBlockLocalStatusManager service
 ResolvedDreamy_JazzT358865 Use non-legacy log parameters for log entries for global blocking and unblocking
 ResolvedDreamy_JazzT358725 Update the GlobalBlockingLinkBuilder service for global account blocks
 ResolvedDreamy_JazzT356923 Create a configuration value to control whether global account blocks are enabled
 ResolvedDreamy_JazzT356925 Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts
 ResolvedDreamy_JazzT357385 Refactor the GlobalBlocking utility class into services
 ResolvedDreamy_JazzT357399 Create GlobalBlockingConnectionProvider
 ResolvedDreamy_JazzT357443 Create GlobalBlockingBlockPurger service
 ResolvedDreamy_JazzT357506 Create GlobalBlockLocalStatusLookup service
 ResolvedDreamy_JazzT357675 Create GlobalBlockLookup service
 ResolvedDreamy_JazzT357925 Create the GlobalBlockManager service

Event Timeline

Dreamy_Jazz created this task.Feb 7 2024, 10:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2024, 10:28 PM
Dreamy_Jazz added a parent task: T356924: Deploy global account blocks to WMF wikis.Feb 7 2024, 10:29 PM
Dreamy_Jazz added a subtask: T356936: Update GlobalBlocking services to support global block on accounts.Feb 7 2024, 10:34 PM
Dreamy_Jazz updated the task description. (Show Details)Mar 4 2024, 3:40 PM
Dreamy_Jazz closed subtask T356936: Update GlobalBlocking services to support global block on accounts as Resolved.Mar 27 2024, 9:40 AM
Dreamy_Jazz claimed this task.May 28 2024, 6:04 PM
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)).
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.
Dreamy_Jazz moved this task from In Progress to Ready on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 28 2024, 6:20 PM
Dreamy_Jazz moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 30 2024, 3:16 PM
Dreamy_Jazz moved this task from In Progress to Ready on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.
Dreamy_Jazz moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 30 2024, 5:11 PM
Dreamy_Jazz moved this task from Sprint Shekere (13th May - 24th May) to Sprint Melodica (Jun 3 - Jun 14) on the Trust and Safety Product Sprint board.Jun 3 2024, 10:08 AM
Dreamy_Jazz edited projects, added: Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)); removed: Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)).
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 7 2024, 10:08 PM
gerritbot added a comment.Jun 7 2024, 11:49 PM

Change #1040292 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Test ApiQueryGlobalBlocks

https://gerrit.wikimedia.org/r/1040292

gerritbot added a project: Patch-For-Review.Jun 7 2024, 11:49 PM
gerritbot added a comment.Jun 8 2024, 12:05 AM

Change #1040297 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Update ApiQueryGlobalBlocks to support global account blocks

https://gerrit.wikimedia.org/r/1040297

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 8 2024, 12:13 AM

Marking this as needs review to allow the first change to be reviewed. The second isn't ready.

gerritbot added a comment.Jun 12 2024, 12:05 PM

Change #1040292 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Test ApiQueryGlobalBlocks

https://gerrit.wikimedia.org/r/1040292

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.10; 2024-06-18).Jun 12 2024, 2:00 PM
Tchanders moved this task from Needs Review to In Progress on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 17 2024, 9:17 AM
Tchanders subscribed.

Moving back, now the tests are merged

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 24 2024, 5:29 PM
Dreamy_Jazz moved this task from Sprint Melodica (Jun 3 - Jun 14) to Sprint Cajon (Jun 24 - July 5) on the Trust and Safety Product Sprint board.Jun 25 2024, 10:42 AM
Dreamy_Jazz edited projects, added: Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)); removed: Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)).
Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.
gerritbot added a comment.Jul 5 2024, 11:45 AM

Change #1040297 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update ApiQueryGlobalBlocks to support global account blocks

https://gerrit.wikimedia.org/r/1040297

ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09); removed: MW-1.43-notes (1.43.0-wmf.10; 2024-06-18).Jul 5 2024, 12:00 PM
Tchanders moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 5 2024, 1:03 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 9 2024, 8:34 PM
Tchanders edited projects, added: Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)); removed: Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)).Jul 14 2024, 2:09 PM
Tchanders moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 17 2024, 3:27 AM
Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning and displaying as expected.

image.png (630×903 px, 73 KB)

image.png (1,027×732 px, 66 KB)

image.png (1,009×728 px, 64 KB)

image.png (1,029×710 px, 56 KB)

image.png (812×795 px, 51 KB)

image.png (869×843 px, 57 KB)

image.png (1,256×569 px, 56 KB)

image.png (971×327 px, 21 KB)

image.png (989×639 px, 46 KB)

image.png (988×801 px, 57 KB)

image.png (794×868 px, 49 KB)

Tchanders closed this task as Resolved.Jul 17 2024, 4:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits