Create GlobalBlockLocalStatusManager service
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The SpecialGlobalBlockStatus class directly manages the local status of blocks in the ::onSubmit method. To make it easier to modify the code that manages the DB table for global blocking of accounts, moving this to a service will make things easier to deal with. Furthermore, it will be easier to test the relevant code.

Acceptance criteria

Create the GlobalBlockLocalStatusManager service

Details

	Subject	Repo	Branch	Lines +/-
	Create GlobalBlockLocalStatusManager service	mediawiki/extensions/GlobalBlocking	master	+312 -0
	Allow GlobalBlockLocalStatusLookup service to accept a wiki ID	mediawiki/extensions/GlobalBlocking	master	+9 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 Update features for IP Masking
Open	None	T355286 [Epic] Globally blocking a temporary account should prevent further account creations
Open	None	T19929 CentralAuth account locks should trigger global autoblocks
Duplicate	None	T340275 Allow GlobalBlocking to block temporary accounts
Open	Skizzerz	T17294 Allow blocking of global accounts
Open	None	T358777 Rename messages with the '-new' suffix to remove this suffix
Open	None	T358776 Remove old versions of GlobalBlocking i18n messages
Open	None	T358773 Remove the global accounts block configuration flag
Open	None	T356924 Deploy global account blocks to WMF wikis
Open	None	T356926 Add support to block global accounts using the globalblock API
Open	None	T356929 Allow SpecialRemoveGlobalBlock to remove a global block on an account
Resolved	Dreamy_Jazz	T356931 Support modifying the status of global blocks on accounts using Special:GlobalBlockStatus
Open	None	T356932 Allow Special:GlobalBlockList to show global blocks for accounts
Open	Dreamy_Jazz	T356934 Allow a user to perform global blocks on accounts using Special:GlobalBlock
Open	None	T356935 The 'globalblocks' API should support listing global blocks for accounts
Resolved	Dreamy_Jazz	T356936 Update GlobalBlocking services to support global block on accounts
Resolved	Dreamy_Jazz	T358150 Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts
Resolved	Dreamy_Jazz	T358157 Update the GlobalBlockManager service to support global blocks on accounts
Resolved	Dreamy_Jazz	T358155 Update GlobalBlockLookup service to support global blocks on accounts
Resolved	Dreamy_Jazz	T359091 Create GlobalBlockLocalStatusManager service
Resolved	Dreamy_Jazz	T357385 Refactor the GlobalBlocking utility class into services
Resolved	Dreamy_Jazz	T357399 Create GlobalBlockingConnectionProvider
Resolved	Dreamy_Jazz	T357443 Create GlobalBlockingBlockPurger service
Resolved	Dreamy_Jazz	T357506 Create GlobalBlockLocalStatusLookup service
Resolved	Dreamy_Jazz	T357675 Create GlobalBlockLookup service
Resolved	Dreamy_Jazz	T357925 Create the GlobalBlockManager service

Event Timeline

Dreamy_Jazz created this task.Mar 4 2024, 5:56 PM

Dreamy_Jazz added a subtask: T357385: Refactor the GlobalBlocking utility class into services.

Change 1008520 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Create GlobalBlockLocalStatusManager service

https://gerrit.wikimedia.org/r/1008520

gerritbot added a project: Patch-For-Review.Mar 4 2024, 5:58 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Mar 4 2024, 11:45 PM

Dreamy_Jazz set the point value for this task to 2.

Change 1009782 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Allow GlobalBlockLocalStatusLookup service to accept a wiki ID

https://gerrit.wikimedia.org/r/1009782

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)); removed Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)).Mar 11 2024, 2:48 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.

Change 1009782 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Allow GlobalBlockLocalStatusLookup service to accept a wiki ID

https://gerrit.wikimedia.org/r/1009782

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Mar 19 2024, 1:00 PM

Dreamy_Jazz updated the task description. (Show Details)Mar 19 2024, 1:20 PM

Change 1008520 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockLocalStatusManager service

https://gerrit.wikimedia.org/r/1008520

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2024, 7:30 AM

Tchanders moved this task from Needs review to Done on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 20 2024, 10:49 AM

Dreamy_Jazz closed this task as Resolved.Mar 20 2024, 11:33 AM

Create GlobalBlockLocalStatusManager serviceClosed, ResolvedPublic2 Estimated Story PointsActions