Page MenuHomePhabricator
Create Task
Maniphest T358773

Remove the global accounts block configuration flag
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Once global blocks have been enabled on all WMF wikis and are stable, we should remove the configuration added in T356923: Create a configuration value to control whether global account blocks are enabled as this is intended as a temporary migration configuration value and not something that would be supported long-term.

Acceptance criteria
  • Remove the wgGlobalBlockingAllowGlobalAccountBlocks config once all WMF wikis are stably performing global account blocks

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove wgGlobalBlockingAllowGlobalAccountBlocksmediawiki/extensions/GlobalBlockingmaster+56 -218
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 ResolvedNiharikaT324492 Temporary accounts - MVP
 ResolvedMadalinaT326816 [Epic] Update features for temporary accounts
 OpenNoneT355286 [Epic] Globally blocking a temporary account should prevent further account creations
 ResolvedDreamy_JazzT368949 [Epic] Implement global autoblocks from global user blocks
 DeclinedNoneT19929 CentralAuth account locks should trigger global autoblocks
 DuplicateNoneT340275 Allow GlobalBlocking to block temporary accounts
 ResolvedFeatureDreamy_JazzT17294 Allow globally blocking of accounts
 ResolvedDreamy_JazzT358777 Rename messages with the '-new' suffix to remove this suffix
 ResolvedDreamy_JazzT358776 Remove old versions of GlobalBlocking i18n messages
 ResolvedDreamy_JazzT358773 Remove the global accounts block configuration flag
 ResolvedDreamy_JazzT356924 Deploy global account blocks to WMF wikis
 ResolvedDreamy_JazzT356926 Add support to block global accounts using the globalblock API
 ResolvedDreamy_JazzT356929 Allow SpecialRemoveGlobalBlock to remove a global block on an account
 ResolvedDreamy_JazzT356931 Support modifying the status of global blocks on accounts using Special:GlobalBlockStatus
 ResolvedDreamy_JazzT356932 Allow Special:GlobalBlockList to show global blocks for accounts
 ResolvedDreamy_JazzT359584 Provide action links on Special:Log for global block entries
 ResolvedDreamy_JazzT356934 Allow a user to perform global blocks on accounts using Special:GlobalBlock
 ResolvedBUG REPORTDreamy_JazzT366352 The "Locally block anonymous users only" checkbox is not properly disabled when it is made visible
 ResolvedDreamy_JazzT356935 The 'globalblocks' API should support listing global blocks for accounts
 ResolvedTchandersT360516 Periodically remove orphaned global_block_whitelist entries
 ResolvedDreamy_JazzT360621 Test and make improvements to the fixGlobalBlockWhitelist.php script
 ResolvedDreamy_JazzT366386 Update GlobalBlockingHooks to support global account blocks
 ResolvedDreamy_JazzT356936 Update GlobalBlocking services to support global block on accounts
 ResolvedDreamy_JazzT358150 Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts
 ResolvedDreamy_JazzT358157 Update the GlobalBlockManager service to support global blocks on accounts
 ResolvedDreamy_JazzT358155 Update GlobalBlockLookup service to support global blocks on accounts
 ResolvedDreamy_JazzT356876 Add a column to store central ID in globalblocks and global_block_whitelist tables
 ResolvedMarosteguiT356987 Add gb_target_central_id to the globalblocks table on the centralauth DB
 ResolvedMarosteguiT356988 Add gbw_target_central_id to global_block_whitelist table on WMF wikis
 ResolvedDreamy_JazzT356922 Deprecate unnecessary GlobalBlocking hooks
 ResolvedDreamy_JazzT359091 Create GlobalBlockLocalStatusManager service
 ResolvedDreamy_JazzT358865 Use non-legacy log parameters for log entries for global blocking and unblocking
 ResolvedDreamy_JazzT358725 Update the GlobalBlockingLinkBuilder service for global account blocks
 ResolvedDreamy_JazzT356923 Create a configuration value to control whether global account blocks are enabled
 ResolvedDreamy_JazzT356925 Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts
 ResolvedDreamy_JazzT357385 Refactor the GlobalBlocking utility class into services
 ResolvedDreamy_JazzT357399 Create GlobalBlockingConnectionProvider
 ResolvedDreamy_JazzT357443 Create GlobalBlockingBlockPurger service
 ResolvedDreamy_JazzT357506 Create GlobalBlockLocalStatusLookup service
 ResolvedDreamy_JazzT357675 Create GlobalBlockLookup service
 ResolvedDreamy_JazzT357925 Create the GlobalBlockManager service
 ResolvedDreamy_JazzT366921 GlobalBlockingHooks::onSpecialPasswordResetOnSubmit is never called
 ResolvedUrbanecmT367647 Review global blocks from a Steward perspective
 ResolvedBUG REPORTDreamy_JazzT369799 Special:GlobalBlockList shows "IP address" as label for target field when global account blocks are enabled

Event Timeline

Dreamy_Jazz created this task.Feb 29 2024, 3:42 PM
Dreamy_Jazz edited parent tasks, added: T17294: Allow globally blocking of accounts; removed: T356924: Deploy global account blocks to WMF wikis.
Dreamy_Jazz added a subtask: T356924: Deploy global account blocks to WMF wikis.
Dreamy_Jazz mentioned this in T358776: Remove old versions of GlobalBlocking i18n messages.Feb 29 2024, 3:48 PM
Dreamy_Jazz removed a subtask: T358776: Remove old versions of GlobalBlocking i18n messages.
Dreamy_Jazz added a parent task: T358776: Remove old versions of GlobalBlocking i18n messages.
Dreamy_Jazz removed a parent task: T17294: Allow globally blocking of accounts.Feb 29 2024, 3:54 PM
Dreamy_Jazz claimed this task.Jul 18 2024, 6:07 PM
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)).
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
gerritbot added a comment.Jul 18 2024, 6:50 PM

Change #1055276 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Remove wgGlobalBlockingAllowGlobalAccountBlocks

https://gerrit.wikimedia.org/r/1055276

gerritbot added a project: Patch-For-Review.Jul 18 2024, 6:50 PM
Dreamy_Jazz closed subtask T356924: Deploy global account blocks to WMF wikis as Resolved.Jul 18 2024, 7:43 PM
Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 23 2024, 9:18 AM
gerritbot added a comment.Jul 24 2024, 11:58 AM

Change #1055276 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Remove wgGlobalBlockingAllowGlobalAccountBlocks

https://gerrit.wikimedia.org/r/1055276

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 24 2024, 12:00 PM
Dreamy_Jazz closed this task as Resolved.Jul 24 2024, 12:01 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.

I think we can skip QA for this change, as there will be no difference visible for a local wiki install, on beta wikis, or production.

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2024, 12:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits