Page MenuHomePhabricator

Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts
Closed, ResolvedPublic2 Estimated Story Points

Description

i18n messages in the GlobalBlocking extension need to be updated to indicate that global blocks on accounts can occur. However, these messages should not be changed if the wiki does not yet support globally blocking accounts and the changes to the message imply that you can globally block an account.

Therefore, in some cases two versions of the i18n messages are needed and in other cases the modifications can be made vague enough to not imply that global blocks on accounts are enabled. For messages which are duplicated, the correct message will be chosen depending on the value of the configuration added in T356923: Create a configuration value to control whether global account blocks are enabled.

Creating these alternative messages in a separate patch allows more time for translations to occur and keeps the overall diff size of patches smaller.

The messages with the -new suffix will be renamed in T358777: Rename messages with the '-new' suffix to remove this suffix, so this suffix is intended to be temporary.

Acceptance criteria
  • Where necessary, two versions of a i18n message exist where one is the original and one is used when global blocks on accounts is enabled
  • If updates are needed but the update does not otherwise cause confusion, the original message should be updated without making an alternative message (for example globalblocking-desc).

QA Results - Local

Related Objects

StatusSubtypeAssignedTask
In Progress Niharika
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenSkizzerz
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedDreamy_Jazz
OpenNone
OpenDreamy_Jazz
OpenNone
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz

Event Timeline

Dreamy_Jazz renamed this task from Duplicate necessary GlobalBlocking messages to allow staged deployment of blocking accounts globally to Duplicate necessary GlobalBlocking messages to allow staged deployment of blocking accounts.Feb 21 2024, 11:01 PM

Change 1005793 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Add and update i18n messages for global blocks on accounts

https://gerrit.wikimedia.org/r/1005793

Dreamy_Jazz renamed this task from Duplicate necessary GlobalBlocking messages to allow staged deployment of blocking accounts to Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts.Feb 22 2024, 4:05 PM
Dreamy_Jazz updated the task description. (Show Details)

Change 1005793 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Add and update i18n messages for global blocks on accounts

https://gerrit.wikimedia.org/r/1005793

For QA I would suggest checking that nothing has broken due to this patch and that some of the messages used by the GlobalBlocking extension have been updated. If you would like a list of the expected changes for messages used by the extension, I can make one.

The following messages should have changed following this patch:

  1. The description shown in Special:Version
  2. When blocking a user using Special:GlobalBlock, the confirmation page should not reference IP addresses in the sentence that starts with You have removed the global block
  3. When using Special:GlobalBlockWhitelist the confirmation message should not reference IP addresses
  4. The log extracts shown on Special:GlobalBlock and Special:Contributions for a IP address which is globally blocked should mention user instead of IP addresses.
  5. The text on Special:Block for an IP address which is globally blocked should have the Other blocks section list the global block without mentioning The IP address... and instead saying The user....
  6. The globalblock-exempt right should say that the user is exempt from global blocks on IP addresses (i.e. Bypass global IP blocks).

Testing the messages not mentioned above will be done as part of other tickets.

@Dreamy_Jazz I received the correct wording for everything except Special:Contributions. I did not get "user" as seen in the screenshot. Please let me know if I missed a step or something, thanks!

UPDATE March 7: For Special:Contributions, it used to say "This IP address is currently globally blocked. The global block log entry is provided below for reference:", now it says "This user is currently globally blocked. The global block log entry is provided below for reference:" which makes the screenshot correct. This will now be moved to Done. Thanks for all your work and steps!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (a5f1c2c) 22:34, 5 March 2024; GlobalBlocking– (a02fc97) 07:27, 5 March 2024
OS: macOS Sonoma 14.2.1
Browser: Chrome 122
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
Special:Version
Special:GlobalBlock
Special:GlobalBlockWhiteList
Special:Block
Special:Contributions
Special:ListGroupRights

✅AC1: https://phabricator.wikimedia.org/T356925

Special:VersionSpecial:GlobalBlockSpecial:GlobalBlockWhitelistSpecial:ContributionsSpecial:BlockGlobalblock-exempt
2024-03-05_14-42-42.png (525×3 px, 119 KB)
2024-03-05_14-42-42.png (525×3 px, 115 KB)
2024-03-06_16-03-44.png (482×3 px, 137 KB)
2024-03-06_16-52-17.png (558×1 px, 141 KB)
2024-03-06_16-48-49.png (1×1 px, 210 KB)
2024-03-06_16-58-06.png (565×1 px, 162 KB)
Dreamy_Jazz closed this task as Resolved.EditedMar 7 2024, 5:27 PM

Thanks for the QA and bearing with my partially unclear suggested steps in this task.