Page MenuHomePhabricator
Create Task
Maniphest T358155

Update GlobalBlockLookup service to support global blocks on accounts
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Dreamy_Jazz
Authored By
Dreamy_Jazz
Feb 21 2024, 10:31 PM
Tags
Referenced Files
F42612786: image.png
Mar 16 2024, 12:48 AM
F42614156: Step 7 Single IP Address is blocked.jpeg
Mar 16 2024, 12:48 AM
F42614149: Step 6 IP Address Range Blocking.jpeg
Mar 16 2024, 12:48 AM
F42614145: Step 5 Special Contributions is blocked for Username.jpeg
Mar 16 2024, 12:48 AM
F42612766: image.png
Mar 16 2024, 12:48 AM
F42614135: Step 4 Username is blocked from Undeleting a Page.jpeg
Mar 16 2024, 12:48 AM
F42614123: Step 4 Username is blocked from Editing its own UserTalk page.jpeg
Mar 16 2024, 12:48 AM
F42614117: Step 4 Username is blocked from Editing its own User page.jpeg
Mar 16 2024, 12:48 AM
View All 14 Files
Subscribers
Aklapper
Djackson-ctr
Dreamy_Jazz

Description

The GlobalBlockLookup service needs to be updated to support looking up global blocks on accounts.

This support includes (but is not limited to):

  • Allowing the service to lookup blocks based on a registered user target
  • Making global blocks on accounts the highest priority over IP address or IP address range blocks which apply to the IP address that the user is using
  • Updating the fields that are read for a lookup

Details

SubjectRepoBranchLines +/-
Update GlobalBlockLookup for global account blocksmediawiki/extensions/GlobalBlockingmaster+440 -175
Give result of ::checkIpsForBlock directly to ::getAppliedBlockmediawiki/extensions/GlobalBlockingmaster+40 -41
Remove error parameter from GlobalBlock constructormediawiki/extensions/GlobalBlockingmaster+30 -17
Make LIKE condition configurable in GlobalBlockLookupmediawiki/extensions/GlobalBlockingmaster+89 -5
Make permission checks pass for FormSpecialPageTestCase testsmediawiki/coremaster+11 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 In Progress• NiharikaT324492 Temporary accounts - MVP
 OpenNoneT326816 Update features for IP Masking
 OpenNoneT355286 [Epic] Globally blocking a temporary account should prevent further account creations
 OpenNoneT19929 CentralAuth account locks should trigger global autoblocks
 DuplicateNoneT340275 Allow GlobalBlocking to block temporary accounts
 OpenSkizzerzT17294 Allow blocking of global accounts
 OpenDreamy_JazzT356990 GlobalBlocking extension has poor test coverage
 OpenNoneT358777 Rename messages with the '-new' suffix to remove this suffix
 OpenNoneT358776 Remove old versions of GlobalBlocking i18n messages
 OpenNoneT358773 Remove the global accounts block configuration flag
 OpenNoneT356924 Deploy global account blocks to WMF wikis
 OpenNoneT356926 Add support to block global accounts using the globalblock API
 OpenNoneT356929 Allow SpecialRemoveGlobalBlock to remove a global block on an account
 ResolvedDreamy_JazzT356931 Support modifying the status of global blocks on accounts using Special:GlobalBlockStatus
 OpenNoneT356932 Allow Special:GlobalBlockList to show global blocks for accounts
 OpenDreamy_JazzT356934 Allow a user to perform global blocks on accounts using Special:GlobalBlock
 OpenNoneT356935 The 'globalblocks' API should support listing global blocks for accounts
 ResolvedDreamy_JazzT356936 Update GlobalBlocking services to support global block on accounts
 ResolvedDreamy_JazzT358150 Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts
 ResolvedDreamy_JazzT358157 Update the GlobalBlockManager service to support global blocks on accounts
 ResolvedDreamy_JazzT358155 Update GlobalBlockLookup service to support global blocks on accounts
 ResolvedDreamy_JazzT356876 Add a column to store central ID in globalblocks and global_block_whitelist tables
 Resolved• MarosteguiT356987 Add gb_target_central_id to the globalblocks table on the centralauth DB
 Resolved• MarosteguiT356988 Add gbw_target_central_id to global_block_whitelist table on WMF wikis
 ResolvedDreamy_JazzT356922 Deprecate unnecessary GlobalBlocking hooks
 ResolvedDreamy_JazzT359091 Create GlobalBlockLocalStatusManager service
 ResolvedDreamy_JazzT358725 Update the GlobalBlockingLinkBuilder service for global account blocks
 ResolvedDreamy_JazzT356923 Create a configuration value to control whether global account blocks are enabled
 ResolvedDreamy_JazzT356925 Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts
 OpenNoneT350075 Migrate raw SQL building in conditions to expression builder in WMF-deployed extensions
 ResolvedDreamy_JazzT350972 Use expression builder instead of raw SQL in GlobalBlocking
 ResolvedDreamy_JazzT357385 Refactor the GlobalBlocking utility class into services
 ResolvedDreamy_JazzT357399 Create GlobalBlockingConnectionProvider
 ResolvedDreamy_JazzT357443 Create GlobalBlockingBlockPurger service
 ResolvedDreamy_JazzT357506 Create GlobalBlockLocalStatusLookup service
 ResolvedDreamy_JazzT357675 Create GlobalBlockLookup service
 ResolvedDreamy_JazzT357925 Create the GlobalBlockManager service

Event Timeline

Dreamy_Jazz created this task.Feb 21 2024, 10:31 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz added a subtask: T356923: Create a configuration value to control whether global account blocks are enabled.Feb 21 2024, 10:42 PM
Dreamy_Jazz added a subtask: T356876: Add a column to store central ID in globalblocks and global_block_whitelist tables.Feb 21 2024, 10:58 PM
Dreamy_Jazz added a subtask: T357675: Create GlobalBlockLookup service.Feb 22 2024, 4:15 PM
gerritbot added a comment.Feb 22 2024, 6:29 PM

Change 1005621 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [Very WIP] Update GlobalBlockLookup for global account blocks

https://gerrit.wikimedia.org/r/1005621

gerritbot added a project: Patch-For-Review.Feb 22 2024, 6:29 PM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 22 2024, 8:09 PM
Dreamy_Jazz set the point value for this task to 3.Feb 23 2024, 3:07 PM
Dreamy_Jazz closed subtask T356923: Create a configuration value to control whether global account blocks are enabled as Resolved.Feb 28 2024, 2:02 PM
Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 28 2024, 8:11 PM
Dreamy_Jazz moved this task from Needs review to In Progress on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 28 2024, 9:54 PM
Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 29 2024, 10:19 PM
Dreamy_Jazz added a subtask: T356922: Deprecate unnecessary GlobalBlocking hooks.Feb 29 2024, 10:57 PM
Dreamy_Jazz added a parent task: T358157: Update the GlobalBlockManager service to support global blocks on accounts.
Dreamy_Jazz added a parent task: T358150: Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts.
Dreamy_Jazz mentioned this in T357675: Create GlobalBlockLookup service.Mar 4 2024, 9:08 AM
gerritbot added a comment.Mar 5 2024, 1:57 PM

Change 1008862 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Make permission checks pass for FormSpecialPageTestCase tests

https://gerrit.wikimedia.org/r/1008862

gerritbot added a comment.Mar 5 2024, 3:06 PM

Change 1008862 merged by jenkins-bot:

[mediawiki/core@master] Make permission checks pass for FormSpecialPageTestCase tests

https://gerrit.wikimedia.org/r/1008862

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 5 2024, 6:01 PM
Dreamy_Jazz closed subtask T357675: Create GlobalBlockLookup service as Resolved.Mar 8 2024, 2:09 PM
gerritbot added a comment.Mar 8 2024, 2:53 PM

Change 1009767 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Make LIKE condition configurable in GlobalBlockLookup

https://gerrit.wikimedia.org/r/1009767

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)); removed Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)).Mar 11 2024, 2:46 PM
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.
gerritbot added a comment.Mar 11 2024, 3:23 PM

Change 1009767 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Make LIKE condition configurable in GlobalBlockLookup

https://gerrit.wikimedia.org/r/1009767

gerritbot added a comment.Mar 12 2024, 1:57 PM

Change 1010521 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Remove error parameter from GlobalBlock constructor

https://gerrit.wikimedia.org/r/1010521

gerritbot added a comment.Mar 12 2024, 2:38 PM

Change 1010531 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Give result of ::checkIpsForBlock directly to ::getAppliedBlock

https://gerrit.wikimedia.org/r/1010531

gerritbot added a comment.Mar 12 2024, 2:57 PM

Change 1010521 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Remove error parameter from GlobalBlock constructor

https://gerrit.wikimedia.org/r/1010521

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.23; 2024-03-19); removed MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 12 2024, 3:00 PM
gerritbot added a comment.Mar 12 2024, 3:14 PM

Change 1010531 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Give result of ::checkIpsForBlock directly to ::getAppliedBlock

https://gerrit.wikimedia.org/r/1010531

gerritbot added a comment.Mar 13 2024, 9:23 AM

Change 1005621 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockLookup for global account blocks

https://gerrit.wikimedia.org/r/1005621

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2024, 9:30 AM
Dreamy_Jazz moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 13 2024, 12:28 PM
Dreamy_Jazz added a comment.EditedMar 13 2024, 1:16 PM

For QA I suggest doing the following:

  1. Checking out the change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalBlocking/+/1009780 for the GlobalBlocking repository - This is done so that you can use Special:GlobalBlock to create global blocks on accounts
  2. Perform a couple of testing blocks where the target of the blocks are accounts - Ignore if the logs created by performing these blocks as they will be slightly broken due to changes were made to the log format in patches which https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalBlocking/+/1009780 depend on.
  3. Checkout the master branch (so your testing is limited to just the changes which have been merged)
  4. Try to make an edit using an account that was globally blocked and verify that you cannot do this.
  5. Load Special:Contributions for a globally blocked account and verify that it is marked as blocked
  6. Make a block on an IP address you are currently using to edit the wiki and then IP address range that includes this IP. For these blocks check the checkbox with the label Globally block anonymous users only.
  7. Test that when editing while logged out you are blocked from editing due to the block on the single IP address
  8. Locally disable the single IP address block (using Special:GlobalBlockStatus)
  9. Repeat step 7, but instead verify that the IP address range block prevents you editing
  10. Re-enable the single IP address block and modify it to target registered users too (i.e. Globally block anonymous users only should not be checked)
  11. Using a globally blocked account, try to make an edit and verify that the block shown is the block on the account
  12. Using an account which is not blocked, try to make an edit and verify that the block shown is the single IP address block
  13. Using an account with the globalblock-exempt right (you can grant this right to sysops using $wgGroupPermissions['sysop']['globalblock-exempt'] = true;), try to make an edit and verify that the edit was successfully made.
Djackson-ctr subscribed.Mar 16 2024, 12:48 AM

Per the ticket Description, I have verified the new code has been implemented and is functioning and displaying as expected... Good Work @Dreamy_Jazz!!!

Blocking an Account using the Username

Step 2 Blocking an Account using the Username.jpeg (722×1 px, 168 KB)

Edit page is blocked for Username

Step 4 Edit page is blocked for Username.jpeg (918×1 px, 150 KB)

Edit Source page is blocked for Username

Step 4 Edit Source page is blocked for Username.jpeg (783×1 px, 150 KB)

EmailUser Page is blocked for Username

Step 4 EmailUser Page is blocked for Username.jpeg (779×1 px, 184 KB)

Move Page is blocked for Username

Step 4 Move Page is blocked for Username.jpeg (606×1 px, 185 KB)

Username is blocked from Deleting a page

Step 4 Username is blocked from Deleting a page.jpeg (563×1 px, 139 KB)

Username is blocked from Editing its own User page

Step 4 Username is blocked from Editing its own User page.jpeg (415×1 px, 89 KB)

Username is blocked from Editing its own UserTalk page

Step 4 Username is blocked from Editing its own UserTalk page.jpeg (771×1 px, 152 KB)

Username is blocked from Undeleting a Page

Step 4 Username is blocked from Undeleting a Page.jpeg (381×1 px, 82 KB)

Username is blocked from Upload File page

image.png (592×1 px, 80 KB)

Special Contributions is blocked for Username

Step 5 Special Contributions is blocked for Username.jpeg (471×1 px, 117 KB)

IP Address Range Blocking

Step 6 IP Address Range Blocking.jpeg (755×1 px, 138 KB)

Single IP Address is blocked

Step 7 Single IP Address is blocked.jpeg (635×1 px, 166 KB)

Error Handling Validation-- Error Message when trying to block a Username that is already Blocked

image.png (884×1 px, 136 KB)

Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 16 2024, 12:53 AM
Dreamy_Jazz closed this task as Resolved.Mar 19 2024, 11:25 AM
Dreamy_Jazz closed subtask T359091: Create GlobalBlockLocalStatusManager service as Resolved.Mar 20 2024, 11:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL