Page MenuHomePhabricator
Create Task
Maniphest T163607

The links to the IPs of the "Global IP block log" go to the user page and not the contributions special page
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
Dreamy_Jazz
Authored By
AlvaroMolina
Apr 21 2017, 9:33 PM
Tags
Referenced Files
F42657199: image.png
Mar 16 2024, 12:55 AM
F42657100: image.png
Mar 16 2024, 12:55 AM
F42657313: image.png
Mar 16 2024, 12:55 AM
F42657248: image.png
Mar 16 2024, 12:55 AM
F42655522: GlobalBlockLog with IP Address Range link displaying UserTalk url.jpg
Mar 16 2024, 12:55 AM
F42655319: GlobalBlockLog with IP Address Range link displaying Contributions url.jpg
Mar 16 2024, 12:55 AM
F42655140: GlobalBlockLog with Talk link displaying UserTalk url.jpg
Mar 16 2024, 12:55 AM
F42655041: GlobalBlockLog with IP Address link displaying Contributions url.jpg
Mar 16 2024, 12:55 AM
View All 9 Files
Subscribers
Aklapper
AlvaroMolina
Djackson-ctr
Dreamy_Jazz
MarcoAurelio

Description

Hi,

I open this task to report a problem that currently exists and I do not know if it has been noticed or tried to solve in the past. This is specifically the "Global IP block log" in which all global locks are registered to the IP addresses.

The problem is that the IP addresses in the registry have a link that instead of pointing to the contributions of the IP address, points to the user page of the same:

* 21:07, 21 April 2017 Example (talk | contribs) globally blocked [[User:177.142.80.159]] (expiration 21:07, 21 October 2017) (Open proxy)

Being that it should show:

* 21:07, 21 April 2017 Example (talk | contribs) globally blocked [[Special:Contributions/177.142.80.159]] (expiration 21:07, 21 October 2017) (Open proxy)

I do not know if you can alter that configuration in the code of the CentralAuth or GlobalBlocking extension. I leave it to criterion. Thanks.

Details

SubjectRepoBranchLines +/-
Use ManualLogEntry to create gunblock entriesmediawiki/extensions/GlobalBlockingmaster+63 -22
Use ManualLogEntry to create gblock and modify entriesmediawiki/extensions/GlobalBlockingmaster+302 -73
Customize query in gerrit

Related Objects

Event Timeline

AlvaroMolina created this task.Apr 21 2017, 9:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2017, 9:33 PM
Glaisher removed a project: MediaWiki-extensions-CentralAuth.Jun 1 2017, 11:39 AM
MarcoAurelio subscribed.Jul 23 2017, 11:22 PM

Well, it does not really matter much since even if we point those to Special:Contributions we at most would see the contributions made by the IP on Meta. I think there is/was a JS hack at Meta that made those links point to tool:guc but I don't remember now. Hopefully one day T28957 will be a reality and we could made those links point to the relevant and correct pages.

Dreamy_Jazz claimed this task.Mar 1 2024, 1:26 PM
Dreamy_Jazz subscribed.

Will be done as part of the patch for T358157, as that includes converting the logs to no longer used the legacy format and also allows the use of ::makeUserLink which will link Special:Contributions for IP addresses.

gerritbot added a comment.Mar 1 2024, 1:39 PM

Change 1005816 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Update GlobalBlockManager for global account blocks

https://gerrit.wikimedia.org/r/1005816

gerritbot added a project: Patch-For-Review.Mar 1 2024, 1:39 PM
gerritbot added a comment.Mar 1 2024, 2:13 PM

Change 1007909 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Use ManualLogEntry to create gblock, modify, and gunblock entries

https://gerrit.wikimedia.org/r/1007909

gerritbot added a comment.Mar 8 2024, 4:42 PM

Change 1009774 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Use ManualLogEntry to create gunblock entries

https://gerrit.wikimedia.org/r/1009774

gerritbot added a comment.Mar 14 2024, 6:46 AM

Change 1007909 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Use ManualLogEntry to create gblock and modify entries

https://gerrit.wikimedia.org/r/1007909

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 14 2024, 7:00 AM
gerritbot added a comment.Mar 15 2024, 10:02 AM

Change 1009774 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Use ManualLogEntry to create gunblock entries

https://gerrit.wikimedia.org/r/1009774

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)).Mar 15 2024, 10:32 AM
Dreamy_Jazz set the point value for this task to 1.
Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.
Dreamy_Jazz added a comment.Mar 15 2024, 1:25 PM

Suggested QA steps (can be performed on beta wikis):

  1. Open Special:Log for a wiki where global blocks have been performed (for beta wikis you definitely use https://en.wikipedia.beta.wmflabs.org as all types of entries are in the logs for this wiki)
  2. Filter for entries under the category Global block log category
  3. Verify that all the logs shown in the list have the target of the block (i.e. the IP address) as a user link. This means that the target IP or IP range should be shown with the link going to Special:Contributions for that IP or IP range. Furthermore, a link to the talk page should be shown after the link in parentheses. An example is below:

image.png (56×234 px, 5 KB)

Testing other changes to the log entries made in these patches will be done in T358865: Use non-legacy log parameters for log entries for global blocking and unblocking once the final patch for that task is merged.

Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 16 2024, 12:55 AM
Djackson-ctr subscribed.

Per the ticket Description, I have verified the new code has been implemented and is functioning and displaying as expected...
Great Work @Dreamy_Jazz and thank you for the steps.

GlobalBlockLog with IP Address link displaying Contributions url.jpg (916×1 px, 194 KB)

GlobalBlockLog with Talk link displaying UserTalk url.jpg (918×1 px, 203 KB)

GlobalBlockLog with IP Address Range link displaying Contributions url.jpg (918×1 px, 235 KB)

GlobalBlockLog with IP Address Range link displaying UserTalk url.jpg (915×1 px, 227 KB)

image.png (907×1 px, 449 KB)

image.png (918×1 px, 453 KB)

image.png (443×936 px, 227 KB)

image.png (717×949 px, 188 KB)

Dreamy_Jazz closed this task as Resolved.Mar 19 2024, 11:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits