Fri, Jan 14
Thu, Jan 13
cc @Prtksxna ASN is in the designs but no one has access to view it atm 😅 I made an assumption but should ipinfo-view-full see ASN? Should ipinfo-view-basic?
Are we waiting until the results of T267235: Add performance instrumentation to IP Info extension [M] to do anything more complicated than a fixed delay? We could do 100ms like T231115#5475342 proposes to start with.
Tue, Jan 11
Did we agree on a time to delay it by?
Mon, Jan 10
Quick grep if it helps:
tests/phpunit/ComparePagerTest.php 10:use MediaWiki\CheckUser\UserManager; 41: $userManager = $this->createMock( UserManager::class );
Sat, Jan 8
Fri, Jan 7
As far as "access to data" goes, yes. For instance, if I get this popup:
Wed, Dec 22
Tue, Dec 21
cc @Tchanders maybe?
From @Tchanders off-band:
I'm thinking that one outcome of https://phabricator.wikimedia.org/T297185 should be to decide whether we should do https://phabricator.wikimedia.org/T297947. I have concerns about changing how blocks are purged in MediaWiki core for the sake of one small feature in the initial, beta version of IPInfo - particularly if the investigation finds that it would have a wide impact
Dec 17 2021
Hm, it occurs to me that whether or not we load from the infobox or the popup, we pass along the same full set of information from the API. Would it be better then to log anytime anyone access the REST point? As @phuedx pointed out:
We shouldn't fool ourselves into thinking that our UI will be the only way that our API is used – a user could create a user script and/or gadget, for example.
do these values logically make sense, as in can IPs be VPN, Hosting provider and a Public Proxy at the same time?
I mean I would certainly never but you could make a server you own do whatever you want I suppose. I don't know if maxmind ever expires its data so it could be more accurate to say "This IP has been used for the following purposes before."
Confirmed there were blockers for T269763: Add Static / Dynamic value to the IP Information box [M] and T297961: Add Proxy Information to infobox so I've moved adding the tooltips for those properties to their associated tickets. This ticket can be for Connection Method/Owner, which has been merged and can act as the template for the future properties.
Will there only ever be one of these values, or could it be a combination of these too?
I skimmed the csv and it can be a combination of many. One notably had four associated with it: is_anonymous,is_anonymous_vpn, is_hosting_provider, is_public_proxy
Dec 15 2021
Going to claim this anyway and look into any necessary pre-reqs
Dec 14 2021
Dec 9 2021
I noticed this was moved into the ready column but shouldn't it remain blocked on account of none of the fields that need information existing yet? Connection type/owner is still going through code review, the proxy information is not currently rendered on the front-end (but is passed in the api), and we cannot get static/dynamic ip info.
Dec 7 2021
fwiw I've only seen accordion really used when we talk about the features of the infobox (eg. in phab tickets)
@phuedx @Tchanders I went ahead and created this follow-up task but could you confirm my understanding of it? We're worried that somewhere else something is checking against ipblocks with the assumption that any block there is unexpired because it assumes expired blocks are regularly purged? So we would need to find those instances and make sure that if necessary the expiry is taken into account.