Page MenuHomePhabricator

ResourcesTest::testFileExistence: File '/var/www/html/w/mw-config/images/help-question.gif' referenced by 'mediawiki.legacy.config' must exist.
Closed, ResolvedPublic

Description

A new test for missing image files referenced from CSS I'm adding in https://gerrit.wikimedia.org/r/#/c/235903/ exposed an issue:

b@ubuntu15:/var/www/wiki/tests/phpunit$ php phpunit.php structure/ResourcesTest.php
PHPUnit already present
PHPUnit 3.7.37 by Sebastian Bergmann.

Configuration read from /var/www/html/w/tests/phpunit/suite.xml

.............................................................   61 / 1847 (  3%)
.............................................................  122 / 1847 (  6%)
.............................................................  183 / 1847 (  9%)
.............................................................  244 / 1847 ( 13%)
.............................................................  305 / 1847 ( 16%)
.............................................................  366 / 1847 ( 19%)
.............................................................  427 / 1847 ( 23%)
..........................FF.................................  488 / 1847 ( 26%)
.............................................................  549 / 1847 ( 29%)
.............................................................  610 / 1847 ( 33%)
.............................................................  671 / 1847 ( 36%)
.............................................................  732 / 1847 ( 39%)
.............................................................  793 / 1847 ( 42%)
.............................................................  854 / 1847 ( 46%)
.............................................................  915 / 1847 ( 49%)
.............................................................  976 / 1847 ( 52%)
............................................................. 1037 / 1847 ( 56%)
............................................................. 1098 / 1847 ( 59%)
............................................................. 1159 / 1847 ( 62%)
............................................................. 1220 / 1847 ( 66%)
............................................................. 1281 / 1847 ( 69%)
............................................................. 1342 / 1847 ( 72%)
........................FF................................... 1403 / 1847 ( 75%)
............................................................. 1464 / 1847 ( 79%)
............................................................. 1525 / 1847 ( 82%)
............................................................. 1586 / 1847 ( 85%)
............................................................. 1647 / 1847 ( 89%)
............................................................. 1708 / 1847 ( 92%)
............................................................. 1769 / 1847 ( 95%)
............................................................. 1830 / 1847 ( 99%)
.................

Time: 32.96 seconds, Memory: 42.50Mb

There were 4 failures:

1) ResourcesTest::testFileExistence with data set #453 ('/var/www/html/w/mw-config/images/help-question.gif', 'mediawiki
.legacy.config', '/var/www/html/w/mw-config/images/help-question.gif')
File '/var/www/html/w/mw-config/images/help-question.gif' referenced by 'mediawiki.legacy.config' must exist.
Failed asserting that file "/var/www/html/w/mw-config/images/help-question.gif" exists.

/var/www/html/w/tests/phpunit/structure/ResourcesTest.php:24
/var/www/html/w/tests/phpunit/MediaWikiTestCase.php:131

2) ResourcesTest::testFileExistence with data set #454 ('/var/www/html/w/mw-config/images/help-question-hover.gif', 'med
iawiki.legacy.config', '/var/www/html/w/mw-config/images/help-question-hover.gif')
File '/var/www/html/w/mw-config/images/help-question-hover.gif' referenced by 'mediawiki.legacy.config' must exist.
Failed asserting that file "/var/www/html/w/mw-config/images/help-question-hover.gif" exists.

/var/www/html/w/tests/phpunit/structure/ResourcesTest.php:24
/var/www/html/w/tests/phpunit/MediaWikiTestCase.php:131

<snip>

/var/www/html/w/tests/phpunit/structure/ResourcesTest.php:24
/var/www/html/w/tests/phpunit/MediaWikiTestCase.php:131

FAILURES!
Tests: 1847, Assertions: 5901, Failures: 4.

This appears to be a bug in 1e06a9f02f9a3ca645f5abe5cd38943fcfa3aea2 where we forgot to actually copy the two image files when copying CSS…

Event Timeline

matmarex assigned this task to ori.
matmarex raised the priority of this task from to High.
matmarex updated the task description. (Show Details)
matmarex added a subscriber: matmarex.
matmarex added a subscriber: ori.

Oh well, I'll fix it myself.

Change 237928 had a related patch set uploaded (by Bartosz Dziewoński):
Add missing images used in installer's CSS

https://gerrit.wikimedia.org/r/237928

Change 237928 merged by jenkins-bot:
Add missing images used in installer's CSS

https://gerrit.wikimedia.org/r/237928