Maniphest T111796

ApiResult size check errors
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Anomie
	Sep 8 2015, 3:32 PM

Tags

Referenced Files

None

Subscribers

Description

Found some size check errors in ApiResult:

Setting NO_SIZE_CHECK also skips validation.
Stuff using ApiSerializable doesn't get size-checked properly.

Details

	Subject	Repo	Branch	Lines +/-
	ApiResult: Fix size checking	mediawiki/core	master	+41 -6

Customize query in gerrit

Related Objects

Mentioned In: rMW46322fff07f2: ApiResult: Fix size checking

Event Timeline

Anomie created this task.Sep 8 2015, 3:32 PM

Anomie claimed this task.

Anomie raised the priority of this task from to Medium.

Anomie updated the task description. (Show Details)

Anomie added a project: MediaWiki-Action-API.

Anomie subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 8 2015, 3:32 PM

Change 236807 had a related patch set uploaded (by Anomie):
ApiResult: Fix size checking

https://gerrit.wikimedia.org/r/236807

gerritbot added a project: Patch-For-Review.Sep 8 2015, 3:42 PM

Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Sep 8 2015, 3:43 PM

Change 236807 merged by jenkins-bot:
ApiResult: Fix size checking

https://gerrit.wikimedia.org/r/236807

Anomie mentioned this in rMW46322fff07f2: ApiResult: Fix size checking.Sep 9 2015, 11:42 PM

Anomie closed this task as Resolved.Sep 10 2015, 2:29 PM

ReleaseTaggerBot added projects: WMF-deploy-2015-09-15_(1.26wmf23), MW-1.26-release.Sep 10 2015, 10:02 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:42 PM